| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-09-13 | |||
| 15:29:46 | mriedem | Kevin_Zheng: commented on https://review.openstack.org/#/c/503601/ | |
| 15:37:46 | bauzas | stephenfin: we begin to have documentation bugs coming along in Launchpad | |
| 15:37:55 | bauzas | stephenfin: should we have a 'docs' tag ? | |
| 15:38:20 | bauzas | stephenfin: context is https://bugs.launchpad.net/nova/+bug/1683651 | |
| 15:38:21 | openstack | Launchpad bug 1683651 in OpenStack Compute (nova) "Policy.json for nova is removed in stable/ocata but the documentation still refers to editing the file for controlling actions" [Medium,Confirmed] | |
| 15:38:35 | bauzas | the point is that I'd like to make sure we have very easily actionable items for bugs | |
| 15:38:44 | bauzas | like point out docs bugs to newcomers | |
| 15:42:17 | bauzas | mmm, nevermind https://bugs.launchpad.net/nova/+bugs?field.tag=doc | |
| 15:43:11 | Kevin_Zheng | mriedem: THX | |
| 15:50:47 | stephenfin | bauzas: Yeah, it's 'doc' | |
| 15:51:15 | stephenfin | That annoys me but we're stuck with it :) | |
| 16:02:27 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add ``HostPortProfileInfo`` class https://review.openstack.org/441590 | |
| 16:16:32 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migration from ``ip`` commands to ``pyroute2`` https://review.openstack.org/484386 | |
| 16:27:30 | melwitt | stephenfin, bauzas: I can add 'docs' as an official bug tag too if that helps | |
| 16:28:12 | stephenfin | melwitt: Wouldn't be a bad idea, if only to stop things falling through the cracks | |
| 16:28:47 | melwitt | yeah, k | |
| 16:32:08 | melwitt | done. we'll just tag new bugs with 'docs' | |
| 16:32:31 | stephenfin | \o/ | |
| 16:33:00 | melwitt | we could change all of the 'doc' tagged bugs to 'docs' but I don't know how to do that in bulk easily | |
| 16:33:51 | mriedem | cburgess: this code https://github.com/openstack/nova/blob/f01bda973a59a44f0443fb8ff9d23c3e8395873d/nova/virt/block_device.py#L52 | |
| 16:35:15 | openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/502700 | |
| 16:36:39 | mriedem | cburgess: and this was a proposed fix https://review.openstack.org/#/c/366724/ | |
| 16:38:11 | stephenfin | melwitt: Nah, if we can we'll just use both. No point making more work for ourselves | |
| 16:39:06 | melwitt | cool | |
| 16:42:55 | mriedem | bauzas: so you should look at this https://review.openstack.org/#/c/366724/ | |
| 16:45:04 | openstackgerrit | Merged openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/503670 | |
| 17:02:11 | openstackgerrit | Michael Still proposed openstack/nova master: Fix missed chown call https://review.openstack.org/503079 | |
| 17:08:34 | openstackgerrit | Nicolas Simonds proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/484997 | |
| 17:19:59 | efried | mikal Here's another attempt that ought to remove our need for temporary_chown: https://review.openstack.org/503756 | |
| 17:20:17 | efried | it's not ideal, but it ought to actually work :) | |
| 17:21:27 | efried | mikal Long-term, if nothing else, once we bring snapshot support in-tree, we would be able to make a case to put the whole open-and-stream method into a nova.privsep.powervm module in nova proper. | |
| 17:22:42 | mikal | efried: its ok, I've given up on the dream of replacing temporary_chown with privsep, as I can't find a way to make that work | |
| 17:22:55 | mikal | efried: I updated the patch in nova to say that thing | |
| 17:23:12 | efried | mikal Saw that -- we can't have a privseppy context manager? | |
| 17:54:48 | openstackgerrit | Merged openstack/nova master: doc: fix flavor notes https://review.openstack.org/502112 | |
| 17:55:31 | openstackgerrit | Merged openstack/nova master: Enable test_iscsi_volume in live migration job https://review.openstack.org/459316 | |
| 18:51:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: factor out compute service start in ServerMovingTest https://review.openstack.org/503037 | |
| 18:51:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Moving more utils to ServerResourceAllocationTestBase https://review.openstack.org/499539 | |
| 18:51:56 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test resource allocation during soft delete https://review.openstack.org/495159 | |
| 19:03:22 | kfarr | gibi here is the patch I mentioned: https://review.openstack.org/#/c/439855/ | |
| 19:03:25 | kfarr | Thank you for taking a look! | |
| 19:24:00 | gibi | kfarr: thanks, I will check | |
| 19:47:13 | melwitt | so, it looks like the ability to run unit tests with a regex is broken recently? I'm doing 'tox -epy27 test_blah' and it's running osprofiler first and then running all tests after | |
| 19:51:30 | cdent | melwitt: does ‘tox -epy27 — test_blah’ work | |
| 19:51:47 | cdent | if so it may be the thing that mtreinish just posted to os-dev about | |
| 19:51:57 | melwitt | cdent: 'tox -epy27 -- --regex test_blah' doesn't work. lemme try your suggestion | |
| 19:53:11 | melwitt | that runs everything too | |
| 19:53:43 | mtreinish | melwitt: hmm I think there is a bug in the nova tox.ini | |
| 19:53:58 | mtreinish | melwitt: try dropping the single quotes around posargs on the py27 job | |
| 19:54:06 | mtreinish | and run 'tox -epy27 -- --regex test_blah' | |
| 19:55:07 | mtreinish | that's probably my fault for not catching the quotes in https://review.openstack.org/#/c/501842/ | |
| 19:55:26 | cdent | hmm, I don’t have this problem, maybe it is related to version of tox? | |
| 19:55:49 | melwitt | oh, hm. let me make sure I have the latest version | |
| 19:56:01 | mtreinish | cdent: does your tox venv have os-testr 1.0.0? | |
| 19:56:39 | cdent | maybe not; slow network has limited my refreshes of late | |
| 20:00:39 | cdent | melwitt, mtreinish: okay, yeah, with a refreshed venv I get the same bad behavior | |
| 20:01:21 | bauzas | FWIW, I don't usually pass args this way when calling the specific py27 tox target | |
| 20:01:35 | bauzas | I'd rather do "tox -epy27 <my_pattern>" | |
| 20:01:37 | melwitt | cdent, mtreinish: yep, that was it. removed the single quotes from tox.ini and then use 'tox -epy27 -- --regex test_blah' works | |
| 20:02:06 | bauzas | oh, a regex, then nvm | |
| 20:02:08 | melwitt | bauzas: yeah, same. but mtreinish says in the commit message of that change that that was apparently working by accident | |
| 20:03:53 | bauzas | lemme look tox.ini | |
| 20:04:10 | bauzas | posargs are treated differently depending on the target | |
| 20:07:29 | melwitt | mtreinish: does the new version of ostestr also do the stdout capture differently? it used to be in a separate section for stdout and now it's just going inline with everything else? | |
| 20:07:56 | bauzas | we quote the posargs for ostestr actually | |
| 20:08:34 | bauzas | so that means that if you pass something like "-- --regex foo", it'll litterally call out ostestr '-- --regex foo' | |
| 20:13:09 | mriedem | mikal: https://review.openstack.org/#/c/503164/ | |
| 20:13:11 | mriedem | come on | |
| 20:14:14 | mikal | mriedem: I replied just now | |
| 20:32:14 | mtreinish | bauzas: yeah we need to set the env variables in the tox.ini | |
| 20:32:24 | mtreinish | the capture fixtures depend on an env var being set | |
| 20:32:34 | mtreinish | and they were done magically by default in .testr.conf | |
| 20:32:39 | mtreinish | which isn't used anymore | |
| 20:32:44 | bauzas | hah! | |
| 20:32:59 | mtreinish | personally I just drop the env variable checks in the base test class because no one ever wants to turn it off | |
| 20:34:42 | mtreinish | bauzas, melwitt: I'll push a patch up to fix the things, one sec | |
| 20:42:13 | melwitt | mtreinish: ah, thanks. didn't realize the stdout env var stuff was being done in .testr.conf | |
| 20:42:27 | mtreinish | melwitt: heh, yeah no one does | |
| 20:42:28 | openstackgerrit | Matthew Treinish proposed openstack/nova master: Fix test runner config issues with os-testr 1.0.0 https://review.openstack.org/503811 | |
| 20:42:33 | mtreinish | melwitt, cdent, mikal: ^^^ | |
| 20:43:55 | mtreinish | you probably want to test that locally (I just pushed it up) | |
| 20:44:06 | melwitt | mtreinish: yep trying it out now | |
| 20:46:31 | mtreinish | bauzas: ^^^ oops forgot about you :) | |
| 20:46:56 | bauzas | heh, np | |
| 20:47:07 | bauzas | waiting for melwitt's test :p | |
| 20:47:33 | melwitt | mtreinish: cool, works for py27 env. are the other posargs with single quotes in tox.ini okay the way they are? | |
| 20:47:50 | bauzas | I guess so | |
| 20:47:57 | melwitt | like what about the functional env | |
| 20:48:04 | mtreinish | I wasn't sure how the pretty_tox.sh script does things | |
| 20:48:20 | melwitt | yeah, I was thinking the same. the functional env is a direct ostestr call tho | |
| 20:48:22 | mtreinish | with quotes it treats posargs as a single arg which breaks for something like --regex foo | |
| 20:48:34 | mtreinish | which needs to be 2 args for argparse to understand it | |
| 20:49:07 | mtreinish | hmm, I'm not sure if that fixes the capture fixtures though. I saw things outside the capture in a local run | |
| 20:49:30 | melwitt | it worked for what I'm working on (wherein I added a couple of print statements) | |
| 20:49:53 | mtreinish | melwitt: ah ok, maybe it was just something else then | |
| 20:49:54 | melwitt | gonna try running -efunctional with a regex to see if that is okay | |
| 20:49:59 | mtreinish | ok | |
| 20:50:09 | dansmith | mikal: this might be a good set for your special list: https://review.openstack.org/#/c/502152 | |
| 20:50:24 | dansmith | mikal: the unregister.* ones | |
| 20:52:53 | mikal | dansmith: I live to obey | |