Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-09-12
16:31:42 efried mikal Okay, thanks. esberglu See ^^. mikal Do you want a LP bug?
16:31:58 mikal Yes please
16:32:02 efried rgr
16:33:26 openstackgerrit Dan Smith proposed openstack/nova master: Add nova-manage db command for ironic flavor migrations https://review.openstack.org/501025
16:35:56 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404
16:36:52 mriedem rybridges: because classloading everything isn't a contract and we break it and then people that used hooks and classloaders complain when we change something internal to nova that breaks their unversioned API
16:37:51 esberglu mikal: efried: I can open the LP bug
16:38:37 openstackgerrit Eric Berglund proposed openstack/nova master: PowerVM Driver: config drive https://review.openstack.org/409404
16:38:55 mikal esberglu: ta, I have a fix now but need to work through the unit test fallout
16:42:49 mikal efried: do you guys have heaps of users of temporary_chown in your code? Because I kind of want to remove that method now that you've brought it to my attention.
16:42:57 mikal efried: because it makes me throw up in my mouth
16:44:34 openstackgerrit Balazs Gibizer proposed openstack/nova master: cover migration cases with functional tests https://review.openstack.org/493865
16:45:06 efried mikal We only use it in image snapshot.
16:45:26 efried mikal If you took it away, we would essentially have to duplicate the logic ourselves.
16:46:23 efried mikal https://github.com/openstack/nova-powervm/blob/fae3f96edb0c257468a93100796b338207a4cfc5/nova_powervm/virt/powervm/image.py#L45-L47
16:47:27 mikal efried: I'd hand hold you through uswing privsep there instead
16:47:36 efried Sorry, s/image snapshot/snapshot/. "image snapshot" doesn't make a lot of sense.
16:48:08 efried mikal Mm, that's another idea, I suppose. Cause it's really the open that needs privs raised, eh?
16:48:53 mikal efried: yeah, although I don't think privsep supp0orts passing off file descriptors (yet)
16:49:06 mikal efried: but yeah, I'd find a way to drag you guys forward before nuking the thing
16:49:07 efried mikal We could essentially just decorate that whole method with @nova.privsep.dac_admin_pctxt.entrypoint and remove the temporary_chown context manager.
16:49:16 efried right?
16:49:29 mikal efried: yes, but the method needs to move into the nova.privsep namespace as part of that decoration
16:49:36 efried oh
16:49:38 mikal efried: but yes, you could have nova.privsep.powervm
16:49:39 efried uhm
16:49:58 efried This is our out-of-tree driver.
16:49:59 mikal Let's fix the immediate problem and then talk the future thorugh
16:50:06 mikal You at the PTG?
16:50:24 efried We do have a toe in the nova.* namespaces, but at the moment its only purpose is redirecting to our virt driver entrypoint.
16:50:35 efried mikal Yeah, I talked to you yesterday morning in the bmvm room :)
16:51:07 efried You want to meet up?
16:51:17 esberglu mikal: https://bugs.launchpad.net/nova/+bug/1716718
16:51:18 openstack Launchpad bug 1716718 in OpenStack Compute (nova) "chown commands failing (no rootwrap filter)" [Undecided,New]
16:51:28 mikal LOL, I am an old man
16:51:38 mikal Let's talk tomorrow in the nova thing, that way I can get the thing fixed first
16:51:45 efried mikal ack
16:54:16 efried mikal Would you guys go for me adding the nova.privsep.powervm module in nova proper? We're in the process of integrating our driver in-tree, so we could argue it's for "future support of the snapshot operation".
16:54:31 prometheanfire anyone around to review https://review.openstack.org/#/c/501533/ for the new castellan release
16:54:32 efried Though tbh, we may not get snapshot into Queens.
16:58:43 mikal efried: so, I'm not a core, I'm basically a homeless guy no one has worked out how to get rid of
16:58:54 mikal efried: but I would be surprised if my betters would accept that thing
16:59:09 mikal efried: you're driver install process could add a file in that directory though...
16:59:27 efried mikal That *may* not be necessary.
16:59:38 efried Ima play with it and see if I can make it work.
16:59:44 mikal Cool
16:59:48 mikal Let me know if you need a hand
17:09:12 dansmith mdbooth: where you at?
17:10:30 efried mikal Like-a-this: https://review.openstack.org/503078
17:13:01 openstackgerrit Michael Still proposed openstack/nova master: Fix missed chown call https://review.openstack.org/503079
17:14:11 mikal efried: https://review.openstack.org/#/c/503079/ is your fix
17:14:17 mikal efried: can you test it with your driver please?
17:19:57 sean-k-mooney stephenfin: are you free for https://etherpad.openstack.org/p/placement-nova-neutron-queens-ptg, i think you would be interested in this
17:21:05 efried mikal Roger wilco. esberglu_lunch When you're back, please patch in https://review.openstack.org/#/c/503079/ and see if it resolves our snapshot snafu
17:22:31 efried esberglu_lunch It will also be instructive to see whether https://review.openstack.org/503078 passes *without* ^
17:30:18 openstackgerrit Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459
17:30:19 openstackgerrit Balazs Gibizer proposed openstack/nova master: use context mgr in instance.delete https://review.openstack.org/443764
17:30:19 openstackgerrit Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297
17:38:17 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/502700
17:39:12 mriedem dansmith: there you go
17:39:50 dansmith mriedem: what now?
17:39:58 mriedem https://review.openstack.org/#/c/501025/
17:40:15 dansmith oh thanks
17:42:12 mriedem sure doll
17:42:16 mriedem wait, i didn't say that
17:48:26 mriedem dansmith: chugging through the 4 patches here which need to go to pike would be nice https://review.openstack.org/#/c/499399/ - already have +2s on all of them, and one is already approved
17:49:40 gmann alex_xu: first things in no more extensions already done right - L207 https://etherpad.openstack.org/p/nova-ptg-queens
18:03:51 openstackgerrit Mathieu Gagné proposed openstack/nova master: Regenerate and pass configdrive when rebuild Ironic nodes https://review.openstack.org/503088
18:09:27 openstackgerrit Elod Illes proposed openstack/nova master: WIP: Transform instance.interface_attach notification https://review.openstack.org/503089
18:24:01 openstackgerrit Mathieu Gagné proposed openstack/nova master: Regenerate and pass configdrive when rebuild Ironic nodes https://review.openstack.org/503088
19:07:39 openstackgerrit Dan Smith proposed openstack/nova master: Add nova-manage db command for ironic flavor migrations https://review.openstack.org/501025
19:12:50 openstackgerrit Merged openstack/nova master: Transform instance.resize.error notifications https://review.openstack.org/417882
19:59:26 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Add recreate test for forced host evacuate not setting dest allocations https://review.openstack.org/503159
19:59:26 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Refactor out claim_resources_on_destination into a utility https://review.openstack.org/503160
19:59:27 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Create allocations against forced dest host during evacuate https://review.openstack.org/503161
19:59:27 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Add recreate test for evacuate claim failure https://review.openstack.org/503162
19:59:28 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Add a test to make sure failed evacuate cleans up dest allocation https://review.openstack.org/503163
19:59:28 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: De-duplicate two delete_allocation_for_* methods https://review.openstack.org/503164
19:59:29 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Remove dest node allocation if evacuate MoveClaim fails https://review.openstack.org/503165
20:36:21 mriedem hmm, why is tox -r -e venv giving me index error lately?
20:40:35 bauzas mriedem: trace ?
20:41:17 bauzas also, does anyone have an handy documentation about explaining how to purge/archive our soft-deleted records ? context is https://bugs.launchpad.net/nova/+bug/1716593 that I want to invalidate
20:41:18 openstack Launchpad bug 1716593 in OpenStack Compute (nova) "reservations table in nova mysql db grows constantly" [Undecided,New]
20:41:35 mriedem nova-manage db archive_deleted_rows
20:41:39 bauzas I can surely ask to run nova-manage, but a link could be awesome
20:41:43 bauzas mriedem: yup I know
20:41:47 bauzas mriedem: I just wanted some docs :)
20:42:10 mriedem http://paste.openstack.org/show/620973/
20:42:28 mriedem bauzas: https://docs.openstack.org/nova/latest/cli/nova-manage.html#nova-database
20:43:27 bauzas mriedem: ta, adding it to the bug report
20:44:40 bauzas mriedem: interesting, trying locally
20:45:22 mwynne Hi guys. I'm trying to allocate an instance that would overcommit RAM but remain within my ratio and it fails. This document (https://docs.openstack.org/arch-design/design-compute/design-compute-overcommit.html) states that you can overcommit RAM, but the "Note" is basically saying you can't overcommit RAM. Am I missing something here? Something doesn't add up to me.
20:45:40 mriedem dansmith: hey, we're friends right?
20:45:53 dansmith mriedem: um, yes?
20:45:55 mriedem https://review.openstack.org/#/c/501025/ <3
20:46:41 cdent mwynne: you’re not trying to allocate more virtual RAM than physical RAM are you?
20:47:31 mwynne cdent: I'm trying to allocate a VM that would push me over the limit of how much total physical RAM I have on my compute nodes.
20:47:43 mwynne But isn't that what overcommit is enabling me to do?
20:47:49 mwynne within the specified ratio?
20:47:56 cdent mwynne: for multiple vms, yes, but not for a single vm

Earlier   Later