Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-08-25
20:03:20 artom https://review.openstack.org/#/c/481478/
20:03:27 artom Yeah, you're even a reviewer on it ;)
20:03:42 mriedem whatever artomous maximus
20:03:46 mriedem are you happy with it?
20:04:01 artom Lemme check the latest version quickly
20:04:30 mriedem stephenfin: can you drop the -2 from this https://review.openstack.org/#/c/482216/ ?
20:04:37 artom Err, nits on wording
20:04:50 artom But since this is a pure doc patch, I figure they're -1 worthy, no?
20:05:09 mriedem yes, i'm also going through it, i'll update after you
20:07:50 mriedem er i just -1ed
20:12:45 mriedem thanks
20:19:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Add device tag support info in support matrix https://review.openstack.org/481478
20:19:10 mriedem updated ^
20:24:09 artom mriedem, couple more nits
20:24:14 mriedem my god
20:24:24 artom bikeshed all the things!
20:25:20 artom If it improves your morale, it's genuinely nice to see you push patches through their final stretch like this, when there's just nits remaining
20:25:44 mriedem if there is one thing i'm all about, it's high morale
20:26:50 artom A high state in general
20:30:28 mriedem oh i guess we don't format that page with rst anyway
20:30:35 mriedem so ``nic1`` doesn't help
20:31:51 artom Maybe the . thing was legit?
20:32:22 mriedem no it wasn't
20:32:26 mriedem it was just .nic1.
20:32:29 mriedem i'll use quotes
20:33:04 admin0 hi all .. i wanted to check if I hit a nova bug .. https://bugs.launchpad.net/nova/+bug/1713144 ..
20:33:05 openstack Launchpad bug 1713144 in OpenStack Compute (nova) "nova metadata service breaks on hostname" [Undecided,New]
20:33:30 artom If you hit it it'll probably defend itself and hit back
20:33:52 mriedem <rimshot>
20:34:54 admin0 :D
20:35:04 openstackgerrit Matt Riedemann proposed openstack/nova master: Add device tag support info in support matrix https://review.openstack.org/481478
20:35:05 openstackgerrit Matt Riedemann proposed openstack/nova master: Document tagged attach in the feature support matrix https://review.openstack.org/498086
20:35:15 admin0 i will wait for it to hit back :)
20:35:16 artom nova-network? Didn't we deprecate that?
20:35:46 mriedem admin0: which release? please provide release version information in the bug report
20:35:53 mriedem if something changed we need to be able to look for when
20:36:55 admin0 sorry .. i updated
20:41:27 mriedem looks like that code hasn't changed in a long time
20:41:27 mriedem netaddr.IPAddress(ip)
20:41:34 mriedem so it's probably something in the netaddr library
20:41:49 mriedem compare the versions where it works and where it doesn't and check the change log for netaddr between them i suppose
20:44:31 mriedem https://github.com/drkjam/netaddr/blob/netaddr-0.7.19/netaddr/ip/__init__.py#L244
20:44:44 mriedem looks like netaddr.IPAddress has always expected an ip rather than fqdn
20:45:09 admin0 i will take it back to ansible
20:47:40 mriedem ah, also, metadata_host defaults to $my_ip,
20:47:46 mriedem which is an IP address, not a hostname
20:47:59 mriedem these StrOpts should really probably be IPOpts
21:24:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Change default for [notifications]/default_publisher_id to $host https://review.openstack.org/498094
21:24:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Change CONF.my_ip to be IPOpt https://review.openstack.org/498095
21:41:59 mriedem what the hell is monkey_patch_modules?
21:42:02 mriedem can we remove that?
21:55:45 clarkb config docs seem to imply it is for testing
21:55:59 openstackgerrit Brianna Poulos proposed openstack/nova master: Add trusted_certs to Instance object https://review.openstack.org/489408
21:56:00 openstackgerrit Brianna Poulos proposed openstack/nova master: WIP Add trusted_certificates to REST API https://review.openstack.org/486204
21:56:00 openstackgerrit Brianna Poulos proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/457711
21:56:06 clarkb is that how fake virt loading worked for the stress job?
21:56:28 mriedem clarkb: no we literally have a fake virt driver in tree
21:56:38 mriedem we use it in the in tree functional tests, and the stress job did too
21:56:43 mriedem or large ops or whatever it was called
21:56:51 clarkb ya large ops that was the name (I couldn't remember it)
21:58:50 openstackgerrit Brianna Poulos proposed openstack/nova master: WIP Add trusted_certificates to REST API https://review.openstack.org/486204
22:29:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Deprecate CONF.monkey_patch https://review.openstack.org/498113
22:29:25 mriedem huzzah ^
22:35:31 cfriesen_ yay for removing code
22:36:56 mriedem the one bright spot of every new release is removing some mistakes from the old releases
22:37:50 cfriesen_ what's with the removal of the line with ec2?
22:38:10 mriedem oh yeah, was going to mention that in the release note - that code isn't in nova so doesn't really need to be in here
22:38:48 cfriesen_ figured it was something like that
22:38:59 openstackgerrit Eric Fried proposed openstack/nova-specs master: RFC: SPEC: PCI passthrough by device ID https://review.openstack.org/497965
22:41:01 fried_rice claudiub ^ !
22:41:55 fried_rice claudiub I would welcome more examples and/or specifics of how HyperV has to hack the world today to make PCI passthrough work.
22:51:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Deprecate CONF.monkey_patch https://review.openstack.org/498113
22:51:27 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Change CONF.my_ip to be IPOpt https://review.openstack.org/498095
22:51:28 openstackgerrit Matt Riedemann proposed openstack/nova master: Change default for [notifications]/default_publisher_id to $host https://review.openstack.org/498094
22:54:40 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Change CONF.my_ip to be IPOpt https://review.openstack.org/498095
22:54:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Change default for [notifications]/default_publisher_id to $host https://review.openstack.org/498094
#openstack-nova - 2017-08-26
00:12:57 openstackgerrit Merged openstack/nova master: Remove the section about extensions from the API concept doc https://review.openstack.org/496500
01:29:39 openstackgerrit Merged openstack/nova master: fix a typo in format_cpu_spec doc https://review.openstack.org/497750
02:13:14 openstackgerrit Merged openstack/nova master: VMware: use WithRetrieval in get_network_with_the_name https://review.openstack.org/325587
02:23:05 openstackgerrit Merged openstack/nova master: VMware: use WithRetrieval in ds_util module https://review.openstack.org/325610
#openstack-nova - 2017-08-28
02:20:08 openstackgerrit Sean McCully proposed openstack/nova master: iso8601.is8601.Utc No Longer Exists https://review.openstack.org/498287
05:51:30 openstackgerrit jichenjc proposed openstack/nova master: use conf for keystone session creation https://review.openstack.org/485121
07:04:13 openstackgerrit Rajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive https://review.openstack.org/498334
07:32:13 openstackgerrit Rajesh Tailor proposed openstack/nova master: Host addition host-aggregate should be case-sensitive https://review.openstack.org/498334
07:46:35 gibi good morning nova
08:20:57 openstackgerrit Markus Zoeller (markus_z) proposed openstack/nova master: docs: Explain the flow of the "serial console" feature https://review.openstack.org/476188
08:35:29 openstackgerrit jichenjc proposed openstack/nova master: check query param for service's index function https://review.openstack.org/489492
08:35:49 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257
08:36:03 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request https://review.openstack.org/451777
08:41:21 openstackgerrit sahid proposed openstack/nova master: libvirt: slowly live-migration to ensure network is ready https://review.openstack.org/497457
08:41:46 openstackgerrit sahid proposed openstack/nova master: libvirt: fix memory locking limit https://review.openstack.org/472633
08:42:09 openstackgerrit sahid proposed openstack/nova master: compute: reset instance events https://review.openstack.org/420026
08:56:04 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Allow users to unset 'keymap' options https://review.openstack.org/496605
08:56:05 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: De-duplicate some graphics tests https://review.openstack.org/497969
08:59:18 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Format NIC features using os-traits definitions https://review.openstack.org/466051
09:08:26 jaypipes alex_xu: hey, would you be OK splitting the functional test here: https://review.openstack.org/#/c/480379/19/nova/tests/functional/db/test_resource_provider.py out into a separate patch (with commented-out asserts linking to a bug number)?
09:09:33 jaypipes alex_xu: it would probably help reviewers in seeing exactly where the bug is located if they could review the functional test with bad assertions (and comments saying "this is wrong because of bug XXXX")
09:11:38 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Rename two VNC options https://review.openstack.org/498387
09:27:31 alex_xu jaypipes: got it, I will split out the functional test
09:29:57 jaypipes alex_xu: ty sir!

Earlier   Later