| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-08-23 | |||
| 02:24:15 | gmann | alex_xu, ok, i will push remaining things there with adding sample patches | |
| 02:24:33 | alex_xu | gmann: thanks! | |
| 02:25:15 | alex_xu | gmann: are you interesting on taking look at how to add sample file for json-schema? | |
| 02:25:50 | alex_xu | gmann: that can be used to avoid the bug like this https://bugs.launchpad.net/nova/+bug/1658571 | |
| 02:25:52 | openstack | Launchpad bug 1658571 in OpenStack Compute (nova) "Microversion 2.37 break 2.32 usage" [High,Fix released] - Assigned to Artom Lifshitz (notartom) | |
| 02:26:49 | gmann | alex_xu, yea that will be nice. | |
| 02:27:07 | artom | A long time ago I started https://review.openstack.org/#/c/430352/ in relation to that bug | |
| 02:27:32 | artom | It needs a massive amount of manual sample fixing to eventually work though :( | |
| 02:28:24 | gmann | artom, ohk, even i was thinking to run a gate job with 'latest' but not all tempest test will pass and it will need lot of refactoring | |
| 02:28:59 | artom | gmann, mine is just for api sample tests, to start with at least | |
| 02:29:08 | gmann | yea | |
| 02:29:59 | artom | I just got discouraged by the, like, 150 failing tests that 2.latest created, and the need to manually go and either skip or fix each one | |
| 02:30:47 | gmann | most of them need capping of microversion | |
| 02:31:55 | gmann | anyways we can think more on this. may be simple set of mandatory element of schema and test them with latest | |
| 02:32:03 | gmann | alex_xu, you have any other idea on this | |
| 02:33:36 | alex_xu | gmann: artom i'm just thinking of the API sample tests also generate all the json-schema to a sample file, then we validate the jsons-schema whether is changed unexpected | |
| 02:34:51 | artom | alex_xu, I'm not sure I follow (it may have something to do with it being 22:30 here) | |
| 02:35:39 | gmann | alex_xu, i see. | |
| 02:35:52 | alex_xu | artom: so the bug is about we change the old schema when change schema in the new version | |
| 02:36:48 | artom | alex_xu, yeah, we inadvertently removed something | |
| 02:36:50 | alex_xu | artom: then we generate all the json-schema sample files through api-sample tests, and compare all the json-schema sample file whether changed | |
| 02:37:29 | gmann | alex_xu, i am just remembering why current sample tests did not catch that bug? | |
| 02:37:48 | artom | gmann, because tests are pinned to a specific microversion | |
| 02:38:02 | artom | gmann, so 2.32 was fine, and what 2.37 added was also fine | |
| 02:38:17 | artom | gmann, we just never tested that what 2.32 added still worked in 2.33, 34, ... 37, etc | |
| 02:39:12 | artom | alex_xu, but some schema changes are intentional, so (if I'm understanding you correctly) we can't just fail if the schema changes | |
| 02:40:10 | alex_xu | gmann: oh...wait. that bugs break the schema in the microversion, not the schema in the old microversion | |
| 02:40:24 | gmann | yea | |
| 02:40:51 | gmann | if anyone change old schema then it should already catch by current tests | |
| 02:41:27 | alex_xu | yea, I see now why artom want to run all the api-samples test on the latest version now | |
| 02:43:19 | gmann | yea | |
| 02:45:55 | artom | alex_xu, gmann, if you are are up for reviewing that, I can try to conjure the motivation to beat into shape and get it to pass Jenkins ;) | |
| 02:46:39 | alex_xu | artom: thanks, I need to clear my mind first | |
| 02:47:14 | artom | alex_xu, of course :) Like I said, it's 22:30, so nothing's happening tonight, that's for sure | |
| 02:47:27 | artom | And it'll take me a few days, I suspect | |
| 02:47:28 | alex_xu | artom: yea :) | |
| 02:47:57 | gmann | artom, alex_xu yea, i also need to think more on this how can cover with minimal effort | |
| 05:59:06 | openstackgerrit | Alex Xu proposed openstack/nova master: Remove the section about extensions from the API concept doc https://review.openstack.org/496500 | |
| 06:08:49 | openstackgerrit | Merged openstack/nova master: update comment for dropping support https://review.openstack.org/494061 | |
| 06:20:57 | tobasco | cfriesen_: sorry for late reply had to leave work yesterday, thanks for testing it out, we create our instances using the api from our controlpanel perhaps there is some integration issue there, but we are sending with device_name but iirc libvirt does not honor user requested device names as it says in the log | |
| 06:21:14 | tobasco | i wonder what the difference is, we use a dell backend for our cinder volumes but i doubt it's really related to cinder though | |
| 06:21:40 | tobasco | cfriesen_: gonna see if i can figure something out, you dont do anything special with properties on your glance image i assume | |
| 06:50:37 | openstackgerrit | Wonil Choi proposed openstack/nova master: libvirt: Fix getting a wrong guest object https://review.openstack.org/496515 | |
| 06:50:42 | tobasco | cfriesen_: thanks for testing it out earlier, didn't have the same problem when booting from horizon either so must be that we are sending some param when we provision using the api | |
| 06:50:55 | tobasco | causing that behaviour, perhaps device_name, gonna see if i can narrow it down | |
| 07:18:03 | openstackgerrit | jichenjc proposed openstack/nova master: Do not attempt volume swap when guest is stopped/suspended https://review.openstack.org/389798 | |
| 07:41:45 | openstackgerrit | Ilya Popov proposed openstack/nova master: Tests: Add cleanup of 'instances' directory https://review.openstack.org/491589 | |
| 08:52:22 | openstackgerrit | Stephen Finucane proposed openstack/nova master: placement: Make API history doc more consistent https://review.openstack.org/477478 | |
| 08:53:04 | openstackgerrit | Stephen Finucane proposed openstack/nova master: pci: Validate behavior of empty devname https://review.openstack.org/396130 | |
| 08:54:32 | openstackgerrit | Merged openstack/nova master: Add language for compute node configuration https://review.openstack.org/489643 | |
| 08:54:47 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: remove cpuset_reserved from __init__ of InstanceNUMATopology https://review.openstack.org/466030 | |
| 08:54:48 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: remove related pinning from __init__ of InstanceNUMATopology https://review.openstack.org/485554 | |
| 08:54:48 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: remove pagesize from __init__ of InstanceNUMATopology https://review.openstack.org/485553 | |
| 08:54:52 | openstackgerrit | jichenjc proposed openstack/nova master: WIP: use conf for keystone session creation https://review.openstack.org/485121 | |
| 09:26:12 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform aggregate.update_prop notification https://review.openstack.org/462576 | |
| 09:27:36 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.resize_prep notification https://review.openstack.org/465081 | |
| 09:29:03 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.rebuild_scheduled notification https://review.openstack.org/473929 | |
| 09:29:37 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.live_migration_rollback_dest notification https://review.openstack.org/480214 | |
| 09:30:18 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.live_migration_force_complete notification https://review.openstack.org/480561 | |
| 09:31:20 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform HostAPI-set_enabled notifications https://review.openstack.org/482622 | |
| 09:32:09 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform libvirt.error notification https://review.openstack.org/484851 | |
| 09:34:38 | openstackgerrit | Elod Illes proposed openstack/nova master: Functional test: cold migrate to compute down https://review.openstack.org/496280 | |
| 09:42:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Improve docstrings of two methods https://review.openstack.org/420298 | |
| 10:02:38 | ratailor | auggy, are you working on https://bugs.launchpad.net/nova/+bug/1538011 | |
| 10:02:41 | openstack | Launchpad bug 1538011 in OpenStack Compute (nova) "Metadata keys are not case sensitive" [Medium,In progress] - Assigned to Augustina Ragwitz (auggy) | |
| 10:15:56 | openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954 | |
| 10:28:31 | stephenfin | ratailor: I don't think auggy's working on OpenStack anymore (???). You can grab it | |
| 10:28:47 | ratailor | stephenfin, Thanks! | |
| 10:29:51 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate 'keymap' options https://review.openstack.org/483994 | |
| 10:29:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Allow users to unset 'keymap' options https://review.openstack.org/496605 | |
| 10:36:44 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Monkey patch the blockdiag extension https://review.openstack.org/476159 | |
| 10:36:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: docs: Document the scheduler workflow https://review.openstack.org/475810 | |
| 10:38:35 | stephenfin | edleafe: Could you take a look at https://review.openstack.org/#/c/475810/ this week? I don't have the full picture so can't address cdent's comments, tbh | |
| 10:39:11 | stephenfin | Feel free to take ownership if you feel like it ;) | |
| 10:55:55 | openstackgerrit | Wonil Choi proposed openstack/nova master: libvirt: Fix getting a wrong guest object https://review.openstack.org/496515 | |
| 11:00:41 | openstackgerrit | Jianghua Wang proposed openstack/nova master: WIP: support os_xenapi's VDI streaming https://review.openstack.org/486475 | |
| 11:17:10 | kashyap | lyarwood: Thanks for sheperding this upstream stable/ocata change throug - https://review.openstack.org/#/c/489198/ | |
| 11:17:18 | kashyap | s/throug/through/ | |
| 12:04:12 | gmann_ | alex_xu: registered BP - https://blueprints.launchpad.net/nova/+spec/api-extensions-merge-queens | |
| 12:04:35 | gmann_ | alex_xu: i added this item in PTG etherpad also - https://etherpad.openstack.org/p/nova-ptg-queens | |
| 12:23:04 | alex_xu | gmann_: thanks! | |
| 12:39:32 | openstackgerrit | Viktor Varga proposed openstack/nova master: Remove mox from unit/conductor/test_conductor.py (1) https://review.openstack.org/496691 | |
| 12:44:22 | cdent | (gibi-core)++ | |
| 12:45:19 | alex_xu | nova api meeting is in 15 mins at #openstack-meeting-4 | |
| 12:45:32 | bhagyashri_s | jaypipes, melwitt: Hi, I want to discuss regarding bfv case, I have done some testing on the stable/pike and what i observed is even if I boot the instance from volume then in that case it allocates the disk_gb as the flavor root_gb in both compute_nodes and allocations table but after applying the patch [1]: https://review.openstack.org/#/c/428481/ on stable/pike then it makes the correct allocations. So why these two patche [1][2] are | |
| 12:45:32 | bhagyashri_s | ignored in the pike. [1]: https://review.openstack.org/#/c/428481/ [2]: https://review.openstack.org/#/c/428505/ | |
| 12:47:55 | edleafe | stephenfin: sure. Would it be easier for me to revise it and push a new version? | |
| 12:49:38 | stephenfin | edleafe: Probably would, yeah. cdent just left a comment saying he'd take a look too. Feel free to take ownership of the whole thing if you'd like to - I just care about the resulting doc :) | |
| 12:49:44 | jaypipes | bhagyashri_s: you can propose them as backports to stable/pike. they just were not highest priority during the last two weeks | |
| 12:50:03 | cdent | edleafe: if you’ve got time/brain you may take point | |
| 12:51:00 | edleafe | cdent: well, since it was my poorly-worded email that started all this... :) | |
| 12:51:09 | edleafe | I'll take a crack at it | |
| 12:51:26 | stephenfin | jaypipes: Talking of backports, could you stick this on your review backlog? https://review.openstack.org/#/c/496605/ Something I'd like to get into Pike before final | |
| 12:52:03 | bhagyashri_s | jaypipes: ok I can. Thank you :) | |
| 12:53:51 | cdent | thanks edleafe | |
| 12:55:09 | jaypipes | stephenfin: I'm not core on stable :) | |
| 12:56:03 | stephenfin | jaypipes: Good thing it's on master (I hope :)) Master first, then backport | |
| 12:56:15 | stephenfin | Only if you've time though, of course | |
| 12:58:46 | stephenfin | thanks edleafe, cdent :) | |
| 13:00:26 | alex_xu | nova api meeting is running at #openstack-meeting-4 | |