Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-08-16
19:45:25 melwitt what do you mean by you don't see the problem? you don't see the use case for the change?
19:45:26 dansmith I get that, I'm just not sure I see the point
19:45:29 dansmith ues
19:45:32 melwitt k
19:45:53 cdent the bug report goes into some detail on why it is bad for ironic, yeah?
19:46:00 melwitt I think the only point is the shuffling of same weights only vs shuffling of all (using host_subset_size)
19:46:08 dansmith it's basically "if the weighers don't know the difference between two things, then spread regardless of what you want"
19:46:24 melwitt yeah
19:46:31 dansmith like, two things that score the same are not equal if you want packing
19:46:39 melwitt right
19:46:47 dansmith and AFAICT, this is just choosing one default over the other (reversing the current default) right?
19:46:59 melwitt but the change wants the ability to shuffle things that score the same
19:47:23 melwitt that is, they can't get what they want with host_subset_size
19:47:49 dansmith yeah, but they're breaking pack people because they want to shuffle a smaller set of the top results
19:48:08 melwitt yeah I know. I was trying to think if there's some way to get them what they want and also not break pack people
19:48:36 dansmith sorry, I realize you think I mean I don't understand what they want
19:48:37 dansmith I do,
19:48:53 melwitt no, I know that you understand
19:48:54 dansmith I just think it's not the automatic applies-to-everybody performance optimization that they think it is
19:49:03 dansmith ack
19:49:18 melwitt I was just trying to explain what I was saying, that I was brainstorming if there's way to fulfill both use cases
19:49:42 dansmith yep yep
19:50:48 dansmith making 0.0 a magic weight seems less desirable to me
19:51:08 dansmith it's more confusing than a boolean called shuffle_same_weight_hosts=True, IMHO
19:51:18 melwitt yeah. the more I think about it the more I think that would be a bad idea. because weights can be negative too, so 0.0 is a real weight
19:51:23 dansmith because you think you disabled all weights and you get completely random behavior
19:51:36 dansmith yep
19:54:36 openstackgerrit Merged openstack/nova master: Add documentation for documentation contributions https://review.openstack.org/492124
19:55:13 openstackgerrit Merged openstack/nova master: Clean up *most* ec2 / euca2ools references https://review.openstack.org/492166
20:03:11 cdent dansmith: I’m done for the night. I it looks like https://review.openstack.org/#/c/493963/ is going to need a recheck. I put the hash on the backport manually.
20:40:38 oomichi sdake:
20:40:56 oomichi oh, sorry. ^^^ is my mistake
21:17:20 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Tweak connection_info translation for the new Cinder attach/detach API https://review.openstack.org/493324
21:17:20 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285
21:20:43 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Add attachment_complete call to volume/cinder.py https://review.openstack.org/493323
21:20:44 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Tweak connection_info translation for the new Cinder attach/detach API https://review.openstack.org/493324
21:20:44 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285
21:35:09 openstackgerrit Merged openstack/nova master: remove extension param and usage https://review.openstack.org/481491
21:38:51 openstackgerrit Eric Fried proposed openstack/nova master: [Trivial] docstrings, typos, minor refactoring https://review.openstack.org/493701
22:42:19 oomichi melwitt: hi, can you take a look at https://review.openstack.org/#/c/494277 ? That is just a follow-up patch for https://review.openstack.org/#/c/492124
22:42:48 oomichi I hesitated to clear many +1 with updating, then created another one
22:42:56 melwitt oomichi: sure, looking
22:43:02 oomichi thanks :)
22:43:49 melwitt +2
22:44:09 oomichi melwitt: thanks again
22:44:14 melwitt np
22:44:46 melwitt thanks for fixing those up
#openstack-nova - 2017-08-17
01:52:58 openstackgerrit zhangbailin proposed openstack/nova-specs master: Modify spelling error in nova-specs document https://review.openstack.org/494094
01:57:45 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954
02:15:53 openstackgerrit Kevin Zhao proposed openstack/nova master: Add video type virtio for AArch64 https://review.openstack.org/493822
02:15:55 openstackgerrit melanie witt proposed openstack/nova master: Request zero root disk for boot-from-volume instances https://review.openstack.org/428481
02:15:56 openstackgerrit melanie witt proposed openstack/nova master: Claim and report zero root disk for boot-from-volume instances https://review.openstack.org/428505
02:20:20 openstackgerrit melanie witt proposed openstack/nova master: Claim and report zero root disk for boot-from-volume instances https://review.openstack.org/428505
02:51:45 openstackgerrit Merged openstack/nova master: Make scheduler.utils.merge_resources ignore zero values https://review.openstack.org/493963
04:35:46 masber hi, I am getting this error when I try to resize vm openstack "Insufficient compute resources: Requested instance NUMA topology cannot fit the given host NUMA topology." any idea?
04:46:43 masber hi, I am getting this error when I try to resize vm openstack "Insufficient compute resources: Requested instance NUMA topology cannot fit the given host NUMA topology." any idea?
04:55:58 openstackgerrit Merged openstack/nova master: Fix contributor documentation https://review.openstack.org/494277
05:47:15 openstackgerrit Jianghua Wang proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954
07:23:10 openstackgerrit jichenjc proposed openstack/nova master: update comment for dropping support https://review.openstack.org/494061
07:37:24 openstackgerrit jichenjc proposed openstack/nova master: Move common definition into common layer https://review.openstack.org/489491
07:37:25 openstackgerrit jichenjc proposed openstack/nova master: WIP:check query param for service's index function https://review.openstack.org/489492
07:41:49 gibi hm, interesting, freenode klined me during the night due to spamming
07:43:49 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955
07:45:54 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
07:46:10 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
07:47:02 openstackgerrit Michael Still proposed openstack/nova master: Cleanup mount / umount and associated rmdir calls https://review.openstack.org/494423
07:48:10 openstackgerrit Rikimaru Honjo proposed openstack/nova master: compute: Sweep duplicated bdm records https://review.openstack.org/290793
08:36:32 openstackgerrit jichenjc proposed openstack/nova master: WIP: use conf for keystone session creation https://review.openstack.org/485121
09:06:41 openstackgerrit Takashi NATSUME proposed openstack/nova-specs master: Abort Cold Migration https://review.openstack.org/334732
09:16:18 openstackgerrit Pavlo Shchelokovskyy proposed openstack/nova master: Allow shuffling best hosts from weighed hosts https://review.openstack.org/494136
09:23:05 yongwc I have a system volume and boot as a nova instance with FC connection, however when I shutdown the instance, the FC connection still be there, never do the terminate_connection operation, anyone know how I can terminate those FC connection on the nova compute host with openstack operation?
09:37:47 openstackgerrit jichenjc proposed openstack/nova master: WIP: fix race condition https://review.openstack.org/494458
10:21:57 trinaths hi, I get this error when I spawn VM, Instance failed to spawn: libvirtError: monitor socket did not show up: No such file or directory. http://paste.openstack.org/show/618651/
10:22:04 trinaths how to resolve this issue
10:22:06 trinaths please help me
10:34:31 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Live migration failed in xapi pool https://review.openstack.org/489451
10:38:06 jaypipes trinaths: https://docs.fedoraproject.org/en-US/Fedora_Draft_Documentation/0.1/html/Virtualization_Deployment_and_Administration_Guide/App_Domain_Monitor_Socket.html
10:41:02 trinaths jaypipes: thanks for the link. I dont get that error.
10:44:09 trinaths jaypipes: here is the output for instance qemu log, http://paste.openstack.org/show/618655/
10:44:18 trinaths jaypipes: there were no errors reported.
11:01:35 openstackgerrit Pavlo Shchelokovskyy proposed openstack/nova master: Allow shuffling hosts with the same best weight https://review.openstack.org/494136
11:10:48 trinaths jaypipes: i get this error in the instance qemu log, http://paste.openstack.org/show/618660/
11:12:46 jaypipes trinaths: I'm afraid I don't know what the solution to that is. It's definitely not a Nova issue, thouhg.
11:13:01 trinaths jaypipes: agree.
11:33:59 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add __str__ method to Host* objects https://review.openstack.org/493082
11:37:46 openstackgerrit Michael Still proposed openstack/nova master: Cleanup mount / umount and associated rmdir calls https://review.openstack.org/494423
12:21:21 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285
12:23:34 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285
13:39:51 maciejjozefczyk dansmith: Hello, could you take a look on this https://review.openstack.org/#/c/491808/ ?
13:51:26 dansmith maciejjozefczyk: I think you're missing a test case there, comments in the review
14:08:46 maciejjozefczyk dansmith: I dont get your comment. You mean to add asserting that fileters dictonary is dict with specific key set according to test case?
14:10:26 dansmith maciejjozefczyk: you need to assert that the filters dict passed to get_by_filters() looks like you expect and includes the host value you are changing (moving)
14:10:47 dansmith admittedly the test doesn't do a good job of this now, but given that you're moving the code you should make sure you're covered
14:11:14 dansmith because before it was asserting that host was in filters as passed to the _get_instances_on_driver() method, which can no longer be asserted
14:23:04 dansmith maciejjozefczyk: does that make sense? if necessary I can just pull it down and fix it myself
14:26:47 maciejjozefczyk dansmith: I'm back, give me a sec
14:30:56 maciejjozefczyk dansmith: so in test_get_instances_on_driver_fallback() It could be better to add little asserting that filters are the same like in L1451? I thought its already done while checking mock_instance_list mock, but I can add assertEqual too
14:31:12 maciejjozefczyk dansmith: you mean to solve it this way or I'm wrong too?
14:31:59 dansmith maciejjozefczyk: L1451 isn't an assertion
14:34:08 dansmith maciejjozefczyk: your assertion on L1487 is asserting that the thing you passed to _get_instances_on_driver() (which modifies it) is the thing that gets passed to get_by_filters(), but you don't assert what is in it

Earlier   Later