Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-08-16
02:17:36 gaoyuan Anyone met the same problem before?
02:17:49 gaoyuan I was using liberty, when met this problem.
02:47:12 openstackgerrit jichenjc proposed openstack/nova master: update comment for dropping support https://review.openstack.org/494061
03:35:48 openstackgerrit Kevin Zhao proposed openstack/nova master: Make uefi as the default boot perproties for AArch64 https://review.openstack.org/489951
06:35:38 openstackgerrit Maciej Jozefczyk proposed openstack/nova master: Remove host filter for _cleanup_running_deleted_instances periodic task https://review.openstack.org/491808
07:26:14 jaypipes gibi: good morning sir. any new bugs today?
07:26:32 gibi jaypipes: good morning
07:27:11 gibi jaypipes: no new bug today. yet. I have the evacuate and the shelve offload fix proposed if you have time to look at some reviews
07:27:18 openstackgerrit zhangbailin proposed openstack/nova-specs master: Modify spelling error in nova-spec document https://review.openstack.org/494094
07:28:12 gibi jaypipes: shelve offload regression + bugfix https://review.openstack.org/#/c/493062/
07:28:55 gibi jaypipes: I've just noticed that the evac bugfix needs a rebase https://review.openstack.org/#/c/493037/
07:29:01 gibi doing that right now
07:30:58 gibi jaypipes: yesterday I started looking at the soft delete and periodic reclaim case but no definit result yet if there is a bug or not
07:32:47 jaypipes gibi: k, reviewing. even though I hate shelving and all that it entails :)
07:35:56 openstackgerrit Balazs Gibizer proposed openstack/nova master: delete allocation of evacuated instance https://review.openstack.org/493037
07:36:17 gibi jaypipes: thanks. I share your feelings about shelve.
07:46:26 jaypipes gibi: k, https://review.openstack.org/#/c/493062/ reviewed.
07:46:36 jaypipes moving on to https://review.openstack.org/#/c/493834/
07:47:56 openstackgerrit zhangbailin proposed openstack/nova-specs master: Modify spelling error in nova-specs document https://review.openstack.org/494094
07:48:22 gibi jaypipes: thanks, I'm going to check your comments
07:49:49 jaypipes gibi: ok, so let's chat about Ia93168b1560267178059284186fb2b7096c7e81f
07:50:11 gibi jaypipes: sure
07:50:21 jaypipes gibi: it makes me uneasy (and probably dansmith too) to add code to the compute manager to directly call the scheduler report client from the compute manager
07:51:25 gibi jaypipes: should that code moved in to resource_tracker?
07:51:27 jaypipes gibi: I understand why you'd want to do this that way, though (to isolate when the delete_allocation_for_instance() method is called to only be during shelve_offloading() instead of trying to reconcile these things in the perioidic interval task of the RT
07:53:14 gibi jaypipes: do you suggest to try to integrate it to _update_usage_from_instance ? https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L1012
07:54:19 jaypipes gibi: no, that method is already trying to do too much :)
07:54:32 gibi jaypipes: agree
07:54:48 jaypipes gibi: my guess is that for shelve_offloaded instances, the periodic interval is going to hit this code block here: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L1183
07:55:12 jaypipes gibi: because instance.host has not yet been un-set and the allocation for the instance is going to be still in the placmeent API
07:55:41 jaypipes gibi: instead of modifying that code block, I'd prefer to add a new remove_offloaded_instance_allocation() method to the *resource tracker* and call that from the compute manager.
07:57:19 jaypipes gibi: I'll add a comment saying so
07:57:26 jaypipes gibi: does that make sense?
07:57:41 gibi jaypipes: that seems like an easy refactoring on the current patch
07:57:47 gibi jaypipes: so I can do that
07:57:48 jaypipes gibi: ya
07:58:03 jaypipes gibi: basically just hiding the reportclient interaction behind an RT call
07:58:13 gibi jaypipes: make sense
07:58:28 gibi jaypipes: especially as the current patch depends on the rt internals anyhow
08:01:20 jaypipes gibi: ya
08:05:06 maciejjozefczyk jaypipes: Hello, about https://review.openstack.org/#/c/491808/ ; I've removed those unit-tests are not testing anything. Tests for this case i think are already done with ./nova/tests/functional/db/test_build_request.py:test_get_by_filters*
08:05:46 jaypipes maciejjozefczyk: lol, I was just reviewing that :)
08:06:04 maciejjozefczyk jaypipes: :D
08:09:29 jaypipes maciejjozefczyk: k, reviewed. problem found. see review comments :)
08:09:42 gibi jaypipes: did you move to EU or it is just insomnia?
08:10:33 jaypipes gibi: I'm in Prague and Kharkiv for next two weeks at Mirantis offices :)
08:11:17 gibi jaypipes: cool. I like having more cores in EU timezones
08:13:16 openstackgerrit Gao Zexu proposed openstack/nova master: Fix a wrong link https://review.openstack.org/494109
08:14:05 jaypipes gibi: :)
08:14:07 maciejjozefczyk jaypipes: good point!
08:14:15 jaypipes maciejjozefczyk: makes sense, yeah?
08:15:05 gibi jaypipes: I guess your comment also applies to my evac patch as there I also call report client from compute.manager. https://review.openstack.org/#/c/493037/3/nova/compute/manager.py@677
08:16:28 maciejjozefczyk jaypipes: yeah, without this i till copy-paste all instances data from db to agent
08:16:51 maciejjozefczyk in case of driver that is not supporting uuids listening
08:18:01 maciejjozefczyk listining*
08:20:52 jaypipes maciejjozefczyk: right
08:21:08 jaypipes gibi: yup :)
08:30:46 openstackgerrit Chris Dent proposed openstack/nova master: Make scheduler.utils.merge_resources ignore zero values https://review.openstack.org/493963
08:53:59 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257
08:57:51 openstackgerrit Pavlo Shchelokovskyy proposed openstack/nova master: Shuffle best hosts from weighed hosts https://review.openstack.org/494136
08:58:32 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request https://review.openstack.org/451777
09:15:17 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Format NIC features using os-traits definitions https://review.openstack.org/466051
09:24:55 openstackgerrit Chris Dent proposed openstack/nova master: Optimize MiniDNS for fewer syscalls https://review.openstack.org/486829
10:18:59 openstackgerrit Kevin Zhao proposed openstack/nova master: Modify the test case of get_disk_mapping_rescue_with_config https://review.openstack.org/494156
10:46:35 openstackgerrit Maciej Jozefczyk proposed openstack/nova master: Remove host filter for _cleanup_running_deleted_instances periodic task https://review.openstack.org/491808
10:59:13 Borg- hi.
10:59:32 Borg- im trying to list instances from DB... but.. there is no instances table.. wtf?
11:00:57 Borg- ahhh nova_api
11:11:59 openstackgerrit David Rabel proposed openstack/nova master: Adds support for gracefull shutdown for VMware instances https://review.openstack.org/494169
11:27:14 openstackgerrit Takashi NATSUME proposed openstack/nova master: Amend the code review guide for microversion API https://review.openstack.org/494173
11:44:30 openstackgerrit Balazs Gibizer proposed openstack/nova master: delete allocation of evacuated instance https://review.openstack.org/493037
11:57:52 openstackgerrit David Rabel proposed openstack/nova master: Adds support for gracefull shutdown for VMware instances https://review.openstack.org/494169
12:17:22 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add ``HostPortProfileInfo`` class https://review.openstack.org/441590
12:19:19 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add __str__ method to Host* objects https://review.openstack.org/493082
12:29:09 openstackgerrit Pavlo Shchelokovskyy proposed openstack/nova master: Shuffle best hosts from weighed hosts https://review.openstack.org/494136
12:47:22 dtantsur folks, how do I find a flavor by its name from Python API?
12:47:34 dtantsur flavors.get('name') does not seem to work..
12:54:48 vdrok dtantsur: list with filter?
12:55:02 vdrok this is what I see happening in novaclient when getting flavor by name
12:55:11 dtantsur it does not even seem to have a support for filters... well, ok :)
12:56:14 vdrok hrm
12:56:22 jaypipes dtantsur: you can't :(
12:57:45 vdrok `GET call to compute for http://192.168.122.22/compute/v2.1/flavors/baremetal` returns 404, then `GET call to compute for http://192.168.122.22/compute/v2.1/flavors?is_public=None` happens
12:59:26 cdent dtantsur: yup, is a list, then filter of the list to get id, then get by id
12:59:28 cdent woot
12:59:53 dtantsur cdent: what does list() return? does it return full Flavor objects?
13:00:26 cdent dtantsur: I’m not sure of the actual python code that’s being called, just which api requests happen
13:00:42 dtantsur ok, I'll check I guess
13:02:07 dtantsur it seems to have a name and an ID, good enough for my case :)
13:08:19 jaypipes dtantsur: yeah, you need to use the id (which is a string, not an int) when get'ing the flavor :(
13:08:40 openstackgerrit Maciej Jozefczyk proposed openstack/nova master: Remove host filter for _cleanup_running_deleted_instances periodic task https://review.openstack.org/491808
13:08:52 dtantsur heh, okay
13:09:57 dtantsur jaypipes: have you seen https://review.openstack.org/#/c/494136/ ?
13:11:05 dtantsur dansmith: hi, around? wdyt about https://review.openstack.org/#/c/492964/ ?
13:12:36 jaypipes dtantsur: I had not. will look at that now...
13:12:55 dtantsur cool. there is a hope that it will bring a relief to our broken CI
13:34:40 openstackgerrit Ed Leafe proposed openstack/nova master: Remove the Pike migration code for flavor migration https://review.openstack.org/494206
13:35:22 dansmith dtantsur: sweet, I'll have a look again in a bit.. jaypipes can you review that?
13:35:45 dtantsur dansmith: he has his +2 there already
13:37:17 dansmith oh before the tripleo run even I see :)

Earlier   Later