| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-08-09 | |||
| 20:32:53 | mriedem | dansmith: yeah, because the only limits we'd get are from NUMATopologyFilter | |
| 20:33:02 | dansmith | but our limit for vcpus is in there | |
| 20:33:07 | dansmith | otherwise we won't check anything, AFAICT | |
| 20:34:48 | mriedem | oh i see, | |
| 20:34:50 | dansmith | mriedem: we're hitting this code: https://github.com/openstack/nova/blob/master/nova/compute/claims.py#L240-L244 | |
| 20:34:52 | mriedem | CoreFilter puts the vcpu limit in there | |
| 20:34:58 | dansmith | hah | |
| 20:34:58 | mriedem | right | |
| 20:35:15 | dansmith | lemme try with ram or something else | |
| 20:35:17 | mriedem | since the CoreFilter isn't enabled, as noted in the commit message, we don't care about filtering on cores... | |
| 20:36:02 | dansmith | must be same with ramfilter? | |
| 20:36:09 | dansmith | because obviously I don't hit that either since no limit | |
| 20:36:36 | mriedem | the flavor he's using fits the ram on the fake driver | |
| 20:36:46 | dansmith | I mean making it not | |
| 20:36:59 | dansmith | yeah novalidhost when I do that and enable ramfilter | |
| 20:38:28 | mriedem | ok +2 on his test then https://review.openstack.org/#/c/490814/ | |
| 20:38:39 | mriedem | i didn't realize the enabled filters impacted the claim code in the compute | |
| 20:39:46 | dansmith | so I didn't realize the filters controlled the compute node claiming behavior | |
| 20:39:54 | dansmith | not sure that really makes sense | |
| 20:40:07 | mriedem | did you just say the same thing as me? | |
| 20:40:12 | dansmith | however, it's nice to know that removing those base filters will stop the compute node from defeating placement's decisions | |
| 20:40:29 | dansmith | two things to set limits with different logic will definitely lead to confusion-based bugs | |
| 20:41:13 | dansmith | now I just gotta find a typo nit in here to get my stat back and we're good to go | |
| 20:42:15 | dansmith | found one | |
| 20:42:31 | mriedem | which change are you talking about? | |
| 20:42:35 | mriedem | oh gibi's patch | |
| 20:42:38 | dansmith | the test | |
| 20:43:33 | mriedem | removed my +2 just in time | |
| 20:43:37 | openstackgerrit | Jay Pipes proposed openstack/nova master: replace chance with filter scheduler in func tests https://review.openstack.org/491529 | |
| 20:43:43 | dansmith | I was just bluffing | |
| 20:43:49 | dansmith | I did find one but it's not worth delaying over | |
| 20:43:49 | mriedem | d'oh | |
| 20:44:05 | mriedem | heh replaying my +2 | |
| 20:44:39 | mriedem | are you happy with cfriesen's wording here then? https://review.openstack.org/#/c/491854/ | |
| 20:45:50 | dansmith | mriedem: I wouldn't say I'm happy | |
| 20:46:05 | mriedem | jaypipes: i'm not sure why i'm the author on this https://review.openstack.org/#/c/488510/3 | |
| 20:46:07 | mriedem | https://review.openstack.org/#/c/488510/ | |
| 20:46:32 | dansmith | mriedem: I've noticed that on a couple things you've updated recently | |
| 20:46:38 | dansmith | resetting the author for some reason I mean | |
| 20:46:38 | mriedem | i didn't update this | |
| 20:46:45 | jaypipes | yeah, me too... | |
| 20:46:51 | jaypipes | haven't cared much, though. :) | |
| 20:47:04 | dansmith | mriedem: you did, PS15 | |
| 20:47:09 | dansmith | and 16 | |
| 20:47:19 | mriedem | yeah it was PS15 | |
| 20:47:31 | mriedem | jaypipes: you want to fix that quick? | |
| 20:47:34 | jaypipes | mriedem: I certainly didn't change the author. | |
| 20:47:42 | jaypipes | mriedem: how do I do that? | |
| 20:47:52 | mriedem | git commit --amend --author "Jay Pipes <jaypipes@gmail.com>" | |
| 20:47:57 | dansmith | are we re-pushing this anyway? | |
| 20:48:07 | dansmith | because ... six hour check run | |
| 20:48:11 | jaypipes | gimme a sec, will do. | |
| 20:48:31 | mriedem | dansmith: i brought it up in the ML http://lists.openstack.org/pipermail/openstack-dev/2017-July/119801.html | |
| 20:48:51 | mriedem | i don't know what causes it automatically, something to do with git review -d + git rebase -i + git commit | |
| 20:48:53 | openstackgerrit | Jay Pipes proposed openstack/nova master: Remove provider allocs in confirm/revert resize https://review.openstack.org/488510 | |
| 20:48:53 | openstackgerrit | Jay Pipes proposed openstack/nova master: Resource tracker compatibility with Ocata and Pike https://review.openstack.org/491012 | |
| 20:48:59 | jaypipes | ok, mriedem done | |
| 20:49:22 | dansmith | mriedem: I do that all the time and it doesn't reset for me | |
| 20:49:30 | dansmith | I've had my way with all of jay's patches that way | |
| 20:49:52 | mriedem | git version 2.7.4 ? | |
| 20:50:20 | dansmith | indeed actually | |
| 20:50:23 | mriedem | git-review Version: 1.25.0 | |
| 20:50:34 | dansmith | same | |
| 20:50:45 | dansmith | I'm not running Windows98 or whatever you run though | |
| 20:51:02 | mriedem | this is xenial 16.04 | |
| 20:52:46 | mriedem | huh | |
| 20:52:46 | mriedem | user@ubuntu:~/git/nova$ cat /etc/debian_version | |
| 20:52:46 | mriedem | stretch/sid | |
| 20:52:58 | jaypipes | mriedem: quick summary of the cause of the "claim mystery" from that resize too big patch please? | |
| 20:52:59 | dansmith | expected :) | |
| 20:53:08 | dansmith | jaypipes: he put it in the comments | |
| 20:53:17 | dansmith | jaypipes: corefilter notenabled == no limit == no vcpu check on the compute node | |
| 20:53:23 | jaypipes | ah | |
| 20:53:34 | dansmith | I'm embarrassed to say I didn't know we had that linkage | |
| 20:53:38 | dansmith | and also, am horrified | |
| 20:54:07 | mriedem | dansmith: like how i gave you credit in those comments? | |
| 20:54:15 | mriedem | does your ego feel better? | |
| 20:54:36 | dansmith | mriedem: yes, that's why I didn't NFO your stats over a comment grammar issue :) | |
| 20:54:56 | mriedem | naval flight officer? | |
| 20:55:26 | dansmith | nuke from orbit | |
| 20:55:27 | dansmith | maybe not a fun analogy these days I guess | |
| 20:55:44 | dansmith | as PDX has been one of the west coast targets mentioned | |
| 20:55:50 | mriedem | heh, fire and fury baby | |
| 20:56:17 | mriedem | urban dictionary has a fun one | |
| 20:56:19 | mriedem | "Near Fatal Orgasm" | |
| 21:00:16 | mriedem | jaypipes: ok +2 on gibi's fix https://review.openstack.org/#/c/491491/ but letting you take the final gander | |
| 21:00:45 | jaypipes | mriedem: k, reviewing. | |
| 21:02:17 | jaypipes | mriedem: done | |
| 21:03:09 | dansmith | I hope all these gaping holes that gibi has found in the last two weeks are coming from him poking at it for reals | |
| 21:03:27 | dansmith | and if so, kudos | |
| 21:03:56 | mriedem | cfriesen: something you should probably fix in here https://review.openstack.org/#/c/491854/ | |
| 21:04:22 | mriedem | yes gibi gets the last minute testing champion award | |
| 21:04:29 | cfriesen | dansmith: what changes would you like in https://review.openstack.org/#/c/491854/ ? | |
| 21:04:41 | mriedem | cfriesen: see the comment i just left | |
| 21:06:23 | cfriesen | mriedem: I can fix that easy. Sounded like Dan wanted something else though as well. | |
| 21:06:59 | mriedem | no he was just being dan | |
| 21:07:14 | cfriesen | oh, in that case | |
| 21:07:40 | mriedem | dansmith: per your question about testing in https://review.openstack.org/#/c/487954/ - there is a change that depends on it here: https://review.openstack.org/#/c/476968/ | |
| 21:08:33 | efried | edmondsw Do you know how we're importing the keystone_authtoken conf group?? | |
| 21:09:32 | openstackgerrit | Chris Friesen proposed openstack/nova master: Remove ram/disk sched filters from default list https://review.openstack.org/491854 | |