Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-08-08
09:20:16 gibi the problem is that now we load only the ComputeFilter in other tests and that cache makes the tests interdependent
09:20:33 gibi so I have to invalidate the cache in the server_group tests
09:21:01 gibi I will push that soon
09:24:36 bauzas gibi: sounds like a fixture to me
09:25:55 gibi bauzas: like a scheduler fixture that 1) invalidate the cache 2) configure the requested filters 3) starts the scheduler service ?
09:26:28 gibi please note that the cache only affect the server group behavior
09:30:34 bauzas gibi: it affected the server group behaviour because we don't define filters to run ?
09:33:18 gibi bauzas: if the first test that hit https://github.com/openstack/nova/blob/master/nova/scheduler/utils.py#L403 has only ComputeFilter configured then a later server_group test fails as _get_group_details raise an exception based on a stale cache
09:34:18 gibi bauzas: previously every filter was configured by default, now it is on ComputeFilter
09:34:49 openstackgerrit Balazs Gibizer proposed openstack/nova master: replace chance with filter scheduler in func tests https://review.openstack.org/491529
09:35:07 gibi bauzas: ^^ now this should pass the func test on the gate as well
09:41:07 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Add datapath type information to OVS vif objects https://review.openstack.org/474892
09:43:17 bauzas gibi: I left some comments
09:43:31 bauzas gibi: I'm unclear on some needed modifications
09:43:45 gibi bauzas: looking
09:48:05 gibi bauzas: responeded
09:51:53 bauzas gibi: okay, looking
09:54:05 bauzas gibi: about the doubled allocation, I thought we were just doing that against different hosts
09:54:19 bauzas gibi: if we resize on same host, we also duplicate the allocation ?
09:54:40 bauzas :/
09:54:55 gibi bauzas: I think so https://review.openstack.org/#/c/490085/
09:55:09 bauzas gibi: could you just split your change in twice then ?
09:55:14 bauzas gibi: and test
09:56:02 gibi bauzas: do you mean one patch for the vcpu=2 and the other is the rest?
09:56:33 gibi I'm going to eat something now but then I will be back
09:57:06 bauzas gibi: well, the problem I see is that if you need to resize an instance, you absolutely now need 2 CPUs
09:57:20 bauzas even for an AIO
09:57:46 bauzas that's probably something I wasn't really concerned, but you can play with allocation ratios
09:57:57 bauzas gibi: oh had a thought
09:58:25 bauzas gibi: what if instead of modifying the fake driver resource, you would just amend the according resize test by providing a cpu allocation ?
09:58:35 bauzas allocation ratio ?
09:58:54 bauzas gibi: it should anyway default to 16.0 so I don't really see *why* we need that
10:52:11 gibi bauzas: OK, I will look into the resize test
11:04:16 cdent gibi: what new bugs have you found today
11:06:38 cdent gibi, bauzas : have you guys seen this https://review.openstack.org/#/c/489205/ is a fix for https://bugs.launchpad.net/nova/+bug/1708978 which is something we ought to make sure is in pike
11:06:39 openstack Launchpad bug 1708978 in OpenStack Compute (nova) "The traits associations are deleted incorrectly" [High,In progress] - Assigned to Alex Xu (xuhj)
11:09:05 gibi cdent: hi! no new bug today
11:09:28 cdent <- disbelief
11:09:33 gibi slow day
11:10:00 gibi still working on the removal of the change scheduler in the func test and the resize to too big flavor patches
11:10:24 gibi so I had no time to play with some custom resource + resize tests
11:10:33 gibi that will be my next fun
11:11:45 cdent I’m not having the best success trying to keep track of everything: there are lots of indvidual patch sets spread around. I need to take some time to find them all.
11:13:41 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add memoize function using oslo.cache https://review.openstack.org/472773
11:13:47 gibi most of them tight to a bug report
11:14:05 gibi so if you look at the high prio bugs then your will find relevant patches
11:14:55 cdent gibi: yeah, I know, it is more in terms of being able to have them all at once for a) an overview of what’s up, b) some local testing with the pending stuff
11:15:37 cdent since they are all spread around, there’s no easy way, to, for example, answer the question of “do these fixes play well together” or “what coverage is missing”
11:17:04 gibi cdent: ahh I see
11:17:12 gibi cdent: I have no good answer for that
11:17:15 cdent :)
11:17:58 cdent I’m currently looking at coverage results when running just functional/test_servers.py to see if that raises any alarms. But because I’m looking at master I now it is missing several of the things that are in progress.
11:20:50 cdent gibi: a lot of what is missing is related to custom resource classes, so your plans for that will be useful
11:23:31 openstackgerrit Alex Xu proposed openstack/nova master: placement: ensure sharing RPs maps combinates with correct shared RP https://review.openstack.org/480379
11:23:32 openstackgerrit Balazs Gibizer proposed openstack/nova master: replace chance with filter scheduler in func tests https://review.openstack.org/491529
11:23:52 alex_xu cdent: ^ remove the 'root', instead to use 'sharing' and 'shared'
11:24:02 gibi cdent: now I just have to find the time to write them :)
11:24:08 cdent thank you alex_xu
11:24:27 gibi bauzas: I removed the vcpu=2 from the SmallFakeDriver to see what fails
11:24:46 gibi bauzas: I think we have a problem with the default 16.0 allocation ration. I don't see that it is applied at all
11:24:58 alex_xu cdent: hope that works :)
11:26:26 gibi bauzas: here is an example test failure http://paste.openstack.org/show/617764/
11:26:26 cdent gibi: do you get reasonable results from placement, but then the fake driver refuses then? If so, it’s probably a bug in the driver itself. If you’re not getting results from placement then is the inventory being set properly?
11:27:39 gibi cdent: L66 worries me http://paste.openstack.org/show/617764/
11:28:15 cdent gibi: it’s max_unit,
11:28:21 cdent that’s the problem
11:28:31 cdent and is an actual problem:
11:29:10 cdent we set max_unit to be the number of real cpus because we don’t think any single consumer should occupy more than the number of cpus, whatever allocation ratio says
11:29:13 cdent which makes sense
11:29:31 cdent but when we create a doubling allocation for the resize to same host, we’re breaking that
11:30:13 gibi bauzas: ^^
11:30:17 cdent so as the code is currently designed, if using doubling, you can never resize to same host a guest with #vcpus == #pcpus
11:30:29 cdent the quick fix for the tests is to use a bigger driverr
11:30:44 gibi yes, that was what I proposed the bauzas suggested allocation ratio
11:30:54 gibi but then I guess we cannot use the allocation ratio trick here
11:31:02 cdent but we may need to consider that the doubling concept is problematic on small hosts…
11:31:14 cdent yeah, allocation ratio doesn’t do anything for max_unit
11:32:34 gibi OK I wait for bauzas to agree then I will push back the previos patch set of https://review.openstack.org/#/c/491529/ that has the SmallFakeDriver modification to 2 vcpus
11:33:07 cdent alex_xu: it isn’t quite right. I’m trying to come up with a suitable alternative. I’ll push something up if that’s okay with you?
11:33:53 alex_xu cdent: yea, appreciate the help, looks like I understand 'shared' and 'sharing' incorrectly
11:33:58 openstackgerrit Sean Dague proposed openstack/nova master: Fix all >= 2 hit 404s https://review.openstack.org/491761
11:34:27 cdent gibi: seems reasonable. I wonder who has an answer to the question about the legitimacy of resizing a large guest on a small host. I don’t really know. I wouldn’t want to do it, but I’m not paying for hardware...
11:35:44 gibi resize on same host feels like a feature to support testing resize on single node devstack
11:39:42 openstackgerrit Sean Dague proposed openstack/nova master: Create reference subpage https://review.openstack.org/490994
11:51:45 openstackgerrit Chris Dent proposed openstack/nova master: placement: ensure RP maps to those RPs that share with it https://review.openstack.org/480379
11:54:12 cdent alex_xu: ^ that may be a bit better. I ended up finding it difficult to make clear.
11:55:33 alex_xu cdent: thanks
11:58:22 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091
12:01:24 openstackgerrit Balazs Gibizer proposed openstack/nova master: Raise NoValidHost if no allocation candidates https://review.openstack.org/491491
12:02:31 gibi bauzas: fixed your comment about the test ^^
12:12:33 bauzas cdent: looking at alex_xu change, thanks for it
12:13:32 bauzas gibi: cdent: looking at the above discussion, could you please summarize the problem with ratios ?
12:14:23 gibi bauzas: we set max_unit of the vcpu resource based on the number of pcpus therefore we cannot ask for more than pcpu amount of vcpu in a single allocation
12:14:39 alex_xu bauzas: thanks for the review
12:14:48 bauzas gibi: mmm, sadly then
12:21:17 gibi bauzas: so are you OK with the SmallFakeDriver vcpu=2 change?
12:21:24 bauzas gibi: looking
12:23:39 bauzas gibi: just reviewing alex_xu and then it's your turn :p
12:25:57 gibi bauzas: OK, thanks
12:28:53 openstackgerrit Alexandra Settle proposed openstack/nova master: Create reference subpage https://review.openstack.org/490994

Earlier   Later