| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-08-07 | |||
| 21:58:50 | cdent | jaypipes, dansmith: i’m somewhat lost on the current scheduler/placement situation. What’s currently on the urgent to do list? (I’m trying to make my plan for tomorrow morning) | |
| 21:59:18 | dansmith | cdent: waiting for jaypipes to refresh the patches, AFAIK | |
| 21:59:43 | jaypipes | dansmith, cdent: yeah, I'm still on it :( I'm lost in unit test hell. :( | |
| 22:00:04 | cdent | okay, I’ll go looking for those in the morning | |
| 22:00:54 | openstackgerrit | Merged openstack/nova master: Use wsgi-intercept in OSAPIFixture https://review.openstack.org/486825 | |
| 22:00:56 | jaypipes | cdent: thx for the cookies. :) | |
| 22:01:37 | cdent | hmmm, I wonder if we wanted to merget that ^^ right now. Will be interesting to see how/if that impacts the gate. | |
| 22:09:28 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Base _ContextAuthPlugin on BaseIdentityPlugin https://review.openstack.org/491203 | |
| 22:11:01 | openstackgerrit | Eric Fried proposed openstack/nova master: Get auth from context for glance endpoint https://review.openstack.org/490057 | |
| 22:11:34 | efried | sdague yt? | |
| 22:38:08 | openstackgerrit | Ed Leafe proposed openstack/nova master: replace chance with filter scheduler in func tests https://review.openstack.org/491529 | |
| 23:20:07 | openstackgerrit | Mohammed Naser proposed openstack/nova master: Introduce new percentage based RAM weigher https://review.openstack.org/491561 | |
| 23:22:24 | cdent | oh look at the time | |
| 23:37:08 | openstackgerrit | Merged openstack/nova master: Split Compute.errors_out_migration into a separate contextmanager https://review.openstack.org/485734 | |
| #openstack-nova - 2017-08-08 | |||
| 02:17:15 | openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/490859 | |
| 05:11:22 | ratailor | alex_xu, Hi | |
| 05:11:31 | ratailor | alex_xu, you around ? | |
| 05:30:15 | ratailor | any sqlalchemy expert here ? | |
| 05:46:45 | suzhengwei_ | Live-migration one instance, if not give destination host, disable nova-compute node will not be scheduled. | |
| 05:46:45 | suzhengwei_ | but if give a disable nova-compute node as the destination host, the migration will execute. | |
| 05:46:45 | suzhengwei_ | What is the consideration of this inconsistent behavior? | |
| 05:52:56 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Improve stable-api doc with current API state https://review.openstack.org/489926 | |
| 06:22:54 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Improve stable-api doc with current API state https://review.openstack.org/489926 | |
| 06:35:36 | openstackgerrit | Merged openstack/nova master: [placement] Add api-ref for RP allocations https://review.openstack.org/450550 | |
| 06:53:05 | alex_xu | ratailor: hi, I'm here | |
| 06:58:12 | openstackgerrit | Bhagyashri Shewale proposed openstack/nova master: Deny volume swapping with non-bootable volume https://review.openstack.org/407346 | |
| 07:01:43 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: fix nova accepting invalid availability zone name with ':' https://review.openstack.org/490722 | |
| 07:01:46 | ratailor | alex_xu, shouldn't this provide case-sensitive result. https://github.com/openstack/nova/blob/master/nova/objects/host_mapping.py#L93 | |
| 07:05:54 | alex_xu | ratailor: mysql doesn't support case-sensitive | |
| 07:06:11 | alex_xu | ratailor: what is your problem? the host name is case-insensitive also? | |
| 07:06:19 | ratailor | alex_xu, so what could be done in that case. | |
| 07:06:22 | ratailor | alex_xu, yes. | |
| 07:07:11 | ratailor | If I try to add a compute node "COMPUTE1.example.com" to host-aggregate, but in fact the actual hostname of node is "compute1.example.com". It should throw HostNotFound error. | |
| 07:07:16 | ratailor | alex_xu, ^^ | |
| 07:08:02 | ratailor | alex_xu, but in this case the host is added to host-aggregate. and while spawning instance scheduler don't filter that host, as it is not actually present. | |
| 07:22:57 | alex_xu | ratailor: emm... | |
| 07:26:59 | alex_xu | ratailor: I guess due to the scheduler keep host<->aggregate mapping in the memory, then the thing becomes case-sensitive | |
| 07:28:17 | alex_xu | ratailor: https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L359 | |
| 07:28:33 | alex_xu | ratailor: have you file a bug for it? | |
| 07:28:38 | ratailor | alex_xu, might be. but even if scheduler fetches it from db, there won't be any host with hostname "COMPUTE1.example.com", so we won't be able to create instance on that. | |
| 07:28:42 | ratailor | alex_xu, not yet. | |
| 07:28:59 | ratailor | alex_xu, I will do that in some time. | |
| 07:29:36 | alex_xu | ratailor: yes, so there is no host_state for 'COMPUTE1.exmaple.com', but there will be a mapping for it in the host_aggregates_map | |
| 07:30:08 | ratailor | alex_xu, yes, | |
| 07:40:22 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: replace chance with filter scheduler in func tests https://review.openstack.org/491529 | |
| 07:44:19 | ratailor | alex_xu, I have reported in launchpad, FYI https://bugs.launchpad.net/nova/+bug/1709260 | |
| 07:44:20 | openstack | Launchpad bug 1709260 in OpenStack Compute (nova) "Addition of host to host-aggregate should be case -sensitive" [Undecided,New] | |
| 07:44:29 | alex_xu | ratailor: thanks | |
| 07:45:17 | ratailor | alex_xu, welcome :) | |
| 08:17:36 | bauzas | gibi: FWIW, reviewing your change today | |
| 08:34:17 | gibi | bauzas: thanks a lot | |
| 08:34:29 | bauzas | tbc, the chance one | |
| 08:34:48 | bauzas | did Gerrit was upgraded ? | |
| 08:35:00 | bauzas | I just provided an URL in a comment and it broke weirdly | |
| 08:36:10 | gibi | bauzas: that change still fail on the gate with the server_group tests but I cannot repoduce it locally and I even removed every server_group related change for them patch | |
| 08:36:22 | bauzas | gibi: ok | |
| 08:37:04 | gibi | bauzas: so any comment is really appreciated | |
| 08:40:37 | gibi | bauzas: also I'm curious about your oppinion about https://review.openstack.org/#/c/491491/4/nova/tests/unit/scheduler/test_scheduler.py@152 | |
| 08:41:40 | bauzas | gibi: you mean about legacy filters being still in use ? | |
| 08:42:14 | gibi | bauzas: about raising NoValidHost if Placement API is not available or not upgraded | |
| 08:43:23 | gibi | bauzas: raising NoValidHost if Placemnet returns {} is clearly a good thing but I'm a bit uneasy about the two other cases | |
| 08:49:04 | bauzas | gibi: sorry, was just refueling my stomach | |
| 08:49:23 | bauzas | by coffee (10:40am here, what people are thinking ?) | |
| 08:50:09 | bauzas | gibi: about the NoValidHost exception ? Well, correct me if I'm wrong but we already do that :) | |
| 08:50:22 | bauzas | gibi: we just return an empty list that will eventually raise that error :) | |
| 08:53:07 | gibi | bauzas: if Placement is not available then Scheduler falls back to normal filtering and if CoreFilter is not enabled it can select a host with not enough vcpu | |
| 08:54:24 | gibi | bauzas: now this can happen in three cases, Placement cannot be accessed, Placement is not upgraded, or Placement returned {}. | |
| 08:54:44 | gibi | bauzas: in the third one I'm happy to raise NoValidHost | |
| 08:54:48 | bauzas | gibi: wait, are you sure ? | |
| 08:55:30 | bauzas | gibi: when I wrote the BP about scheduler calling placement in Ocata, I made it clear that if Placement wasn't there, we should return an empty list | |
| 08:55:31 | gibi | bauzas: based on this https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L133 | |
| 08:55:44 | bauzas | then it's a regression | |
| 08:55:56 | bauzas | in Pike | |
| 08:56:25 | gibi | so it is OK for you to raise NoValidHost in all the 3 cases. I can accept this. :) | |
| 08:56:27 | bauzas | Placement isn't optional | |
| 08:56:34 | bauzas | if the driver supports it | |
| 08:56:50 | bauzas | at least that's what we had in Ocata | |
| 08:56:57 | bauzas | gibi: lemme show you the ocata code | |
| 08:57:12 | gibi | bauzas: but then this whole bunch of code is unnecessary https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L124-L144 | |
| 08:58:27 | bauzas | gibi: https://github.com/openstack/nova/blob/stable/ocata/nova/scheduler/filter_scheduler.py#L184-L189 | |
| 08:59:31 | gibi | bauzas: OK, that sounds convincing | |
| 09:00:00 | bauzas | that's at least what we had in Ocata | |
| 09:00:17 | bauzas | given it was in the filter scheduler code, it was only for that driver | |
| 09:00:26 | gibi | bauzas: then I' don't know why we have so much code in the scheduler manager to distinguish between the different cases | |
| 09:00:40 | bauzas | probably a consequence of reviews and whack-a-mole gaming | |
| 09:00:42 | gibi | either we got a non empty result from placement or it is a NoValidHost | |
| 09:00:56 | bauzas | or we could want to be more gentle | |
| 09:01:04 | bauzas | and in that case, it's a feature | |
| 09:01:28 | gibi | then my patch breaking that feature | |
| 09:01:29 | bauzas | but the fact is, we came from a fact in Ocata where any problem communicating to Placement was leading to a NoValidHost | |
| 09:03:40 | gibi | and as in Ocata placement was not mandatory we needed to easy that up | |
| 09:04:14 | gibi | but can we be strict in Pike? | |
| 09:09:19 | bauzas | gibi: no, Placement was optional in Newton but mandatory in Pike | |
| 09:09:26 | bauzas | graaah | |
| 09:09:35 | bauzas | lemme rephrase it | |
| 09:10:06 | bauzas | gibi: Placement = {"Newton": "optional", "Ocata": "mandatory"} | |
| 09:10:34 | gibi | so we can be strict in Pike | |
| 09:10:53 | gibi | then I'm happy to raise NoValidHost in all three cases | |
| 09:11:23 | bauzas | gibi: https://docs.openstack.org/releasenotes/nova/ocata.html#id7 | |
| 09:11:35 | bauzas | "he Nova FilterScheduler driver is now able to make scheduling decisions based on the new Placement RESTful API endpoint that becomes mandatory in Ocata. " | |