| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-08-03 | |||
| 10:45:46 | mdbooth | The code's fine. | |
| 10:46:08 | lyarwood | right, I can't see anything in master that would handle a corner case for active instances | |
| 10:46:25 | lyarwood | so having it in stable should be the same | |
| 10:46:47 | robcresswell | sdague: Referring the edit flavor issue, if that wasnt apparent. I'm not a fan of UI's inventing features that APIs dont support, so I'm on board with getting rid of it. So I'll make the settings changes and deprecate it for Pike. | |
| 10:46:50 | lyarwood | running instances wouldn't be touched until they reboot and the domain is recreated | |
| 10:46:50 | mdbooth | My concern would exclusively be around potential for weirdness if an instance reboots and gets very slightly different domain xml. | |
| 10:47:30 | mdbooth | It's probably fine, though. | |
| 10:47:41 | sdague | robcresswell: works for me | |
| 10:48:05 | mdbooth | It's just a question about how conservative we are with stable, and user's reasonable expectations around such changes with minor updates within stable. | |
| 10:48:07 | robcresswell | sdague: Cool. Sorry for the trouble thats caused you. I wasn't really aware of the issue. | |
| 10:48:30 | sdague | robcresswell: or at least a popup warning. I think the way it was presented to users they didn't realize that it wasn't a native feature and that it would cause issues | |
| 10:48:48 | sdague | robcresswell: yeh, honestly, a lot of the nova team didn't realize it was a thing until atlanta ptg | |
| 10:55:36 | robcresswell | sdague: Yeah, fair enough. At least we can start solving it now. | |
| 10:55:56 | robcresswell | sdague: If anything else like this comes up, feel free to ping me about it. I do love to remove code. | |
| 10:56:55 | sdague | will do | |
| 11:08:00 | maestropandy | Please vote (+3) for our presentation submitted for openstack sydney 2017. Today last day for voting, requesting all to vote. OpenStack cloud storage - Advanced performance tuning & operational best practices with Ceph https://www.openstack.org/summit/sydney-2017/vote-for-speakers/#/19056 ##### Docker Networking over OpenStack Cloud – Challenges, Solutions & Road-map >> https://www.openstack.org/summit/sydney-2017/vote-for-speakers/#/1 | |
| 11:08:51 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] Avoid error log on 405 response https://review.openstack.org/490021 | |
| 11:30:43 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091 | |
| 11:32:13 | openstackgerrit | Sean Dague proposed openstack/nova master: Fix lists in process doc https://review.openstack.org/490431 | |
| 11:33:42 | stephenfin | maestropandy: I would imagine this also applies to IRC http://lists.openstack.org/pipermail/openstack-dev/2017-July/120121.html Please don't do it | |
| 11:42:33 | openstackgerrit | Sean Dague proposed openstack/nova master: Fix whitespace in rest_api_version_history https://review.openstack.org/490435 | |
| 11:47:03 | openstackgerrit | Sean Dague proposed openstack/nova master: Fix list rendering in code-review.rst https://review.openstack.org/490437 | |
| 11:51:37 | openstackgerrit | Sean Dague proposed openstack/nova master: fix list rendering in rpc doc https://review.openstack.org/490442 | |
| 11:53:56 | sdague | stephenfin: so I'm just going through the toc list and looking for the blockquotes popping out and fixing | |
| 12:00:37 | stephenfin | sdague: Done | |
| 12:00:54 | openstackgerrit | Sean Dague proposed openstack/nova master: Fix list rendering in bdm doc. https://review.openstack.org/490446 | |
| 12:05:07 | openstackgerrit | Sean Dague proposed openstack/nova master: fix list rendering in aggregates https://review.openstack.org/490448 | |
| 12:05:52 | stephenfin | sdague: That's a lot of patches | |
| 12:06:10 | stephenfin | tbh, if they're all that simple, I think you could squash em | |
| 12:06:23 | openstackgerrit | Sean Dague proposed openstack/nova master: fix list rendering in cells https://review.openstack.org/490449 | |
| 12:06:34 | sdague | stephenfin: if you want I can | |
| 12:06:49 | sdague | some of them are big enough that one per file seemed fine | |
| 12:06:58 | sdague | and less likely to merge conflict the world and redo them all | |
| 12:07:25 | sdague | the don't use much test resource | |
| 12:08:17 | sdague | stephenfin: the space you point out here doesn't matter for html rendering - https://review.openstack.org/#/c/490431 | |
| 12:09:54 | openstackgerrit | Matthew Booth proposed openstack/nova master: Fix scope of errors_out_migration in resize_instance https://review.openstack.org/487495 | |
| 12:09:55 | openstackgerrit | Matthew Booth proposed openstack/nova master: Split Compute.errors_out_migration into a separate contextmanager https://review.openstack.org/485734 | |
| 12:09:55 | openstackgerrit | Matthew Booth proposed openstack/nova master: Automatically revert resize which fails on destination https://review.openstack.org/462521 | |
| 12:09:56 | openstackgerrit | Matthew Booth proposed openstack/nova master: Functional test for auto revert resize https://review.openstack.org/489654 | |
| 12:09:56 | openstackgerrit | Matthew Booth proposed openstack/nova master: fake_notifier: Refactor wait_for_versioned_notification https://review.openstack.org/489637 | |
| 12:09:57 | openstackgerrit | Matthew Booth proposed openstack/nova master: Fix scope of errors_out_migration in finish_resize https://review.openstack.org/487515 | |
| 12:09:57 | openstackgerrit | Matthew Booth proposed openstack/nova master: Ensure errors_out_migration errors out migration https://review.openstack.org/479802 | |
| 12:10:44 | openstackgerrit | Sean Dague proposed openstack/nova master: fix list rendering in policy-enforcement https://review.openstack.org/490451 | |
| 12:12:39 | sdague | stephenfin: that looks like all the top level ones at least | |
| 12:17:37 | openstackgerrit | sahid proposed openstack/nova master: libvirt: update the active migrations DS to support migration result https://review.openstack.org/409260 | |
| 12:17:39 | openstackgerrit | sahid proposed openstack/nova master: libvirt: ensure live-migration success https://review.openstack.org/409261 | |
| 12:18:11 | openstackgerrit | Sean Dague proposed openstack/nova master: reflow rpc doc to 80 columns https://review.openstack.org/490455 | |
| 12:18:58 | openstackgerrit | Sean Dague proposed openstack/nova master: reflow rpc doc to 80 columns https://review.openstack.org/490455 | |
| 12:21:52 | moshele | sahid: hi can you review https://review.openstack.org/#/c/398265/ ? | |
| 12:29:50 | stephenfin | sdague, asettle: Oh, did we change the docs job to only build docs now? | |
| 12:30:11 | asettle | Uhh I don't think so, no | |
| 12:30:15 | asettle | I asked about it | |
| 12:30:27 | asettle | You can adjust it, but there was a recommendation not to keep it | |
| 12:31:03 | stephenfin | asettle: I ask because I note that https://review.openstack.org/#/c/490448/ has returned Jenkins results for only two jobs | |
| 12:31:06 | stephenfin | so something changed | |
| 12:31:27 | asettle | Oh, weird... I didn't touch that (I know, I know, I didn't stick my nose in this one :P) | |
| 12:31:38 | asettle | stephenfin: maybe check in infra | |
| 12:32:14 | asettle | It is only a white space edit... hmmm | |
| 12:39:02 | sambetts | jaypipes, edleafe: I think we might need to do this to fix the ironic resource class logic: https://review.openstack.org/#/c/490459/ | |
| 12:41:22 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: WIP: resize with custom resource https://review.openstack.org/490461 | |
| 12:46:46 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: WIP: resize with custom resource https://review.openstack.org/490461 | |
| 12:52:33 | edleafe | sambetts: just getting caffeinated | |
| 12:52:50 | edleafe | sambetts: looking at the bug report, it seems that the the flavor itself in wrong | |
| 12:53:13 | sambetts | edleafe: the bug report was for a different issue | |
| 12:53:14 | edleafe | sambetts: it zeroes out the "standard" resources, but doesn't include the ironic resource class | |
| 12:53:29 | sambetts | edleafe: the bug report is unrelated to using it with Ironic | |
| 12:53:42 | stephenfin | sdague: They're all done. The only one I'm not gone on is the last. I can fix the issues I have if you want https://review.openstack.org/#/c/490455/2 | |
| 12:53:43 | edleafe | sambetts: well, not really | |
| 12:54:00 | edleafe | as Ironic would be the only system using flavors like that | |
| 12:54:33 | sambetts | but in a non-ironic deployment there is nothing stopping me creating a flavor like that and nova doesn't error nicely | |
| 12:54:46 | sambetts | thats what the bug report is saying | |
| 12:55:02 | sambetts | thats why it doesn't mention ironic | |
| 12:55:35 | sambetts | you can't say its not a bug because someone would just not do that in a normal case | |
| 12:55:50 | edleafe | sambetts: Sure, but there are a zillion incorrect ways to do things. We can't protect against every wrong setup | |
| 12:56:51 | edleafe | sambetts: it is returning a 400, as it should | |
| 13:00:42 | sambetts | I just don't expect that nova should even make the request to the placement API, because the error message identifies a bad request from nova | |
| 13:07:39 | cdent | \o/ | |
| 13:08:35 | cdent | so no matt, jay or dan yet it seems, I guess I’ll see if can fix the test issues in 488510 | |
| 13:18:48 | edleafe | cdent: there are some ironic resource class issues if you're bored :) | |
| 13:19:23 | cdent | edleafe: heh, issues abound | |
| 13:19:33 | cdent | i’m looking at fixing these test issues | |
| 13:19:37 | cdent | they are mostly mechanical | |
| 13:19:42 | cdent | but plentiful | |
| 13:19:43 | edleafe | cool | |
| 13:29:12 | openstackgerrit | Stephen Finucane proposed openstack/nova master: reflow rpc doc to 80 columns https://review.openstack.org/490455 | |
| 13:30:34 | openstackgerrit | Matt Riedemann proposed openstack/nova master: hardware offload support for openvswitch https://review.openstack.org/398265 | |
| 13:37:12 | openstackgerrit | Merged openstack/nova master: Fix lists in process doc https://review.openstack.org/490431 | |
| 13:40:31 | dansmith | mriedem: are you working on that set? | |
| 13:40:33 | openstackgerrit | Merged openstack/nova master: Fix whitespace in rest_api_version_history https://review.openstack.org/490435 | |
| 13:40:43 | dansmith | mriedem: I just commented on both the bottom two | |
| 13:41:14 | openstackgerrit | Merged openstack/nova master: Fix list rendering in code-review.rst https://review.openstack.org/490437 | |
| 13:42:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Make use of definition lists, literals https://review.openstack.org/490481 | |
| 13:43:12 | cdent | dansmith, mriedem I was going to fix the failing unit tests on the top patch, but my lack of familiarity is meaning that teasing out the mocks is proving slow. If one of you two want to pick it up, that’s cool, otherwise I’ll carry on and learn something | |
| 13:43:34 | stephenfin | mriedem: Is it too late to ask for FFE for this? https://review.openstack.org/#/c/453808/3 | |
| 13:44:06 | stephenfin | I can't work on moving nova-manage to cliff for another six months without it | |
| 13:44:06 | dansmith | cdent: okay I'm surprised mriedem or jaypipes aren't already in the middle of that, so let's confirm before I go make another mess | |
| 13:46:08 | cdent | at least one of the failures is because we’ve now got code within methods making demands that unrelated “unit” tests are not satisfying | |
| 13:46:41 | cdent | (just the first one, the others make some sense) | |
| 13:51:25 | cdent | dansmith: are you jumping, or shall I carry on with what I’m able to get for now? | |
| 13:52:03 | dansmith | cdent: I'm handling other morning stuff waiting for mriedem to catch me up.. if you're fixing things, I'd just keep going with that | |