| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-08-01 | |||
| 15:37:54 | mriedem | gibi: that's going to be needed for this bug https://bugs.launchpad.net/nova/+bug/1707252 | |
| 15:37:55 | jaypipes | gibi: not at this time, I don't think so. | |
| 15:37:55 | openstack | Launchpad bug 1707252 in OpenStack Compute (nova) "Claims in the scheduler does not account for doubling allocations on resize to same host" [Medium,Confirmed] | |
| 15:37:55 | dfisher | i can trade that for fire-putting-outting, maybe | |
| 15:38:29 | mdbooth | mriedem: Incidentally, I now have a patch on top of gibi's patch, but because it also has another dependency I can't push it | |
| 15:38:58 | mdbooth | Any chance we could keep the scope of gibi's patch small so it can merge soon? | |
| 15:39:04 | mdbooth | And add more later. | |
| 15:39:40 | gibi | mdbooth: If you are refering to https://review.openstack.org/#/c/487958/ then I think that patch is pretty close to land | |
| 15:39:47 | mriedem | mdbooth: i was assuming any new tests would be built on top | |
| 15:40:01 | mdbooth | gibi: Yep, that's the one. | |
| 15:40:08 | mdbooth | mriedem: Excellent, just checking. | |
| 15:40:08 | mriedem | mdbooth: believe me, i'd like to see that test patch land asap | |
| 15:40:17 | gibi | mdbooth: I think that patch will not grow further | |
| 15:40:37 | mdbooth | gibi: Now could you land it in the next 10 minutes? ;) | |
| 15:40:51 | gibi | mdbooth: I have no power over it ;) | |
| 15:41:30 | mdbooth | I have your patch stashed in the middle of my own series, so I need to be really careful not to submit it! | |
| 15:43:01 | gibi | mdbooth: to be clear it is not my patch, it is shared at least between jaypipes, dansmith, cdent and myself. Just to make it easy ;) | |
| 15:43:58 | gibi | mriedem: so I'm not committing myself to start the resize to same host today, but if nobody starts that until I wake up tomorrow then I will stat | |
| 15:44:17 | gibi | mriedem: s/stat/start/ | |
| 15:44:32 | mriedem | gibi: ok i might start that today | |
| 15:44:37 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add redirect for api-microversion-history doc https://review.openstack.org/489641 | |
| 15:45:05 | gibi | mriedem: ping me when you start to avoid double work | |
| 15:45:31 | mriedem | aye aye | |
| 15:46:45 | mriedem | fyi, also sent to the ML https://etherpad.openstack.org/p/nova-pike-release-candidate-todo | |
| 15:48:38 | openstackgerrit | Drew Fisher proposed openstack/nova master: Add language for compute node configuration https://review.openstack.org/489643 | |
| 15:49:43 | openstackgerrit | Jay Pipes proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958 | |
| 15:49:43 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs https://review.openstack.org/489273 | |
| 15:49:44 | openstackgerrit | Jay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize() https://review.openstack.org/488510 | |
| 15:50:00 | jaypipes | gibi: done. | |
| 15:51:06 | gibi | jaypipes: looking | |
| 15:54:34 | dansmith | dfisher-cinder: sorry, I was distracted while you were exploding | |
| 15:55:11 | sdague | mriedem: woot, now we just need to figure out what other redirects are needed | |
| 15:55:29 | mriedem | sdague: basically everything | |
| 15:55:36 | mriedem | placement, vendordata, everything has changed | |
| 15:55:41 | mriedem | api microversion history | |
| 15:55:45 | mriedem | i'm in -doc | |
| 16:00:56 | gibi | jaypipes: looks good to me | |
| 16:06:56 | bauzas | mriedem: have time for a quick question about https://bugs.launchpad.net/nova/+bug/1702454 ? | |
| 16:06:56 | openstack | Launchpad bug 1702454 in OpenStack Compute (nova) "Transforming the RequestSpec object into legacy dicts doesn't support the requested_destination field" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza) | |
| 16:07:38 | bauzas | mriedem: given it works for Pike but not Newton and Ocata, the regression test would be different between stable changes and the master change | |
| 16:07:52 | bauzas | mriedem: doesn't that look a bit weird ? | |
| 16:08:54 | bauzas | mriedem: tbc, I'll be testing that if you have 2 hosts (A, B) with A as a target for the instance, it would provide a NoValidHost if A is not accepting it | |
| 16:09:15 | bauzas | mriedem: that would be for the fix | |
| 16:09:32 | bauzas | mriedem: and without the fix (in Ocata and N) it would just provide B as instance.host | |
| 16:09:43 | bauzas | or at least accepting to evacuate | |
| 16:09:57 | bauzas | see my problem ? | |
| 16:10:24 | bauzas | the cherry-pick change would be different | |
| 16:10:31 | openstackgerrit | Dan Smith proposed openstack/nova master: Add some more cellsv2 doc goodness https://review.openstack.org/487183 | |
| 16:10:31 | mriedem | bauzas: do we have a fix to make in pike at all? | |
| 16:10:56 | bauzas | mriedem: so, only a stable change ? | |
| 16:11:02 | bauzas | I'm confused | |
| 16:11:27 | bauzas | like I said in the bug report, the bug was fixed implicitly by https://review.openstack.org/#/c/469037/ but we can't just backport it | |
| 16:12:10 | mriedem | bauzas: if it's fixed on master, then yes it's a stable only change | |
| 16:12:32 | bauzas | okay, lemme upload then and we'll discuss | |
| 16:12:54 | mriedem | unless you just write the regression test for master but no fix | |
| 16:13:03 | mriedem | as you said, the backport of the test would be weird | |
| 16:15:05 | bauzas | anyway, looks difficult to discuss unless I'm uploading it | |
| 16:15:09 | bauzas | so I'll do | |
| 16:18:00 | mriedem | does that mean sylvain's wife is variable? | |
| 16:18:08 | openstackgerrit | Sean Dague proposed openstack/nova master: add redirects for existing broken docs urls https://review.openstack.org/489650 | |
| 16:18:14 | sdague | mriedem: ^^^ | |
| 16:18:41 | sdague | mriedem: also, here are real 404s from today, which include stuff going way back - http://paste.openstack.org/show/617142/ | |
| 16:18:44 | bauzas | mriedem: oh oops, WIFE + $idea | |
| 16:18:52 | bauzas | $ikea even | |
| 16:18:54 | mdbooth | mriedem: *potentially* variable. In practise it may not actually be modified after assignment. | |
| 16:19:36 | mriedem | sdague: can those tabs be fixed? | |
| 16:19:49 | sdague | mriedem: sure | |
| 16:20:14 | openstackgerrit | Dan Smith proposed openstack/nova master: Add some more cellsv2 doc goodness https://review.openstack.org/487183 | |
| 16:20:43 | openstackgerrit | Sean Dague proposed openstack/nova master: add redirects for existing broken docs urls https://review.openstack.org/489650 | |
| 16:21:15 | mdbooth | So I can rebase 7 patches on top of the revert function tests | |
| 16:22:28 | sdague | mriedem: I'm going to walk away for a bit, but I can rebase sfinucan's patches later today probably, and add any more redirects if we need them | |
| 16:22:51 | sdague | although I think most of the moves already happened | |
| 16:24:08 | openstackgerrit | Matthew Booth proposed openstack/nova master: Fix scope of errors_out_migration in resize_instance https://review.openstack.org/487495 | |
| 16:24:08 | openstackgerrit | Matthew Booth proposed openstack/nova master: Split Compute.errors_out_migration into a separate contextmanager https://review.openstack.org/485734 | |
| 16:24:09 | openstackgerrit | Matthew Booth proposed openstack/nova master: Automatically revert resize which fails on destination https://review.openstack.org/462521 | |
| 16:24:09 | openstackgerrit | Matthew Booth proposed openstack/nova master: fake_notifier: allow waiting on either notification type https://review.openstack.org/489637 | |
| 16:24:10 | openstackgerrit | Matthew Booth proposed openstack/nova master: Fix scope of errors_out_migration in finish_resize https://review.openstack.org/487515 | |
| 16:24:10 | openstackgerrit | Matthew Booth proposed openstack/nova master: Ensure errors_out_migration errors out migration https://review.openstack.org/479802 | |
| 16:24:11 | openstackgerrit | Matthew Booth proposed openstack/nova master: Functional test for auto revert resize https://review.openstack.org/489654 | |
| 16:24:25 | mdbooth | Meh, at least now I have something to point people at | |
| 16:33:42 | openstackgerrit | Merged openstack/python-novaclient master: Remove custom autodoc implementation https://review.openstack.org/480262 | |
| 16:39:06 | openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/489604 | |
| 16:39:31 | mriedem | dansmith: jaypipes: i'm +2 on gibi's test now https://review.openstack.org/#/c/487958/ - should i just push that through? | |
| 16:39:39 | mriedem | since you both worked on it and sean is afk | |
| 16:39:53 | dansmith | mriedem: I'm not likely to +W it in its current form, so probably | |
| 16:39:59 | mriedem | ok | |
| 16:40:01 | jaypipes | mriedem: actually I'd like to add one more assertion in there. | |
| 16:40:28 | mriedem | jaypipes: can it go on top? | |
| 16:40:35 | jaypipes | mriedem: sure I suppose | |
| 16:40:47 | mriedem | i just want to stop iterating on this one | |
| 16:40:55 | jaypipes | ok with me | |
| 16:40:57 | mriedem | but if you're ready like now then i can wait | |
| 16:41:18 | jaypipes | mriedem: please proceed. | |
| 16:41:57 | mriedem | done | |
| 16:43:00 | cdent | jaypipes: has a plan (for migrations) distilled out of today’s conversations yet, or is that still pending? | |
| 16:43:32 | jaypipes | cdent: 1707071 is the primary bug I'm tracking right now. | |
| 16:44:29 | cdent | jaypipes: yes, but I thought any potential solutions to that impinge on the wider migration picture? | |
| 16:45:06 | jaypipes | cdent: not quite following you on that... | |
| 16:47:30 | cdent | jaypipes: maybe I misunderstood your answer to my question. Are you saying “yes, that’s what 1707071 is about” or “no, I’m focused on the details of making sure that we create the right allocations”? Looks like the former? | |
| 16:48:05 | jaypipes | cdent: I'm focused on trying to not have Pike compute node RTs fight each other writing and overwriting allocation records. | |