Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-08-01
14:00:43 gibi bauzas: there is example evacuate test in the server_group functional test I think
14:01:10 bauzas gibi: maybe, I'll look :)
14:01:18 mriedem bauzas: keep in mind, the way we do the functional regression tests is a 2 patch process,
14:01:22 gibi bauzas: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_server_group.py#L412
14:01:22 mriedem the first writes the test recreating the bug,
14:01:26 mriedem asserting the failure,
14:01:29 mriedem the 2nd patch fixes the bug
14:01:34 mriedem and adjusts the test
14:01:34 bauzas the functional server groups tests just do a lot so I'm not remembering if it's also calling evacuate :p
14:01:45 bauzas mriedem: yup, I know, no worries
14:01:58 bauzas I did reviewed a few of you :p
14:02:18 gibi bauzas: also a notification sample test with evacuate is up on review https://review.openstack.org/#/c/482148/3/nova/tests/functional/notification_sample_tests/test_instance.py
14:02:18 mriedem i know, quotas things
14:02:38 gibi bauzas: this one is better as it uses force_down
14:03:11 bauzas thanks gibi :)
14:03:12 mriedem bauzas: i also don't think https://bugs.launchpad.net/nova/+bug/1678056 is pike-rc-potential
14:03:12 openstack Launchpad bug 1678056 in OpenStack Compute (nova) "RequestSpec records are never deleted when destroying an instance" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza)
14:03:17 mriedem request specs not getting deleted is a latent issue
14:03:27 bauzas same problem
14:03:31 bauzas same situation
14:03:56 bauzas we have that since we persisted the Requestspec records
14:04:04 mriedem sure, but it's not a pike blocker
14:04:05 bauzas so that's not really a regression
14:04:06 mriedem it's latent
14:04:23 bauzas but AFAIK I thought RC1 was not only for regressions :)
14:04:29 bauzas RC2 and others yup so
14:04:37 mriedem pike-rc-potential is not your personal wishlist of bugs for review :)
14:05:12 bauzas anyway, seems I agreed to remove pike-rc-potential for the former, I'm okay to remove that tag for the latter :)
14:05:18 mriedem yup, done
14:05:28 mriedem i'm just working on my etherpad of stuff to do for rc1
14:05:33 mriedem so that's why i'm being harsh on these tagged bugs
14:05:39 bauzas no worries
14:05:41 mriedem and as a result i'm taking it out on you
14:05:54 bauzas yup, I understand
14:05:57 bauzas no worries again
14:06:05 bauzas I just want to make sure we don't forget them
14:06:19 mriedem i could never forget the wasteland that is request spec bugs :)
14:06:22 bauzas and since we were working on features during last milestones, I'll ping a few of us during those weeks
14:06:46 mriedem ^ not sure what you mean there
14:07:06 mriedem you mean you held off on pinging people for bug reviews b/c of working on closing out features?
14:07:12 bauzas exacrlt
14:07:16 mriedem ok
14:07:17 bauzas exactly
14:07:38 bauzas now, it's time for asking to review bugs
14:07:55 bauzas of course, regressions first, totally agreed
14:08:02 mriedem gmann: alex_xu: do you know if patches were put up for modifying the api plugins and stable api docs pages for the new routes stuff?
14:20:20 openstackgerrit Spencer Yu proposed openstack/python-novaclient master: Nova client should retry with Retry-After value https://review.openstack.org/447766
14:23:38 openstackgerrit Jackie Truong proposed openstack/nova master: Add trusted_certs to instance_extra https://review.openstack.org/457711
14:25:50 mriedem melwitt: we should update this doc for counting quotas https://docs.openstack.org/nova/latest/user/quotas.html
14:33:32 gibi jaypipes, dansmith: sorry for being stubborn but I still not get it. The only difference I see in the logs between ps17 and ps18 is that in ps17 server booted on host2 and then moved to host1 while in ps18 it is booted on host1 and moved to host2
14:33:41 openstackgerrit Matt Riedemann proposed openstack/nova master: Add release note for PUT /os-services/* for non-compute services https://review.openstack.org/489621
14:34:31 gibi jaypipes, dansmith: and as the periodic tasks runs in the same order in both patch sets the two patch sets test two different scenari
14:35:21 dansmith gibi: tbh I haven't looked at the later ones in detail.. as I said on the review, I think we should revert back to PS14 and roll on, but I'm not sure if there was a reason for the refactor
14:37:10 gibi dansmith: the refactor was only for reduce duplication and increase readability by better naming
14:37:50 gibi dansmith: I think 14 and 17 executes the same scenario but 18 executes a different one (different move direction)
14:38:23 dansmith gibi: well, like I said, the duplication in the test makes it _more_ readable IMHO, even if a bit wasteful
14:38:34 dansmith gibi: agree we could have improved the naming a bit though
14:39:57 jaypipes gibi: yeah, as I walked to get breakfast I realized you are correct
14:42:27 openstackgerrit Jay Pipes proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958
14:42:27 openstackgerrit Jay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs https://review.openstack.org/489273
14:42:28 openstackgerrit Jay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize() https://review.openstack.org/488510
14:42:29 jaypipes dansmith, gibi, mriedem: ok, good to go now ^^
14:42:38 jaypipes for the test resize patch at least
14:43:10 jaypipes dansmith, gibi, mriedem: now I go back to trying to actually fix the bug 1707071
14:43:10 openstack bug 1707071 in OpenStack Compute (nova) "Compute nodes will fight over allocations during migration" [Medium,In progress] https://launchpad.net/bugs/1707071 - Assigned to Jay Pipes (jaypipes)
14:44:11 gibi dansmith, jaypipes: then I guess we are not bringing back the duplications by inlining util functions I introduced
14:46:36 jaypipes gibi: I think what you did made the test easier to read and consume.
14:46:50 jaypipes gibi: I know dansmith disagrees a bit, though
14:47:10 jaypipes but dansmith is a disagreeable man.
14:47:28 jaypipes who requires a constant IV drop of caffeine to agree with anything.
14:47:55 jaypipes is it Friday yet?
14:48:16 cdent soon, jaypipes. soon
14:48:21 jaypipes hehe
14:48:24 mriedem https://images-na.ssl-images-amazon.com/images/I/51S%2BpPtReeL._AC_UL320_SR228,320_.jpg
14:49:22 mriedem or https://s-media-cache-ak0.pinimg.com/originals/49/d7/a0/49d7a0676e7945b3fb7bcf4c4533fd99.jpg
14:49:25 sdague gibi: honestly, on the test front, duplication is not a bad thing. You are trying to understand individual test functions in their own context, and if you have to chase a bunch of common code, it's a lot harder to put the state in your head
14:52:25 gibi sdague: I have no firm oppinion I think for me the usefullness of deduplication depends on how well I can trust the utility function to do what it promise
14:53:55 dansmith sdague: exactly
14:53:57 gibi sdague: to build that trust during review I guess I inline the utils in my head at the first usage but then later I just trust them
14:57:32 openstackgerrit Jay Pipes proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958
14:57:33 openstackgerrit Jay Pipes proposed openstack/nova master: placement: remove existing allocs when set allocs https://review.openstack.org/489273
14:57:33 openstackgerrit Jay Pipes proposed openstack/nova master: remove source provider allocs in confirm_resize() https://review.openstack.org/488510
14:57:35 jaypipes dansmith: made those changes you pointed out in the review ^^
14:58:44 openstackgerrit khushbu parakh proposed openstack/nova master: Closes-Bug: #1454515 https://review.openstack.org/488941
14:58:44 openstack bug 1454515 in OpenStack Compute (nova) "Property "instance.disable_terminate" is always "False" and never actually used." [Low,In progress] https://launchpad.net/bugs/1454515 - Assigned to Khushbuparakh (khushbuparakh)
14:59:24 sdague gibi: right, but that's because you are familiar with them. People reading tests will not be, so it takes longer to understand what is going on if they also need to digest utils
15:05:59 dfisher ok, i'm still struggling trying to get a compute node talking to a devstack rig. What services need to be running on the compute node? Obviously nova-compute but what else?
15:06:06 dfisher this is all with beta3
15:06:32 dfisher nova service-list sees my compute node, but cell_v2 discover_hosts can't find it
15:07:02 gibi sdague: sure, there is an overhead due to the extra indirection until the reader gets familiar with the utils but after that it is a lot easier to read the deduplicated code (not to mention chaging it)
15:07:19 jaypipes gibi, dansmith, mriedem, cdent: for the record, I was wrong, dansmith and gibi were right. sorry that I jumped the gun.
15:07:30 mriedem dfisher: what does nova-manage cell_v2 list_cells show?
15:07:34 mriedem do you have a cell0 and cell1?
15:07:55 jaypipes gibi, dansmith, mriedem, cdent: and I did not mean to shut anyone down. I just thought I'd figured out the issue
15:07:57 dfisher mriedem: yes. I have both cell0 and cell1
15:08:10 cdent jaypipes: I’ll have a aggregate map WIP up shortly
15:08:20 jaypipes cdent: cool, thanks.
15:08:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Deprecate cells v1 https://review.openstack.org/489632
15:08:23 gibi jaypipes: you made me think for a while, but I like these mental challenges so no worries
15:08:24 sdague dfisher: what versions of devstack code do you have?

Earlier   Later