| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-08-01 | |||
| 10:47:31 | bauzas | maybe we could just split nikola's patch in two and just at least add the migration object at first, before trying to claim | |
| 10:47:34 | johnthetubaguy | anyways, not sure any of that helps | |
| 10:47:51 | sdague | bauzas: we run the resize tests in multihost I think | |
| 10:48:01 | bauzas | sdague: cool then | |
| 10:48:06 | sdague | bauzas: but I haven't looked that hard to verify | |
| 10:48:16 | bauzas | sdague: I can check | |
| 10:51:41 | cdent | sdague, bauzas: we talked about that last night, and dan confirmed there are some, but the issue with them is that they don’t run in a constrained environment nor concurrent placements and don’t validate the allocations, so the fact that there isn’t yet doubling of allocations isn’t an issue because there’s spare capacity | |
| 10:52:02 | sdague | cdent: yeh, that makes sense | |
| 10:52:31 | sdague | honestly, that's one of those things where doing the in tree functional testing with a couple of fake computes is probably the best way to flush it out | |
| 10:52:43 | cdent | sdague: that’s what gibi’s new test does | |
| 10:52:46 | cdent | so is very good to have | |
| 10:52:57 | sdague | cdent: does that still need review? | |
| 10:53:14 | bauzas | cdent: dan confirmed there are some what ? | |
| 10:53:39 | cdent | but I suspect that there are lots of edges that won’t get covered and in about 18 months we’ll see a lot of bugs from big deployments | |
| 10:53:46 | cdent | bauzas: there are some resize tests | |
| 10:54:01 | cdent | sdague: yes, it needs review, but I’m not sure how “done” it is: https://review.openstack.org/#/c/487958/ | |
| 10:54:20 | bauzas | cdent: ah | |
| 10:54:32 | bauzas | cdent: yeah, I know that but I do wonder if we test those multihost | |
| 10:54:46 | cdent | yes, multihost | |
| 10:54:51 | bauzas | ok | |
| 10:55:36 | bauzas | cdent: I see your comment now, you mean those test exist but aren't really stress-testing at limits so we can't really verify capacity issues | |
| 10:55:42 | bauzas | tests* | |
| 10:56:09 | bauzas | so, not a big deal for functional testing, but not for placement-specific concerns | |
| 10:56:15 | bauzas | gotcha | |
| 10:58:23 | gibi | cdent, sdague: I'm still intended to understand and remove the last time.sleep(1) left in the setUp() of that tests as that is ugly and might not be necessary | |
| 11:05:32 | openstackgerrit | Merged openstack/nova master: fix test_rebuild_server_exc instability https://review.openstack.org/487382 | |
| 11:08:54 | gibi | OK I think that sleep was only needed before the fake virt driver was updated to keep a local nodes copy and the periodic tasks was running every second | |
| 11:09:21 | gibi | that two things together caused a race on setting the nodes of the fake virt driver | |
| 11:09:25 | sdague | gibi: yeh, I just went through with a fine toothed comb there and provided some import | |
| 11:09:28 | sdague | input | |
| 11:09:57 | gibi | sdague: thanks. checking... | |
| 11:10:13 | sdague | gibi: mostly also bringing fresh eyes of not being familiar with some of this, so some code restructure for clarity that might help as well | |
| 11:11:46 | gibi | sdague: sure, fresh eyes helps a lot | |
| 11:12:39 | openstackgerrit | Merged openstack/nova master: Fix example in _serialize_allocations_for_consumer https://review.openstack.org/487614 | |
| 11:16:22 | openstackgerrit | Merged openstack/nova master: rootwrap.d cleanup mislabeled files https://review.openstack.org/486831 | |
| 11:30:38 | sdague | gibi / cdent - https://review.openstack.org/#/c/487327 | |
| 11:30:47 | sdague | can we fix wsgi_intercept instead? | |
| 11:31:12 | sdague | because if we don't pass those vars, people can't build their venvs | |
| 11:34:51 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.rebuild_scheduled notification https://review.openstack.org/473929 | |
| 11:35:09 | gibi | sdague: I have an env that is behind proxy and I can build the env there without passing the PROXY wars | |
| 11:35:54 | gibi | sdague: But if this can be fixed in wsgi_intercept then I'm happy with that solution | |
| 11:36:08 | openstackgerrit | Merged openstack/nova master: Instance remains in migrating state forever https://review.openstack.org/483911 | |
| 11:36:10 | sdague | gibi: not everyone can - https://review.openstack.org/#/c/189569/ | |
| 11:36:29 | sdague | it was added because without it people were blocked from running tests | |
| 11:37:07 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.rebuild_scheduled notification https://review.openstack.org/473929 | |
| 11:37:09 | sdague | unless tox itself changed since then | |
| 11:37:32 | jaypipes | cdent: morning. | |
| 11:37:42 | cdent | sdague: I think tox has changed | |
| 11:38:10 | cdent | it’s difficult to fix in the wsgi_intercept because of the way urllib3 manages proxy variables very early in its handling | |
| 11:38:15 | cdent | (at least last time I checked) | |
| 11:38:18 | cdent | jaypipes: morning | |
| 11:38:20 | jaypipes | cdent: unfortunately, trying to fix bug #1707071 has been excruciating. Looks like I'm going to need to go back to the drawing board and rewrite my patch pretty much from scratch. | |
| 11:38:20 | openstack | bug 1707071 in OpenStack Compute (nova) "Compute nodes will fight over allocations during migration" [Medium,In progress] https://launchpad.net/bugs/1707071 - Assigned to Jay Pipes (jaypipes) | |
| 11:38:29 | cdent | jaypipes: oh noes! | |
| 11:38:30 | sdague | ok, so we need to figure out when it changed, because our minimum is 2.0 | |
| 11:38:40 | cdent | sdague: i’ll look in the changelogs | |
| 11:38:59 | sdague | gibi: if you can confirm when tox changed, and bump the minimum at the same time, I'm +2 | |
| 11:39:00 | gibi | cdent: thanks for taking that | |
| 11:39:10 | gibi | sdague: good point | |
| 11:39:14 | sdague | I just don't want to break folks | |
| 11:39:44 | cdent | jaypipes: is there a crucial bit, or is it many things combined? | |
| 11:41:30 | cdent | sdague, gibi: 2.1.0: http://tox.readthedocs.io/en/latest/changelog.html#id12 | |
| 11:42:12 | gibi | cdent: thanks! I will update the patch with the mimimum bump soon | |
| 11:43:04 | jaypipes | cdent: the latter | |
| 11:43:18 | jaypipes | cdent: and the fact that we need to deal with Ocata computes migrating to Pike computes. | |
| 11:43:55 | cdent | jaypipes: do you have an idea/plan or still cogitating? anything I can do to help? | |
| 11:43:56 | sdague | gibi: I can actually bump it if you like, you are working on more important patches | |
| 11:44:54 | jaypipes | cdent: not on this bug, no. but in debugging, I did notice that the aggregate refresh rate in the resource tracker/report client was super high. I know you'd submitted a bug on that (or related) some time ago. might be nice to look at reducing the number of those calls. | |
| 11:44:57 | openstackgerrit | Sean Dague proposed openstack/nova master: do not pass proxy env variables by tox https://review.openstack.org/487327 | |
| 11:45:08 | sdague | gibi: fixed + approved | |
| 11:46:13 | openstackgerrit | Merged openstack/python-novaclient master: Remove run_tests.sh https://review.openstack.org/488276 | |
| 11:46:46 | cdent | jaypipes: it’s on the cycle of the periodic job isn’t it? Or is it happening even more than that? | |
| 11:47:09 | jaypipes | cdent: it happens every time reportclient._ensure_resource_provider() runs | |
| 11:47:14 | jaypipes | cdent: so.. a lot. | |
| 11:47:17 | gibi | sdague: thanks a lot! | |
| 11:47:46 | cdent | jaypipes: ah, okay, yeah. these days we do that even more. will poke. | |
| 11:51:40 | openstackgerrit | Merged openstack/python-novaclient master: Update URLs in docs, comments and setup.cfg https://review.openstack.org/488271 | |
| 12:00:14 | openstackgerrit | Michael Still proposed openstack/nova master: Move execs of tee to privsep. https://review.openstack.org/489438 | |
| 12:00:14 | openstackgerrit | Michael Still proposed openstack/nova master: Read from console ptys using privsep. https://review.openstack.org/489486 | |
| 12:26:11 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Test resize with placement api https://review.openstack.org/487958 | |
| 12:27:26 | gibi | sdague: I've fixed your comments in https://review.openstack.org/487958 | |
| 12:32:49 | mriedem | gibi: want to skip the notification meeting today? | |
| 12:33:17 | gibi | mriedem: I can chair it but I don't see any pressing issue to discuss | |
| 12:33:57 | gibi | mriedem: therefore I suggested to skip | |
| 12:34:05 | mriedem | seconded | |
| 12:34:34 | gibi | mriedem: Should I send a second mail to the ML about the skip? | |
| 12:34:43 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091 | |
| 12:35:21 | mriedem | gibi: up to you | |
| 12:35:54 | gibi | mriedem: then I won't. I don't think anybody besides you and me could be interested | |
| 12:42:10 | jaypipes | gibi: gah. I was just in the process of reworking that resize tests... | |
| 12:45:42 | sdague | mriedem: ... http://logs.openstack.org/81/488381/3/experimental/gate-tempest-dsvm-cells-ubuntu-xenial/b5f4fa1/logs/devstacklog.txt.gz#_2017-08-01_10_56_05_959 ... oh cells munging hostnames | |
| 12:46:10 | sdague | cells v1 that is | |
| 12:47:18 | sdague | we should rename cells v1 to apoptosis | |
| 12:47:52 | mriedem | it's not deprecated yet | |
| 12:47:59 | mriedem | cells v1 is alive and well | |
| 12:48:06 | sdague | alive... sure | |
| 12:48:22 | sdague | mriedem: we really haven't deprecated it yet? | |
| 12:48:51 | sdague | because it's definitely in freeze for everything bug critical fixes, it seems like deprecation should be a thing | |
| 12:48:57 | sdague | even if we don't have a remove date | |
| 12:51:17 | gibi | jaypipes: sorry for that. I read back and only see an opportunity to refactor but not that somebody already started that | |