| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-28 | |||
| 13:55:37 | superdan | T and Y are together on both | |
| 13:55:49 | superdan | I thought it was AZERTY? | |
| 13:56:59 | bauwser | rather, yting | |
| 13:59:59 | cdent | can someone merge this https://review.openstack.org/#/c/488363/ looking at that warning is getting tiresome | |
| 14:05:28 | kashyap | superdan: Thanks for the review on this: https://review.openstack.org/#/c/485752/ | |
| 14:05:38 | kashyap | superdan: And thanks for the little snark, too :P | |
| 14:06:10 | superdan | heh | |
| 14:06:56 | kashyap | Can anyone +W it? I can also backport it to the revlevant upstream branches | |
| 14:09:28 | superdan | kashyap: sdague loves +Wing patches like that | |
| 14:10:01 | kashyap | :-) I thought of pinging him explicitly, but refrained in the spirit of being a good citizen as I shouldn't specifically nag people | |
| 14:10:15 | kashyap | And just ask the generic "ether", that is the channel :-) | |
| 14:10:31 | superdan | kashyap: sdague owes us all a beer after yesterday, so I think today it's uniquely okay to ask him directly :P | |
| 14:11:08 | kashyap | sdague: If you are listening in, it's a straight-forward perf issue fixed by calling a simple "please set cache mode" method. And the reporter has even confirmed the fix works -- https://review.openstack.org/#/c/485752/ | |
| 14:11:25 | superdan | cdent: fix mriedem's comment and I'll fast approve | |
| 14:11:36 | kashyap | superdan: What happened yesterday that bestows this windfall on the rest? | |
| 14:11:53 | superdan | kashyap: oh nothing.. just a good-faith-gone-awry sort of deal | |
| 14:11:59 | kashyap | :D | |
| 14:13:44 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] quash unicode warning with shared provider https://review.openstack.org/488363 | |
| 14:14:04 | cdent | superdan: done ^. tvm | |
| 14:14:26 | superdan | cdent: doneski | |
| 14:14:40 | cdent | rawkin or something | |
| 14:17:32 | bauwser | mriedem: cdent: FYI https://review.openstack.org/#/c/488363/1/nova/objects/resource_provider.py@741 | |
| 14:17:57 | bauwser | I'm not a SQLA expert, but I know that you need all your strings to be unicode (and UTF-8) if you want to use SQLA | |
| 14:18:36 | cdent | bauwser: I think the relevant point here is that os_traits is _not_ which might be a surprise to some (it was to me) | |
| 14:18:47 | bauwser | cdent: ostraits is a python lib | |
| 14:18:59 | bauwser | cdent: so it really just gives us what python gives us | |
| 14:19:11 | bauwser | there is no contract about what it returns | |
| 14:19:18 | cdent | yes, I know that, but no, it has a choice of how it constructs the values | |
| 14:19:20 | bauwser | and a shit ton of 3rd-party libs behave the same | |
| 14:19:21 | cdent | it could have don them as unicdoe | |
| 14:19:54 | bauwser | the point is just, SQLA by default expects unicode, so in general you explicitely convert | |
| 14:20:18 | bauwser | cdent: that reminds me | |
| 14:20:19 | cdent | yes, and? | |
| 14:20:44 | bauwser | cdent: I'm not sure that if we create a trait like CUSTOM_mé | |
| 14:20:51 | bauwser | it will correctly work | |
| 14:20:59 | bauwser | because we won't define the charset | |
| 14:22:10 | cdent | "pattern": "^CUSTOM\_[A-Z0-9_]+$", | |
| 14:22:25 | cdent | so it is moot on that front | |
| 14:22:45 | cdent | none of this changes that matt’s right that a comment is helpful | |
| 14:22:49 | cdent | it’s been done, it’s merged. | |
| 14:25:01 | bauwser | cdent: oh correct, we only accept ASCII | |
| 14:25:04 | bauwser | even less | |
| 14:25:11 | bauwser | so that's not a big deal | |
| 14:31:00 | kashyap | mriedem: Thanks for the merge! | |
| 14:31:48 | kashyap | (For this https://review.openstack.org/#/c/485752/) | |
| 14:37:39 | fried_rice | sdague You got a minute? | |
| 14:39:05 | openstackgerrit | Alex Szarka proposed openstack/nova master: fix test_rebuild_server_exc instability https://review.openstack.org/487382 | |
| 14:42:00 | kashyap | People, are simple performance fixes acceptable for "Phase-2" support (Newton)? | |
| 14:43:33 | lyarwood | kashyap: your cache change is just a bugfix IMHO, not a perf fix, it just happens to help with the latter. | |
| 14:43:46 | mriedem | omg we have a wild lyarwood sighting | |
| 14:43:59 | kashyap | LOL | |
| 14:44:23 | kashyap | lyarwood: Noted. Just in case you're wondering: if I'm masquereding something to "smuggle" a fix in, no, I wasn't :-) | |
| 14:44:27 | superdan | just yesterday I warned another manager that we were taking lyarwood back by force, if necessary, at the end of his side contract | |
| 14:46:15 | lyarwood | superdan: not helped by my `yeah sure I can help with that` follow up ;) | |
| 14:46:23 | kashyap | lyarwood: When you craw out of your cave, your comment isn't clear - does that mean, as a stable maint, do you find it acceptable to backport to Newton, or not? | |
| 14:46:28 | superdan | lyarwood: yeah :/ | |
| 14:46:34 | mriedem | lyarwood: you're the new tonyb | |
| 14:46:49 | mriedem | kashyap: bug fixes to newton are ok | |
| 14:46:56 | kashyap | mriedem: Okido, thanks | |
| 14:47:10 | lyarwood | mriedem: what did you do to the old tonyb? | |
| 14:47:39 | mriedem | lyarwood: tonyb signs up to help with everything | |
| 14:48:00 | sdague | fried_rice: I'm about to lose power here as they move our power to another pole | |
| 14:48:14 | sdague | so... poke me later | |
| 14:48:18 | fried_rice | sdague Sweet. I think I may have figured it out. Thanks. | |
| 14:55:28 | mriedem | superdan: looking over my old todo list, i had a note about online data migrations for multiple cells, | |
| 14:55:47 | mriedem | e.g. object code looks in the api db first and if not found, looks in the 'cell' db for looking things up | |
| 14:55:57 | mriedem | but with multiple cells, you wouldn't know which cell db to lookup from | |
| 14:56:16 | mriedem | so that probably goes in our list of things you have to do before you can do multi cell | |
| 14:56:48 | superdan | depends on the migration I guess | |
| 14:56:57 | superdan | mriedem: but you could use multiple configs to handle that today | |
| 14:57:28 | superdan | mriedem: i.e. use the config for one of the cell conductors you have if it doesn't hit the api db, and if it does, just add creds for the api db and the one cell you're looking at | |
| 14:57:39 | superdan | but yeah I'd have to think about the best way to test those things | |
| 14:59:47 | mriedem | ok i was just thinking about like migrating quotas, we look in api, then look in cell, but really if we did it like the api code, we'd iterate the cells to find the quota limit - although something like quota limits in multiple cells would be wonky - it could be default in a new cell but custom in an old cell | |
| 15:00:03 | mriedem | probably just best to say, make sure your online data migrations are done before attempting adding a new cell | |
| 15:00:30 | superdan | yeah | |
| 15:00:40 | mriedem | i should also get this cleaned up https://review.openstack.org/#/c/460377/ | |
| 15:02:56 | superdan | ugh yeah | |
| 15:03:28 | openstackgerrit | Ed Leafe proposed openstack/nova master: Handle hash ring rebalancing in ironic flavor migration https://review.openstack.org/487954 | |
| 15:12:54 | mriedem | bauwser: going to update the reno in https://review.openstack.org/#/c/484828/ per cdent's comment? | |
| 15:13:46 | bauwser | mriedem: sure, can do | |
| 15:14:26 | bauwser | mriedem: I'm just going to end up my work week prematurely because of corporate network requirements that require major upgrades for me | |
| 15:15:26 | mriedem | bauwser: you know how when i asked if you were talking to your dog when in boston and i said the dog said 'le woof' and you looked like that doesn't make sense/ | |
| 15:15:27 | mriedem | ? | |
| 15:15:50 | mriedem | i said the same thing to my wife, who knows a little french, and she did the same, and said, "that doesn't make sense, it would be la woof" | |
| 15:16:00 | mriedem | i can't win | |
| 15:16:04 | bauwser | mriedem: heh | |
| 15:16:35 | bauwser | mriedem: I was litterally about to show my dog yesterday on the hangout as it was bugging me | |
| 15:17:28 | bauwser | anyway, my internal network connection is about to blow out in a few, so \o | |
| 15:20:18 | bauwser | cdent: one tuple (openvpn 2.4, fedora 23) | |
| 15:27:57 | openstackgerrit | Matt Riedemann proposed openstack/nova master: DNM: simulate rpc delay when cleaning up allocations from source node https://review.openstack.org/488500 | |
| 15:30:26 | mriedem | superdan: ^ like this? | |
| 15:30:56 | superdan | mriedem: yeah exactly | |
| 15:32:06 | mriedem | leakypipes: i'm going to close out the placement-claims bp | |
| 15:32:16 | mriedem | the main bits are done for pike, rest can be something else in queens | |
| 15:32:18 | leakypipes | k | |
| 15:37:32 | leakypipes | superdan: what was that bug number again? I remember it was a palindrome but my scrollback is too little to grab it.. | |
| 15:37:41 | leakypipes | 1707071? | |
| 15:37:51 | superdan | yep | |
| 15:38:05 | leakypipes | got it, thanks | |
| 15:56:55 | s-dean | Hi could somebody tell me what, this command queries | |