| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-27 | |||
| 13:17:34 | mriedem | cdent: regarding functional testing, i was thinking the same yesterday, but didn't have time, | |
| 13:17:52 | vdrok | morning dansmith , missed all the fun :) | |
| 13:18:23 | dansmith | vdrok: me too, but.. good morning vdrok :P | |
| 13:18:29 | mriedem | but was thinking it could be relatively simple to write a functional test that starts 2 compute services, creates a server, checks allocations are just on the source host, does a resize to the 2nd compute, checks allocations are retained for both nodes, then does a resize confirm (and another test that does a resize revert), and then validates allocations after that is done | |
| 13:19:15 | cdent | relatively | |
| 13:19:34 | mriedem | cdent: but me working on something like that probably can't happen until tomorrow at this rate | |
| 13:19:51 | mriedem | i actually have *gasp* family commitments tonight | |
| 13:20:11 | cdent | I’m sicker than sick at the moment, but bored enough to still be hanging out | |
| 13:21:26 | sean-k-mooney | mriedem: hi i know your pretty busy with the ff today but any chance of inlcuding the 1 patch for mellanox's ovs offload and the 2 required for our nic feature based scheudling blueprint in pike or will they be pushed to queens? | |
| 13:22:08 | kashyap | mdbooth: When you get a moment, hope I addressed all of your remarks here: "libvirt: Post-migration, set cache value for Cinder volume(s)" -- https://review.openstack.org/#/c/485752/ | |
| 13:22:22 | gibi | mriedem: do we already have functional test that boot VMs which really uses the placement service. If there is such then I can try to put together the above suggested resize test | |
| 13:22:31 | mriedem | sean-k-mooney: i think the ovs offload from moshele is probably doable - i think i'd like a bp in nova for that though, just something simple to mirrow the neutron RFE | |
| 13:22:38 | mriedem | since nova doesn't do RFE bugs for blueprints | |
| 13:22:53 | mriedem | gibi: we do | |
| 13:23:09 | mriedem | gibi: the PlacementFixture is used in the _IntegratedHelpersMixin | |
| 13:23:13 | mriedem | which several functional tests use | |
| 13:23:26 | gibi | mriedem: cool, then I will put something together | |
| 13:23:35 | mriedem | there are other functional regression tests which don't use that mixin but still use the placement fixture to avoid warnings from the compute services in the logs | |
| 13:23:39 | gibi | mriedem: I anyhow wanted to test VM moving with placement | |
| 13:23:55 | mriedem | gibi: cool, that would be something that builds on https://review.openstack.org/#/c/483566/ | |
| 13:24:07 | mriedem | the other tricky thing though is the test has to use the filter scheduler, | |
| 13:24:08 | sean-k-mooney | mriedem: ok good to know. i saw that netronomes patchs seem to have merged so im sure jangutter is happy with that it would be nice to finish netronomes version too. im sure it will make moshele equally happy | |
| 13:24:13 | mriedem | lots of our functional tests just use the chance scheduler | |
| 13:24:22 | mriedem | gibi: so you'd have to use the filter scheduler with a minimal set of filters enabled | |
| 13:24:30 | mriedem | like RetryFilter and ComputeFilter i think | |
| 13:24:41 | gibi | mriedem: I'm aware of that based on the server group functional tests | |
| 13:24:58 | sdague | dansmith / mriedem is there a reason to not make --verbose the default behavior for list_cells | |
| 13:25:15 | sean-k-mooney | s/netronome/mellanox/ | |
| 13:25:18 | dansmith | sdague: makes it harder to be used by scripts | |
| 13:25:25 | mriedem | gibi: this is one that i worked on https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1671648.py | |
| 13:25:29 | mriedem | host most of the things yo'ud need i think | |
| 13:25:33 | sdague | I'm trying to understand the usage for just cellid | |
| 13:25:34 | jangutter | sean-k-mooney, mriedem: yep, I'm pretty happy with moshele's patch -> it's cross-platform enough for us to use as well. | |
| 13:25:34 | dansmith | mriedem: sdague: is someone fixing the cell mapping? | |
| 13:25:36 | mriedem | 2 nodes | |
| 13:25:39 | mriedem | filter scheduler + placement | |
| 13:25:41 | sdague | dansmith: in what way? | |
| 13:25:48 | mriedem | you'd just need to remove the part about it making one compute fail | |
| 13:25:52 | gibi | mriedem: cool, thanks for the pointer | |
| 13:26:04 | sdague | dansmith: doesn't my ps4 do that? | |
| 13:26:12 | dansmith | sdague: I haven't looked | |
| 13:26:21 | mriedem | dansmith: https://review.openstack.org/#/c/487809/4 | |
| 13:26:33 | mriedem | sdague: we don't use --verbose by default for list_cells since it dumps your transport and db mqs | |
| 13:26:37 | mriedem | s/mqs/urls/ | |
| 13:26:42 | mriedem | which have creds in them | |
| 13:26:55 | sdague | mriedem: ok, so run it through secret filter | |
| 13:27:14 | mriedem | do we have a secret filter? | |
| 13:27:16 | sdague | I guess, it's not really very discoverable that to get the good stuff you need --verbose | |
| 13:27:33 | mriedem | --dump-your-secrets? | |
| 13:27:43 | mriedem | --hand-over-your-cash? | |
| 13:28:01 | sdague | https://github.com/openstack/oslo.utils/blob/f69aa3c3866f1d1800184b6c905c77988278cd18/oslo_utils/strutils.py#L248 | |
| 13:28:16 | mriedem | sdague: that's not going to do what you want | |
| 13:28:20 | dansmith | and anyone scripting with this already will be very confused if they stop getting a clean list of uuids | |
| 13:28:33 | mriedem | sdague: that's based on known keys https://github.com/openstack/oslo.utils/blob/f69aa3c3866f1d1800184b6c905c77988278cd18/oslo_utils/strutils.py#L57 | |
| 13:28:39 | mriedem | the url doesn't have keys in it | |
| 13:28:50 | sdague | mriedem: sure, I'm just saying it's pretty solvable | |
| 13:29:17 | mriedem | sure, we could parse the url and mask the user/password part | |
| 13:29:18 | sdague | dansmith: ok, well as someone not steeped in it, it's not obvious how you get the full mapping | |
| 13:29:21 | mriedem | and rebuild the url before displaying | |
| 13:30:05 | mriedem | so let's throw that as a debug/improvement idea on the big etherpad | |
| 13:30:34 | sdague | http://paste.openstack.org/show/616726/ | |
| 13:30:55 | sdague | that's kind of the brute path I'd expect an operator to go through trying to figure it out | |
| 13:31:01 | bhagyashris | cdent, gibi, jaypipes: Hi I am trying to test the shared resource provider thing on the current master but facing some issue to create the instance I have followed the steps mentioned in [1]: http://paste.openstack.org/show/616724/ and got the error at n-cond and n-cpu side as mentioned in [2]: http://paste.openstack.org/show/616725/ | |
| 13:31:29 | dansmith | sdague: making help work seems like an obvious improvement we should make | |
| 13:31:54 | mriedem | the nova-manage help system is a latent sucky problem right? | |
| 13:32:03 | cdent | bhagyashris: looking | |
| 13:32:16 | mriedem | maybe cliff or whatever stephenfin wanted to convert it to helps there | |
| 13:32:23 | mriedem | so -h is implied if you don't specify args | |
| 13:32:38 | bhagyashris | cdent, gibi, jaypipes: without using the nfs i am able to create the instance successfully. | |
| 13:32:48 | bhagyashris | cdent: ok thank you :) | |
| 13:33:05 | sdague | so I actually don't understand the argument about the extra columns being a problem | |
| 13:33:10 | sdague | because if you are parsing those tables | |
| 13:33:16 | sdague | you are already doing awk positional | |
| 13:33:21 | sdague | or something equiv | |
| 13:33:22 | dansmith | sdague: yeah, this is actually not the thing I was thinking of | |
| 13:33:50 | sdague | dansmith: ok, once you are off, we can chat then :) | |
| 13:34:09 | dansmith | sdague: so not opposed to it being verbose all the time, but sounds like obscuring the url is something mriedem thinks is important | |
| 13:34:25 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add support for Windows network commands https://review.openstack.org/487405 | |
| 13:35:28 | gibi | bhagyashris: that is something new for me. It seems to be specific to your shared disk case | |
| 13:35:32 | sdague | dansmith: I'm totally fine with password masking by default | |
| 13:35:36 | sdague | I think that's very reasonable | |
| 13:35:59 | bhagyashris | gibi: yes | |
| 13:36:28 | cdent | bhagyashris: are you able to tell if the conductor started the process of telling the compute to build the instance? If so, then the placement side of things is working properly, and whatever has gone wrong there with the lock may be the issue. From what you’ve pasted it is hard to tell what’s going on | |
| 13:37:19 | mriedem | god it's awesome how the docs migration has broken all cached urls https://docs.openstack.org/nova/latest/cells.html | |
| 13:37:33 | cdent | quite | |
| 13:37:42 | mriedem | search for "docs nova-manage list_cells" in google and ^ is the first hit | |
| 13:37:44 | mriedem | and it's a 404 | |
| 13:38:22 | cdent | I would have thought there would be redirects | |
| 13:38:33 | moshele | mriedem: ok I will create bp | |
| 13:38:55 | mriedem | cdent: me too | |
| 13:39:02 | mriedem | but maybe we need to do those explicitly now | |
| 13:39:08 | mriedem | i'm complaining in #openstack-doc | |
| 13:41:46 | sdague | hmmm no jay yet? He had wanted this merged, but it needed a reno - https://review.openstack.org/#/c/357726/ | |
| 13:42:35 | mriedem | how about we hold that for queens | |
| 13:42:52 | dims | mriedem : it's under /user, no? | |
| 13:42:53 | bhagyashris | cdent: ohk, Just wanted to confirm one thing. the steps i have mentioned in the [1]: http://paste.openstack.org/show/616724/ for nfs shared resource provider thing to test is correct? | |
| 13:43:16 | cdent | bhagyashris: let me read through that again, to be sure | |
| 13:43:18 | mriedem | dims: yes, but i know that, someone else won't | |
| 13:43:35 | mriedem | AJaeger is going to rebuild the site map | |
| 13:43:37 | mriedem | to see if that fixes it | |