| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-26 | |||
| 13:31:59 | mriedem | dansmith: i haven't heard of anything | |
| 13:32:02 | dansmith | amazing | |
| 13:32:13 | mriedem | gibi: ok looks good, i wanted to show you something else first | |
| 13:32:34 | sdague | mriedem: ok, I'm not sure what behavior you are looking for, but there are result runs here - https://review.openstack.org/#/c/487246 | |
| 13:32:35 | gibi | mriedem: sure | |
| 13:32:56 | mriedem | sdague: yeah i'll look after the api meeting | |
| 13:36:17 | mriedem | gibi: i was reminded of this testtools matcher yesterday https://review.openstack.org/#/c/486850/6/nova/tests/unit/api/openstack/compute/test_versions.py@303 | |
| 13:36:25 | mriedem | self.assertThat(jsonutils.loads(res.body), | |
| 13:36:25 | mriedem | matchers.DictMatches(expected)) | |
| 13:36:30 | mriedem | which is similar to what you're doin | |
| 13:36:37 | mriedem | if it fails, it tells you what the diff is | |
| 13:36:44 | mriedem | gibi: so i wonder if we could re-use that | |
| 13:36:59 | gibi | mriedem: I can check that out | |
| 13:37:11 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migration from ``ip`` commands to ``pyroute2`` https://review.openstack.org/484386 | |
| 13:38:34 | gibi | mriedem: I will plug that in to the notification sample test to see if it works and then I will check what it prints when something does not match | |
| 13:40:17 | gmann_ | mriedem: hum, i can do abandon. but i wan to give try to merge schema and code split among files. but for next release | |
| 13:40:37 | gmann_ | mriedem: we need to abandon or detach from BP to close BP? | |
| 13:41:45 | mriedem | gmann_: no, i just wanted to clean up the review queue for that bp | |
| 13:42:36 | mriedem | moshele: is that building into an existing bp? | |
| 13:42:40 | mriedem | or something else? | |
| 13:43:25 | moshele | mriedem: I just opened neutron RFE | |
| 13:45:26 | gmann_ | mriedem: ok, i will detach that from it. | |
| 13:46:57 | jaypipes | moshele: done. | |
| 13:52:29 | kashyap | "recheck pep8" is a thing? | |
| 13:52:37 | mriedem | no | |
| 13:53:16 | mriedem | cdent: sdague: wording nit in https://review.openstack.org/#/c/486623/3/releasenotes/notes/deprecate_wsgi_log_format-43a10b7a608ea8f3.yaml | |
| 13:53:47 | cdent | yeah, good point, probably “preferred deployment mode" | |
| 13:53:52 | openstackgerrit | Sean Dague proposed openstack/nova master: deprecate ``wsgi_log_format`` config variable https://review.openstack.org/486623 | |
| 13:54:03 | sdague | mriedem: done | |
| 13:54:13 | kashyap | mriedem: Thanks. Sigh, I made a silly tabs / spaces mistake, and paying the penalty of not running `pep8` locally first on last iteration | |
| 13:55:36 | bauzas | mriedem: could you please point me out the super etherpad for reviews ? | |
| 13:55:45 | bauzas | I mean, the one for the left BPs | |
| 13:56:09 | bauzas | mriedem: yeah I'm lazy and I can find it by myself but hopefully your tab is still open | |
| 13:57:30 | jangutter | https://etherpad.openstack.org/p/nova-pike-feature-freeze-status | |
| 13:58:19 | gmann_ | bauzas: this one - https://etherpad.openstack.org/p/nova-pike-feature-freeze-status | |
| 13:58:30 | bauzas | thanks | |
| 13:59:17 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Post-migration, set cache value for Cinder volume(s) https://review.openstack.org/485752 | |
| 13:59:24 | kashyap | And 'recheck pep8' doesn't fix it, as I botched up indentation. The above should fix it. | |
| 14:02:32 | alex_xu | mriedem: I think I will continue https://review.openstack.org/#/c/458004 after freeze as a bug fix. it just adds a test, it isn't realy part of no more ext BP. | |
| 14:03:04 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge server create schema for availability zone extension https://review.openstack.org/451331 | |
| 14:04:10 | jangutter | sean-k-mooney: you perhaps around to do a (hopefully) final eyeball on https://review.openstack.org/#/c/483459/ ? | |
| 14:05:20 | vdrok | good morning folks | |
| 14:05:30 | gibi | mriedem: it seems replacing JsonEqual with DictMatcher passes the sample tests so this direction looks promising | |
| 14:05:48 | gibi | mriedem: I will rework my improvement patch | |
| 14:06:08 | vdrok | mriedem: seeing http://logs.openstack.org/88/473888/12/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-multinode-ubuntu-xenial/d56cef7/logs/screen-n-cond-cell1.txt.gz#_Jul_26_11_15_52_052437 again in the multinode job :( I thought the option you've added in the last patchset of devstack change was the workaround for the subnode? | |
| 14:10:02 | dansmith | vdrok: jlvillal said you guys had fixed that | |
| 14:10:45 | dansmith | vdrok: this: https://review.openstack.org/#/c/477313/ | |
| 14:10:55 | dansmith | but I guess that was grenade | |
| 14:11:18 | vdrok | dansmith: we did add the nomulticell for grenade. but for the multinode job I thought the fix was https://review.openstack.org/#/c/477556/4..5/lib/nova | |
| 14:11:21 | dansmith | vdrok: this? http://logs.openstack.org/88/473888/12/check/gate-tempest-dsvm-ironic-ipa-wholedisk-agent_ipmitool-tinyipa-multinode-ubuntu-xenial/d56cef7/logs/screen-n-cond-cell1.txt.gz#_Jul_26_11_15_52_128079 | |
| 14:12:02 | dansmith | vdrok: I don't think so | |
| 14:13:44 | dansmith | vdrok: you won't get any reschedules with the multicell layout, so if you really hit those in regular gate jobs like this then we need to make you non multicell for now I guess | |
| 14:13:47 | dansmith | even in the regular ones | |
| 14:14:43 | jangutter | moshel: regarding my comments on https://review.openstack.org/#/c/398265 it's basically nova sending extra data to os-vif, so that in future os-vif can handle representors uniformly. | |
| 14:14:55 | vdrok | dansmith: hrm, so this means we need to add some stuff to devstack to check that if virt driver = ironic add the nomulticell everywhere? | |
| 14:15:04 | jangutter | moshele: ^^ sorry for misspelling your nick. | |
| 14:15:21 | dansmith | vdrok: don't you start nova-compute from your devstack plugin such that you can just set it there? | |
| 14:16:04 | vdrok | dansmith: we restart it :) but if it was already configured for multicell it fails. at least it failed when I tried this way | |
| 14:16:44 | vdrok | lemme try to find that patch | |
| 14:17:47 | vdrok | dansmith: here https://review.openstack.org/481114. was tested at https://review.openstack.org/481593 | |
| 14:18:37 | moshele | jangutter: Ok, I will update the representor_address | |
| 14:19:37 | vdrok | n-cond-cell1 log is still there, and is empty http://logs.openstack.org/93/481593/2/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-pxe_snmp-tinyipa-ubuntu-xenial-nv/5972121/logs/screen-n-cond-cell1.txt.gz | |
| 14:20:09 | dansmith | vdrok: yep | |
| 14:21:05 | dansmith | vdrok: give me a sec | |
| 14:21:15 | vdrok | sure | |
| 14:25:38 | bauzas | mriedem: around ? I'm just reading https://review.openstack.org/#/c/485435/6/novaclient/tests/functional/v2/test_os_services.py@74 and I do wonder if we track somewhere the non-possibility to disable/enable a non-compute service | |
| 14:25:46 | bauzas | that's something I missed | |
| 14:26:00 | sdague | mriedem: can you check out whatever you were verifying yesterday in https://review.openstack.org/#/c/487246/ ( the wait for service patch ), or at least point me to what I'm looking for | |
| 14:26:43 | bauzas | I do remember you modified the REST API to use a PUT /os-services/ instead of an action and you made it cell-aware, but I don't remember we said to not accept enablement/disablement for internal services but computes | |
| 14:28:40 | bauzas | mriedem: nevermind, saw the commit msg in https://review.openstack.org/#/c/464280/ | |
| 14:30:26 | dansmith | vdrok: so you can set this variable early enough to make it work right? https://review.openstack.org/487443 | |
| 14:30:52 | mriedem | bauzas: https://bugs.launchpad.net/python-novaclient/+bug/1700359/comments/2 | |
| 14:30:53 | openstack | Launchpad bug 1700359 in OpenStack Compute (nova) "test_os_service_disable_enable fails with "ERROR (NotFound): Could not find binary nova-scheduler on host"" [Medium,Confirmed] | |
| 14:31:40 | mriedem | bauzas: trying to perform actions on non-compute services literally won't work, | |
| 14:31:52 | mriedem | because we look up the service in the cell via the host mapping, which only exists for compute services | |
| 14:31:55 | bauzas | mriedem: yeah it made sense to me | |
| 14:32:10 | mriedem | i just have the todo to put something in the release notes for it | |
| 14:32:25 | bauzas | mriedem: and because we only care about the enable/disable flag by the scheduler only for finding a target | |
| 14:32:32 | jaypipes | jangutter: where are you getting the vif_plug_ovs package here? https://github.com/Netronome/agilio-ovs-openstack-plugin/blob/d3f53fd3e6eaaa3d4b5f98978b2f3aa504a7a8cd/vif_plug_agilio_ovs/agilio_ovs.py#L29-L31 | |
| 14:32:40 | bauzas | mriedem: given other services and not targets for instances | |
| 14:33:00 | jaypipes | jangutter: I don't see os-vif in the list of requirements.txt Python packages. | |
| 14:33:23 | jangutter | jaypipes: yep, there's a sizeable set of cleanups still on that repo. | |
| 14:33:26 | openstackgerrit | Merged openstack/nova master: Using plain routes for the microversions test https://review.openstack.org/485061 | |
| 14:34:49 | dansmith | jaypipes: we're claiming in the scheduler now right? | |
| 14:35:02 | dansmith | oh no | |
| 14:35:06 | dansmith | nm that one hasn't merged yet | |
| 14:35:32 | dansmith | jaypipes: hopefully after it does, the ironic people won't have reschedules during their test runs :/ | |
| 14:35:33 | jaypipes | dansmith: looking at the -1s on that now. | |
| 14:35:58 | cdent | gibi: on https://review.openstack.org/#/c/487327/ I assume the virtenv’s still build correctly before runnin the actual tests? That error message is produced by wsgi-intercept, which gets upset about proxy variables when using the urllib3 interceptor | |
| 14:36:46 | vdrok | dansmith: yup, seems like it should help, thanks! we'll have to add it to our base builder in project-config | |
| 14:37:34 | dansmith | vdrok: okay, you'll work on that/ | |
| 14:37:42 | vdrok | yup | |
| 14:37:53 | vdrok | will propose a project-config patch now | |
| 14:38:03 | dansmith | vdrok: once we merge the scheduler claiming patch, hopefully you won't get any more reschedules during test runs like this, which will probably be faster anyway | |
| 14:38:22 | dansmith | should make your runs faster I mean | |
| 14:38:39 | dansmith | probably good to do this devstack variable in the meantime anyway | |
| 14:38:55 | vdrok | ++ | |
| 14:41:35 | mriedem | sdague: question in https://review.openstack.org/#/c/486700/2/nova/tests/fixtures.py | |
| 14:44:12 | mriedem | oh dan https://review.openstack.org/#/c/487443/ | |
| 14:44:43 | dansmith | mriedem: I was rushing | |