Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-07-25
21:53:26 mriedem jaypipes: ^
22:04:33 jackie-truong Hi @dansmith, are you available? I have some questions on nova/objects/instance.py that I think you can answer
22:04:46 dansmith jackie-truong: for a few minutes yeah
22:05:22 jackie-truong dansmith: I'm helping out with this patch https://review.openstack.org/#/c/457711/
22:06:10 jackie-truong dansmith: And we're having some issues with properly initializing the list of strings (trusted_certs) so that it is actually an Instance field
22:07:01 dansmith jackie-truong: well, it's defined as a field, which means it's actually a field, but go on...
22:07:38 jackie-truong We're seeing the error "Instance object has no attribute 'trusted_cert'"
22:08:03 dansmith jackie-truong: well, it's defined as "trusted_certs" (note the plural), so maybe that's why?
22:08:23 jackie-truong dansmith: Sorry, that was a typo on my part
22:08:35 jackie-truong "Instance object has no attribute 'trusted_certs' "
22:08:37 dansmith damn, thought that was going to be quick :P
22:09:00 jackie-truong dansmith: lol
22:09:07 dansmith well, I'd need to see where/how it's used then I guess,
22:09:08 jackie-truong dansmith: If you need to head out, I can hop on later this week
22:09:25 jackie-truong dansmith: We thought this would be sufficient: "instance['trusted_certs'] = db_inst['trusted_certs']"
22:09:25 dansmith but you really shouldn't get an AttributeError the way you have it defined here
22:09:42 dansmith L457?
22:10:00 jackie-truong dansmith: Yes, L457
22:10:22 dansmith db_inst is an "Instance" as well although it's from the model.. maybe it's actually complaining about that one?
22:10:34 jackie-truong dansmith: Would we need to add some lines to load the trusted_certs attribute in obj_load_attr?
22:11:09 dansmith jackie-truong: I don't see trusted_certs on the db model
22:11:24 dansmith so I expect that's the problem. is there some other patch that is supposed to be under this?
22:12:31 jackie-truong Yes, this is part of the Nova certificate validation blueprint https://blueprints.launchpad.net/openstack/?searchtext=nova-validate-certificates
22:12:56 jackie-truong dansmith: But no, we didn't add anything to nova/db/sqlalchemy/models.py
22:13:12 dansmith jackie-truong: well, uh, where do you think it's getting stored then? :P
22:13:19 jackie-truong Good point ><
22:13:26 dansmith jackie-truong: but yeah, I bet that's what you're hitting
22:13:56 jackie-truong Cool, thanks! So there's no need to add anything to instance.py's obj_load_attr?
22:14:26 jackie-truong In other words, once we put trusted_certs in the db models, then L457 should be good?
22:15:37 dansmith L457 will be yeah.. you only need obj_load_attr() changes if you want to be able to lazy-load this field, which I think I said on that review a while back
22:15:59 dansmith you'll need a sql migration to add the column, then support on the model, then this patch and it should load
22:16:20 dansmith although a list is a list, not a column, so you need to figure out how you're going to store that and bring it in as a list of things, but I'm sure you know that
22:16:43 jackie-truong Got it. Thanks a lot, dansmith!
22:24:33 openstackgerrit Vipin Balachandran proposed openstack/nova master: VMware:Use power_state const for power state check https://review.openstack.org/483122
22:26:44 dansmith jackie-truong: np
22:38:12 openstackgerrit Tony Breeds proposed openstack/nova master: Avoid chowning console logs in libvirt https://review.openstack.org/472229
22:38:12 openstackgerrit Tony Breeds proposed openstack/nova master: First attempt at adding a privsep user to nova itself. https://review.openstack.org/459166
22:38:13 openstackgerrit Tony Breeds proposed openstack/nova master: Move the last_bytes util method to libvirt https://review.openstack.org/472228
22:38:13 openstackgerrit Tony Breeds proposed openstack/nova master: Do not import nova.conf into nova/exception.py https://review.openstack.org/485907
22:38:14 openstackgerrit Tony Breeds proposed openstack/nova master: Move libvirt usages of chown to privsep. https://review.openstack.org/471972
22:38:14 openstackgerrit Tony Breeds proposed openstack/nova master: rootwrap.d cleanup mislabeled files https://review.openstack.org/486831
22:43:21 openstackgerrit Nicolas Simonds proposed openstack/nova master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/484997
23:00:07 jaypipes mriedem: sorry, was out back mowing the dirt patch...
23:00:13 jaypipes mriedem: what did you find?
23:01:34 jaypipes mriedem: ah, I read the comments on the patch. nice catch, and thank you sir.
23:07:48 dansmith wow, big information leak from papa cisco there
23:13:33 cburgess dansmith Do what...?
23:14:18 dansmith cburgess: the forward of the internal cisco "go sway the vote" email that got forwarded to the dev list with a ton of cisco email and mailing lists
23:15:19 smcginnis Someone's probably going to get a sterm talking to.
23:15:37 smcginnis melwitt: http://lists.openstack.org/pipermail/openstack-dev/2017-July/120115.html
23:16:06 melwitt lol
23:16:27 smcginnis Gah - s/sterm/stern/
23:18:40 dansmith I really really want to go register for some interesting websites with those group addresses
23:19:05 dansmith "Dear openstack summit core, please confirm your registration to Latex Fetish Weekly"
23:19:19 smcginnis lol
23:19:34 melwitt :)
23:21:22 melwitt I assumed it was an accident when I opened it but it looks to be on purpose?
23:22:45 dansmith seems purposeful to me. misguided and naive, but purposeful
23:22:50 dansmith needless to say, I've already voted :)
23:22:57 melwitt yeah
23:22:57 melwitt hah
23:26:42 cburgess So... sorry about that. Someone internal wasn't aware of the proper community norms. Gary, our internal person who owns our summit participation is going to make sure that individual, and everyone internal involved in summit talks understand community norms and adheres to them in the future.
23:35:14 mtreinish heh, I'm also pretty sure that voting page isn't ready yet
23:35:25 mtreinish like there's still the deadlines from boston listed
23:36:54 mtreinish and the backend isn't filtering at all. I searched for dansmith's name and it showed all of his proposed talks going back to atl
23:37:20 dansmith yeah I noticed that too
23:42:55 jaypipes cburgess: Gary was the one that sent the internal Cisco email...
23:44:17 cburgess jaypipes I take it by that statement that you are also pointing out that the internal email is somewhat against the community spirit?
23:45:11 jaypipes cburgess: wasn't it? it's basically the "go vote for all of Cisco's submissions" email.
23:46:22 cburgess jaypipes I suppose thats a fair statement. There is some desire internally to show our level of involvement and promote our talka. But I agree that it is also a form of vote swaying that is at odds with the community standards.
23:47:00 cburgess I'll discuss it internally, though I'm fairly certain other companies do, or have done similar things in the past. But its a fair point that its not in keeping with the spirit.
23:47:09 jaypipes cburgess: totes
23:47:48 jaypipes cburgess: an email saying "hey everyone, please do your civic duty and go review and vote on summit talk proposals so that the summit schedule has excellent content" would be perfectly fine.
23:48:54 cburgess jaypipes and those do happen as well. Its a fair point. Gary is, in general, very supportive of the community and its standards (he is co-organizer of the LA OpenStack meetup). There is some conflict at times between the community and internal desires. I agree that we could do better and I'll bring those up.
23:49:16 jaypipes cburgess: I'm not bitching about it. :)
23:49:57 jaypipes cburgess: was just pointing out that Gary (the person you mentioned was responsible for adhering to community norms) was the one who sent the email internally at Cisco :)
23:50:16 jaypipes cburgess: I didn't know if you were aware of that.
23:50:38 jaypipes cburgess: trust me, I've bitched about similar emails that Mirantis marketing has sent out internally.
23:51:06 jaypipes cburgess: and anyway, there's way more important things for me to bitch about: https://twitter.com/jaypipes/status/889889832025165827
23:51:09 jaypipes clearly.
23:51:38 cburgess jaypipes Well everyone is responsible for community norms (and yeah I'm aware I saw the thread, internally and on the dev list). Its hard for me to apply more the mild pressure on the internal type comms. But both Gary and I can apply much more preasure as it relates to external community involvement and comms.
23:52:01 cburgess jaypipes LOL.. seen more then a few of those myself.
23:52:24 jaypipes cburgess: hey, if it makes you feel better, I voted up your proposed talk :)
23:52:32 cburgess lol thanks
23:54:12 jaypipes and now.. I'm off.
23:54:13 jaypipes ciao
23:54:49 openstackgerrit Jackie Truong proposed openstack/nova master: Add trusted certificates to InstanceExtras https://review.openstack.org/457711
#openstack-nova - 2017-07-26
00:24:05 mriedem jangutter: question in https://review.openstack.org/#/c/483459/15/nova/network/os_vif_util.py@333
01:06:02 alex_xu oomichi: thanks
01:16:52 openstackgerrit Matt Riedemann proposed openstack/nova master: Translate the return value of attachment_create and _update https://review.openstack.org/486194
01:16:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285
01:26:31 moshele mriedem, jaypipes: hi can you review https://review.openstack.org/#/c/398265/ ?
01:33:54 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Wrong href link returned when providing non-existed version in GET version API https://review.openstack.org/486850
02:08:54 openstackgerrit Merged openstack/nova master: Add VIFHostDevice support to libvirt driver https://review.openstack.org/486426
02:11:31 openstackgerrit Moshe Levi proposed openstack/nova master: hardware offload support for openvswitch https://review.openstack.org/398265
02:33:41 saphi Hi guys. I'm deploying Openstack Pike on Ubuntu 16.04 use ubuntu archive repository. I have two node controller and compute. nova-compute was installed on both of them. So I have two compute nodes. But When I launch an instance. If the instance go to compute-node, it can't download Image from glance-api. If the instance go to controller node, It run successful.
02:35:22 saphi On glance-api.log, the error is timed out.
02:40:50 saphi Oh. the problem is my network configuration
02:57:40 tetsuro reported a bug that you can't use ":" as az name, and proposed 2 solutions. could you advise me which solution is better on https://bugs.launchpad.net/nova/+bug/1695861 ?
02:57:41 openstack Launchpad bug 1695861 in OpenStack Compute (nova) "Invalid availability zone name with ':' is accepted" [Undecided,Confirmed]

Earlier   Later