| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-25 | |||
| 13:06:18 | bauzas | if so, nevermind my concern | |
| 13:06:18 | cdent | in gabbi itself | |
| 13:06:30 | sdague | cdent: that's just optimizing for the opens? | |
| 13:06:31 | bauzas | a-ha, so a transitive dependency anyway | |
| 13:07:04 | cdent | sdague: that, and for avoiding on disk files when CONF.log_dir is not set. I was doing an strace and so many lines of open and closing dnstest.txt | |
| 13:07:24 | openstackgerrit | Alexandra Settle proposed openstack/nova master: doc: Rework index page per new sections https://review.openstack.org/478485 | |
| 13:07:24 | sdague | yeh, that seems reasonable | |
| 13:07:32 | bauzas | cdent: any plan to push wsgi-intercept to for example openstack ? | |
| 13:07:51 | sdague | cdent: I kind of wonder whether the write to disk path is needed at all | |
| 13:07:51 | TheJulia | mriedem: not ignoring you, presently debating a related grenade issue in another channel | |
| 13:08:12 | cdent | bauzas: neither wsgi-intercept nor gabbi will come to openstack because a few of the other contributors _really_ do not want that | |
| 13:08:19 | bauzas | cdent: that's understandable | |
| 13:08:39 | bauzas | well, if we already have that transitive dependency for gabbi, anyway... | |
| 13:08:51 | sdague | cdent: I remember seeing minidns spew a bunch in the past, and was always curious about getting it to stop that | |
| 13:09:00 | cdent | sdague: I tried that, and what I found was there are few different tests where there are more than one dns manager (instance/floating ip) that are sharing the same data file | |
| 13:09:03 | mriedem | TheJulia: np, take your time | |
| 13:09:29 | cdent | sdague: and I didn’t have the horsepower to go digging to see if that could be changed | |
| 13:10:38 | cdent | sdague: for most tests the in-memory thing is used | |
| 13:13:57 | mriedem | TheJulia: found what i was looking for http://logs.openstack.org/49/485349/4/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial/376d4dd/console.html#_2017-07-25_04_37_15_094371 | |
| 13:14:26 | TheJulia | mriedem: I do love how much faster test runs :) | |
| 13:14:49 | mriedem | 4 minutes is faster? | |
| 13:15:42 | TheJulia | this can cut a reboot out of the process of handing a ready machine off, so naturally much faster :) | |
| 13:16:05 | mriedem | TheJulia: final questions when you get a moment are, i see some patches in flight on the ironic side, should we hold the nova change for those? or make the nova change depends-on them? | |
| 13:16:12 | mriedem | like https://review.openstack.org/#/c/484032/5 | |
| 13:19:50 | dtantsur | if jlvillal agrees, we can merge it now, and address the tests issues in a follow-up | |
| 13:20:03 | dtantsur | I suspect this is the only in-flight patch that matters | |
| 13:20:27 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Wrong href link returned when providing non-existed version in GET version API https://review.openstack.org/486850 | |
| 13:21:55 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migration from ``ip`` commands to ``pyroute2`` https://review.openstack.org/484386 | |
| 13:22:04 | TheJulia | dtantsur: I already got agreement from him to do that last night :) | |
| 13:23:30 | TheJulia | dtantsur: well, agreement on the ironic patch :) | |
| 13:23:53 | dtantsur | okie, let's wait for Sam's review, and Just Do It (tm) | |
| 13:26:00 | TheJulia | Excellent! | |
| 13:26:13 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | |
| 13:26:20 | openstackgerrit | Chris Dent proposed openstack/nova master: Optimize MiniDNS for fewer syscalls https://review.openstack.org/486829 | |
| 13:31:40 | s-dean | Hi, dont wana be a pest, any of you guys able to help me for 2 seconds ? | |
| 13:34:12 | mriedem | dtantsur: TheJulia: so i'm hearing we're good to go on the nova change then | |
| 13:34:20 | mriedem | if so, i will hassle mr dague | |
| 13:36:16 | jaypipes | bauzas: alloc_reqs_by_rp_uuid is a map of compute node UUID to list of allocation requests | |
| 13:36:19 | dtantsur | yeah, I suspect so | |
| 13:36:27 | dtantsur | the final word is for TheJulia though :) | |
| 13:38:58 | TheJulia | I think so | |
| 13:40:52 | bauzas | jaypipes: sure, but what if the first compute node UUID is not corresponding to the first host from the ones given by get_sorted_hosts() ? | |
| 13:41:08 | jaypipes | bauzas: it's a dict... | |
| 13:41:30 | jaypipes | bauzas: not sure what you're asking, sorry... | |
| 13:42:14 | bauzas | jaypipes: oh sorry, just saw edleafe's comment | |
| 13:42:23 | bauzas | https://review.openstack.org/#/c/483566/10/nova/scheduler/filter_scheduler.py@202 | |
| 13:42:52 | bauzas | we're getting a list of allocation requests *per* compute node | |
| 13:43:28 | jaypipes | bauzas: right | |
| 13:43:46 | sdague | mriedem: what's up now? | |
| 13:43:47 | bauzas | jaypipes: I was confused by your TODO in https://review.openstack.org/#/c/483566/10/nova/scheduler/filter_scheduler.py@270 | |
| 13:43:48 | edleafe | bauzas: don't feel bad - I had to read that over several times before it made sense to me, too | |
| 13:44:00 | jaypipes | bauzas: that alloc_reqs_by_rp_uuid is a dict, keyed by compute node UUID, of allocation requests that contain that compute node | |
| 13:44:07 | bauzas | jaypipes: so the same compute node could have more than one allocation request ? | |
| 13:44:23 | bauzas | just tbc | |
| 13:44:32 | edleafe | bauzas: there could be several allocs for a given compute node. The TODO is about being smarter about picking which one to use | |
| 13:44:56 | bauzas | the real problem I had is that allocation_candidates just was discussed when I was in and out, and now I'm paying the price by giving you silly comments :/ | |
| 13:44:58 | jaypipes | bauzas: yep. imagine in the future, nested r-p's there may be dozens of allocation requests that partially allocate resources on the compute node. | |
| 13:45:09 | jaypipes | bauzas: same with things like shared storage | |
| 13:45:25 | jaypipes | bauzas: not a problem, don't worry about it. | |
| 13:45:25 | mriedem | sdague: https://review.openstack.org/#/c/215385/ | |
| 13:45:28 | bauzas | jaypipes: ah, right | |
| 13:45:39 | bauzas | nested RPs is understandable by me | |
| 13:46:01 | bauzas | because you could consume more than one thing for a specific compute node | |
| 13:46:10 | bauzas | ah, and I see your point with shared storage | |
| 13:46:22 | jaypipes | bauzas: so, imagine a compute host with 2 NUMA nodes and 4 PCI devices, affined to the different NUMA cells. We might potentially have a lot of allocation requests (candidates) for those child providers plus resources on the compute host itself (like VCPU, etc) | |
| 13:46:30 | bauzas | we could potentially have the compute node having allocation request for local resources + shared resource ? | |
| 13:46:42 | jaypipes | bauzas: yep | |
| 13:46:46 | bauzas | jaypipes: that, I'm clear for nested RPs | |
| 13:46:53 | bauzas | okay, nevermind all my comments then | |
| 13:46:56 | bauzas | I'm on board now :) | |
| 13:46:57 | jaypipes | bauzas: one alloc request might have local disk, another consuming from shared disk. | |
| 13:47:00 | sdague | mriedem: ah, that one. Approved | |
| 13:47:09 | jaypipes | bauzas: of course, that's not currently possible, but you see the idea | |
| 13:47:09 | bauzas | jaypipes: thanks for explaning it | |
| 13:47:14 | jaypipes | no worries | |
| 13:48:08 | mriedem | dtantsur: TheJulia: what is the story on https://review.openstack.org/#/c/468353/ ? | |
| 13:48:14 | mriedem | required for pike? | |
| 13:49:37 | sdague | melwitt: https://bugs.launchpad.net/nova/+bug/1706310 that's addressed by your new quota counting? | |
| 13:49:38 | openstack | Launchpad bug 1706310 in OpenStack Compute (nova) "Quota usage is not updated if an instance is deleted while booting" [Undecided,New] | |
| 13:49:42 | dtantsur | mriedem: I think this is nice-to-have, but still optional | |
| 13:49:56 | dtantsur | I guess it may cause some longer discussions | |
| 13:49:58 | TheJulia | mriedem: the consensus is not required this cycle, it just allows for greater use case flexibility ultimately shipping a source IP address off to cinder in the event there is firewalling present. | |
| 13:50:03 | bauzas | jaypipes: +2d FTW | |
| 13:50:25 | sdague | mriedem: that one is a little less straight forward, and honestly probably a good ptg conversation | |
| 13:50:29 | sdague | it adds virt driver methods | |
| 13:50:54 | mriedem | right i'd like to defer it | |
| 13:51:00 | sdague | mriedem: agreed | |
| 13:51:01 | TheJulia | sdague: good point | |
| 13:51:07 | mriedem | as something else - ironic bfv + network-managed storage | |
| 13:51:30 | jaypipes | edleafe: I can clean those nits up later. at this point, I'm nervous about kicking off another gate recheck odyssey ;) | |
| 13:52:00 | cdent | jaypipes: you might like these then: https://review.openstack.org/#/c/486237/ | |
| 13:52:17 | edleafe | jaypipes: totally agree | |
| 13:52:47 | ildikov | mriedem: oh ok, tnx for the info :) | |
| 13:56:47 | mriedem | sdague: about that quota bug, yes counting quotas would address that, but also, it could already be a known issue fixed in ocata, | |
| 13:56:52 | mriedem | the reporter didn't say what version they were using | |
| 13:56:55 | mriedem | i'm leaving comments | |
| 14:06:57 | openstackgerrit | Jan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver https://review.openstack.org/486426 | |
| 14:09:10 | openstackgerrit | Jan Gutter proposed openstack/nova master: Add VIFHostDevice support to libvirt driver https://review.openstack.org/486426 | |
| 14:11:52 | mriedem | sdague: the dependencies for the cells fleetify devstack change are all merged https://review.openstack.org/#/c/477556/ | |
| 14:12:00 | mriedem | sdague: thoughts on putting that in right now? | |