| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-24 | |||
| 15:02:48 | sean-k-mooney | yes though i have to drop for meeting in an hour | |
| 15:03:14 | sean-k-mooney | jangutter: ^ | |
| 15:03:52 | jangutter | sean-k-mooney: I split off https://review.openstack.org/#/c/486426/ but I'm not sure I wrote the test right. | |
| 15:05:49 | sean-k-mooney | jangutter: well that is partly a technically question and partly a political one. you added _set_config_VIFHostDevice | |
| 15:06:53 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Migration from 'ip' commands to pyroute2 https://review.openstack.org/484386 | |
| 15:08:04 | mriedem | s-dean: yes the cells table is for cells v1 only | |
| 15:08:06 | jangutter | sean-k-mooney: yep, and used "unplugin" rather than "plugin" -> other VIF tests that don't go out via an os-vif plugin seem to use that, rather than "plugin" | |
| 15:08:07 | sean-k-mooney | jangutter: technically in test_vif.py you should only assert that the designer was called. and then in https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/test_designer.py you should assert that correct xml is generated when you pass in the os_vif_hostdevice | |
| 15:08:25 | mriedem | s-dean: you have a nova_api db yes? | |
| 15:08:33 | mriedem | s-dean: did you run nova-manage api_db sync ? | |
| 15:09:08 | mriedem | s-dean: also https://docs.openstack.org/nova/latest/cells.html and https://docs.openstack.org/ocata/install-guide-ubuntu/nova.html for docs | |
| 15:09:22 | sean-k-mooney | jangutter: but politcally nova has not done it this way else where in the file so you should follow the files convention of have test_vif.py also test desighern fuctionality though really this should be change across the board in that file in a seperate patch | |
| 15:09:37 | jangutter | sean-k-mooney: ah, that makes it a lot finer-grained. | |
| 15:10:57 | sean-k-mooney | jangutter: yes unfutrnetlly that is not how the other unitest have been written so it better to follow the convention in the file though we should proably file a bug to make it more granular | |
| 15:11:35 | sean-k-mooney | jangutter: i think the current patch is fine given the convention that is inplace | |
| 15:11:43 | mriedem | s-dean: it could also mean that the nova.conf that you're running nova-manag db sync against doesn't have the [api_database]connection option set? | |
| 15:12:20 | s-dean | yes I have nova_api database, I have run the commands in order as specified in the documentation, However ERROR: could not access cell mapping database - has api db been created? | |
| 15:12:29 | s-dean | keeps appearing | |
| 15:12:45 | mriedem | s-dean: the command is looking for entries in the cell_mappings table in the nova_api db | |
| 15:12:59 | s-dean | they exist | |
| 15:13:07 | jangutter | sean-k-mooney: thanks, I and that clears up the other questions I also had. I had wondered why there seemed to be two sets of tests in test_vif.py | |
| 15:13:11 | mriedem | or whatever you called it, but it would be defined by the [api_database]connection url in nova.conf | |
| 15:13:13 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | |
| 15:13:26 | mriedem | s-dean: how do the cell_mappings entries exist if you don't have a nova_api db? | |
| 15:13:33 | mriedem | oh you said you have it | |
| 15:13:34 | stvnoyes | mriedem good morning Matt, when you get some time, please take a look at the updated cinder v3 migrate review. thanks. - https://review.openstack.org/#/c/463987/ | |
| 15:13:37 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | |
| 15:13:49 | mriedem | s-dean: is [api_database]connection set in nova.conf when running nova-manage db sync? | |
| 15:13:54 | s-dean | I have created it, Is this a potential bug | |
| 15:14:13 | s-dean | yes my connection string is correct | |
| 15:14:40 | mriedem | s-dean: just to be clear, so you have both [database]/connection and [api_database]/connection set in nova.conf? | |
| 15:14:44 | mriedem | and they are different values, yes? | |
| 15:14:45 | s-dean | yes | |
| 15:14:48 | s-dean | yes | |
| 15:15:08 | s-dean | one for nova_api | |
| 15:15:10 | mriedem | ok, and you ran nova-manage api_db sync ? | |
| 15:15:15 | s-dean | and on for nova db | |
| 15:15:19 | s-dean | yes | |
| 15:15:28 | sean-k-mooney | jangutter: i think its a legacy thing. but generally when writhing unit test you should mock any fuction call to other modules in the current project and test only how the output of the fuction is used and test the internals of that fuction in a seperate test in that modules test file | |
| 15:15:43 | mriedem | did you run nova-manage cell_v2 map_cell0 | |
| 15:16:26 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform HostAPI-set_enabled notifications https://review.openstack.org/482622 | |
| 15:16:27 | sean-k-mooney | jangutter: but in all cases the convention of the file you are extending take presedence over teh convetions of the project as a whole though one would hope they more or less agree | |
| 15:16:36 | mriedem | stephenfin: fyi, docs theme is jacked here https://docs.openstack.org/nova/latest/cells.html | |
| 15:17:06 | s-dean | I have run Step 3,4,5,6 at step 6 following error | |
| 15:17:06 | s-dean | ERROR: could not access cell mapping database - has api db been created? | |
| 15:17:19 | jangutter | sean-k-mooney: yep. No joke "writhing unit test" is pretty accurate. | |
| 15:17:53 | mriedem | s-dean: steps in which doc? the install guide? | |
| 15:17:59 | s-dean | ubuntu 16.04 | |
| 15:18:12 | s-dean | ocata install guide | |
| 15:18:40 | mriedem | s-dean: so you have a nova_cell0 database as well? | |
| 15:18:45 | mriedem | there are 3 dbs involved | |
| 15:18:45 | s-dean | yeah | |
| 15:18:47 | mriedem | ok | |
| 15:18:50 | s-dean | nova_api | |
| 15:18:52 | s-dean | nova | |
| 15:18:58 | s-dean | _cell0 | |
| 15:19:24 | s-dean | nova_cell0 | |
| 15:19:35 | mriedem | ok and the cell_mappings.database_connection url for the cell_0 entry in the nova_api database is correct? | |
| 15:19:36 | s-dean | all exist | |
| 15:19:38 | knikolla | o/ is the rbd information for the ephemeral disks only in the nova,ceph.conf files? We've changed monitor IPs but old VMs still have the old information with old IPs. | |
| 15:20:06 | s-dean | i shall check | |
| 15:21:20 | s-dean | transport url for cell1 exists, cell0 has the following none:/// | |
| 15:21:33 | mriedem | for the database_connection/ | |
| 15:21:34 | mriedem | ? | |
| 15:21:41 | s-dean | no | |
| 15:21:55 | s-dean | database connection on both cell0 and cell1 are the same | |
| 15:22:09 | mriedem | except one should point at cell0 and one should point at cell1 | |
| 15:22:18 | mriedem | well, the cell0 mapping should point at the nova_cell0 db, | |
| 15:22:25 | mriedem | and the cell1 mapping should point at the nova db | |
| 15:23:08 | s-dean | mysql+pymysql://nova:mypassword@my_ip/nova?charset=utf8&ssl_ca=/etc/nova/tls/mysql/ca-cert.pem&ssl_cert=/etc/nova/tls/mysql/server-cert.pem&ssl_key=/etc/nova/tls/mysql/server-key.pemnova_cell0 | |
| 15:23:27 | s-dean | is this the issue > nova_cell0 | |
| 15:23:39 | s-dean | is this the issue > server-key.pemnova_cell | |
| 15:23:45 | sdague | mriedem / dansmith - is there a new timing issue where GET right after POST is going to 404 - https://bugs.launchpad.net/nova/+bug/1682423 ? | |
| 15:23:46 | openstack | Launchpad bug 1682423 in OpenStack Compute (nova) "create instance with dashbaord / 404 returned" [Undecided,New] | |
| 15:24:48 | mriedem | s-dean: i think the issue is that's pointing at the nova db | |
| 15:24:52 | mriedem | nova? | |
| 15:25:02 | mriedem | i think that should be nova_cell0? | |
| 15:25:14 | s-dean | why is it on the end of the connection string ? | |
| 15:25:20 | dansmith | sdague: in ocata? | |
| 15:25:37 | mriedem | s-dean: my guess is a string substitution bug in map_cell0 | |
| 15:25:45 | mriedem | s-dean: do you have the latest stable/ocata code? or 15.0.0? | |
| 15:25:55 | s-dean | from the cloud archive | |
| 15:25:56 | sdague | dansmith: yeh, I was wondering if the cells v2 transition opens up a window there | |
| 15:26:10 | dansmith | sdague: it's not supposed to, no | |
| 15:26:27 | dansmith | if it was master just now I'd suspect some quota thing | |
| 15:26:39 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Stop using mox stubs in test_console_auth_tokens.py https://review.openstack.org/477374 | |
| 15:27:02 | mriedem | s-dean: what's the version of nova? | |
| 15:27:08 | s-dean | to seconds | |
| 15:27:10 | s-dean | two | |
| 15:27:42 | s-dean | nova-api | 2:13.0.0-0ubuntu2 | |
| 15:27:51 | mriedem | s-dean: whoa that's mitaka | |
| 15:27:57 | mriedem | ocata is 15.0.0 | |
| 15:28:13 | s-dean | wait | |
| 15:28:14 | s-dean | sorry | |
| 15:28:15 | s-dean | nova-api | 2:15.0.5-0ubuntu1~cloud0 | |
| 15:28:45 | mriedem | ok that's better | |
| 15:29:19 | mriedem | s-dean: did you run map_cell0 with 15.0.5 or earlier? | |
| 15:29:21 | mriedem | because https://docs.openstack.org/releasenotes/nova/ocata.html | |
| 15:29:27 | s-dean | fresh install | |
| 15:29:27 | mriedem | https://launchpad.net/bugs/1673613 | |