Earlier  
Posted Nick Remark
#openstack-nova - 2017-07-20
15:52:49 jaypipes gibi: cool. enjoy your long weekend! :)
15:53:11 gibi jaypipes: thanks!
16:00:54 openstackgerrit Jay Pipes proposed openstack/nova master: Remove improper LOG.exception() calls in placement https://review.openstack.org/485726
16:00:56 jaypipes gibi: fixed already :) ^^
16:16:32 mriedem +2
16:19:46 openstackgerrit Stephen Finucane proposed openstack/nova master: DNM: Try to figure out what the tenant is returning https://review.openstack.org/485733
16:20:59 mriedem would be nice to get some eyes on this https://review.openstack.org/#/c/446671/
16:21:24 mriedem we've got 3 patches left for the cinder attachment stuff
16:21:30 mriedem and this is probably the least complicated
16:22:43 dfisher mriedem: is this for multi-attach?
16:23:05 mriedem it's for using the new cinder 3.27 attachments api which is a prereq for multiattach
16:23:09 openstackgerrit Matthew Booth proposed openstack/nova master: Split Compute.errors_out_migration into a separate contextmanager https://review.openstack.org/485734
16:23:47 dfisher mriedem: i assume with all this changing, https://bugs.launchpad.net/nova/+bug/1527623 may get another look?
16:23:48 openstack Launchpad bug 1527623 in OpenStack Compute (nova) "Nova might orphan volumes when it's racing to delete a volume-backed instance" [Medium,In progress] - Assigned to ChangBo Guo(gcb) (glongwave)
16:24:31 mriedem w/o loading a bunch of context into my head right now i can't say
16:25:04 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285
16:27:01 oorgeron Hi folks, I'd like to get https://review.openstack.org/#/c/446643/ reviewed. Anyone around to help?
16:27:59 mriedem oorgeron: that's not something we need to spend time reviewing when we're 7 days from the pike feature freeze
16:28:01 mriedem and is not a bug fix
16:28:24 dansmith +1
16:28:42 oorgeron so you want me to shift it to blueprint or rfe?
16:28:50 mriedem it's already got a blueprint tied to it
16:28:59 mriedem so bring it up when we start talking about blueprints for queens
16:29:02 mriedem in a few weeks please
16:29:43 openstackgerrit Sean Dague proposed openstack/nova master: WIP: request_log addition for running under uwsgi https://review.openstack.org/485602
16:31:54 oorgeron mriedem: I'll hold off on it for now.
16:32:09 mriedem thanks
16:32:32 mriedem if there are going to be oracle people at the ptg in denver, i think it would also be good to bring this up as a topic in a cross-project session
16:32:35 mriedem since this is more than just nova
16:32:39 mriedem and all projects should be on the same page
16:32:58 mriedem otherwise you get 50% of the projects accepting this and others don't and you're stuck
16:33:02 mriedem oorgeron: ^
16:33:07 oorgeron mriedem: it's already in other projects and most don't require any changes beyond having oslo.db 4.24 or above.
16:33:25 jaypipes oorgeron: wish I had been aware of https://review.openstack.org/#/c/427970/ :(
16:33:47 mriedem this is what i'm talking about
16:33:58 mriedem poorly communicated crosss-project effort
16:42:16 TheJulia mriedem: following up from last night re ironic bfv, we have achieved a successful boot, and teardown, at least as far as nova is concerned. Our test vm never booted back up for disk cleaning. hshiina has volunteered to take a stab at fixing the unit tests since the tooling doesn't make creating a wrapped object easy.
16:42:49 mriedem ildikov: comments in https://review.openstack.org/#/c/446671/
16:42:59 mriedem ildikov: only thing i worry about is the VolumeUnattached case
16:43:23 mriedem TheJulia: can't just use bdm._bdm_obj.is_volume?
16:43:56 mriedem the unit test should just pass in a block_device_info['mappings'] = [DriverVolumeBlockDevice(BlockDeviceMapping)]
16:44:15 TheJulia Well, if that works, then that should be a stupidly quick fix
16:44:17 TheJulia hshiina: ^^^
16:54:06 sean-k-mooney anyone know is there a way to convert a vm in to a glance image other then creating a snapshot.
16:56:42 bbansal guys, can anyone tell whom to contact in order to update about requirement consume?
16:57:02 mriedem bbansal: can you reword your question?
16:57:23 bbansal i see nova/requirements.txt:tooz!=1.57.4,>=1.47.0 # Apache-2.0
16:57:46 bbansal and my CI fails because version of tooz which gets installed as per upper-constraints.txt is 1.57.4
16:58:16 bbansal the openstack-requirements channel mentioned that project which still have this !=1.57.4 needs to consume the requirement update
16:58:24 cdent sdague: did you see my comments from ps1 on https://review.openstack.org/#/c/485602/ ? There’s a confused sentence in the commit message, and I also suggested some ways to avoid modifying paste.ini (if that turns out to be important, your email suggests it’s not).
16:58:52 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Read datapath_type from VIF object https://review.openstack.org/474914
17:00:36 bbansal manila project has updated their changeset for the same
17:00:41 bbansal https://review.openstack.org/#/c/485406
17:01:12 mriedem bbansal: there is a bot that syncs the global-requirements changes to nova
17:01:24 mriedem like this https://review.openstack.org/#/c/455970/
17:01:49 ildikov mriedem: checking
17:01:51 bbansal okay, so i need to wait until changes are updated on all projects
17:03:43 bbansal @mriedem: yesterday u filed a bug related to n-net if u remember, can u please provide change set again
17:04:42 bbansal or the bug id
17:05:29 sdague cdent: yeh, I did, I just wanted to get things passing first.
17:05:44 sdague I'll fix the commit message before moving it out of WIP
17:08:41 larsks dansmith: btw, i just rebased https://review.openstack.org/#/c/467699/, which we had previously discussed. I see a jenkins failure but pretty sure it's unrelated.
17:09:32 dansmith larsks: okay, I'm trying to think of who the best person to review that is
17:09:34 dansmith mriedem: ^
17:18:35 ildikov mriedem: if you got a moment, I got lost a bit on the VolumeUnattached stuff in remove check_detach
17:22:57 ildikov mriedem: in check_detach the VolumeUnattached exception should not be raised without multi-attach and I think even with that it would mean that something strange is going on
17:23:19 ildikov mriedem: without it we hit InvalidVolume
17:26:05 openstackgerrit Kashyap Chamarthy proposed openstack/nova master: libvirt/driver.py: Set cache value for Cinder volume post-migration https://review.openstack.org/485752
17:26:20 mriedem bbansal: https://review.openstack.org/#/c/485300/
17:27:31 mriedem dansmith: larsks: does this go into config drive / metadata service API?
17:27:37 dansmith yeah
17:27:48 bbansal thanks
17:28:08 mriedem hmm
17:28:20 mriedem so just our usual old random shove whatever we want in there i guess?
17:28:31 larsks mriedem: note that this change preserve existing behavior.
17:28:48 larsks ...and implements more correct behavior for those who want it.
17:28:48 dansmith mriedem: yeah, I think it's pretty compatible
17:29:26 dansmith mriedem: we've been doing no more fine-grained changes than one per release right? in terms of versions, I mean
17:29:33 dansmith and we've not really been super consistent on that, AfAIK
17:30:37 mriedem we haven't been versioning the metadata api at all when network_data.json changes as far as i know
17:30:44 mriedem there was some other change or two earlier in pike that didn't have a version bump
17:30:46 dansmith oh okay
17:30:55 mriedem filed under bug fixes
17:30:59 dansmith even better then
17:31:00 dansmith "better"
17:31:14 mriedem right. if this were the rest api, it would be a response body change
17:31:22 mriedem *compute api
17:34:56 mriedem left comments
17:35:00 mriedem this isn't so much a bug as a wishlist item
17:35:04 mriedem but i didn't -1
17:36:30 dansmith mriedem: did you read the bug?
17:37:10 dansmith IIRC, you can't properly configure redhat-style interface definitions with just the global list
17:37:39 dansmith if you use the smashed together version, then you break resolution when you bring interfaces down
17:37:43 dansmith *some interfaces I mean
17:38:33 larsks mriedem: I claim this is absolutely a bug.
17:38:33 mriedem ok, i didn't -1
17:38:43 mriedem i left some concerns
17:38:48 dansmith mriedem: it's totally not wishlist, IMHO :)
17:38:52 mriedem i have to run for a bit
17:39:00 mriedem ok change the severity in LP

Earlier   Later