| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-19 | |||
| 13:13:31 | bauzas | mriedem: when you're up and fully coffeenated, just ping me about https://review.openstack.org/#/c/484828/ | |
| 13:13:39 | bauzas | caffeinated even | |
| 13:17:07 | mriedem | bauzas: in a meeting for the next 2 hours | |
| 13:17:43 | bauzas | mriedem_meeting: heh | |
| 13:17:46 | bauzas | no worries | |
| 13:24:16 | openstackgerrit | Béla Vancsics proposed openstack/nova master: Transform aggregate.update_metadata notification https://review.openstack.org/460625 | |
| 13:25:57 | cdent | gibi: I’ve been able to create a flapping testing on /allocation_candidates too | |
| 13:26:31 | cdent | wrote it gabbi-style, will push it up in a moment for additional discussion | |
| 13:26:46 | gibi | cdent: cool then it is not an environemnet issue | |
| 13:31:11 | gibi | cdent: I have the SQL SELECT statements both for the passing and failing case, I put them in the bugreport | |
| 13:31:48 | cdent | ah excellent | |
| 13:33:10 | cdent | weird | |
| 13:33:24 | gibi | cdent: looks quite different | |
| 13:33:29 | cdent | yes | |
| 13:33:41 | gibi | but I'm far from a SQL expert | |
| 13:34:52 | cdent | i’ll take a closer look at the sql building code after I push up these tests | |
| 13:35:06 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: [placement] test shared custom resource provider https://review.openstack.org/485088 | |
| 13:35:38 | gibi | cdent: thanks, I'm pretty much lost | |
| 13:36:36 | cdent | gibi: the code has become quite dense around this stuff | |
| 13:36:46 | cdent | what you’re trying to do is supposed to work | |
| 13:37:30 | gibi | cdent: and it works if the shared resource is not a custom resource or if I add the sharing trait to the compute provider as well | |
| 13:37:36 | cdent | I think that you initially had it working with both providers having the MISC_* trait was coincidence; the data that comes back is a bit wack in that situation | |
| 13:37:48 | cdent | you get too many allocation_requests | |
| 13:38:04 | gibi | cdent: could be, I haven't dig in to that output | |
| 13:41:44 | sdague | mriedem_meeting: I went through the hypervisor and service changes | |
| 13:42:04 | sdague | there are some follow ups that could be done, but I think they are probably good enough to merge, those are mostly test tweaks | |
| 13:42:33 | openstackgerrit | Chris Dent proposed openstack/nova master: DNM: [placement] demonstrate flapping /allocation_candidates results https://review.openstack.org/485209 | |
| 13:42:39 | sdague | mriedem_meeting: so if you release your -2 they'll merge | |
| 13:43:09 | cdent | gibi: ^^ has the gabbi | |
| 13:43:45 | gibi | cdent: thanks | |
| 13:48:26 | mriedem_meeting | sdague: ok thanks | |
| 13:49:35 | gibi | cdent: your gabbi does what I wanted to do | |
| 13:50:40 | cdent | gibi: I was hoping this fix might be related but it’s not: https://review.openstack.org/#/c/480379/ | |
| 13:52:23 | gibi | cdent: we tried that patch yestarday and didn't help | |
| 13:54:18 | cdent | :) | |
| 14:08:46 | openstackgerrit | Sean Dague proposed openstack/nova master: nova.utils.get_service_url() https://review.openstack.org/458257 | |
| 14:12:54 | efried | sdague ^^ ? | |
| 14:14:13 | efried | sdague A rebase? | |
| 14:16:38 | sdague | efried: yeh, I was just looking at the priority etherpad and it said that needed rebasing | |
| 14:16:43 | sdague | so I did | |
| 14:16:48 | efried | sdague Thanks! | |
| 14:16:59 | sdague | efried: you should check that I did it correctly :) | |
| 14:17:12 | efried | sdague I'm gonna need to rework it as soon as ksa releases anyway. | |
| 14:17:44 | efried | sdague The client consumption won't change, prolly just the get_service_url() method itself. | |
| 14:17:55 | efried | But yeah, it'll get put through the ringer at that time. | |
| 14:18:22 | openstackgerrit | Sean Dague proposed openstack/nova master: Add tags to instance.create Notification https://review.openstack.org/459493 | |
| 14:18:48 | sdague | efried: ok cool | |
| 14:24:51 | openstackgerrit | Zhenyu Zheng proposed openstack/python-novaclient master: Microversion 2.52 - Support tag when boot https://review.openstack.org/484617 | |
| 14:29:07 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add Virtual Ethernet device pair https://review.openstack.org/484726 | |
| 14:31:14 | cdent | gibi: I added a bit more info https://bugs.launchpad.net/nova/+bug/1705231 | |
| 14:31:16 | openstack | Launchpad bug 1705231 in OpenStack Compute (nova) "Placement returns no allocation candidate for request that needs both compute resources and custom shared resources" [High,Triaged] | |
| 14:32:04 | cdent | jaypipes: that ^ probably needs your sql brain | |
| 14:33:19 | gibi | cdent: thanks. I hope jaypipes can figure out the root cause | |
| 14:36:06 | jaypipes | cdent, gibi: thanks. will look at it shortly, | |
| 14:36:20 | cdent | thanks jaypipes | |
| 14:36:34 | gibi | jaypipes: thanks | |
| 14:50:43 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add Virtual Ethernet device pair https://review.openstack.org/484726 | |
| 14:50:44 | openstackgerrit | Ed Leafe proposed openstack/nova master: WIP - Migrate Ironic Flavors https://review.openstack.org/484949 | |
| 14:54:38 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add Virtual Ethernet device pair https://review.openstack.org/484726 | |
| 14:54:59 | edleafe | dansmith: mriedem_meeting: cdent: ^^ Addressed the concerns | |
| 14:57:08 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add Open vSwitch patch port https://review.openstack.org/485228 | |
| 15:02:03 | sdague | sfinucan: confused on https://review.openstack.org/#/c/428241 - because I thought we were going the other direction | |
| 15:03:24 | stephenfin | sdague: Oh, I wasn't aware of that | |
| 15:03:26 | stephenfin | That changes things | |
| 15:03:46 | sdague | see efried's work there | |
| 15:03:54 | stephenfin | will do | |
| 15:12:17 | mriedem | bauzas: ok https://review.openstack.org/#/c/484828/ | |
| 15:12:27 | mriedem | aller! | |
| 15:12:48 | bauzas | mriedem: so, I was thinking about accepting custom drivers if they use the placement API | |
| 15:13:09 | bauzas | mriedem: I mean, if all our drivers are given a list of hosts by the placement API | |
| 15:13:35 | bauzas | mriedem: the problem with the FilterScheduler driver is that it will call filters N times when you have N hosts | |
| 15:14:00 | bauzas | mriedem: so I think some operators would like to just call once a 3rd-party system | |
| 15:14:37 | bauzas | mriedem: if we do that, I think it would not be an interop problem given we'll be sure that any destination would be accepted by placement API | |
| 15:14:40 | openstackgerrit | Feodor Tersin proposed openstack/nova master: libvirt: Straighten resize condition in Image.cache https://review.openstack.org/485236 | |
| 15:15:14 | bauzas | of course, like I said, it means that all the drivers would be calling placement for both getting hosts to verify, and would also claim the allocation too | |
| 15:15:31 | bauzas | thoughts about that? | |
| 15:15:35 | mriedem | bauzas: i'm not sure what that has to do with the bug fix at hand | |
| 15:15:47 | mriedem | which needs to go back to ocata where the custom scheduler driver loading was broken | |
| 15:15:58 | bauzas | mriedem: so, about that | |
| 15:16:01 | bauzas | mriedem: for the bug | |
| 15:16:14 | bauzas | mriedem: just adding the new choice would be okay I think | |
| 15:16:28 | bauzas | mriedem: but not saying it would be deprecated by Queens IMHO | |
| 15:16:32 | sean-k-mooney | bauzas: it would not be transparent on upgrade | |
| 15:16:49 | bauzas | sean-k-mooney: not sure I understand why | |
| 15:17:14 | bauzas | I wouldn't deprecate a choice | |
| 15:17:18 | bauzas | just adding a new one | |
| 15:17:24 | sean-k-mooney | bauzas: there was nothing that requried them to call the custom_driver custom_driver in the setup.cfg entrypoint before | |
| 15:17:30 | bauzas | the problem with upgrades is when you stop to use an opt | |
| 15:17:45 | mriedem | bauzas: adding choices is not ok | |
| 15:17:49 | mriedem | it's not backward compatible | |
| 15:17:55 | mriedem | when upgrading *to* ocata | |
| 15:18:24 | mriedem | we have to drop 'choices', | |
| 15:18:31 | bauzas | mriedem: not only then | |
| 15:18:42 | mriedem | and when loading up the entry point in the scheduler manager, if it's not in our whitelist of 'choices' that we support today, then we log a warning | |
| 15:19:02 | bauzas | mriedem: because if you upgrade from Newton, then you need to modify your nova.conf because the value wouldn't be the same | |
| 15:19:17 | bauzas | mriedem: in Newton, you needed to pass a python path | |
| 15:19:39 | sean-k-mooney | bauzas: you could not use the alis form stevador? | |
| 15:19:43 | bauzas | mriedem: in Ocata, you need to pass just a name for an existing entrypoint | |
| 15:21:17 | sean-k-mooney | bauzas: i guess the point still stands if we keep the choices field we would need a config change on upgrade and a change to the python module that exports the driver to export it as custom_driver | |
| 15:21:29 | mriedem | bauzas: i don't think that's right | |