Posted	Nick	Remark
#openstack-nova - 2017-07-14
21:04:42	melwitt	I based it off stuff I found in sqlalchemy/api.py
21:04:42	mriedem	should that be filter_by?
21:04:58	melwitt	no based on what I copied
21:05:19	mriedem	where is filter_by defined?
21:05:36	melwitt	I was trying to do like this https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L2192
21:07:15	mriedem	you need some leakypipes
21:08:23	melwitt	yeah. I think I'm gonna just log what I'm returning from get_counts() and see what kind of garbage might be in there for that test
21:11:03	melwitt	filter_by is a method on the query, like query.filter_by(...)
21:11:45	mriedem	yup
21:12:07	mriedem	https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L1835 is similar to what you're doing
21:12:53	melwitt	yeah, that's exactly what I was looking at. that's the existing instance quota refresh sync function
21:16:50	openstackgerrit	melanie witt proposed openstack/nova master: Make security_group_rules use check_deltas() for quota https://review.openstack.org/477700
21:16:53	openstackgerrit	melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242
21:16:54	openstackgerrit	melanie witt proposed openstack/nova master: Make key_pairs use check_deltas() for quota https://review.openstack.org/477699
21:16:57	openstackgerrit	melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243
21:16:58	openstackgerrit	melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521
21:17:05	openstackgerrit	melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945
21:17:10	openstackgerrit	melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946
21:17:23	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: WIP: test against the counting quotas change https://review.openstack.org/484048
21:30:13	openstackgerrit	Jan Gutter proposed openstack/os-vif master: Improve OVS Representor Lookup https://review.openstack.org/484051
21:33:52	mriedem	blarg, we added tags to build request for no reason
21:34:08	mriedem	and/or started passing tags to conductor for no reason when we already had them in the build request
21:34:09	mriedem	double blarg
21:52:05	mriedem	superdan: i know you're looking for something to review at 4pm on a friday https://review.openstack.org/#/c/469800/
22:53:48	openstackgerrit	Davanum Srinivas (dims) proposed openstack/nova master: [WIP] Getting rid of crud around castellan options https://review.openstack.org/484036
23:08:01	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/484067
23:48:47	openstackgerrit	Merged openstack/nova master: Default reservations=None in Cells v1 and conductor APIs https://review.openstack.org/483917
#openstack-nova - 2017-07-15
00:01:40	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/484067
01:03:51	mriedem	melwitt: AHA http://logs.openstack.org/21/416521/61/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/1328370/logs/screen-n-api.txt.gz#_Jul_14_22_13_44_084898
01:03:58	mriedem	counts = {'project': {'instances': 2, 'ram': Decimal('128'), 'cores': Decimal('2')}}
01:04:00	mriedem	they aren't ints
01:04:27	mriedem	maybe because it's not going through the models stuff
01:08:45	melwitt	gdi. well, at least it's clear now. gonna look into why that's sometimes the case
01:09:00	melwitt	makes me wonder why the existing query I copied doesn't do that
01:09:10	mriedem	just do this https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L853
01:09:16	mriedem	field: int(results[idx] or 0)
01:09:23	mriedem	^ is from using .sum also
01:09:35	mriedem	my guess is because of something to do with using model queries or not
01:09:39	mriedem	vs straight sqla
01:09:41	mriedem	but idk
01:09:45	melwitt	yeah, I assumed I'd have to use int()
01:09:54	melwitt	ohh.. yeah maybe
01:10:00	mriedem	i was going to push the change assuming you and james were out galavanting
01:10:34	melwitt	heh. not galavanting yet :)
01:13:03	melwitt	I like the way jaypipes did this a lot more. I was working on it late last night/this morning and couldn't think how to enumerate over the fields in a good way
01:22:15	openstackgerrit	melanie witt proposed openstack/nova master: Make security_group_rules use check_deltas() for quota https://review.openstack.org/477700
01:22:18	openstackgerrit	melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242
01:22:19	openstackgerrit	melanie witt proposed openstack/nova master: Make key_pairs use check_deltas() for quota https://review.openstack.org/477699
01:22:22	openstackgerrit	melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243
01:22:23	openstackgerrit	melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521
01:22:30	openstackgerrit	melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945
01:22:35	openstackgerrit	melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946
01:34:19	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.50 - fix quota class sets resource usage https://review.openstack.org/483060
01:34:19	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: Add support for the 2.51 microversion https://review.openstack.org/483149
04:25:16	openstackgerrit	Merged openstack/nova master: Remove 'create_rule_default' https://review.openstack.org/479773
11:42:31	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091
12:01:16	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/484067
12:02:36	openstackgerrit	Davanum Srinivas (dims) proposed openstack/nova master: [WIP] Getting rid of crud around castellan options https://review.openstack.org/484036
14:19:57	openstackgerrit	zhangdaolong proposed openstack/python-novaclient master: Fix the inappropriate parameter name https://review.openstack.org/480826
16:12:21	openstackgerrit	zhangdaolong proposed openstack/python-novaclient master: Add sub command volume-attachment https://review.openstack.org/484147
16:47:54	openstackgerrit	Merged openstack/nova master: Updated from global requirements https://review.openstack.org/484067
16:59:26	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: Add functional test for resize-confirm plus quota validation https://review.openstack.org/483559
16:59:26	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: Add resize down test which also verifies quota changes https://review.openstack.org/484151
16:59:27	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: DNM: run resize tests against counting quotas 15 times each https://review.openstack.org/484152
16:59:48	mriedem	melwitt: bauzas: ^ will run resize up + confirm and resize down + revert 15 times each, single tenant, in serial, against the counting quotas change
16:59:53	mriedem	to sniff out any issues with leaking quotas
17:08:08	openstackgerrit	Chris Dent proposed openstack/nova master: [placement] cover deleting standard trait https://review.openstack.org/484153
17:08:09	openstackgerrit	Chris Dent proposed openstack/nova master: [placement] cover deleting a custom resource class in use https://review.openstack.org/484154
17:22:26	openstackgerrit	Chris Dent proposed openstack/nova master: [placement] cover deleting a custom resource class in use https://review.openstack.org/484154
17:31:29	kbaegis	Hi all. I'm seeing Compute host compute could not be found. in a traceback generated by nova-compute
17:31:36	kbaegis	Does that mean that it can't resolve it?
17:32:02	kbaegis	it then says "Compute_service record created for compute:compute"
17:32:09	kbaegis	But doesn't show up in nova service-list
17:54:29	openstackgerrit	Chris Dent proposed openstack/nova master: [placement] fix 500 error when allocating to bad class https://review.openstack.org/484162
18:09:36	openstackgerrit	zhangdaolong proposed openstack/python-novaclient master: Fix the inappropriate parameter name https://review.openstack.org/480826
18:14:43	openstackgerrit	zhangdaolong proposed openstack/python-novaclient master: Add sub command volume-attachment https://review.openstack.org/484147
19:36:08	openstackgerrit	Matt Riedemann proposed openstack/nova master: Optimize creating servers with tags https://review.openstack.org/484170
19:36:29	mriedem	kbaegis: ocata code?
19:36:47	mriedem	kbaegis: when nova-compute starts up, the ResourceTracker will create the compute_nodes record in the cell database automatically,
19:36:54	mriedem	so it might spew some warnings before that happens
19:37:07	mriedem	like when the libvirt driver is looking for the compute node to enable the service
19:37:23	mriedem	the reason you can't list it using nova service-list is probably because the compute host isn't mapped to a cell,
19:37:36	mriedem	to do that, you run 'nova-manage cell_v2 discover_hosts'
19:38:13	mriedem	kbaegis: we have some docs on this here https://docs.openstack.org/nova/latest/cells.html
19:38:21	mriedem	and in the install guide
19:38:39	mriedem	https://docs.openstack.org/ocata/install-guide-ubuntu/nova-compute-install.html
19:39:04	mriedem	let me know if that fixes your problem and/or if there is anything you think is missing from the docs, like in our FAQs section
20:27:09	mriedem	melwitt: https://review.openstack.org/#/c/484151/ helped me sort something out - when we resize down, we don't reserve any quota since we already have the quota covered for the resize, since we're going down, so usage just won't change until we confirm the resize
20:27:20	mriedem	i need to write a separate test for resize down + confirm
20:46:26	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: Add resize down test which also verifies quota changes https://review.openstack.org/484151
20:46:27	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: DNM: run resize tests against counting quotas 15 times each https://review.openstack.org/484152
20:48:00	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: DNM: run resize tests against counting quotas 15 times each https://review.openstack.org/484152
21:03:31	openstackgerrit	Merged openstack/nova master: Dump tracked version notifications when swap volume tests fail https://review.openstack.org/483939
21:47:18	openstackgerrit	Matt Riedemann proposed openstack/nova master: Optimize creating servers with tags https://review.openstack.org/484170
22:02:04	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: Add resize down test which also verifies quota changes https://review.openstack.org/484151
22:02:04	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: DNM: run resize tests against counting quotas 15 times each https://review.openstack.org/484152
22:10:27	openstackgerrit	Matt Riedemann proposed openstack/nova master: api-ref: mention disk size limitations in resize flavor https://review.openstack.org/484176
23:03:11	clarkb	mriedem: looks like logstash confirms that tooz release was cause of spike in fails there
23:51:14	prometheanfire	mriedem: /win 5
23:51:16	prometheanfire	bah

Earlier   Later