| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-14 | |||
| 15:09:48 | mriedem | gibi: http://logs.openstack.org/39/483939/1/check/gate-nova-tox-functional-ubuntu-xenial/95a614f/console.html#_2017-07-14_14_16_48_905908 | |
| 15:09:59 | mriedem | and http://logs.openstack.org/17/483917/1/check/gate-nova-tox-functional-ubuntu-xenial/f92a89d/console.html#_2017-07-14_13_14_22_687228 | |
| 15:10:10 | mriedem | i hit the first while trying to push a patch to debug the second | |
| 15:10:43 | mriedem | of course i'm also hitting random testtools.matchers._impl.MismatchError: 200 != 401 stupidity | |
| 15:10:47 | mriedem | b/c of the eventlet thing | |
| 15:11:09 | gibi | mriedem: seems you are the lucky winner today | |
| 15:11:16 | mriedem | melwitt: maybe we throw a hack retry loop in the functional api fixture if we get a 401 | |
| 15:13:52 | gibi | mriedem: the host things seems like some kind of race condition. We can hack it away with by ignoring the host param during the sample matching | |
| 15:14:02 | mriedem | but, | |
| 15:14:12 | mriedem | we want to know the host is set in the sample i'd think | |
| 15:14:23 | gibi | mriedem: yeah, this is why it is just a hack | |
| 15:14:29 | mriedem | do we need to use a unique host maybe? or put a lock on the test? | |
| 15:17:32 | gibi | mriedem: honestly, I don't know | |
| 15:18:17 | mriedem | ok well i think i can push one change here | |
| 15:18:29 | mriedem | these metadata api functional tests aren't setting wsgi keepalive=false | |
| 15:19:57 | mriedem | melwitt: do you know if we have a bug for these random 401s in the functional tests? | |
| 15:20:14 | mriedem | maybe https://bugs.launchpad.net/nova/+bug/1696834 | |
| 15:20:16 | openstack | Launchpad bug 1696834 in OpenStack Compute (nova) "Intermittent "KeyError: 'allocations'" in functional tests" [Medium,Confirmed] | |
| 15:20:19 | mriedem | same symptom i think | |
| 15:20:36 | melwitt | I dunno, maybe if sdague linked to one with his change? I don't know of one | |
| 15:20:49 | mriedem | yeah i was going to use that too | |
| 15:20:52 | mriedem | alright working on something | |
| 15:22:07 | gibi | mriedem: I will play a bit with the unshelve host mistmatch but it is already after 5pm in my time so not promising much for today | |
| 15:22:09 | cdent | this may be the same problem that the multicell scheduler functional test that dan’s working on is seeing (requests to the placement service and compute api get intermingled) | |
| 15:22:31 | cdent | “this” == the thing that mriedem is looking at | |
| 15:23:01 | cdent | that functional test: https://review.openstack.org/#/c/452006/ | |
| 15:23:25 | mriedem | yeah | |
| 15:23:31 | mriedem | i hate "this" | |
| 15:23:38 | mriedem | also hate "that" though... | |
| 15:24:48 | cdent | long term if we switch the fixtures to use wsgi-intercept instead of installing an eventlet service, it _might_ help | |
| 15:24:50 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance.create https://review.openstack.org/483969 | |
| 15:25:50 | cdent | but unless the the keepalive = false is being used everywhere, doing just that might fix it | |
| 15:26:22 | mriedem | it's not used everywhere yeah, | |
| 15:26:28 | mriedem | so that's what i'm going to try, throwing that into the ConfFixture | |
| 15:26:33 | cdent | mriedem++ | |
| 15:26:34 | mriedem | which is used for default config in all testes | |
| 15:26:38 | mriedem | *tests | |
| 15:26:39 | mriedem | heh | |
| 15:27:25 | cdent | keepalive = false on testes is a complicated thought | |
| 15:27:40 | cdent | birth control? | |
| 15:27:50 | figleaf | vasectomy | |
| 15:28:10 | mriedem | come on guys, i try to keep a clean channel here | |
| 15:28:28 | figleaf | mriedem: that's the funniest thing you've said all year | |
| 15:34:05 | openstackgerrit | Merged openstack/nova master: Stop counting hw_video:ram_max_mb against quota https://review.openstack.org/483133 | |
| 15:34:14 | superdan | woot | |
| 15:34:45 | melwitt | how'd that make it past the gauntlet | |
| 15:35:08 | superdan | melwitt: the universe wanted that to merge as bad as we did | |
| 15:35:25 | melwitt | heh | |
| 15:43:18 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Set wsgi.keep_alive=False globally for tests https://review.openstack.org/483972 | |
| 15:47:14 | gibi | mriedem: I have a theory about the unshelve host mismatch | |
| 15:47:41 | gibi | mriedem: the test first shelve offload the instance then unshelve it | |
| 15:48:06 | gibi | mriedem: the compute manager sets the state of the instance to SHELVE_OFFLOADED earlier than clearing the host of the instance | |
| 15:48:10 | gibi | mriedem: here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4446-L4457 | |
| 15:48:15 | openstackgerrit | melanie witt proposed openstack/nova master: Make security_group_rules use check_deltas() for quota https://review.openstack.org/477700 | |
| 15:48:17 | openstackgerrit | melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242 | |
| 15:48:18 | openstackgerrit | melanie witt proposed openstack/nova master: Make key_pairs use check_deltas() for quota https://review.openstack.org/477699 | |
| 15:48:21 | openstackgerrit | melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243 | |
| 15:48:22 | openstackgerrit | melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521 | |
| 15:48:28 | openstackgerrit | melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945 | |
| 15:48:33 | openstackgerrit | melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946 | |
| 15:48:54 | gibi | mriedem: the test waits for the instance to change state to SHELVE_OFFLOADED to start the unshelve | |
| 15:49:19 | gibi | mriedem: so in theory we can have unshelve.start sent earlier than the compute manager setting the instance host to null | |
| 15:49:33 | mriedem | gibi: ah yeah i think i fixed something like that when tempest was race failing on shelve tests too | |
| 15:49:35 | mriedem | similar thing | |
| 15:50:00 | mriedem | so need to wait for the shelved_offloaded vm_state and instance.host is none | |
| 15:50:14 | gibi | OK, I will code that up | |
| 15:50:58 | mriedem | gibi: cool, i'll report a bug for it | |
| 15:51:29 | openstackgerrit | Jan Gutter proposed openstack/os-vif master: Add support for VIFPortProfileOVSRepresentor https://review.openstack.org/483921 | |
| 15:52:10 | gibi | mriedem: thanks | |
| 15:52:30 | mriedem | https://bugs.launchpad.net/nova/+bug/1704423 | |
| 15:52:31 | openstack | Launchpad bug 1704423 in OpenStack Compute (nova) "_test_unshelve_server intermittently fails in functional versioned notification tests" [Medium,Triaged] | |
| 15:53:14 | leakypipes | figleaf just quoted Forrester on the OpenStack ML. I think he needs to Unprison his Think Rhino. | |
| 15:54:08 | mriedem | leakypipes: have you entered the 'hosted projects' circus? | |
| 15:55:25 | leakypipes | mriedem: nope. | |
| 16:06:27 | openstackgerrit | Maciej Kucia proposed openstack/nova master: Add JSON schema validation to PCI whitelist https://review.openstack.org/476098 | |
| 16:11:10 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Add functional test for resize-confirm plus quota validation https://review.openstack.org/483559 | |
| 16:18:03 | figleaf | leakypipes: to be fair, Forrester was *in* the quote. It wasn't a Forrester quote | |
| 16:18:50 | leakypipes | figleaf: I know, I was just joking with ya. :) | |
| 16:18:56 | openstackgerrit | Jay Pipes proposed openstack/nova master: claim resources in placement API during schedule() https://review.openstack.org/483566 | |
| 16:18:57 | openstackgerrit | Jay Pipes proposed openstack/nova master: scheduler: isolate _get_sorted_hosts() https://review.openstack.org/483564 | |
| 16:18:57 | openstackgerrit | Jay Pipes proposed openstack/nova master: add dict of allocation requests to select_dests() https://review.openstack.org/483565 | |
| 16:19:07 | figleaf | leakypipes: :) | |
| 16:19:19 | leakypipes | figleaf: fixed your comments in the above patches ^^. | |
| 16:21:09 | figleaf | leakypipes: thx. Will get to them shortly | |
| 16:24:47 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: fix unshelve notification test instability https://review.openstack.org/483986 | |
| 16:25:07 | gibi | mriedem: fix for unshelve test is up ^^ | |
| 16:26:27 | mriedem | thanks | |
| 16:26:55 | gibi | mriedem: I'm leaving now for the weekend. See you on Monday | |
| 17:01:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Deprecate 'keymap' options https://review.openstack.org/483994 | |
| 17:13:17 | rbartra | Hello stephenfin, I have a question regarding https://review.openstack.org/#/c/449288/19/nova/api/openstack/compute/flavor_manage.py ... I am wondering how to retrieve the current policy value from the verify_deprecated_policy method? I am trying with oslo_policy.policy, but I keep getting an empty rules list. I am also unable to import 'from nova import policy' which is how the current rule is retrieved in flavor_manage.py . | |
| 17:17:01 | stephenfin | rbartra: How come you can't import nova.policy? | |
| 17:17:57 | stephenfin | Ah, wait - that'd be a circular import | |
| 17:18:28 | stephenfin | rbartra: You could just move that function to nova/policy.py instead? | |
| 17:18:30 | rbartra | stephenfin: correct, that is is the issue I am seeing | |
| 17:18:49 | rbartra | stephenfin: yes, I am cool with that as well | |
| 17:19:00 | stephenfin | As am I | |
| 17:19:12 | rbartra | stephenfin: Great! Thank you! | |
| 17:19:19 | stephenfin | Thanks for sticking with that, btw. I realize I've made you jump through a few hoops for it :) | |
| 17:19:24 | stephenfin | but it'll be worth it in the end | |
| 17:19:41 | rbartra | stephenfin: I appreciate all the reviews and feedback :) | |