| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-13 | |||
| 13:19:24 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: use already loaded BDM in instance. |
|
| 13:22:22 | sean-k-mooney | stephenfin: cool i have subscribed to the bug so i should get pinged if they respond | |
| 13:24:32 | sean-k-mooney | stephenfin: the only thing i hate about the contrail plugin is that they do not use the setup.cfg to declare there entrypoitns and instead to it all in setup.py https://github.com/Juniper/contrail-nova-vif-driver/blob/master/setup.py | |
| 13:25:02 | stephenfin | sean-k-mooney: That's because they're not using pbr | |
| 13:25:08 | sean-k-mooney | stephenfin: but its a good example of how to do in correctly otherwise | |
| 13:25:37 | stephenfin | pbr had setuptools plugins that allow reading of things like that from 'setup.cfg'. By default though, setuptools doesn't support that | |
| 13:25:41 | stephenfin | *has | |
| 13:25:54 | stephenfin | sean-k-mooney: We could always draft a cookiecutter template if it would help people? | |
| 13:26:06 | sean-k-mooney | stephenfin: oh really . there is one | |
| 13:26:16 | sean-k-mooney | oh you mean for os-vif plugins? | |
| 13:26:40 | sean-k-mooney | stephenfin: the cookicutter template for new openstack project i think has not been updated for pbr yet | |
| 13:26:42 | stephenfin | Yup, a cookiecutter template for plugins | |
| 13:26:45 | sean-k-mooney | stephenfin: unless you did it | |
| 13:26:51 | stephenfin | I think I did | |
| 13:27:22 | sean-k-mooney | oh i have been meaning to aks you how to fix one of our repos to use pbr correctly | |
| 13:28:24 | stephenfin | sean-k-mooney: link? | |
| 13:28:49 | sean-k-mooney | stephenfin: https://github.com/openstack/devstack-plugin-libvirt-qemu | |
| 13:28:52 | gmann_ | mriedem: i replied on https://review.openstack.org/#/c/482994/1 | |
| 13:28:57 | openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Support boot from Cinder volume https://review.openstack.org/215385 | |
| 13:29:06 | sean-k-mooney | stephenfin: hum need to fix the readme too... | |
| 13:29:33 | gmann_ | mriedem: 'events' can be empty fro coding we have on controller side :) but very rare to rare timing things | |
| 13:29:42 | gmann_ | *from | |
| 13:29:57 | sean-k-mooney | stephenfin: we can gret rid of all the mail map stuff correct and there is some other boiler plate stuff that pbr will do for us too i think | |
| 13:29:58 | gmann_ | https://github.com/openstack/nova/blob/d955eb1db753f191acb02eb9758080329da5b866/nova/api/openstack/compute/instance_actions.py#L106 | |
| 13:31:11 | mriedem | gmann_: ok, but an empty events list is different from an event with no 'event.start_time' key | |
| 13:33:41 | stephenfin | sean-k-mooney: What's wrong with that project exactly? Looks a-ok to me? | |
| 13:33:56 | gmann_ | mriedem: is it. 'events' has direct 'start_time' so 'events' will be with no sub key | |
| 13:34:34 | gmann_ | mriedem: i commented the event record on compute service side and then we will have like this - http://paste.openstack.org/show/615266/ | |
| 13:35:01 | sean-k-mooney | stephenfin: it may be fine now. i know orginally after teh cookie cotter template it had the old change log and a few other things but rodolfo may have allready cleaned up everythin | |
| 13:35:40 | mriedem | gmann_: consider it like the os-extended-volumes:volumes_attached field in the server details response | |
| 13:35:58 | mriedem | that can be an empty list, which doesn't mean os-extended-volumes:volumes_attached.id is marked optional in the api ref | |
| 13:36:16 | mriedem | it means os-extended-volumes:volumes_attached will be in the response, but can be an empty list | |
| 13:36:25 | mriedem | And the description reflects that, " The attached volumes, if any." | |
| 13:36:49 | mriedem | now if you have volumes attached, the os-extended-volumes:volumes_attached.id and os-extended-volumes:volumes_attached.delete_on_termination keys will be in there, | |
| 13:36:51 | mriedem | and they are required | |
| 13:37:01 | mriedem | i'm saying it's the same thing for instance action events and the start_time field per event | |
| 13:37:10 | mriedem | *Except* the 'events' list is optional | |
| 13:37:16 | mriedem | which was what i changed in my patch | |
| 13:37:25 | mriedem | https://review.openstack.org/#/c/480792/ | |
| 13:41:27 | gibi | mriedem: hi! I proposed the first patch to use already in scope BDM for the notification payload as you suggested yesterday. Could take a brief look to see if it is a good directions? https://review.openstack.org/#/c/483324/ | |
| 13:42:42 | gmann_ | mriedem: i see your point. and from api-ref yes your point makes more sense to understand the api response. but from tempest response schema those should not be marked required | |
| 13:42:53 | mriedem | gibi: yeah maybe later | |
| 13:43:29 | mriedem | gmann_: but why? if there are events, and there is an event within the list of events, tempest should care that start_time is there | |
| 13:44:26 | mriedem | the keys for the event will be in the response, the values may be null if the event is not done, like finish_time and traceback | |
| 13:44:27 | mriedem | and result | |
| 13:44:38 | mriedem | required == you expect a key in the body dict, right? | |
| 13:44:49 | mriedem | required != that key must map to a non-None value | |
| 13:45:31 | gmann_ | mriedem: i am saying it can eb emtpy list means no start_time inside 'events' key | |
| 13:46:02 | gmann_ | mriedem: if api controller always insert those subkey even as null then i agree but that is not case | |
| 13:46:40 | gmann_ | because we insert 'events' key in response based on policy and insterts its subkey based on event we have in db or not | |
| 13:47:30 | gmann_ | so if later is not there we end up with 'events' with no sub key | |
| 13:48:36 | mriedem | gmann_: is jsonschema going to validate against an entry that isn't in the response? | |
| 13:48:52 | mriedem | we should have 2 schemas, | |
| 13:49:03 | mriedem | 1 for the instanceAction response, which has the 'events' key which is optional and is an array | |
| 13:49:27 | stephenfin | sean-k-mooney, ralonsoh: https://review.openstack.org/483398 | |
| 13:49:29 | mriedem | and 1 for the instanceAction.events, which is an object type, which has fields like start_time, finish_time, traceback, etc - those are required | |
| 13:49:34 | stephenfin | Ye silly gooses :) | |
| 13:50:33 | stephenfin | gmann_: Can you take a second look at my replies here when you have a chance? https://review.openstack.org/#/c/478484/ | |
| 13:51:41 | ralonsoh | stephenfin: thanks! I'll review the patch now | |
| 13:51:55 | gmann_ | mriedem: current schema will check 'events' as optional as it is policy based. as on some cloud it can be present and on other it cannot be | |
| 13:53:02 | gmann_ | mriedem: and my point is to have 'events' array schema also same way which validate start_time etc if those are present in response otherwise skip | |
| 13:53:31 | gmann_ | mriedem: but if we say those as mandatory in api-ref i am ok to validate those strictly by not looking at the code. | |
| 13:53:56 | gmann_ | which i should not when i work from tempest perspective :) | |
| 13:54:47 | gmann_ | stephenfin: sure, ll check tomorrow morning. may be i still argue on those doc in reference but let me rethink on those | |
| 13:55:41 | stephenfin | gmann_: Sounds good to me | |
| 13:59:34 | mriedem | nova meeting in 1 minute | |
| 14:02:27 | sean-k-mooney | stephenfin: hehe thanks for taking a look at openstack/devstack-plugin-libvirt-qemu most of the crft can be removed but we shoudl keep the docs/release note stuff | |
| 14:03:24 | stephenfin | sean-k-mooney: Yeah, you can rework it to add that | |
| 14:03:28 | stephenfin | fine by me :) | |
| 14:05:21 | sean-k-mooney | stephenfin: yep ill be happy too. i didnt actully expect a patch. i was just hopeing for some pointers to make sure we were uptodate with the new ways to handel pbr and the other project config stuff | |
| 14:05:48 | stephenfin | Ah, it's all good. Easy fix | |
| 14:05:54 | openstackgerrit | Hironori Shiina proposed openstack/nova master: Ironic: Get IP address for volume connector https://review.openstack.org/468353 | |
| 14:11:22 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Populate the 'configuration' section https://review.openstack.org/478473 | |
| 14:11:23 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Populate the 'cli' section https://review.openstack.org/478472 | |
| 14:11:23 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Populate the 'user' section https://review.openstack.org/478475 | |
| 14:11:24 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Switch to openstackdocstheme https://review.openstack.org/477751 | |
| 14:11:24 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Populate the 'contributor' section https://review.openstack.org/478474 | |
| 14:11:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Start using oslo_config.sphinxext https://review.openstack.org/482961 | |
| 14:11:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Rework README to reflect new doc URLs https://review.openstack.org/480074 | |
| 14:11:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Start using oslo_policy.sphinxext https://review.openstack.org/479358 | |
| 14:11:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: policies: Fix Sphinx issues https://review.openstack.org/480516 | |
| 14:11:27 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Populate the 'reference' section https://review.openstack.org/478484 | |
| 14:11:27 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Rework index page per new sections https://review.openstack.org/478485 | |
| 14:11:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Remove dead files https://review.openstack.org/478470 | |
| 14:19:30 | jangutter | sean-k-mooney: so how would I write an external plugin _without_ creating a new VIF type? | |
| 14:31:13 | bauzas | jaypipes: I saw your rant yesterday about the scheduler, could you please clarify your concerns ? | |
| 14:31:36 | bauzas | jaypipes: the fact that we're amending the ReqSpec by adding the found host ? | |
| 14:31:55 | jaypipes | bauzas: hmm? no, nothing to do with amending reqspec | |
| 14:32:04 | bauzas | it's just because of the affinity filter, but not sure I understand your problem honestly | |
| 14:32:21 | bauzas | jaypipes: you were telling dan you had a problem with that yesterday night :) | |
| 14:32:44 | jaypipes | bauzas: oh, yeah, sorry, that was a different rant :) | |
| 14:33:04 | bauzas | anway, if I can help you... | |
| 14:33:17 | bauzas | at least by sharing thoughts | |
| 14:33:19 | jaypipes | bauzas: my general annoyance with the scheduler is its tight coupling of state with decision-making. | |
| 14:34:00 | jaypipes | bauzas: And I'd much prefer to deal with things like num_instances > 0 outside of the filter scheduler. | |
| 14:34:46 | bauzas | jaypipes: the real problem is that since we really only supported FilterScheduler (ChanceScheduler being only for tests or crazy operators), we really didn't had a clear interface | |
| 14:35:09 | bauzas | so we built a pile of dependencies between the driver, the host manager and the filters | |
| 14:35:29 | jaypipes | bauzas: that and the unit tests are a pile of spaghetti that test way too much surface area and therefore if you change any little thing, a million tests crash and burn. | |
| 14:35:47 | bauzas | the code itself isn't very large, that's just the fact that we're poorly defining our internal interfaces | |
| 14:35:56 | jaypipes | that, and there's no reason for the WeighedHost class to begin with. | |