Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-07-13
00:01:35 mriedem i'm going to go berate my family for awhile
00:02:15 melwitt heh
00:06:27 mriedem alex_xu: when you're around, i've got the novaclient change up for the 2.50 microversion but a todo question in there about how we want to handle the python api if at all https://review.openstack.org/#/c/483060/3/novaclient/v2/quota_classes.py
00:06:43 mriedem otherwise the functional tests i added for the cli are all passing, so i'd just need to remove the WIP from the commit message
00:48:32 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955
00:49:00 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
00:49:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
00:50:08 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926
00:54:06 openstackgerrit Merged openstack/nova master: Trivial: Remove unnecessary format specifier https://review.openstack.org/481574
00:58:45 openstackgerrit Merged openstack/nova master: api-ref: Fix parameters in server-security-groups https://review.openstack.org/476434
00:59:19 openstackgerrit Merged openstack/nova master: api-ref: Add X-Openstack-Request-Id description https://review.openstack.org/474847
01:11:07 openstackgerrit Merged openstack/nova master: Remove nova.api.extensions.server.extensions usage https://review.openstack.org/481494
01:11:46 openstackgerrit Merged openstack/nova master: Stop using deprecated 'message' attribute in Exception https://review.openstack.org/482014
01:12:21 openstackgerrit Merged openstack/nova master: Fix a missing classifier https://review.openstack.org/478733
01:12:56 openstackgerrit Merged openstack/nova master: Query deleted instance records during _destroy_evacuated_instances https://review.openstack.org/467774
01:13:32 openstackgerrit Merged openstack/nova master: Fix parameters and description for os-volume_attachments https://review.openstack.org/480832
01:14:07 openstackgerrit Merged openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322
01:14:44 openstackgerrit Merged openstack/nova master: Use PCIAddressField in oslo.versionedobjects https://review.openstack.org/466201
01:22:46 openstackgerrit Merged openstack/os-vif master: fix read the representor phys_port_name https://review.openstack.org/480213
01:31:12 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Add support for the 2.51 microversion https://review.openstack.org/483149
01:46:16 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800
01:54:59 mriedem melwitt: i hope the outdoors was enjoyable. i've finished all of the non-test parts of https://review.openstack.org/#/c/416521/ now - found another thing in the compute manager
01:55:03 mriedem easy thing
01:55:53 mriedem i also found 2 more places in the compute manager code that was cleaning up deleted instances but wasn't accounting for that video ram thing with adjust ram quota :)
02:10:54 alex_xu mriedem: I guess your concern about strict parameters is that it may break the backward-compatible?
02:11:17 openstackgerrit Debo Zhang proposed openstack/nova master: Fix typo. https://review.openstack.org/483159
02:11:56 alex_xu it sounds ok we strict parameters in the new microversion. So when the developer upgrade their client code to new microversion, they should check whether there is any interface change in the sdk interface
02:13:27 alex_xu mriedem: and we have parameter change in the some microversion https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L76
02:13:45 mriedem alex_xu: yeah we'd leave **kwargs for microversion 2.0 to 2.49 and then have strict kwargs for 2.51
02:13:48 mriedem *2.50
02:13:55 alex_xu gmann: fyi, mriedem already have a patch for the 2.50 in python-novaclient
02:14:09 mriedem i also identified some issues in the 2.50 api change
02:14:13 mriedem mostly docs
02:14:25 mriedem https://review.openstack.org/#/c/467999/
02:15:29 alex_xu mriedem: thanks, I can fix that
02:22:04 gmann alex_xu, mriedem thanks for client patch
02:22:26 gmann alex_xu, you are fixing api comments? or should i
02:22:55 mriedem my eyes are going to dry up and fall out so i'm going to be afk
02:23:38 alex_xu gmann: I can handle that
02:23:46 gmann alex_xu, thanks
02:32:41 openstackgerrit Debo Zhang proposed openstack/nova master: Fix typo. https://review.openstack.org/483162
03:10:28 openstackgerrit Debo Zhang proposed openstack/nova master: Fix typo https://review.openstack.org/483159
03:21:38 openstackgerrit Debo Zhang proposed openstack/nova master: Fix typo https://review.openstack.org/483162
03:34:00 openstackgerrit Alex Xu proposed openstack/nova master: Fix the releasenote and api-ref for quota-class API https://review.openstack.org/483170
03:34:11 alex_xu gmann: mriedem ^
03:54:34 openstackgerrit Debo Zhang proposed openstack/nova master: Fix typo https://review.openstack.org/483159
04:09:34 openstackgerrit Merged openstack/nova master: improve notification short-circuit https://review.openstack.org/482497
06:00:23 openstackgerrit jichenjc proposed openstack/nova master: add description for supports_migrate_to_same_host https://review.openstack.org/481483
07:05:26 openstackgerrit Alex Xu proposed openstack/nova master: Fix the releasenote and api-ref for quota-class API https://review.openstack.org/483170
07:19:58 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(4/4) https://review.openstack.org/469800
07:48:50 openstackgerrit Alex Szarka proposed openstack/nova master: Raise a real Exception instead of direct Exception call https://review.openstack.org/482200
08:07:49 jangutter sean-k-mooney: would you have an example handy on that alternate way to set the bridge name in a VIF? (something about trunk ports, I think...)
08:30:29 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257
08:40:29 openstackgerrit LiChunlin proposed openstack/nova master: update the description of hypervisor statistics response https://review.openstack.org/462355
08:49:42 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request https://review.openstack.org/451777
08:50:52 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Add memoize function using oslo.cache https://review.openstack.org/472773
09:05:09 openstackgerrit Merged openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779
09:30:26 openstackgerrit ChangBo Guo(gcb) proposed openstack/nova master: rbd: Remove unnecessary 'encode' calls https://review.openstack.org/412356
09:32:00 bauzas stephenfin: hola
09:32:09 stephenfin bauzas: Morning
09:32:30 bauzas stephenfin: could you please remember me if we need to add a _LW() for any warning log ?
09:32:35 bauzas I think so
09:32:42 bauzas only debug logs are not needed
09:33:01 openstackgerrit yuanyue proposed openstack/nova master: Remove ports on create_port timeout during instance build https://review.openstack.org/483280
09:33:17 stephenfin bauzas: No, IIRC we don't need any _L* translations. We only translate exceptions now
09:33:29 bauzas okay
09:33:34 stephenfin ...which use the '_' symbol
09:33:49 bauzas yeah that I know
09:34:06 bauzas I thought we said to only translate logs having no debug level
09:34:26 bauzas but I didn't remember we said to stop translating any level log
09:35:01 stephenfin Hmm, lemme go check
09:35:53 stephenfin gcb: Can you say, do we still need to translate LOG.warning logs?
09:36:49 stephenfin bauzas: https://docs.openstack.org/nova/latest/i18n.html
09:36:57 stephenfin Log messages should not be translated. Any use of _LI(), _LW(), _LE(), _LC() are vestigial and will be removed over time.
09:37:11 stephenfin gcb: It's good - we figured it out :)
09:37:26 bauzas stephenfin: cool thanks
09:37:30 gcb stephenfin: yes, look at https://docs.openstack.org/oslo.i18n/latest/user/usage.html
09:37:42 openstackgerrit Alex Szarka proposed openstack/nova master: Add method for verify multiple versioned notifications https://review.openstack.org/465526
09:37:54 gcb Starting with the Pike series, OpenStack no longer supports log translation. It is not necessary to add translation instructions to new code, and the instructions can be removed from old code. Refer to the email thread understanding log domain change on the openstack-dev mailing list for more details.
09:38:07 gcb stephenfin^^
09:38:23 stephenfin gcb: Excellent. Thank you :)
09:40:39 cdent stephenfin: I'm not wise in the ways of policy, does this change (or the linked bug) make sense: https://review.openstack.org/#/c/481443/
09:42:04 stephenfin cdent: I was purposefully leaving that until if/when johnthetubaguy was back. Apparently we were removing all default rules, so I'd imagine that will have some bearing on that
09:43:03 cdent stephenfin: ah okay, so the burden of setting the default is on the deployment?
09:44:02 stephenfin cdent: Wait, no - that was _discoverable_ policies (because they no longer make sense)
09:44:40 stephenfin Looks like claudiub added a load of those default rules. Maybe he can review https://review.openstack.org/#/c/481443/ and see if it makes sense?
09:56:36 openstackgerrit Rikimaru Honjo proposed openstack/nova master: compute: Do not create bdms before successfully reserving a volume https://review.openstack.org/290793
10:07:07 openstackgerrit Stephen Finucane proposed openstack/nova master: Always set MTU when plugging devices https://review.openstack.org/408781
10:12:10 pallavi_ Hi , I have done ubuntu manual installation for ocata release. I have launched instance. But accessing to the instance is not happening.?? Can anyone please help me out to figure it out
10:17:00 claudiub stephenfin: replied. that patch LGTM.
10:18:30 stephenfin claudiub: Thanks :) If you're happy, so am I
10:23:27 claudiub stephenfin: if you're happy and you know it, clap your hands! *clap* *clap*. :D
10:23:49 cdent thanks claudiub
10:28:11 gibi bauzas: hi! There is a small test and doc only patch that needs a second +2. Could you check it please? https://review.openstack.org/#/c/480469/
10:28:22 bauzas gibi: roger this.
10:28:43 gibi bauzas: thanks!
10:35:51 sean-k-mooney jangutter: hi the bridge name is currently set here https://github.com/openstack/neutron/blob/8326a65a5e3c70c66a5297c618d0202c9395cc3f/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#L94-L105
10:37:03 sean-k-mooney jangutter: so in you mech driver if you just overrided that fuction you can pass the bridge name via the vif binding details.
10:38:40 sean-k-mooney jangutter: this then get populated into the os-vif network object here https://github.com/openstack/nova/blob/d955eb1db753f191acb02eb9758080329da5b866/nova/network/os_vif_util.py#L225-L226
10:40:17 sean-k-mooney jangutter: and its used in os-vif here: https://github.com/openstack/os-vif/blob/4a8e07f6c502e5e3b99db9ba543a501fbb138596/vif_plug_ovs/ovs.py#L97 and anywayer else we need the bridge name

Earlier   Later