| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-12 | |||
| 13:29:16 | stephenfin | bauzas: Could I ask you to look at the doc-migration series starting with https://review.openstack.org/#/c/478468/ too? | |
| 13:29:26 | bauzas | stephenfin: roger this. | |
| 13:29:34 | stephenfin | Shouldn't take long, and it's easy re-arrange stuff later if we don't like the end result | |
| 13:29:42 | stephenfin | bauzas: Ta :) | |
| 13:30:03 | ralonsoh | jaypipes: thanks! Also I added functional tests. YOu only need to have a live OVS running in the system to execute them | |
| 13:30:37 | jaypipes | ralonsoh: I saw those. ++ | |
| 13:36:26 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Always set MTU when plugging devices https://review.openstack.org/408781 | |
| 13:41:02 | gibi | stephenfin: thanks for the rebase | |
| 13:46:03 | openstackgerrit | Chason Chan proposed openstack/python-novaclient master: switch to openstackdocstheme https://review.openstack.org/477757 | |
| 13:48:20 | mriedem | o/ | |
| 13:49:35 | jaypipes | cdent: thx for your comments on https://review.openstack.org/#/c/482383/1. Answered. Please have a gander at the latest revision. | |
| 13:51:35 | gibi | mriedem: good morning! I fixed the last outstanding issue with the BDM in notification patch https://review.openstack.org/#/c/448779/ | |
| 13:51:46 | mriedem | jaypipes: should i just remove this sentence? https://review.openstack.org/#/c/454322/35/nova/api/openstack/compute/rest_api_version_history.rst@598 | |
| 13:51:54 | mriedem | jaypipes: i think that would probably clear up the confusion in that paragraph | |
| 13:52:00 | jaypipes | mriedem: yeah | |
| 13:52:11 | jaypipes | mriedem: I'd appreciate that. sorry for not yet responding to you. | |
| 13:53:02 | mriedem | gibi: cool | |
| 13:53:06 | mriedem | jaypipes: np | |
| 13:53:14 | mriedem | gibi: i'll go through that today | |
| 13:54:31 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/477091 | |
| 13:55:40 | gibi | mriedem: thanks! | |
| 14:13:27 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: doc: Switch from oslosphinx to openstackdocstheme https://review.openstack.org/477757 | |
| 14:13:27 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: doc: Create directory structure for docs migration https://review.openstack.org/480135 | |
| 14:13:28 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Remove custom autodoc implementation https://review.openstack.org/480262 | |
| 14:16:50 | mriedem | alex_xu: i understand your comments on the os-services change now; fwiw i care less about the wasted db call - this api won't be used often and i'd rather keep the complexity in here to a minimum | |
| 14:17:01 | mriedem | but i can investigate it, and add validation for the other error cases you pointed out, | |
| 14:17:11 | mriedem | like passing status=enabled and disabled_reason | |
| 14:39:17 | mriedem | gibi: if you'll be around for 5 minutes i'll have something for you | |
| 14:40:11 | mriedem | gibi: https://review.openstack.org/#/c/448779/ | |
| 14:40:28 | mriedem | questions in there about why we aren't using the existing in scope BDMs when building the payload, like during instance.create | |
| 14:40:50 | mriedem | seems that could be optimized to use the bdms we already have when we notify, rather than always look them up from the db - but maybe that's a later optimization | |
| 14:42:37 | gibi | mriedem: looking... | |
| 14:44:56 | gibi | mriedem: I think we can do some optimization on the loading of BDM. But I feel that it would be better to do that separately | |
| 14:45:31 | mriedem | heh, of course you would :) | |
| 14:45:34 | mriedem | also https://review.openstack.org/#/c/448779/38/nova/tests/fixtures.py | |
| 14:45:49 | mriedem | gibi: it's not even 5pm yet! :) | |
| 14:45:58 | stephenfin | sean-k-mooney, moshele, jaypipes: What on earth is IVS, in the context of network interfaces? | |
| 14:46:05 | gibi | mriedem: true :) | |
| 14:46:17 | jaypipes | stephenfin: it's Indigo (plumbgrid) stuff | |
| 14:46:28 | jaypipes | plumgrid | |
| 14:46:29 | mriedem | gibi: fwiw i'm ok with deferring the optimization part since loading bdms is disabled by default | |
| 14:46:38 | mriedem | but i wanted to make sure we discussed it first | |
| 14:47:03 | jaypipes | stephenfin: NIH OVS for NFV? :) | |
| 14:47:13 | gibi | mriedem: let's see if I can make the optimization this week then we can squash the two patches but if I run out of time then it would be nice to merge at least what we have already | |
| 14:47:19 | stephenfin | jaypipes: So not an "initialization vector"? :) It's rather un-Googleable | |
| 14:47:56 | mriedem | gibi: how about you put a TODO in the code in the InstanceAction init where it calls BlockDevicePayload.from_instance to investigate optimizing that by passing in any existing in-scope BDMs, rather than pull from the db | |
| 14:47:56 | jaypipes | stephenfin: no. I mean, there's the ivshmem thing but that's DPDK-related. | |
| 14:48:01 | mriedem | gibi: i'll +2 with the todo | |
| 14:48:06 | mriedem | check out my question in the cinder fixture also | |
| 14:48:10 | jaypipes | stephenfin: depends on the context I guess. | |
| 14:48:10 | gibi | mriedem: sure, I can do that til 5 pm :) | |
| 14:48:15 | mriedem | \o/ | |
| 14:48:42 | stephenfin | jaypipes: Cool cool. TA | |
| 14:48:45 | stephenfin | *Ta | |
| 14:50:21 | jaypipes | mriedem, dansmith, edleafe, bauzas: so do you think we should be returning alternate *destination hosts* or do you think we should be returning alternate *allocation requests*? I'm questioning my thoughts here. :( | |
| 14:50:45 | dansmith | jaypipes: I thought the whole point was to store alternate allocation requests | |
| 14:51:05 | dansmith | jaypipes: otherwise cell conductor has to formulate such a thing, without the details the scheduler has, and I don't think that's going to work | |
| 14:51:15 | dansmith | s/store/return/ | |
| 14:51:37 | dansmith | so conductor can almost blindly throw the allocation request at placement, and if it sticks, send it along | |
| 14:51:49 | cdent | I agree with dansmith. I seem to recall that's why we ended up down the allocation_candidates path in the first place? | |
| 14:51:57 | dansmith | one of yeah | |
| 14:52:03 | jaypipes | dansmith: yeah, that was my initial thought. I guess I've gotten bent out of shape on this latest patch series. :( | |
| 14:52:12 | jaypipes | I think I need a braincation. | |
| 14:53:14 | cdent | dansmith: since you're here, I was reading some cells docs and code: Is the main reason that discover_hosts doesn't do map_instances so that you can have granularity of timing and volume of change? Are there other reasons? | |
| 14:53:56 | dansmith | cdent: we only needed map_instances to bridge between like mitaka and newton | |
| 14:54:08 | dansmith | cdent: now instance maps are created when we create instances | |
| 14:54:47 | dansmith | cdent: and we would need it if we were grafting a cell from one deployment onto another or something like that, so I don't know that we should remove it necessarily | |
| 14:54:53 | cdent | ah, right, I see. thanks. | |
| 14:55:03 | cdent | yeah, keeping it around seems a handy thing | |
| 14:56:16 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779 | |
| 14:58:19 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix api-ref for instance action events's attribute as optional https://review.openstack.org/482994 | |
| 14:58:45 | moshele | jaypipes: hi can you send an invite to my gmaiil moshe010@gmail.com ? | |
| 14:58:58 | ralonsoh | jaypipes: and rodolfo.ah@gmail.com | |
| 14:59:28 | bauzas | jaypipes: allocation requests looks good to me | |
| 14:59:45 | bauzas | jaypipes: but I just think we need to make sure those allocation requests would be for RPs in the same cell, nope ? | |
| 14:59:46 | jaypipes | moshele, ralonsoh: done | |
| 15:00:03 | dansmith | bauzas: yes, and he noted that | |
| 15:00:25 | jaypipes | bauzas: yes, I agree with that. but I need to rework these patches. I got off track returning alternate host states instead of a dict of allocation requests. | |
| 15:00:34 | bauzas | jaypipes: btw. I just left a question in https://review.openstack.org/#/c/482382/3 | |
| 15:00:52 | bauzas | jaypipes: about why we would not use the current existing method | |
| 15:01:11 | jangutter | jaypipes: If my work hangouts doesn't work, please yell. I can also do personal. | |
| 15:01:16 | bauzas | jaypipes: dansmith: btw. sorry about me not reviewing the patches previously, I was (again) in PTO | |
| 15:01:36 | dansmith | bauzas: I just assume you're on PTO unless you say otherwise | |
| 15:01:54 | bauzas | .... and Friday is an holiday day :( | |
| 15:02:02 | bauzas | so terrible | |
| 15:02:18 | bauzas | I should be done with all my PTOs for last year FWIW | |
| 15:02:58 | bauzas | I sincerely apologize for that | |
| 15:05:02 | gibi | mriedem: added the TODO and fixed / answered the fixture comments in https://review.openstack.org/#/c/448779 | |
| 15:06:36 | ftersin | mdbooth: hi, thank you for reviewing. If you have the opportunity, pls, look at my comments there, i just asked some details for the reworking | |
| 15:07:35 | mriedem | gibi: is the indent intentional here? https://review.openstack.org/#/c/448779/39/nova/tests/fixtures.py@1270 | |
| 15:08:03 | gibi | mriedem: yes, I tried to explain the reason of that in my response to your comment | |
| 15:08:57 | gibi | mriedem: either need the explicity detach in the test or I break the swap volume tests. | |
| 15:09:14 | mriedem | ok just checking | |
| 15:09:43 | gibi | mriedem: will propose a clean up on this fixture at some point | |
| 15:10:41 | mriedem | ok, +2 | |
| 15:10:48 | mriedem | i left a comment for other reviewers too | |
| 15:10:56 | gibi | mriedem: thanks | |
| 15:10:56 | mriedem | a todo or note in there would also be good, | |
| 15:10:59 | mriedem | but only if you respin | |
| 15:11:18 | gibi | mriedem: OK | |