| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-07-07 | |||
| 17:06:08 | openstackgerrit | John Griffith proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285 | |
| 17:06:15 | mriedem | http://logs.openstack.org/56/477556/3/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/ee3e9b6/logs/subnode-2/screen-n-cpu.txt.gz#_Jul_05_20_44_19_705646 | |
| 17:06:41 | mriedem | the subnode n-cpu is doing the server group affinity check, which blows up b/c the cell conductor doesn't have an api db connection, | |
| 17:06:52 | mriedem | the nova-cpu.conf on the subnode is missing the config option to disable that upcall | |
| 17:10:38 | vdrok | mriedem: cool, thanks! Do we need to set it in ironic plugin or it's going to be handled on Nova side? | |
| 17:10:50 | mriedem | not sure, it needs to be handled in https://review.openstack.org/#/c/477556/4/lib/nova though | |
| 17:11:18 | mriedem | i think this is where the nova-cpu.conf is used https://review.openstack.org/#/c/477556/4/lib/nova@818 | |
| 17:13:33 | vdrok | mriedem: aha, ok. | |
| 17:15:05 | mriedem | i don't know what nova.conf it's copying though, or where that is configured | |
| 17:17:30 | mriedem | ah i think i know where to set it | |
| 17:17:36 | mriedem | if dan is ok with me touching his change | |
| 17:19:22 | mriedem | superdan: i think i know how to fix the subnode nova.conf thing for the upcall in https://review.openstack.org/#/c/477556/ - ok with me doing that? | |
| 17:20:58 | superdan | mriedem: not sure what you mean "fix the upcall" | |
| 17:21:11 | mriedem | the subnode n-cpu conf isn't configured to disable the server group upcall | |
| 17:21:17 | mriedem | i know where to fix it in the fleetify change | |
| 17:21:21 | mriedem | asking permission | |
| 17:21:23 | superdan | it's not? | |
| 17:21:26 | mriedem | f no | |
| 17:21:44 | superdan | ohh, subnode | |
| 17:21:45 | superdan | gotcha | |
| 17:21:47 | superdan | yes please | |
| 17:21:57 | mriedem | aye aye | |
| 17:22:20 | mriedem | is it weird when i can see the mail man out of the corner of my eye and look at him and he nods at me cross my yard to drop something off? | |
| 17:22:27 | mriedem | should we have such a familiar relationship at this point? | |
| 17:23:41 | mriedem | ok it's up https://review.openstack.org/#/c/477556/4..5/lib/nova | |
| 17:23:43 | mriedem | and now it's taco time | |
| 17:24:31 | smcginnis | mriedem: But it's not Tuesday. | |
| 17:28:17 | openstackgerrit | Mathieu Gagné proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322 | |
| 17:34:34 | melwitt | unless I'm missing something, we have some bugs in nova/conductor/manager.py where RequestSpec objects are being passed to _set_vm_state_and_notify() that doesn't handle them | |
| 17:39:32 | melwitt | nevermind, I think I see where it's being converted to a dict before calling the notify | |
| 17:43:08 | mriedem | melwitt: i need you to solve the riddle of why shelved offloaded volume attach wasn't failing in the multi-cell setup | |
| 17:43:17 | mriedem | only you are capable of cracking that nut | |
| 17:44:54 | melwitt | now that you've said that, you'll probably figure it out within a few minutes :) | |
| 17:45:47 | mriedem | no i gave up | |
| 17:46:12 | melwitt | dangit | |
| 17:52:08 | melwitt | I keep reading _BaseTaskTestCase as BasketCase | |
| 17:52:54 | figleaf | do you have the time to listen to me whine? | |
| 18:01:00 | melwitt | it was for the channel. important stuff | |
| 18:01:23 | figleaf | for all the basket cases in the channel | |
| 18:02:01 | figleaf | superdan: https://www.youtube.com/watch?v=NUTGr5t3MoY | |
| 18:02:23 | superdan | ah, dang, I didn't make the connection | |
| 18:23:43 | mriedem | leakypipes: is this complete now? https://blueprints.launchpad.net/nova/+spec/shared-resources-pike | |
| 18:24:01 | mriedem | there are no open changes, and the allocation request candidate stuff handles RPs associated via aggregate | |
| 18:24:55 | leakypipes | mriedem: yeah. #4 on that list is the only one not done, and the allocation candidates will handle that (not in the scheduler reporting client, but rather int he scheduler during claims) | |
| 18:25:25 | mriedem | leakypipes: ok cool i'm going to close it out then | |
| 18:25:26 | mriedem | thanks | |
| 18:25:29 | leakypipes | kk | |
| 18:26:43 | mriedem | fried_rice: same with https://blueprints.launchpad.net/nova/+spec/powervm-nova-compute-driver - i think i'm going to close that out | |
| 18:26:52 | mriedem | i don't see anything critical in there that we need to get in for pike | |
| 18:27:27 | fried_rice | mriedem Critical, no. Some nice-to-haves. But closing the bp shouldn't preclude further changes in pike, right? | |
| 18:29:25 | mriedem | closing it means i'm not going to look at anything proposed for it | |
| 18:29:26 | mriedem | in pike | |
| 18:29:37 | mriedem | because i need to narrow my focus on what still needs to get done | |
| 18:31:47 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates https://review.openstack.org/476631 | |
| 18:31:48 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: claim resources in scheduler https://review.openstack.org/476632 | |
| 18:32:06 | leakypipes | mriedem, superdan: ^^ | |
| 18:32:43 | leakypipes | definitely should add some functional testing for that. | |
| 18:32:56 | leakypipes | but it's good enough to get reviews on IMO. | |
| 18:34:04 | superdan | did you just kick that out of the gate with that push? | |
| 18:34:09 | superdan | yup | |
| 18:35:42 | mriedem | git review -R | |
| 18:35:44 | mriedem | ftw | |
| 18:35:50 | superdan | yeah | |
| 18:36:34 | leakypipes | mriedem, superdan: yeah, sorry about that :( | |
| 18:37:25 | leakypipes | figleaf had a worry about the previous patch, so perhaps you could see his review on the previous revision of https://review.openstack.org/476632 | |
| 18:39:21 | clarkb | fwiw git review -R shouldn't really be necessary anymore. You should only get a rebase from git review if it hits a merge conflict | |
| 18:39:27 | clarkb | in which case you hvae to push a rebase at some point | |
| 18:42:31 | superdan | clarkb: gerrit identified the bottom as a rebase only. | |
| 18:42:51 | superdan | so I don't think that is accurate for this case | |
| 18:43:12 | leakypipes | superdan: I rebased to master explicitly (by mistake) | |
| 18:43:19 | figleaf | leakypipes: did that comment make any sense? | |
| 18:43:21 | superdan | leakypipes: right I know | |
| 18:43:43 | leakypipes | figleaf: well, I tried to answer as best I could. did you see my response? | |
| 18:43:53 | figleaf | just looking... | |
| 18:44:12 | leakypipes | guys, I need to run out for a couple hours... I will be back later on. sorry! | |
| 18:44:24 | figleaf | leakypipes: np - I have to run out now too | |
| 18:44:45 | figleaf | leakypipes: but I'm still confused as to how this is going to work w/o returning alloc candidates | |
| 19:01:11 | mriedem | superdan: booya fleetify is passing the multinode job http://logs.openstack.org/56/477556/5/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/aed9486/ | |
| 19:01:51 | superdan | schwing | |
| 19:02:01 | mriedem | and the migration not found errors are gone | |
| 19:02:32 | mriedem | subnode nova-cpu.conf also has the disable flag http://logs.openstack.org/56/477556/5/check/gate-tempest-dsvm-neutron-multinode-full-ubuntu-xenial-nv/aed9486/logs/subnode-2/etc/nova/nova-cpu.conf.txt.gz | |
| 19:11:39 | mriedem | jgriffith: clarified what i meant in https://review.openstack.org/#/c/330285/88/nova/compute/api.py@3901 | |
| 19:12:24 | openstackgerrit | Sumedh Degaonkar proposed openstack/nova master: Adds 'sata' as a valid disk bus for qemu and kvm hypervisors https://review.openstack.org/459794 | |
| 19:12:43 | jgriffith | mriedem thanks, once they get network back up in the lab I'll go back through and fix the unit tests and pep8 I appear to have broken | |
| 19:12:56 | jgriffith | also will see if I can figure out what broke after the rebase | |
| 19:13:43 | jgriffith | mriedem oh... looks like you didn't see the update | |
| 19:13:56 | jgriffith | mriedem https://review.openstack.org/#/c/330285/89/nova/compute/api.py@3901 | |
| 19:14:03 | mriedem | ha | |
| 19:14:13 | jgriffith | :) | |
| 19:14:19 | mriedem | volume_id doesn't exist | |
| 19:14:24 | mriedem | volume['id'] is what you need | |
| 19:14:39 | jgriffith | awww crap!!! | |
| 19:14:45 | mriedem | otherwise looks good | |
| 19:14:48 | openstackgerrit | Sumedh Degaonkar proposed openstack/nova master: Adds 'sata' as a valid disk bus for qemu and kvm hypervisors https://review.openstack.org/459794 | |
| 19:14:56 | mriedem | let me pad some stats here | |
| 19:15:01 | jgriffith | mriedem thanks, knew I was screwed when I couldn't test | |
| 19:16:50 | mriedem | figleaf: we have some other changes to do in https://blueprints.launchpad.net/nova/+spec/custom-resource-classes-in-flavors right? there is some data migration thing that is supposed to happen on startup of the nova-compute service with ironic, so it can retrofit older flavors | |
| 19:18:59 | mriedem | ah yeah this https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/custom-resource-classes-in-flavors.html#data-model-impact | |
| 19:19:43 | mriedem | superdan: in ^ should that say "will not be schedulable" ? | |
| 19:20:48 | superdan | mriedem: I think it's saying that until you account for the new resource types, | |