Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-07-05
15:35:41 sean-k-mooney sfinucan: mriedem what does the hydrate fuction do? https://github.com/openstack/nova/blob/bdd6876b8feca2532fa5d9e2e98028b4d19ba6b6/nova/network/model.py#L492-L496 i didnt know object could be thristy
15:36:00 mriedem sean-k-mooney: deserializes the json blob
15:36:14 mriedem *serialized json string i mean
15:36:36 mriedem that thing gets stored in the instance_info_cache.network_info column as a serialized json string
15:36:39 sean-k-mooney mriedem: ok and its not called load or deserialize because?
15:36:48 mriedem because hydrate is cooler?
15:36:53 mriedem idk
15:37:08 mriedem we should call it explode()
15:37:13 mriedem and implode()
15:37:24 sean-k-mooney ok well some new i learned today.
15:45:14 mriedem gibi: comments inline
15:47:39 gibi mriedem: thanks, looking
15:48:11 mriedem no sdague this week?
15:48:26 mriedem clarkb: can you peek at the assertions about compute endpoint format being made in here? https://review.openstack.org/#/c/479818/
15:48:30 mriedem https://review.openstack.org/#/c/479818/6/novaclient/v2/versions.py
15:48:37 ericyoung we have a patch for nova, to use ScaleIO for ephemeral storage. It's passed CI and mdbooth had offered to review it for us.
15:48:59 ericyoung We haven't been able to get ahold of him, can someone else take a look for us at https://review.openstack.org/#/c/407440/
15:49:37 mriedem ericyoung: just fyi, there are 35 blueprints that need review yet for pike https://blueprints.launchpad.net/nova/pike
15:50:21 clarkb mriedem: you can do unversioned if the endpoint supports version discovery which nova does do?
15:50:23 clarkb mordred: ^
15:50:57 mriedem looking at https://developer.openstack.org/api-ref/compute/#api-versions it's not totally clear to me
15:51:41 clarkb mriedem: / list all major versions <- pretty sure that means /compute/ is valid rather than /compute/vWhatever
15:51:48 ericyoung mriedem: this blueprint was already approved for pike
15:51:51 mriedem i remember the openstacksdk team having a thread in the ML last year struggling with the plethora of possible endpoint url formats in the wild
15:52:03 mriedem ericyoung: yes, so are those other 34
15:52:06 mriedem ericyoung: that's my point
15:52:51 mriedem clarkb: yeah i remember having reported this to the sdk team https://bugs.launchpad.net/python-openstacksdk/+bug/1631480
15:52:51 openstack Launchpad bug 1631480 in OpenStack SDK "session endpoint lookup doesn't handle endpoints with paths" [Undecided,New]
15:53:03 mriedem because we had a network endpoint like this: publicURL: http://localhost:5000/network |
15:56:08 mriedem dansmith: will we be cellsv2 meeting today?
15:56:11 mriedem because i have developments
15:56:25 dansmith mriedem: sure
15:57:39 ericyoung mriedem: understood. I'm not trying to be a pain, just wondering if there was someone else who could look or if we should just sit tight.
15:57:54 mriedem ericyoung: you're basically in the latter camp at this point
15:59:22 cdent anybody want to put eyes on https://review.openstack.org/#/c/460147/ has one +2 already. bauzas ? mriedem ?
16:00:57 mriedem i've been -1 on that one a few times now, so i can look at it again
16:01:36 gibi mriedem: I will try to do a binary->source renaming with the major version bump. I think it is not that hard in this particular case.
16:05:11 bauzas cdent: looking
16:11:54 bauzas cdent: jaypipes: we're not passing back the generation bit when deleting ? https://review.openstack.org/#/c/460147/15/nova/scheduler/client/report.py@666
16:12:17 cdent the response body is empty when deleting
16:12:32 cdent (in that case)
16:13:17 mriedem yeah, so our generation + 1 could actually be wrong
16:13:21 mriedem but,
16:13:29 openstackgerrit Mathieu Gagné proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322
16:13:31 mriedem i think when we try to use that incorrect generation we'll fail later, and get it corrected
16:13:32 mriedem somewhere in here
16:14:12 mriedem in _get_inventory_and_update_provider_generation
16:14:23 stephenfin mriedem: Random question. Is there any reason we would want 'refresh_cache' to be False for '_has_port_binding_extension'? https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L1013
16:14:50 mriedem and _update_inventory_attempt
16:14:54 mriedem stephenfin: no idea
16:14:59 stephenfin I ask because I note that _has_multi_provider_extension always refreshes the cache, while _has_auto_allocate_extension never does (outside of tests)
16:15:00 stephenfin Ah :)
16:15:10 mriedem there is no rhyme or reason to when we refresh the cache of neutron extensions
16:15:18 mordred mriedem, clarkb: what's the question about unversioned endpoints?
16:15:28 cdent mriedem: yeah, it will get correct if wrong, what's being doing there is an optimistic sort of "this is more likely to be correct than it would be if we did nothing"
16:15:32 mriedem the auto allocation extension was new in mitaka and i believe not optional, or so i was told,
16:15:53 mriedem but we check for it's existence to see if we're talking to older neutron
16:15:57 bauzas mriedem: cdent: well, I'd say it's unfortunate but workable given we retry
16:16:07 mriedem mordred: https://review.openstack.org/#/c/479818/6/novaclient/v2/versions.py
16:16:18 bauzas cdent: yeah, from a REST PoV that's understandable
16:16:35 bauzas cdent: but I'm just thinking that we assert things a way too much hard
16:16:35 mordred mriedem: looking now
16:16:56 mriedem parsing that sentence is a way too much hard
16:16:57 mriedem :)
16:17:08 stephenfin mriedem: Given that the refresh_cache function actually does some sanity checks before firing off requests suggests we could _always_ refresh the cache https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L1003-L1005
16:17:32 mordred mriedem: the endpoints in the catalog should either be example.com/compute or example.com/compute/v2.1 if the operator puts a versioned endpoint into the catalog
16:17:37 stephenfin ...though maybe the auto allocation extension could be removed altogether. I'll have a look-see
16:18:09 mordred mriedem: we just added a crap ton of code to handle these things and tests for them in keystoneauth
16:18:18 mriedem stephenfin: yeah and that defaults to refresh every 10 minutes by default
16:18:32 mriedem stephenfin: is this cache refresh really a problem?
16:18:45 mriedem are operators enabling and disabling extensions ad hoc and it's causing real issues?
16:19:10 stephenfin I've no idea and was hoping you could enlighten me
16:19:10 mriedem mordred: and the sdk has a crap ton of code for it too :)
16:19:24 mriedem stephenfin: i assume operators are not doing that
16:19:48 mordred mriedem: yah - well, we should be porting the sdk over to use the code in ksa now so that there is only one place - but yeah
16:19:48 stephenfin mriedem: I would assume that too. I'm just adding a '_has_dns_extension' function and wanted to know if the cache check should be there or not
16:20:15 mordred mriedem: anyway - I'll leave some comments ...
16:20:23 stephenfin I'm going to stick it in to be safe but then go on a hunt for more info (likely goose chase - meh)
16:20:29 mriedem kevinbenton: do you know if the dns extension in neutron is optional?
16:20:57 stephenfin mriedem: I'm pretty sure sean-k-mooney said it was
16:21:05 stephenfin You need to have designate deployed for it to work
16:21:41 sean-k-mooney most of the extentions in neutron are optional.
16:22:00 stephenfin sean-k-mooney: Any idea where we'd find a definitive list?
16:22:59 mordred mriedem: OH - this is in novacient
16:23:07 mordred mriedem: I thought this was in nova server
16:23:10 sean-k-mooney well running openstack extension list | grep dns only gave me os-floating-ip-dns
16:23:21 sean-k-mooney so on ocata its not required.
16:23:21 mordred mriedem: as soon as we cut a release, you can straight-up delete this code
16:23:36 mordred mriedem: I'll make you a patch RSN
16:23:37 sean-k-mooney ill check master but i dont think its mandatoary
16:24:57 mriedem sean-k-mooney: os-floating-ip-dns is from the compute api
16:25:00 mriedem i.e. nova
16:25:03 mriedem i.e. nova-network
16:25:15 mriedem i don't know where or how openstack extension list gets it's data
16:27:17 mordred efried: https://review.openstack.org/#/c/479818 is worth looking at - it's right in the midst of all of the discovery work
16:29:34 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Add Cinder v3 detach to swap_volume https://review.openstack.org/456971
16:29:35 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Remove check_detach https://review.openstack.org/446671
16:29:36 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Implement new attach Cinder flow https://review.openstack.org/330285
16:29:57 dansmith efried: solidarity my brother.
16:35:25 dansmith mriedem: have you done any looking at this yet? https://review.openstack.org/#/c/416521/

Earlier   Later