Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-29
15:42:03 cfriesen sfinucan: basically that's the opinion of some people--that dedicated a whole separate pCPU to the emulator threads consumes too many pCPUs
15:42:19 cfriesen s/dedicated/dedicating
15:43:21 sfinucan Grr. I said that exact thing during reviews of that spec, but didn't put it succinctly enough
15:43:47 cfriesen sfinucan: I'm not entirely convinced that sharing emulator threads on a single pCPU is *guaranteeed* to be safe, like if one instance starts seriously hammering on I/O or does live migration or something
15:44:17 sfinucan I think I suggested using 'vcpu_pin_set', but another configuration option (a mask, from the looks of things?) is much better
15:44:33 sfinucan cfriesen: I've just reached that mail now, heh
15:47:58 cfriesen sfinucan: hence my overcommit ratio suggestion, then operators could tune the number of RT instances per "emulator pCPU" to whatever they feel comfortable with..setting it to 1 gives you the behaviour of "emulator_threads_policy=isolate"
16:08:21 openstackgerrit Merged openstack/nova master: XenAPI: device tagging https://review.openstack.org/333781
16:08:34 efried sfinucan Found bugs in https://review.openstack.org/#/c/476159/ :)
16:17:53 openstackgerrit Dan Smith proposed openstack/nova master: Sanitize instance in InstanceMetadata to avoid un-pickleable context https://review.openstack.org/478991
16:25:39 sfinucan efried: How dare you
16:25:48 sfinucan I'll take a look shortly :)
16:27:09 efried sfinucan I didn't touch that one.
16:27:42 efried sfinucan BTW, I don't think your monkeypatch will play well with my explicit newlines and box sizes, except by coincidence.
16:28:06 sfinucan I was planning to drop the newlines and most of the box sizes, tbh
16:28:25 sfinucan the only box size I planned to keep was the one for the box that's currently truncated
16:29:08 efried sfinucan As you wish; though the squished-in bottoms make it look like something's truncated (even when it's not).
16:29:17 efried And I think there might be two long boxes now.
16:29:31 sfinucan efried: good call. Maybe I should keep all the sizes so and just strip the newlines?
16:29:37 sfinucan Given that they're not necessary
16:30:05 efried sfinucan Either way, unless you figure out how to autosize the boxes, it'll need to be trial and error to get it rendering right.
16:30:28 sfinucan Yup. Hopefully we can figure something out instead :(
16:44:47 openstackgerrit Merged openstack/nova master: Add keypairs field to InstanceCreatePayload https://review.openstack.org/419730
16:45:34 openstackgerrit Merged openstack/nova master: Add key_name field to InstancePayload https://review.openstack.org/463002
17:03:49 dansmith artom: why in the metadata test did you subclass FakeDeviceMetadata and FakeDeviceBus ?
17:04:33 dansmith those aren't registered objects, which is a problem for deserializing an Instance, but it also doesn't seem to matter if I use the real devices
17:04:37 dansmith er real objects
17:10:38 jaypipes sean-k-mooney: https://review.openstack.org/#/c/449257/ needs rebasing. can you handle? not sure where ralonso is today.
17:11:01 sean-k-mooney jaypipes: he went home about an hour ago
17:11:16 jaypipes sean-k-mooney: can you rebase or perhaps he can do in morning?
17:11:34 sean-k-mooney ill ask him to do it in the morning
17:11:41 sean-k-mooney i can take a look at rebaseing too
17:12:40 sean-k-mooney jaypipes: other then the merge conflict does it look ok?
17:12:50 jaypipes sean-k-mooney: mostly
17:13:34 jaypipes sean-k-mooney: it's just the bottom of the series so needs to be rebased in order to make progress on the series.
17:26:46 openstackgerrit Dan Smith proposed openstack/nova master: Sanitize instance in InstanceMetadata to avoid un-pickleable context https://review.openstack.org/478991
17:31:43 jaypipes sean-k-mooney: I found a number of issues with that patch. please see my comments.
17:33:28 sean-k-mooney jaypipes: well thats why we have review :) ill ask rodolfo to adres them in the morning
17:33:36 sean-k-mooney jaypipes: thanks for taking a look
17:38:02 melwitt I have a patch up to fix an intermittent functional test failure with placement PUT /allocations if anyone could please review https://review.openstack.org/#/c/478683/
17:57:57 edleafe melwitt: looks good
17:58:52 melwitt edleafe: thanks for the review!
18:21:33 dansmith melwitt: I can split that test fix out if you want, but it's even more obscure without the change to the code I think
18:23:07 melwitt dansmith: no, it's not that. fixing the test is cool, it's just I was looking for how is anything testing the sanitization
18:23:31 openstackgerrit Sean Dague proposed openstack/nova master: remove the very old unmaintained wsgi scripts https://review.openstack.org/479027
18:23:40 dansmith oh I see
18:23:50 sdague dansmith: the devstack bits just merged, and it's running by default, so we can delete those files now
18:25:18 melwitt it would be ideal if we have a test that would catch it if we regress again in the future
18:26:04 dansmith melwitt: yeah, I can't easily reproduce the actual thing I think, but I can make sure we've replaced the instance
18:26:26 openstackgerrit Dan Smith proposed openstack/nova master: Sanitize instance in InstanceMetadata to avoid un-pickleable context https://review.openstack.org/478991
18:26:29 dansmith melwitt: thusly ^
18:26:32 dansmith sdague: ack
18:26:38 melwitt dansmith: I think that's fine. just something that would fail with the old code and pass with the new
18:28:05 dansmith gah, I reset the reproducer again
18:32:54 openstackgerrit sean mooney proposed openstack/os-vif master: set mtu on all code paths https://review.openstack.org/469951
19:15:34 openstackgerrit John Griffith proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285
19:24:42 openstackgerrit melanie witt proposed openstack/nova master: Request zero root disk for boot-from-volume instances https://review.openstack.org/428481
19:24:42 openstackgerrit melanie witt proposed openstack/nova master: Claim and report zero root disk for boot-from-volume instances https://review.openstack.org/428505
19:41:33 openstackgerrit melanie witt proposed openstack/nova master: Make security_group_rules use check_deltas() for quota https://review.openstack.org/477700
19:41:34 openstackgerrit melanie witt proposed openstack/nova master: Add scatter gather utilities for cells https://review.openstack.org/475957
19:41:35 openstackgerrit melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242
19:41:36 openstackgerrit melanie witt proposed openstack/nova master: Make key_pairs use check_deltas() for quota https://review.openstack.org/477699
19:41:38 openstackgerrit melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243
19:41:42 openstackgerrit melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521
19:41:49 openstackgerrit melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945
19:41:52 openstackgerrit melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946
20:13:15 dansmith jaypipes: sdague: we broke metadata server a bit ago, this fix has been validated by the osa people, and just needs a +W: https://review.openstack.org/#/c/478991/
20:16:25 jaypipes dansmith: done
20:16:34 dansmith jaypipes: thanks
20:19:14 sdague dansmith: double +A
20:19:22 dansmith woot
20:19:29 sdague so... why didn't that trip us up in integration tests?
20:19:34 dansmith I get an embroidered blazer for that right?
20:19:40 sdague we just don't touch the right bits?
20:19:44 dansmith sdague: because we don't actually pickle I imagine
20:20:14 dansmith wtf
20:20:20 dansmith sdague: sorry, integration tests.. because we're not configured to use memcache I imagine
20:26:07 sdague dansmith: ah, yeh, that definitely could be
20:26:16 sdague ok, at least that's an answer :)
20:53:19 melwitt sdague: fix for intermittent functional job fails in the gate (such as http://logs.openstack.org/91/478991/3/gate/gate-nova-tox-functional-py35-ubuntu-xenial/34d3264/testr_results.html.gz) needs a +W https://review.openstack.org/#/c/478683/
20:54:49 sdague melwitt: nice fix
20:54:51 sdague +W
20:55:03 melwitt sdague: thanks!
20:56:20 openstackgerrit Ed Leafe proposed openstack/nova master: Add uuid to scheduler's HostState object https://review.openstack.org/476630
20:56:20 openstackgerrit Ed Leafe proposed openstack/nova master: placement: support GET /allocation_candidates https://review.openstack.org/475448
22:02:51 openstackgerrit Takashi NATSUME proposed openstack/nova master: Use PCIAddressField in oslo.versionedobjects https://review.openstack.org/466201
22:08:07 openstackgerrit Merged openstack/nova master: Handle version for PUT and POST in PlacementFixture https://review.openstack.org/478683
23:10:59 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add 'updated_at' field to InstancePayload in notifications https://review.openstack.org/475276
23:25:22 openstackgerrit John Griffith proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285
23:26:20 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (1/2) https://review.openstack.org/430608
23:27:38 openstackgerrit Takashi NATSUME proposed openstack/nova master: List/show all server migration types (2/2) https://review.openstack.org/459483
#openstack-nova - 2017-06-30
00:31:56 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add 'updated_at' field to InstancePayload in notifications https://review.openstack.org/475276
02:34:58 openstackgerrit Artom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082
02:35:00 openstackgerrit Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021
03:05:05 openstackgerrit Chason Chan proposed openstack/python-novaclient master: switch to openstackdocstheme https://review.openstack.org/477757
03:06:03 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938
03:06:13 gmann alex_xu, sfinucan finally able to enable the network quota in sample file ^^
03:06:59 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938
03:11:44 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix to return server groups quota in quota class set https://review.openstack.org/467999
03:14:33 openstackgerrit Gao Yuan proposed openstack/nova master: Remove mox from nova.tests.unit.virt.test_block_device https://review.openstack.org/477904

Earlier   Later