Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-29
00:10:25 openstackgerrit melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521
00:10:52 openstackgerrit melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945
00:10:55 openstackgerrit melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946
01:30:21 gaoyuan anyone doing bp/remove-mox-pike online?
01:32:01 gaoyuan I have a little question
01:50:00 gmann gaoyuan, yes, what is question?\
02:12:09 gaoyuan gmann: please see this review https://review.openstack.org/#/c/477812/2
02:12:37 gaoyuan Ken'ichi Ohmichi says he prefer another patch using mock
02:13:06 gaoyuan what in the bp description of remove-mox-pike, it states Please note: self.stub_out does not make use of mox, it is there to replace to use of "self.stub.Set" in an easy to review way. Moreover, and proposals to remove the use of stub_out should not be part of this spec.
02:13:23 gmann gaoyuan, checking
02:13:36 gmann gaoyuan, left comment on https://review.openstack.org/#/c/477904/1
02:13:55 gmann gaoyuan, on preferable way of mocking things.
02:14:34 gaoyuan Does this mean we should use self.stub_out to replace self.stub.Set?
02:14:41 gaoyuan or I misunderstood
02:15:07 gaoyuan gmann, thanks for the updating.
02:16:32 gmann gaoyuan, yes, as of now we are replacing the self.stub.Set with self.stub_out
02:17:10 gmann gaoyuan, because if there are lot of changes in review changing the self.stub.Set to mock (i saw in some of the review) then it is very hard to review
02:17:57 gaoyuan gmann, but it's got a -1, and I already abandoned it, https://review.openstack.org/#/c/477384/, this one got +2 already
02:17:57 gmann gaoyuan, in that case you pointed it is just 1 line and thats why may be kenichi prefer the mock instead of stub_out
02:18:29 gaoyuan OK, I understand
02:18:59 gmann gaoyuan, i saw, seems like other patch was initially proposed. but as i mentioned as it is just 1 line so it is +2
02:19:20 gmann gaoyuan, but if its too many changes then stub_out is preferable as of now
02:19:54 gaoyuan gmann, finally, if you still have time, https://review.openstack.org/#/c/451614/, please have a look at this one
02:20:44 gmann gaoyuan, you should comment on that patch instead of new patch (just matching the timing of your review on another patch and your patch :))
02:21:10 gmann gaoyuan, but main idea is same as you understood. self.stub.Set -> self.stub_out
02:21:51 gmann gaoyuan, sure, i will check but may be in evening or tomorrow for sure. added in queue
02:21:56 gaoyuan gmman, in test_vmops.py, I used a function mock_out_object which is created by myself in nova/test.py
02:22:30 gaoyuan OK, good day then
02:22:56 gaoyuan gmann, I hope I am not too much disturbing.
02:22:57 gmann gaoyuan, but stub_out does not work there ?
02:23:29 gmann gaoyuan, not at all, we really appreciate your help on fixing mox things and rally nice work.
02:23:59 gaoyuan no
02:24:03 gaoyuan I have commetns
02:24:11 gaoyuan unless I am wrong
02:24:16 gmann gaoyuan, ok, let me check the changes in detail ad
02:24:23 gmann and will get back to you
02:24:47 gaoyuan gmann, 2ks
02:24:49 gaoyuan 3ks
05:01:16 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix a missing classifier https://review.openstack.org/478733
05:27:05 openstackgerrit Alex Xu proposed openstack/nova master: placement: add traits support to get resource_providers with shared https://review.openstack.org/478464
05:38:10 mkrai_ Hi I have question regarding nova serial console. How does it work?
05:38:59 mkrai_ In Ironic, a new shellinabox process is started which serves the serial console via ipmitool. How is it done in Nova?
05:39:09 mkrai_ Link to code or any doc will be helpful.
05:39:16 mkrai_ Thanks in advance.
06:08:33 openstackgerrit Gao Yuan proposed openstack/nova master: Remove mox from nova.tests.unit.virt.test_block_device https://review.openstack.org/478749
06:11:37 openstackgerrit Gao Yuan proposed openstack/nova master: Remove mox from nova.tests.unit.virt.xenapi.test_vm_utils.py https://review.openstack.org/478749
06:56:46 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Exception Error logs shown in Citrix XenServer CI https://review.openstack.org/478437
07:03:07 openstackgerrit Radoslav Gerganov proposed openstack/nova master: VMware: Factor out relocate_vm() https://review.openstack.org/270115
07:03:07 openstackgerrit Radoslav Gerganov proposed openstack/nova master: VMware: Live migration of instances https://review.openstack.org/270116
07:19:06 gmann mordred, can you check this - https://review.openstack.org/#/c/459172/ (could not find you on #openstack)
07:30:16 openstackgerrit Béla Vancsics proposed openstack/nova master: [WIP] Transform live_migration_post_dest notification https://review.openstack.org/469784
07:35:33 openstackgerrit Chason Chan proposed openstack/nova master: import the admin guide content from openstack-manuals https://review.openstack.org/477497
07:52:04 openstackgerrit Ildiko Vancsa proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285
07:52:47 bauzas now I have long backlog of emails and other reviews to look after :(
08:11:42 openstackgerrit Naichuan Sun proposed openstack/nova master: xenapi: Exception Error logs shown in Citrix XenServer CI https://review.openstack.org/478437
08:12:36 openstackgerrit klyang proposed openstack/nova master: Fix the log information argument mistake https://review.openstack.org/478792
08:12:48 ebbex What's the status on the nova-metadata wsgi script? Is it ok to use nova/wsgi/nova-metadata.py, or has it been replaced with something more up-to-date?
08:20:35 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Populate the 'configuration' section https://review.openstack.org/478473
08:20:36 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Populate the 'cli' section https://review.openstack.org/478472
08:20:36 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Populate the 'user' section https://review.openstack.org/478475
08:20:37 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Switch to openstackdocstheme https://review.openstack.org/477751
08:20:37 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Populate the 'contributor' section https://review.openstack.org/478474
08:20:38 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Populate the 'reference' section https://review.openstack.org/478484
08:20:38 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Remove dead plugin https://review.openstack.org/478469
08:20:39 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Rework index page per new sections https://review.openstack.org/478485
08:20:39 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Remove cruft from conf.py https://review.openstack.org/478468
08:20:40 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Create directory structure for docs migration https://review.openstack.org/478471
08:20:40 openstackgerrit Stephen Finucane proposed openstack/nova master: doc: Remove dead files https://review.openstack.org/478470
08:29:20 openstackgerrit garyk proposed openstack/nova master: VMware: ensure that live migration attaches to correct interface https://review.openstack.org/478797
08:31:58 openstackgerrit garyk proposed openstack/nova master: VMware: ensure that live migration attaches to correct interface https://review.openstack.org/478797
08:39:27 lpigueiras hello, could you take a look to this PR plz: https://review.openstack.org/#/c/476122/ ?
08:39:58 lpigueiras it should solve this bug: https://bugs.launchpad.net/nova/+bug/1592167 for a cells deployment
08:39:58 openstack Launchpad bug 1592167 in OpenStack Compute (nova) mitaka "Deleted keypair causes metadata failure" [Medium,Fix released] - Assigned to Matt Riedemann (mriedem)
08:59:34 moshele sfinucan: hi
08:59:50 moshele sfinucan: can we release the os-vif?
09:01:28 sfinucan moshele: I think that's mriedem's decision
09:01:52 sfinucan jaypipes or sean-k-mooney might have an idea, but neither of those are online :/
09:02:19 moshele sfinucan: I will check
09:02:45 openstackgerrit Alex Xu proposed openstack/nova master: placement: add traits support to get resource_providers with shared https://review.openstack.org/478464
09:17:17 alex_xu gmann: just filed a bug for quota-class https://bugs.launchpad.net/nova/+bug/1701211
09:17:18 openstack Launchpad bug 1701211 in OpenStack Compute (nova) "The network related quotas aren't deprecated in quota-class API" [Undecided,Confirmed]
09:18:56 gmann alex_xu, thanks. i will update spec and push ML soon
09:19:03 alex_xu gmann: thanks
09:22:11 AK47 ..
09:24:21 bauzas sfinucan: you could help some tech debt kill by looking at https://review.openstack.org/#/c/469037/ :)
09:24:43 sfinucan bauzas: Oh, definitely. Nice work
09:25:01 sfinucan Just finishing doc-rework patches, then I'll move onto that
09:25:06 sfinucan Our man pages are really rubbish :(
09:25:33 sfinucan except for nova-manage, funnily enough, heh
09:27:11 bauzas ++
09:29:17 openstackgerrit Moshe Levi proposed openstack/os-vif master: unplug_vf_passthrough: don't try to delete representor netdev https://review.openstack.org/478820
09:32:11 openstackgerrit Chason Chan proposed openstack/python-novaclient master: switch to openstackdocstheme https://review.openstack.org/477757
09:38:54 sfinucan bauzas: What are we replacing rootwrap with in the longterm? oslo.policy?
09:39:08 bauzas sfinucan: privsep, no ?
09:39:20 sfinucan yup, it is privsep
09:39:23 sfinucan My bad :)
09:39:47 bauzas that's fine, mikal isn't watching us :p
09:59:53 sfinucan bauzas: Question - I'm working on patches for https://specs.openstack.org/openstack/docs-specs/specs/pike/os-manuals-migration.html
10:00:12 sfinucan That tells us to use doc-migration for the topic
10:00:30 sfinucan But I'm guessing I should link against a blueprint, and that's called os-manuals-migration

Earlier   Later