Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-28
14:45:38 jaypipes sdague: I was being facetious :)
14:45:40 sdague :)
14:45:48 sdague that's fine, I was being specific :)
14:47:11 openstackgerrit Lucian Petrut proposed openstack/nova master: Raise MigrationPreCheckError if instance location is unavailable https://review.openstack.org/469779
14:50:59 sdague you forgot the sudo
15:02:11 sfinucan sdague: It's https://specs.openstack.org/openstack/docs-specs/specs/pike/os-manuals-migration.html
15:02:46 sfinucan So I guess I should use 'os-manuals-migration', even though the spec says to use 'doc-rework' as the topic
15:03:57 sdague sfinucan: ok, but that's not the blueprint
15:04:16 sdague the blueprint: .... only works if that is the short name of the blueprint
15:04:28 avanko_ i'm looking for somebody who can help to solve issue with Openstack-Neutron. our team is processing cluster stress test on OPNFV FDS, OStack-ODL-FDSio-HA, when running the test, we have a blocker, at some stage, the nova stops adding ports to VM
15:05:16 avanko_ is there anybody to help us with this? please contact me on avanko@cisco.com, so we can set up a brief call and go through the discovered issue in more detail. currently we are blocked by this issue
15:09:30 openstackgerrit Takashi NATSUME proposed openstack/nova master: Stop using mox stubs in test_remote_consoles.py https://review.openstack.org/478423
15:20:21 openstackgerrit Ildiko Vancsa proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285
15:26:12 cfriesen someone just pointed out that after you boot up an instance with neutron ports it's possible to delete the ports in neutron. Does this seem odd to anyone else?
15:41:06 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Remove check_detach https://review.openstack.org/446671
15:54:21 sdague sfinucan / johnthetubaguy - on the config guide side, how are we feeling about adding all the pass through keystone auth options?
15:54:22 sdague https://review.openstack.org/#/c/358701/
15:54:30 sdague https://bugs.launchpad.net/nova/+bug/1615666
15:54:30 openstack Launchpad bug 1615666 in OpenStack Compute (nova) "Nova config misses [cinder] insecure option" [Undecided,New]
16:02:34 edleafe jaypipes: figured out the problem with the failing functional test in https://review.openstack.org/#/c/475448/
16:03:06 edleafe jaypipes: the DB fixture is wiping the database, but the internal _TRAITS_SYNCED flag is still True
16:03:23 edleafe jaypipes: So in subsequent tests, none of the standard traits are there
16:03:24 jaypipes edleafe: ah!.
16:03:29 jaypipes edleafe: great catch.
16:03:42 jaypipes edleafe: thank you!
16:03:43 edleafe I fixed it by adding a reset method to the Trait objects
16:03:48 edleafe object
16:03:59 edleafe and calling it from the db fixture
16:04:03 edleafe Does that sound OK?
16:04:06 jaypipes edleafe: ++
16:04:15 edleafe cool, will push in a few
16:04:19 jaypipes edleafe: ty sir!
16:04:42 jaypipes edleafe: if you feel like getting those parens style issues I missed that efried found, that would be cool too.
16:05:24 edleafe jaypipes: sure, why not?
16:05:33 jaypipes thanks!
16:05:37 edleafe jaypipes: anything to clean up that ugly style :;P
16:05:41 jaypipes :)
16:16:36 openstackgerrit Sean Dague proposed openstack/nova master: Clarify that vlan feature means nova-network support https://review.openstack.org/478551
16:23:52 cfriesen I'd welcome some more reviews of https://review.openstack.org/#/c/461456 It appears that Sahid and I are at a bit of an impasse as to what the semantics of "hw:cpu_realtime_mask" should be. I think it's confusing to have an implied "all-cpus-are-realtime" and that it should be treated as indicating which vCPUs are realtime rather than an exclusion mask indicating which vCPUs are not realtime
16:56:24 openstackgerrit Ed Leafe proposed openstack/nova master: Add a reset for traits DB sync https://review.openstack.org/478564
16:56:41 edleafe jaypipes: ^^ Made it a separate patch
16:57:25 edleafe jaypipes: I can rebase the series on that, or if you think it can merge fast, you can rebase the series on master later
17:01:21 jaypipes edleafe: ah, cool.
17:02:34 jaypipes edleafe: +2 from me.
17:02:42 jaypipes bauzas: feel free to fast-track above patch from edleafe
17:03:41 jaypipes in other news, someone just needs to boot the damn EMC ScaleIO CI system. it's completely unreliable and just noise.
17:04:40 edleafe jaypipes: bauzas is on PTO today
17:05:02 jaypipes alex_xu, melwitt: see edleafe's patch above. simple and sweet and would be good to merge.
17:05:11 jaypipes dansmith: ^^ you too.
17:05:18 dansmith yeah I'm looking
17:05:25 dansmith it seems like a weird way to accomplish that
17:05:25 jaypipes danke
17:05:41 dansmith being in the database fixture I mean
17:05:46 jaypipes dansmith: you mean as opposed to just resetting the _TRAITS_SYNC variable?
17:05:54 dansmith we do all the rest of these global resets in the test base
17:06:07 dansmith lemme get you a link
17:06:32 dansmith https://github.com/openstack/nova/blob/master/nova/test.py#L259
17:06:33 dansmith for example
17:06:47 dansmith and https://github.com/openstack/nova/blob/master/nova/test.py#L295
17:06:48 dansmith and https://github.com/openstack/nova/blob/master/nova/test.py#L306
17:07:02 dansmith and https://github.com/openstack/nova/blob/master/nova/test.py#L267
17:07:08 openstackgerrit Ed Leafe proposed openstack/nova master: placement: support GET /allocation_candidates https://review.openstack.org/475448
17:07:21 dansmith and https://github.com/openstack/nova/blob/master/nova/test.py#L266
17:08:08 jaypipes dansmith: so in short, you'd prefer to call that in the base test setup, yes?
17:08:53 dansmith jaypipes: that and I don't think it should be an object method
17:09:02 melwitt I also don't like the arbitrary putting it on the DatabaseFixture. it's not related to that
17:09:17 edleafe dansmith: so maybe around line 276 in that file?
17:09:22 dansmith jaypipes: we have a bunch of other things in the test base that just import a module and nuke the module-level variable
17:09:57 dansmith edleafe: not in that if, no.. just put it down like 296 or so
17:10:05 dansmith no need to make it conditional, just always nuke
17:11:40 edleafe dansmith: ok, so no worries about it being _PRIVATE? I see the others are referenced directly
17:11:50 dansmith edleafe: no
17:11:54 edleafe k
17:12:12 dansmith all the tests do all day is butt into the private business of other stuff.. :)
17:18:28 openstackgerrit Ed Leafe proposed openstack/nova master: Add a reset for traits DB sync https://review.openstack.org/478564
17:18:36 edleafe dansmith: jaypipes: amended^^
17:20:19 jaypipes edleafe: approved.
17:42:29 openstackgerrit melanie witt proposed openstack/nova master: Make security_group_rules use check_deltas() for quota https://review.openstack.org/477700
17:42:30 openstackgerrit melanie witt proposed openstack/nova master: Add scatter gather utilities for cells https://review.openstack.org/475957
17:42:31 openstackgerrit melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242
17:42:32 openstackgerrit melanie witt proposed openstack/nova master: Make key_pairs use check_deltas() for quota https://review.openstack.org/477699
17:42:34 openstackgerrit melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243
17:42:37 openstackgerrit melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521
17:42:42 openstackgerrit melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945
17:43:02 openstackgerrit melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946
17:44:27 openstackgerrit Ed Leafe proposed openstack/nova master: Add traits to the ResourceProviders filters https://review.openstack.org/474602
18:02:46 dansmith melwitt: what's your thinking on the 300 second timeout?
18:02:58 dansmith I'm thinking anything waiting for us would have given up before that
18:03:35 melwitt dansmith: I copied it from the wait_for_instance_event() in compute/manager as a starting point
18:04:07 melwitt yeah, I wasn't sure what to make it
18:05:21 dansmith okay, that is waiting for neutron do do a thing, but nothing else is blocked on us at that point
18:05:46 melwitt okay. maybe it should be related to the rpc timeout then. I can't remember if that defaults to 120 or so. checking
18:05:54 dansmith but here, theres an http or rpc client waiting on us in most cases, which would be 60s max I think
18:05:58 dansmith 60
18:06:27 dansmith I think if we have a hard-coded timeout, 60 is a good choice personally
18:07:00 dansmith I also was thinking the inner method would take the timeout as a param.. because we might want instance list to timeout quickly, but other things we might want to be more tolerant
18:07:13 dansmith either way, we don't have to have the timeout perfect to land
18:08:02 melwitt okay. do you think maybe timeout should be a kwarg to each utility method? I thought about it but wasn't sure if it was over optimizing
18:08:47 dansmith melwitt: the inner one I think.. the helpers can use a hard coded value I think
18:11:44 melwitt dansmith: okay. I was thinking the helpers don't know what they are going to do (instance list vs something else) but I think you're thinking people can use the inner method for more control so it can be only there. makes sense to me

Earlier   Later