Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-23
17:06:27 superdan that's what I meant, where are you going to be
17:06:47 superdan mriedem: well, yeah if you end up in PDX we'll be glad to show you a good time :P
17:07:06 artom mriedem, done
17:07:19 artom mriedem, is Huawei bringing you in to the motherland?
17:07:24 mriedem artom: yup
17:07:36 openstackgerrit Artom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622
17:07:39 openstackgerrit Artom Lifshitz proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387
17:07:48 openstackgerrit Artom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082
17:07:50 openstackgerrit Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021
17:17:02 melwitt dtp made me confused about the compute node marker thing again
17:17:40 melwitt does passing the marker mean return the one with the marker or the one after it?
17:18:01 superdan should be after it
17:18:10 melwitt okay, then that makes sense
17:18:39 melwitt ah "select = select.where(cn_tbl.c.id > marker)"
17:18:59 melwitt PHEW
17:38:52 dtp thanks melwitt for clearing that up
18:02:45 dtp are the api-ref files read by normies or are they just for nova devs?
18:13:30 cfriesen_ dtp: anyone coding to the HTTP API
18:13:44 dtp thanks
18:13:46 cfriesen_ but that could be end-users, not openstack devs
18:23:20 mriedem cfriesen_: some small issues in https://review.openstack.org/#/c/435141/ but +2
18:28:39 openstackgerrit Merged openstack/nova master: Remove code that produces warning in modern Python https://review.openstack.org/476952
18:37:16 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: Microversion 2.48: Standardization of VM diagnostics https://review.openstack.org/473228
18:42:07 cfriesen_ mriedem: for the "do the version check once", were you thinking of storing it in something like "have_embedded_flavor_info" or something like "have_version_2_47"?
18:42:55 mriedem cfriesen_: either
18:43:02 mriedem don't care as much about the name of the variable
18:44:22 cfriesen_ mriedem: as for re-using _expand_dict_key(), I tried but "flavor" doesn't support delattr/getattr/setattr
18:45:06 cfriesen_ mriedem: it's logically the same thing, but the types don't work
18:48:17 artom cfriesen_, for what it's worth, I'm a fan of indicating meaning rather than numeric version numbers
18:49:17 cfriesen_ artom: was leaning that way myself
18:56:42 openstackgerrit Ildiko Vancsa proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285
19:41:12 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Handle uuids in os-hypervisors API https://review.openstack.org/471899
19:43:48 openstackgerrit Merged openstack/nova master: Fix misuse of assertIsNone https://review.openstack.org/476736
20:09:40 mriedem mgagne: it's close https://review.openstack.org/#/c/454322/
20:09:58 mriedem mostly easy things to address
20:11:49 openstackgerrit Jay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates https://review.openstack.org/476631
20:11:49 openstackgerrit Jay Pipes proposed openstack/nova master: Add uuid to scheduler's HostState object https://review.openstack.org/476630
20:11:50 openstackgerrit Jay Pipes proposed openstack/nova master: placement: support GET /allocation_candidates https://review.openstack.org/475448
20:11:50 openstackgerrit Jay Pipes proposed openstack/nova master: WIP - placement: claim resources in scheduler https://review.openstack.org/476632
20:16:16 fried_rice leakypipes https://review.openstack.org/#/c/475448/9..11/nova/api/openstack/placement/handlers/allocation_candidate.py@160 -- Is there something preventing the request containing `resources=` (i.e. an empty value)?
20:16:28 fried_rice leakypipes If not, ^ will still raise ValueError
20:18:01 leakypipes fried_rice: the JSONSChema validation.
20:18:16 fried_rice leakypipes Which part of that ensures it's nonempty?
20:19:19 fried_rice leakypipes I would have expected "required": [ "resources" ] would just ensure the `resources` key is present.
20:19:54 fried_rice Because an empty value could be valid.
20:22:35 fried_rice leakypipes Just tried it out locally: `jsonschema.validate({'resources': ''}, schema, format_checker=jsonschema.FormatChecker())` passes
20:31:37 leakypipes fried_rice: then we'll have to go and change all the schema validators in all the handlers in placement...
20:32:03 fried_rice leakypipes Or just catch ValueError and convert it to HttpBadRequest
20:32:13 leakypipes fried_rice: which I can try and do this weekend. but for now, I'm tired. :)
20:35:12 leakypipes fried_rice: hold up, pushing a new patch to add that check to normalize_resources_qs_param
20:35:37 fried_rice leakypipes ight.
20:36:34 fried_rice leakypipes Yuh, that'd do it. Since that guy's clearly allowed to raise HttpBadRequest
20:41:01 mriedem melwitt: do you get a 406 or a 405 from placement if requesting a microversion that doesn't exist?
20:41:19 mriedem your consumers/allocations code is checking for a 406 response, but i thought it would be a 405
20:41:33 openstackgerrit Jay Pipes proposed openstack/nova master: move resources_from_request_spec() to utils https://review.openstack.org/476629
20:41:34 openstackgerrit Jay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates https://review.openstack.org/476631
20:41:34 openstackgerrit Jay Pipes proposed openstack/nova master: Add uuid to scheduler's HostState object https://review.openstack.org/476630
20:41:35 openstackgerrit Jay Pipes proposed openstack/nova master: placement: support GET /allocation_candidates https://review.openstack.org/475448
20:41:35 openstackgerrit Jay Pipes proposed openstack/nova master: WIP - placement: claim resources in scheduler https://review.openstack.org/476632
20:41:36 openstackgerrit Jay Pipes proposed openstack/nova master: return 400 Bad Request when empty string resources https://review.openstack.org/477019
20:41:41 leakypipes fried_rice: ^
20:41:46 leakypipes melwitt: 406
20:41:57 fried_rice leakypipes Ack.
20:43:37 leakypipes mriedem: https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/microversion.py#L114
20:43:46 leakypipes 406 HTTP Not Acceptable
20:45:06 mriedem ok
20:45:19 mriedem https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/microversion.py#L187 being the key part
20:47:12 leakypipes well, line 189, but yeah
20:51:31 mriedem not line 188?
20:51:50 mriedem melwitt: some comments in https://review.openstack.org/#/c/469634/ - overall looks ok, some questions about additional testing, but that could probably be follow on too
20:52:26 leakypipes mriedem: :)
20:53:13 mriedem landing and then booking ass over to the other gate
20:53:15 mriedem o/
21:26:43 leakypipes sean-k-mooney: did you like my "does it now?" comment? :)
21:30:02 sean-k-mooney leakypipes: :) yes yes i did
21:30:11 leakypipes hehe
21:30:22 leakypipes sean-k-mooney: meetings suck.
21:31:39 sean-k-mooney the worst part is i obviosly context switch to something else and then when i came back i finished the unit test and duplicated it to create the socond one and still didnt see it
21:34:01 sean-k-mooney leakypipes: by they way do you want me to open a bug for that or is it fine as is
21:34:35 sean-k-mooney leakypipes: e.g. the patch not the lack of the rest of the comment
21:34:57 leakypipes sean-k-mooney: fine as it is.
21:35:36 sean-k-mooney cool ill respin on monday so
21:39:09 leakypipes sean-k-mooney: no prob! enjoy your weekend :)
21:39:42 sean-k-mooney leakypipes: you too :)
21:40:19 sean-k-mooney leakypipes: wouldnt want to upset sfinucan by working too weekends in a row :P
21:40:44 leakypipes heh
21:40:47 leakypipes or two even.
21:40:52 openstackgerrit Jay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates https://review.openstack.org/476631
21:40:53 openstackgerrit Jay Pipes proposed openstack/nova master: WIP - placement: claim resources in scheduler https://review.openstack.org/476632
21:41:06 leakypipes fried_rice: fixed based on your (excellent, thank you!) comments ^
21:41:20 fried_rice leakypipes Ack
22:02:24 jgriffith superdan ping
22:02:56 superdan jgriffith: I'm like one foot out the door...
22:03:06 jgriffith bummer
22:03:14 jgriffith alright, I'll just catch ya next week
22:03:20 superdan urgent?
22:03:23 jgriffith it's about your cells update to devstack
22:03:38 jgriffith nah.. I can just roll back to an older version of devstack for now and look at it again later
22:03:40 jgriffith no worries
22:03:43 jgriffith have a good week-end

Earlier   Later