| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-06-22 | |||
| 09:42:53 | markus_z | each of those tools has different pros/cons, I haven't found a clear winner yet, inkscape has simply the fewest cons for me | |
| 09:43:48 | kashyap | markus_z: I do the same in LaTex. Spend way too much time than I care to admit. Sometimes I wonder if I should give up. But I like the end result | |
| 09:44:00 | kashyap | markus_z: E.g. Look at slides 5 and 6 - https://kashyapc.fedorapeople.org/A-Practical-Look-at-QEMU-and-libvirt-Block-Layer-Primitives-NLUUG-Spring-2017.pdf | |
| 09:44:21 | kashyap | It uses TikZ :P (https://en.wikipedia.org/wiki/PGF/TikZ) | |
| 09:44:59 | markus_z | kashyap: hehe, yeah, I spent there so much time too :D | |
| 09:45:18 | markus_z | kashyap: http://latexdraw.sourceforge.net/ <- saved me a lot of time during my masters thesis | |
| 09:45:37 | markus_z | It draws pstricks, super fancy :) | |
| 09:45:41 | kashyap | markus_z: But more serious, TikZ teaches us vector graphics and Bezier Curves, etc. | |
| 09:45:58 | kashyap | markus_z: Oh, did't know that. There's a similar site for LaTex symbols | |
| 09:46:17 | kashyap | Where you hand-draw the symbol roughly, and the site will point out the syntax, can't find it now | |
| 09:46:54 | markus_z | yeah, now I remember that | |
| 09:47:43 | markus_z | http://detexify.kirelabs.org/classify.html | |
| 09:47:47 | markus_z | ^ you mean that? | |
| 09:51:41 | kashyap | markus_z: That's it | |
| 09:52:02 | kashyap | I have it in my bookmarks, but I forgot the keyword to look for | |
| 09:59:44 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: Removes potentially bad exit value from accepted list in Quobyte volume driver https://review.openstack.org/453537 | |
| 09:59:45 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: Switch Nova Quobyte volume driver to mount via systemd-run https://review.openstack.org/432344 | |
| 10:05:50 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975 | |
| 10:45:34 | BloqueNegro | :Q | |
| 10:49:02 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: use context mgr in instance.delete https://review.openstack.org/443764 | |
| 10:49:02 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | |
| 10:49:03 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | |
| 12:06:36 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285 | |
| 12:28:03 | openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient master: Cleanup duplicated methods https://review.openstack.org/476493 | |
| 12:29:55 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: _schedule_instances() supporting a RequestSpec object https://review.openstack.org/469037 | |
| 13:45:31 | mriedem | artom: are you fixing the unit tests on that series? | |
| 13:45:40 | mriedem | the tagged attach one i mean | |
| 13:45:49 | mriedem | although i guess it's after midnight for you now | |
| 13:46:32 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Don't delete neutron port when attach failed https://review.openstack.org/403568 | |
| 13:51:08 | artom | mriedem, no, it's 16:50 | |
| 13:51:18 | artom | mriedem, I was just about to address your comments | |
| 13:51:19 | mriedem | oh heh, well i'm just fixing this up | |
| 13:51:24 | mriedem | or you can | |
| 13:51:37 | artom | How far along are you? I've yet to open my editor | |
| 13:51:43 | mriedem | just need to run the tests | |
| 13:51:54 | mriedem | i'll finish it | |
| 13:52:02 | artom | mriedem, cool, thanks! | |
| 13:53:12 | dane-fichter | dansmith: Could you take a look at https://review.openstack.org/#/c/457711/8 when you get a chance? I've resolved the unit test issues, so I think it's ready to go. | |
| 13:53:42 | stvnoyes | mriedem: thanks for the review on the migrate change, i have a couple of questions | |
| 13:54:00 | dansmith | dane-fichter: no blueprint link? | |
| 13:54:36 | stvnoyes | i was originally going to use vol_id as the key in that old_attachments dict, but saw that nova allows you to connect a volume multiple times to the same instance. Is that a bug or a feature? | |
| 13:55:00 | stvnoyes | if it's a bug, then I can use the vol_id as a key. | |
| 13:55:38 | mriedem | stvnoyes: by connect do you mean calling os-brick.connect_volume or os-initialize_connection in cinder? | |
| 13:55:46 | dane-fichter | dansmith: it's this one: https://blueprints.launchpad.net/nova/+spec/nova-validate-certificates | |
| 13:55:58 | mriedem | stvnoyes: either way the volume_id and bdm.id are for the same bdm record | |
| 13:56:10 | dansmith | dane-fichter: needs linkage in the commit message | |
| 13:56:27 | mriedem | stvnoyes: at least i think so | |
| 13:56:31 | dane-fichter | dansmith: ok. I'll link it. | |
| 13:56:42 | stvnoyes | i was concerned that if the volume was connected multiple times to the instance, we could swap the attachment_ids bentween the bdms on rollback | |
| 13:56:53 | dansmith | dane-fichter: the spec isn't merged though right? | |
| 13:57:03 | mriedem | stvnoyes: but i think it's the same bdm record regardless | |
| 13:57:25 | mriedem | otherwise when you get the bdm by volume id and instance uuid, you'd have more than one which would be a failure | |
| 13:57:34 | stvnoyes | mriedem: ok I see what you mean. | |
| 13:57:42 | mriedem | i do think we connect on the dest and the source at the same time | |
| 13:57:44 | mriedem | during the migration | |
| 13:57:55 | mriedem | and then if successful, we disconnect from the source host in post live migration | |
| 13:58:07 | dane-fichter | dansmith: The spec has merged. See https://review.openstack.org/#/c/357151/ | |
| 13:58:12 | mriedem | johnthetubaguy really knows the internals of this | |
| 13:58:32 | stvnoyes | btw, it does seem to be a bug to allow a volume to attach to the same instance multiple times. Things definitely break when the volume is unmounted. you lose both attachments. | |
| 13:58:35 | stvnoyes | in cinder | |
| 13:58:58 | dansmith | dane-fichter: ah, this is linked from the BP: https://review.openstack.org/#/c/441538/ | |
| 13:59:01 | stvnoyes | I guess I'll file a bug... | |
| 13:59:02 | dansmith | which is abandoned I se | |
| 13:59:04 | dansmith | *see | |
| 13:59:30 | dane-fichter | dansmith: Dammit. I'll fix that too. | |
| 13:59:58 | mriedem | artom: maybe i will let you handle this one, because there are some other things to do here | |
| 14:00:04 | artom | mriedem, sure | |
| 14:00:05 | dansmith | dane-fichter: anyway, I have no context on this so it'd take me some time to get up to speed and be able to review it and there's a lot of important stuff flying around. So, I'll add it to the queue, but... | |
| 14:00:42 | dansmith | dane-fichter: jaypipes is very busy with those same things, so you might try to get johnthetubaguy to look at it first | |
| 14:01:43 | mriedem | artom: ok comments posted | |
| 14:01:48 | mriedem | some issues with the tests | |
| 14:02:46 | dane-fichter | dansmith: ok | |
| 14:02:57 | artom | mriedem, I'm on it | |
| 14:03:04 | dane-fichter | this change is really simple and doesn't require a ton of context | |
| 14:06:24 | openstackgerrit | dane-fichter proposed openstack/nova master: Add trusted certificates to InstanceExtras https://review.openstack.org/457711 | |
| 14:06:28 | stvnoyes | mriedem: one other question. I like the idea of putting old_attachments in the base class LiveMigrateData. But I didn't see any examples of how to add new fields to a base class, they don't seem to be versioned. Do you know of an example where something like that was done? | |
| 14:08:06 | mriedem | dane-fichter: see comments in PS9 | |
| 14:08:16 | mriedem | *PS8 | |
| 14:08:23 | mriedem | dane-fichter: missing some tests | |
| 14:08:24 | dansmith | dane-fichter: for sure, but it's adding something to the data model which is important, and I see no dependent patches that actually use it | |
| 14:08:34 | dansmith | dane-fichter: so knowing the full context of what the plan here is is.. kindof important | |
| 14:09:31 | mriedem | stvnoyes: i believe if you add a field to LiveMigrateData, it will require a version bump on each subclass that is versioned | |
| 14:09:41 | mriedem | stvnoyes: if it doesn't, we'll have to ask dansmith | |
| 14:10:17 | dansmith | mriedem: yeah, I think so.. I don't think we've had to do that yet, but yeah.. | |
| 14:10:37 | stvnoyes | ok thanks. I'll give that a try. | |
| 14:14:05 | ftersin | mdbooth: hi. are you around? | |
| 14:16:45 | mriedem | dansmith: melwitt: are these good for review now? https://review.openstack.org/#/c/428481/7 | |
| 14:16:52 | mriedem | i wasn't sure if we were holding up for placement things or something | |
| 14:18:38 | mriedem | johnthetubaguy: if/when you're around, the pike review priorities are up and would be nice to get in https://review.openstack.org/#/c/470420/ | |
| 14:18:52 | mriedem | jaypipes: dansmith: ^ you too | |
| 14:19:01 | mriedem | super late this cycle | |
| 14:19:45 | jaypipes | mriedem: done | |
| 14:21:37 | mriedem | thanks suge | |
| 14:22:05 | mriedem | i'm going to play a sassy southerner from the 30s today | |
| 14:24:03 | alex_xu | mriedem: do you know why we need to mock this method https://review.openstack.org/#/c/459593/30/nova/tests/unit/conductor/test_conductor.py@1419? | |
| 14:24:52 | alex_xu | mriedem: I remember that mock, it raise InstanceNotFound, but why the test can get InstanceAction and Tags from the db... | |
| 14:24:59 | alex_xu | s/I remember/I remove/ | |
| 14:27:13 | mriedem | alex_xu: you mean why do the instance tag db api methods call _check_instance_exists_in_project(context, instance_uuid) first? | |
| 14:27:53 | alex_xu | mriedem: no, I mean why we can't remove the mock of '_check_instance_exists_in_project' | |
| 14:28:04 | mriedem | alex_xu: that would be a question for Kevin_Zheng :) | |