Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-19
21:15:09 dansmith jaypipes: i.e. tests/unit/test_fixtures
21:15:17 dansmith I was going to -1 you for your new untested fixture,
21:15:25 dansmith but it seems that none of the placement fixtures are tested...
21:15:39 jaypipes dansmith: you mean besides the functional API tests that use them?
21:16:19 dansmith jaypipes: yeah, we don't just assume the nova fixtures work because other tests use them...
21:16:41 jaypipes dansmith: ok :)
21:18:05 dansmith jaypipes: I'll defer to mriedem, assuming we're not going to hold you to that here since there aren't tests for the others
21:18:14 dansmith I was just surprised
21:19:07 dansmith jaypipes: I do think we want tests for that normalize helper you pulled out though
21:19:21 jaypipes dansmith: yup, no prob. I can handle that. :)
21:20:05 dansmith jaypipes: I also don't see tests that make sure this doesn't work before microversion 1.8, but I'm not sure if that's convention or not
21:20:10 dansmith I would expect we would just check that we get a 404
21:48:04 mriedem the more i look at this, the more it hurts https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L887-L894
21:48:24 mriedem the note is obviously wrong now, it was added before we tracked neutron preexisting ports https://review.openstack.org/#/c/22610/2/nova/network/quantumv2/api.py
21:49:10 mriedem at this point, isn't what we return going to be all ports for the instance? since created and preexisting is the full set of ports for a given instance, either during server create or interface attach
21:50:20 dansmith heh, yeah because "created_port_ids + preexisting_port_ids"
21:50:34 mriedem or
21:50:42 mriedem https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L982
21:51:01 mriedem preexisting_port_ids might not be "all" preexisting ports for the instance, it might be only the ones in the attach request that aren't new
21:51:21 mriedem so if i create my instance with port A, and then attach B, preexisting_port_ids will have B in it but not A, i think
21:51:23 dansmith all that stuff is crap
21:51:45 mriedem i.e. preexisting_ports_for_the_current_request
21:54:06 openstackgerrit melanie witt proposed openstack/nova master: Add FixedIPList.get_count_by_project() https://review.openstack.org/446246
21:54:07 openstackgerrit melanie witt proposed openstack/nova master: Add FloatingIPList.get_count_by_project() https://review.openstack.org/446247
21:54:07 openstackgerrit melanie witt proposed openstack/nova master: Add get_count_by_vm_state() to InstanceList object https://review.openstack.org/446244
21:54:08 openstackgerrit melanie witt proposed openstack/nova master: Add SecurityGroupList.get_counts() https://review.openstack.org/446245
21:54:08 openstackgerrit melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242
21:54:10 openstackgerrit melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243
21:54:11 openstackgerrit melanie witt proposed openstack/nova master: Count networks to check quota https://review.openstack.org/446241
21:54:13 openstackgerrit melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521
21:54:15 openstackgerrit melanie witt proposed openstack/nova master: Count security groups to check quota https://review.openstack.org/457860
21:54:17 openstackgerrit melanie witt proposed openstack/nova master: Count fixed ips to check quota https://review.openstack.org/457861
21:54:20 openstackgerrit melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945
21:54:22 openstackgerrit melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946
21:54:25 openstackgerrit melanie witt proposed openstack/nova master: Count floating ips to check quota https://review.openstack.org/457862
21:54:38 mriedem i still can't figure out https://bugs.launchpad.net/nova/+bug/1645175 then
21:54:38 openstack Launchpad bug 1645175 in OpenStack Compute (nova) "Neutron port got deleted when attach interface failed" [Medium,In progress] - Assigned to Matt Riedemann (mriedem)
21:55:13 mriedem guess i'm going to need to recreate with devstack and a bunch of table dumps when it happens
21:57:09 openstackgerrit Merged openstack/nova master: placement: produce set of allocation candidates https://review.openstack.org/473377
22:09:07 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix the note at the end of allocate_for_instance https://review.openstack.org/475578
22:09:08 mriedem dansmith: maybe ^ makes more sense; i've been meaning to update that for awhile
22:14:52 mriedem i could be missing something, but i think this actually removes things from the cache which were attached to the instance before a new attach operation
22:15:03 mriedem which would be...bad
22:19:00 openstackgerrit Merged openstack/nova master: Handle uuid in HostAPI.compute_node_get https://review.openstack.org/461532
22:39:14 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/475563
22:47:07 mriedem we shall see https://review.openstack.org/475596
22:54:39 openstackgerrit Jay Pipes proposed openstack/nova master: placement: support GET /allocation_candidates https://review.openstack.org/475448
22:54:40 openstackgerrit Jay Pipes proposed openstack/nova master: placement: separate normalize_resources_qs_param https://review.openstack.org/475599
22:54:40 openstackgerrit Jay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates https://review.openstack.org/475600
22:54:46 jaypipes dansmith: ^
#openstack-nova - 2017-06-20
00:35:26 openstackgerrit Merged openstack/nova master: api-ref: cleanup PUT /os-hypervisors/statistics docs https://review.openstack.org/474250
00:45:24 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938
00:48:17 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add api-ref for os-quota-class-set APIs https://review.openstack.org/467938
00:59:17 alex_xu mriedem: sorry, I commented at wrong place. We can implement that check in the python code.
02:16:14 Kevin_Zheng ping mriedem
02:44:34 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix to return server groups quota in quota class set https://review.openstack.org/467999
02:50:15 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix to return server groups quota in quota class set https://review.openstack.org/467999
03:12:33 openstackgerrit Moshe Levi proposed openstack/os-vif master: hardware offload support for openvswitch https://review.openstack.org/460278
03:18:52 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Don't delete neutron port when attach failed https://review.openstack.org/403568
04:00:34 gmann alex_xu, oomichi updated quota class fix, check now - https://review.openstack.org/#/c/467999/
04:05:03 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add missing parameters in limits.inc https://review.openstack.org/475640
04:12:11 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/475563
04:43:11 alex_xu gmann: cool, will try to reach it asap
04:43:22 gmann alex_xu, thanks
04:43:32 alex_xu gmann: np, thanks for the patch also
07:10:17 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Don't delete neutron port when attach failed https://review.openstack.org/403568
07:17:30 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix to return server groups quota in quota class set https://review.openstack.org/467999
08:06:47 ralonsoh Hello fellow reviewers, can I take your attention to https://review.openstack.org/#/c/449257/?
08:07:17 ralonsoh The spec was merged months ago, but I still have two out of four patches pending for reviews
08:07:27 ralonsoh thanks in advance
08:55:21 openstackgerrit Gábor Antal proposed openstack/nova master: Transform instance.soft_delete notifications https://review.openstack.org/460029
09:07:20 openstackgerrit Gábor Antal proposed openstack/nova master: Transform instance.soft_delete notifications https://review.openstack.org/460029
09:08:36 gabor_antal sfinucan, bauzas: would you please give back +2s on my patchset https://review.openstack.org/460029 ? I had to modify the json because https://review.openstack.org/#/c/451789/ was merged a few days ago.
09:15:20 openstackgerrit Merged openstack/nova master: Provide error message in MismatchError for api-samples tests https://review.openstack.org/475489
09:22:24 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Fix to return server groups quota in quota class set https://review.openstack.org/467999
09:30:53 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Add datapath type information to OVS vif objects https://review.openstack.org/474892
09:34:53 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for RP traits https://review.openstack.org/474550
09:39:26 gabor_antal sfinucan: thanks!
09:41:25 openstackgerrit Andrey Volkov proposed openstack/nova master: Add ability to view quota details for project owner https://review.openstack.org/386008
09:44:00 openstackgerrit Gábor Antal proposed openstack/nova master: Transform instance.resize_prep notification https://review.openstack.org/465081
09:56:09 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/os-vif master: Read datapath_type from VIF object https://review.openstack.org/474914
10:13:34 openstackgerrit Moshe Levi proposed openstack/os-vif master: hardware offload support for openvswitch https://review.openstack.org/460278
10:47:48 openstackgerrit Merged openstack/nova master: Consolidate index and detail methods in HypervisorsController https://review.openstack.org/475458
11:10:48 openstackgerrit Gábor Antal proposed openstack/nova master: Transform aggregate.update_prop notification https://review.openstack.org/462576
11:16:37 openstackgerrit Béla Vancsics proposed openstack/nova master: Transform aggregate.update_metadata notification https://review.openstack.org/460625
11:25:30 boolman Hi guys, I'm having trouble with a new deployment.. I'm using juju to deploy ocata. and I seem to have issues with my compute-nodes/placement API, http://ix.io/xHP http://ix.io/xHO
11:27:42 openstackgerrit Béla Vancsics proposed openstack/nova master: Use more specific asserts in tests https://review.openstack.org/466609
11:49:04 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/475563
11:53:30 openstackgerrit Moshe Levi proposed openstack/os-vif master: hardware offload support for openvswitch https://review.openstack.org/460278
11:56:37 openstackgerrit Gábor Antal proposed openstack/nova master: Transform instance.rebuild_scheduled notification https://review.openstack.org/473929
12:30:46 openstackgerrit Jay Pipes proposed openstack/nova master: placement: separate normalize_resources_qs_param https://review.openstack.org/475599
12:30:47 openstackgerrit Jay Pipes proposed openstack/nova master: placement: support GET /allocation_candidates https://review.openstack.org/475448
12:30:47 openstackgerrit Jay Pipes proposed openstack/nova master: placement: scheduler uses allocation candidates https://review.openstack.org/475600
12:36:28 bhagyashris boolman: Hi, you can make sure that the [placement] section is there in the /etc/nova/nova.conf if its not then you should add this and restart the nova compute service.
12:40:08 mriedem sdague: when you get some time, can you go through the bottom set of +2ed changes in melwitt's quotas series? starts here: https://review.openstack.org/#/c/446241/ - they are mostly mechanical conversions from old style to new style quota checks.
12:40:08 sfinucan moshele, jaypipes: Am I missing something with https://review.openstack.org/#/c/460278/?
12:40:11 rfolco jaypipes, could you please review https://review.openstack.org/#/c/460147/ ?
12:40:38 sfinucan fwict, you have nested try-excepts for the same exception. Surely there's no reason for that and the whole thing could be flattened?
12:41:09 sfinucan ...but I can't seem to get that point across in Gerrit, unfortunately :)
12:41:54 sdague mriedem: yeh, probably an hour from now

Earlier   Later