Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-08
20:08:16 mriedem else i'm going to defer it to queens
20:13:12 mriedem gdi, you know what's awesome,
20:13:31 mriedem overriding a method and tests start failing, you spend too much time trying to figure out why,
20:13:43 mriedem and realize you're not returning the results of the method you're now delegating too
20:13:45 mriedem *to
20:18:10 openstackgerrit Maciej Kucia proposed openstack/nova master: libvirt: Extract method _guest_add_spice_channel https://review.openstack.org/470787
20:18:11 openstackgerrit Maciej Kucia proposed openstack/nova master: libvirt: Extract method _guest_add_video_device https://review.openstack.org/470783
20:18:11 openstackgerrit Maciej Kucia proposed openstack/nova master: libvirt: Extract method _guest_add_memory_balloon https://review.openstack.org/470786
20:18:12 openstackgerrit Maciej Kucia proposed openstack/nova master: libvirt: Extract method _guest_add_watchdog_action https://review.openstack.org/470785
20:18:12 openstackgerrit Maciej Kucia proposed openstack/nova master: libvirt: Extract method _guest_add_pci_devices https://review.openstack.org/470784
20:18:56 melwitt does anyone know if it matter whether you give a sqlalchemy in_() call a list or a set? is there any benefit in a set vs a list?
20:19:01 melwitt *matters
20:25:39 bauzas melwitt: AFAIK, it just needs a container
20:26:33 bauzas ie. anything having an __in__
20:26:45 melwitt bauzas: yeah, I know it accepts list, tuple, set. I was just curious if there was a benefit of any over others. I didn't see anything when I googled so far
20:27:15 dansmith isn't it generating a text query?
20:27:22 dansmith such that you need iter() not __in__ ?
20:27:37 dansmith in that case, I can't imagine it would matter, other than that a set avoids potential dupes
20:28:01 bauzas mmmm, http://docs.sqlalchemy.org/en/latest/core/sqlelement.html#sqlalchemy.sql.operators.ColumnOperators.in_
20:28:09 melwitt yeah, that would make sense why there no mention about it mattering
20:28:14 bauzas it just says lists and tuples
20:28:18 melwitt *there's. guh, I can't type today
20:28:39 bauzas honestly, I think it's not a big deal
20:28:58 melwitt I assumed it's not a big deal, I was just curious about it
20:30:05 bauzas melwitt: if it accepts sets, then cool, as dansmith said
20:30:30 melwitt I know. I know what it accepts. I was curious how it worked and decided to ask if anyone happened to know
20:30:32 bauzas for dupes I mean
20:31:50 bauzas unrelated, could someone tell me the cases where when we have a live-migration, the instance can be shutoff ?
20:32:29 bauzas AFAIK, when it's timing out, it's not shut the instance off, right?
20:35:37 dansmith bauzas: afaik live migration only works on a running instance, and if you want to live migrate it you need to start it paused to do so
20:36:41 openstackgerrit Dan Smith proposed openstack/nova master: Fix lookup of instance mapping in metadata set-password https://review.openstack.org/472405
20:37:04 bauzas dansmith: sorry, the question is about the output of a live-migration
20:37:29 bauzas dansmith: I'm trying to understand https://bugs.launchpad.net/nova/+bug/1696025
20:37:29 openstack Launchpad bug 1696025 in OpenStack Compute (nova) "live-migration sometimes failed" [Undecided,New]
20:37:35 bauzas but I'll ask for more details
20:44:18 openstackgerrit Merged openstack/nova master: Add PCIWeigher https://review.openstack.org/379524
20:46:51 openstackgerrit Steve Noyes proposed openstack/nova master: WIP: update live migration to use v3 cinder api https://review.openstack.org/463987
20:56:43 melwitt this is weird, api sample test fail because of the v2.1 in the url? http://logs.openstack.org/59/457859/17/check/gate-nova-tox-functional-py35-ubuntu-xenial/6e6bd37/testr_results.html.gz
20:57:09 mriedem dansmith: you can live migrate a paused instance
20:57:15 mriedem we have a tempest test for it
20:57:37 dansmith mriedem: right
20:58:08 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Handle uuids in os-hypervisors API https://review.openstack.org/471899
20:58:55 sdague melwitt: that actually looks like the template didn't fill for some reason
20:59:42 melwitt sdague: oh, I see. so it shouldn't be showing the placeholders
20:59:57 sdague no, or they should match
21:00:05 openstackgerrit Corey Bryant proposed openstack/nova master: Pass CLI options to nova-placement-api https://review.openstack.org/472378
21:00:10 mriedem meeting time
21:00:44 melwitt yeah. everything looks to match, except possibly the "v2.1" part. but that parameter is called "versioned_compute_endpoint" so it seems like it would encompass the v2.1
21:02:31 openstackgerrit melanie witt proposed openstack/nova master: Add FixedIPList.get_count_by_project() https://review.openstack.org/446246
21:02:31 openstackgerrit melanie witt proposed openstack/nova master: Add FloatingIPList.get_count_by_project() https://review.openstack.org/446247
21:02:32 openstackgerrit melanie witt proposed openstack/nova master: Add get_count_by_vm_state() to InstanceList object https://review.openstack.org/446244
21:02:32 openstackgerrit melanie witt proposed openstack/nova master: Add SecurityGroupList.get_counts() https://review.openstack.org/446245
21:02:33 openstackgerrit melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242
21:02:35 openstackgerrit melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243
21:02:37 openstackgerrit melanie witt proposed openstack/nova master: Count networks to check quota https://review.openstack.org/446241
21:02:39 openstackgerrit melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521
21:02:41 openstackgerrit melanie witt proposed openstack/nova master: Add InstanceGroup._remove_members_in_db https://review.openstack.org/457858
21:02:44 openstackgerrit melanie witt proposed openstack/nova master: Count server group members to check quota https://review.openstack.org/457859
21:02:49 openstackgerrit melanie witt proposed openstack/nova master: Count security groups to check quota https://review.openstack.org/457860
21:02:55 openstackgerrit melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945
21:02:57 openstackgerrit melanie witt proposed openstack/nova master: Count fixed ips to check quota https://review.openstack.org/457861
21:02:59 openstackgerrit melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946
21:03:01 openstackgerrit melanie witt proposed openstack/nova master: Count floating ips to check quota https://review.openstack.org/457862
21:03:35 openstackgerrit Balazs Gibizer proposed openstack/nova master: Transform instance.live_migration_rollback notification https://review.openstack.org/402124
21:04:56 openstackgerrit Balazs Gibizer proposed openstack/nova master: Transform instance.soft_delete notifications https://review.openstack.org/460029
21:06:31 bauzas cdent: you could be interested in https://bugs.launchpad.net/nova/+bug/1696830
21:06:31 openstack Launchpad bug 1696830 in OpenStack Compute (nova) "nova-placement-api default config files is too strict" [Low,In progress] - Assigned to Corey Bryant (corey.bryant)
21:07:08 bauzas cdent: I'm honestly not opiniated but given oslo.config supports this, placement should accept that too
21:07:55 cdent bauzas: I don't have much of an opinion either. sdague wrote that code if I remember right.
21:08:46 cdent hmm, not clear on how that fix will work
21:17:14 bauzas cdent: seems like the patch is not fully done yet
21:17:27 bauzas cdent: just pointed you the bug report rather
21:17:42 openstackgerrit Merged openstack/nova master: Add get_minimum_version_all_cells() helper for service https://review.openstack.org/471431
21:18:40 openstackgerrit Merged openstack/nova master: Fix device metadata service version check for multiple cells https://review.openstack.org/471432
21:19:42 openstackgerrit Merged openstack/nova master: Move rebuild notification tests into separate method https://review.openstack.org/451789
21:29:04 efried Can anyone explain why e.g. https://review.openstack.org/#/c/471796/ is showing a merge conflict?
21:29:15 efried It appears to be right at the tip of the newton branch.
21:29:56 bauzas efried: I need to rebase it
21:30:13 efried bauzas I tried that. It's already where it should be, as far as I can tell.
21:30:39 efried There are several like this.
21:31:24 bauzas efried: lemme test again
21:32:38 mikal The CI system was telling lies yesterday
21:33:21 mriedem yes it was
21:33:26 efried Yeah, but how do we get it to straighten up?
21:33:30 bauzas mikal: mmm, so recheck then ?
21:34:23 mriedem efried: just needs a recheck
21:34:25 mriedem which i just did
21:34:33 efried k, cool
21:34:49 bauzas just did too
21:34:57 mriedem NOOOOOOO
21:34:59 mriedem double recheck
21:35:03 mriedem sends it to the black hole
21:35:14 bauzas recheck recheck recheck
21:35:28 bauzas (candyman)
21:36:07 jgriffith mriedem FYI, it appears that cinder-migrate is broken anyway and would seem that it has been for some time now.
21:36:45 mriedem jgriffith: great
21:36:59 mriedem jgriffith: not sure if scottda's tempest changes to test retype in a multinode job ever landed
21:37:03 mriedem but he was working on that
21:37:22 jgriffith mriedem not sure.. but anyway, I started on this: https://docs.google.com/document/d/10IfIeZ4luPbPOd2oi57FByQ5ByN223KN4j81EskOIM0/edit#
21:37:25 jgriffith ildikov ^^

Earlier   Later