Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-08
14:25:30 bauzas well, take an object, pass it as an argument to a remote method, you won't get the same object at the end
14:29:52 sfinucan hmm, well I'm going to try something to see if it makes sense
14:30:01 sfinucan it might not, but then I'll know :)
14:31:19 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285
14:31:20 openstackgerrit Matt Riedemann proposed openstack/nova master: Skip microversion discovery check for update/delete volume attachments https://review.openstack.org/469668
14:31:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Use 3.27 microversion when creating new style volume attachments https://review.openstack.org/469609
14:31:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Use microversions for new style volume attachments https://review.openstack.org/469579
14:31:44 mriedem sdague: could you add the bottom 3 changes here to your review queue? ^
14:31:50 mriedem the new cinder stuff depends on that
14:33:03 sdague yeh, can do
14:33:21 sdague it will be a minute, in the middle of unrelated stuff
14:34:24 mriedem sure, thanks
14:34:44 mriedem dansmith: looks like your devstack fleet week patch needs to depend on the check min service version in all cells patch
14:34:51 mriedem http://logs.openstack.org/94/436094/32/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/0d3a7e2/console.html#_2017-06-08_13_33_37_461957
14:34:54 mriedem i think...
14:38:03 bauzas sfinucan: the consensus is basically about providing a general __eq__ rule
14:38:18 bauzas sfinucan: semantically, the equivalence really depends on the object type
14:38:39 bauzas sfinucan: like for example, you could assume some fields are irrelevant for that
14:38:43 sfinucan Yeah, that sounds fair. It does seem pretty contextual
14:39:21 bauzas the same goes with __hash__
14:39:45 bauzas since objects can be very different, we try hard to not define __hash__ on a global basis
14:40:50 bauzas sfinucan: that said, you know we have an obj_equal_prims() right?
14:41:22 sfinucan bauzas: I've just spotted that, alright
14:41:41 bauzas cool
14:41:58 bauzas that's the only thing we can really do on a general basis
14:42:05 bauzas if primitives are equal, fine
14:42:29 bauzas but standing that obj_1 == obj_2 is a total different deal
14:42:47 bauzas same goes for obj1 in an objectlist
14:46:34 dansmith mriedem: aye, not sure why I wasn't hitting that before
14:47:14 mriedem dansmith: i think the test was recently-ish merged
14:47:22 mriedem well,
14:47:23 dansmith ah
14:47:36 mriedem and it required the ssh validation stuff being turned on, which happened globally about 2 weeks ago
14:47:50 dansmith mriedem: thanks for fixing the bottom patch, I just realized I needed to get back to it
14:48:10 dansmith is the merge conflict because of all the infra drama yesterday?
14:48:17 mriedem yes, i've rechecked
14:48:25 mriedem well, i assume it is, i haven't tried rebasing
14:48:26 dansmith cool
14:48:39 dansmith it's running it so I think it must've been
14:48:42 dansmith otherwise it'd kick right out
14:49:29 cfriesen kashyap: I haven't, one of our people might have and I'm pinging for confirmation. We're just going GA with Newton though, so we're not exactly bleeding edge.
14:52:40 johnthetubaguy mriedem: was just taking a peak at the cinder patches (https://review.openstack.org/#/c/469668/3)
14:53:02 johnthetubaguy mriedem: any reason not to cache the availablity of a microversion, once we find its available?
14:54:53 cfriesen johnthetubaguy: couldn't they reboot the cinder service at any time?
14:55:11 cfriesen johnthetubaguy: or are you expecting monotonic increases
14:55:21 johnthetubaguy cfriesen: yeah, but we don't really support downgrades
14:55:40 johnthetubaguy cfriesen: your right in general though, just wondering if we can be simpler
14:56:14 johnthetubaguy actually, yeah, downgrading past this point just isn't going to work, as far as I understand it
14:58:35 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Add NovaComparableObject mixin https://review.openstack.org/472285
14:59:04 sfinucan bauzas, dansmith: What about that? ^
14:59:06 mriedem johnthetubaguy: replied inline
14:59:18 sfinucan johnthetubaguy: Oh hai
14:59:18 mriedem johnthetubaguy: in general because caching of versions gets complicated
14:59:32 mriedem especially when nova as the client might need to request multiple different versions based on which operation we're doing
14:59:42 mriedem like if we need 3.27 today for something but 3.33 tomorrow for something else
14:59:55 dansmith sfinucan: why not use equal_prims for that?
14:59:56 mriedem johnthetubaguy: for now i'm just keeping it simple
15:00:10 dansmith sfinucan: more "is this equal" helpers seems bad to me
15:00:16 johnthetubaguy mriedem: I was thinking caching was simpler, but you are right
15:00:26 mriedem it's simple in the simple case :)
15:00:29 johnthetubaguy mriedem: what you have is clearly correct
15:00:51 sfinucan dansmith: I was hoping you'd tell me :) I'm not confident enough in that code to say they're interchangeable
15:00:57 sfinucan If they are, I can take that route
15:01:07 mriedem johnthetubaguy: when talking about this last week, mordred was also saying that at some point i think ksa can provide this info, so we don't need the extra call to cinder
15:01:11 mriedem to get the version doc
15:01:15 mriedem ksa would just provide it
15:01:35 sfinucan (by "that code", I mean "all things object'y")
15:01:47 johnthetubaguy mriedem: good point, he is cooking things in that area, they can do the caching
15:01:49 mriedem johnthetubaguy: i.e. when we get the ksa session (which is cached...)
15:01:51 dansmith sfinucan: I'm saying if you want to have a mixin that implements __eq__, use the existing equal_prims thing to determine equality in your handler, don't define another one
15:02:08 mriedem johnthetubaguy: but thanks for reviewing, and welcome back
15:02:53 mordred mriedem: yes
15:02:56 mordred mriedem: this is correct
15:07:23 openstackgerrit Rick Bartra proposed openstack/nova master: Add policy granularity to the Flavors API https://review.openstack.org/449288
15:10:13 openstackgerrit Chris Friesen proposed openstack/python-novaclient master: 2.47: Show flavor info in server details https://review.openstack.org/435141
15:10:24 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Add NovaComparableObject mixin https://review.openstack.org/472285
15:10:28 mordred johnthetubaguy, mriedem: the ksa patches for all of this are under review, so hopefully should be able to take legit forward aciton in the next couple of weeks
15:10:30 sfinucan dansmith: Like that?
15:12:40 openstackgerrit Matt Riedemann proposed openstack/nova master: Add docstring for test_limit_check_project_and_user_zero_values https://review.openstack.org/472287
15:12:53 mriedem cdent: bauzas: melwitt: ^
15:16:23 cfriesen kashyap: apparently we have booted UEFI on Newton by specifying ‘--property hw_firmware_type=uefi” on the image and then booting as normal.
15:16:36 kashyap cfriesen: Thank you for confirming
15:16:45 kashyap cfriesen: I just checked with Fedora 25, and current Nova Git
15:17:01 kashyap cfriesen: I thought the Q35 machine type was _mandatory_ for OVMF
15:17:37 kashyap But, apparently it worked even with stock F25; which was QEMU 2.7 or something
15:19:09 cfriesen kashyap: we're using CentOS 7's qemu-kvm-ev-2.6.0-28.el7_3.9.1, so who knows what all they've done. :)
15:19:39 openstackgerrit sean mooney proposed openstack/os-vif master: set mtu on all code paths https://review.openstack.org/469951
15:20:13 mnaser stable/newton is broken with the new release of oslo.db that drops sqlite_db (it was removed in stable/ocata and beyond but not in stable/newton apparently): https://review.openstack.org/#/c/472290/
15:20:25 mnaser not sure why a notification didn't pop up here but if a small eye could be kept on that :)
15:20:39 kashyap cfriesen: Heh
15:21:49 mriedem mnaser: i'm not sure why something dropped in ocata would break newton,
15:21:55 mriedem since we should be using upper-constraints
15:22:55 mnaser mriedem: maybe it was my mistake, but pretty much i did a pip install from the stable/newton repo and there doesn't seem to be a limit for oslo.db in requirements.txt
15:23:11 mnaser so it downloaded the latest version of the library which has this commit from a few days ago => https://github.com/openstack/oslo.db/commit/cc64f7010522e812a696159009a72e59e2b017a8
15:23:16 mriedem mnaser: it'd be in tox.ini
15:23:43 mnaser mriedem ok i see it
15:23:56 mriedem mnaser: yeah that's 4.19.0, but we're not using that in newton https://github.com/openstack/requirements/blob/stable/newton/upper-constraints.txt#L215
15:24:15 mriedem https://github.com/openstack/nova/blob/stable/newton/tox.ini#L12 should have you covered
15:24:23 mnaser mriedem: sorry about that then, should i abandon that patch in that case?
15:24:46 openstackgerrit Alex Szarka proposed openstack/nova master: Refactor create_delete_server_with_instance_update https://review.openstack.org/466296

Earlier   Later