Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-07
15:23:47 mriedem help-wise
15:24:02 dansmith landfill?
15:24:15 mriedem tire fire
15:24:54 jaypipes mriedem: there's way too many Nova config options for libvirt live migration because there's way too many configuration options for libvirt live migration. period...
15:25:52 mriedem the heart wants what it wants jay
15:25:58 mriedem and it wants mfing config options
15:26:10 kashyap The Nova time-outs and re-tries seemed to be the ones that can be removed?
15:26:25 gbarros mriedem I see that you +2 mhenkel's vif patch. Could you take a peek at the blueprint also pls?
15:26:40 gbarros mriedem https://blueprints.launchpad.net/nova/+spec/opencontrail-nova-vif-plugin
15:26:42 kashyap Err, before someone jumps on me, "removed" as in ... "can they be reconsiderd"
15:27:47 mriedem gbarros: as in approve the bp?
15:27:51 mriedem btw, -2 on the stable/ocata backport
15:27:56 mriedem we don't backport features
15:28:20 gbarros mriedem, on the bp, if it looks ok to you.
15:28:38 gbarros mriedem, ack on -2 for the backport. It was worth a shot :)
15:29:27 openstackgerrit Baodong (Robert) Li proposed openstack/nova-specs master: Expose vlan trunking in metadata/configdrive https://review.openstack.org/471815
15:29:57 gbarros mriedem, on the backport I'm mostly wanting to see if it will pass CI.
15:30:06 jaypipes kashyap: if there was a stable and consistently-converging live-migration interface in libvirt, those options wouldn't be needed. :)
15:30:09 mriedem gbarros: approved the bp, i forgot about that one
15:30:14 gbarros mriedem ty!
15:30:20 cdent jaypipes: i'm a bit confused and concerned about your lack of concern on the conusmer uuid thing, especially if the fix is doing and update or insert instead of what's there now?
15:30:24 kashyap jaypipes: Nod...
15:30:36 mriedem gbarros: mhenkel: now you just need to get jaypipes to review the chnage
15:30:37 jaypipes cdent: I'm not concerned *for that patch*.
15:30:38 mriedem *change
15:31:01 jaypipes cdent: nobody other than Nova is yet writing allocations. we can add a patch in the future to handle that situation.
15:31:14 kashyap jaypipes: I also wonder if this can be elided - 'live_migration_inbound_addr'
15:31:28 jaypipes cdent: I don't want to hold things up endlessly trying to figure out the perfect solution for everything in the future, that's all.
15:31:51 jaypipes cdent: especially since we're running out of time quickly for Pike.
15:33:09 cdent jaypipes: agreed it would be nice to get this done, but this doesn't need a perfect solution, it just needs normal SQL...
15:33:57 cdent I think the code has a bug. Not an architecture confusion (like over in the how to deal with complex allocations thread). Those are different types of concerns.
15:34:07 gbarros jaypipes, at your convenience :) https://review.openstack.org/#/c/441183/
15:34:31 jaypipes cdent: would you mind taking a looksie at melwitt's https://review.openstack.org/#/c/469634/10 test failure on _test_sync_traits()?
15:35:01 jaypipes cdent: why can't this be done in a patch after the one in question?
15:35:25 cdent jaypipes: we fixed that late last night with: https://review.openstack.org/#/c/471508/
15:35:55 openstackgerrit Gábor Antal proposed openstack/nova master: Move rebuild notification tests into separate method https://review.openstack.org/451789
15:35:56 cdent jaypipes: we can, that would be fine, but we have to agree to do so
15:37:27 gabor_antal sfinucan, oomichi: Would you please give back +2 on https://review.openstack.org/#/c/451789 ? I had to rebase it manually.
15:37:29 jaypipes cdent: I agree to do so. :)
15:37:38 jaypipes cdent: ok, cool (on the testsync traits thing)
15:38:11 cdent awesome, thanks jaypipes, that's more than I hoped for
15:38:19 jaypipes gbarros: you know what would make reviewing that easier? more than 0 lines of documentation on the opencontrail vif plugin repo :)
15:38:57 gbarros jaypipes, tell me about it :) mhenkel keeps telling me it's fully documented... somewhere... :)
15:40:05 gbarros mhenkel, could you help us out by pointing out the docs? Maybe a link to it in the readme?
15:40:21 jaypipes mriedem, gbarros: I thought I remembered some conversation where we wanted to make "vhostuser_vrouter_plug" mention contrail specifically before we merged this patch?
15:40:52 jaypipes gbarros: or is vhostuser_vrouter_plug already in the Neutron vif details and we can't change it?
15:40:58 mriedem jaypipes: the latter
15:41:07 mriedem see my question about that in the 2nd to last patch set
15:41:16 mriedem their plugin now registers with contrail in the name,
15:41:21 gbarros jaypipes, I believe there is a TODO on that?
15:41:22 mriedem but the vif details thing is already baked into neutron
15:41:23 openstackgerrit Merged openstack/nova master: Revert "Remove Babel from requirements.txt" https://review.openstack.org/471498
15:41:26 mriedem yeah i added the todo
15:42:05 jaypipes gbarros: yeah, totes, there's a TODO, was just seeing if I remembered reading a discussion about it correctly :)
15:42:25 jaypipes gbarros: I'm getting old and can't remember all the things.
15:43:40 gbarros jaypipes, you're ahead of me there, I could never remember all the things.
15:45:38 jaypipes mhenkel, gbarros: +W'd.
15:45:45 mriedem i don't understand this https://github.com/openstack/nova/blob/7815108d4892525b0047c787cbd2fe2f26c204c2/nova/virt/libvirt/driver.py#L568
15:45:51 mriedem live_migration_tunneled is a boolean
15:45:53 mriedem so why would it be None?
15:46:04 mriedem if Falsey or True
15:46:06 mriedem god
15:46:30 jaypipes mriedem: the default before the option came into existence?
15:46:37 mriedem it might have been a string
15:46:44 mriedem that's my guess, so i'm checking history
15:47:00 jaypipes ya
15:47:47 mriedem nope it was always boolean https://github.com/openstack/nova/commit/621594fc41d0e07fd63dfe7c3c5cfee9edc380ad#diff-f4019782d93a196a0d026479e6aa61b1R171
15:48:07 mriedem oh but not default
15:48:47 gbarros ty jaypipes
15:49:33 jaypipes mriedem: right.
15:50:18 jaypipes mriedem: True, False, None. The unholy Triumvirate.
15:50:31 openstackgerrit Merged openstack/nova master: Fix cell0 naming when QS params on the connection https://review.openstack.org/471487
15:52:37 openstackgerrit Baodong (Robert) Li proposed openstack/nova-specs master: Expose vlan trunking in metadata/configdrive https://review.openstack.org/471815
15:53:41 gbarros jaypipes to it's a trool type instead of bool? (dad joke...)
15:54:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Cleanup the plethora of libvirt live migration options https://review.openstack.org/471834
15:54:51 mriedem it's a flaming bag of pug manure
15:54:54 jaypipes gbarros: :) yes indeed.
15:55:16 jaypipes mriedem: hey now, that is a step too far sir!
15:55:42 mriedem i shouldn't sully pug manure by relating it to live_migration_tunneled?
15:56:07 gbarros ha
15:56:54 jaypipes mriedem: correct.
15:57:28 jaypipes mriedem: lest I would have to resort to a comment about human babies.
15:57:52 mriedem jaypipes: if you want to talk about baby feces i'm game
15:57:59 mriedem let's bring comstud into this as well
15:58:05 jaypipes mriedem: good god no.
15:58:20 dansmith what is the deal with this traits fail? http://logs.openstack.org/34/469634/10/check/gate-nova-tox-functional-ubuntu-xenial/a007f54/testr_results.html.gz
15:58:37 dansmith doesn't look related, but it seems like a thing that would be 100% fail
15:58:45 dansmith maybe something we hit yesterday and have since resolved?
15:59:08 cdent dansmith: rebase, it's been fixed:
15:59:29 cdent https://review.openstack.org/#/c/471508/
15:59:32 dansmith okay, so it needs a rebase to pass?
15:59:36 dansmith cdent: ^
16:00:21 mriedem it's not 100% fail so you could recheck
16:00:28 openstackgerrit Dan Smith proposed openstack/nova master: placement: use separate tables for projects/users https://review.openstack.org/470645
16:00:59 openstackgerrit Dan Smith proposed openstack/nova master: placement project_id, user_id in PUT /allocations https://review.openstack.org/469634
16:02:02 dansmith really, seems like it would be
16:02:04 dansmith either way, rebased
16:03:58 openstackgerrit Merged openstack/nova master: Send request_id on neutron calls https://review.openstack.org/468356
16:06:44 openstackgerrit Merged openstack/nova master: Send out notifications when instance tags changed https://review.openstack.org/459923
16:13:15 cfriesen_ mriedem: regarding your live migration uri stuff...don't we have another issue too? we pass the unmodified "migrate_uri" to guest.migrate(), and that gets written to the 'migrate_uri' parameter that gets passed to self._domain.migrateToURI3()

Earlier   Later