| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-06-06 | |||
| 21:41:46 | zzzeek | bauzas: repr() will hide the password but str() should be fine... | |
| 21:44:39 | melwitt | zzzeek: we tried that and it didn't work because it was percent-encoding colon and forward slash that were in the database connection url | |
| 21:48:00 | zzzeek | melwitt: can you show me this URL | |
| 21:48:25 | bauzas | zzzeek: eg. 'mysql+pymysql://test:abcd0123%AB@controller/nova' | |
| 21:49:00 | melwitt | zzzeek: it was in the review I linked but here ya go: reference = 'mysql+pymysql://nova:abcd0123@AB@controller/nova_cell0' actual = u'mysql+pymysql://nova:abcd0123%40AB@controller/nova_cell0' | |
| 21:49:16 | melwitt | that's one example | |
| 21:49:47 | melwitt | it changed the @ in the password to %40 | |
| 21:51:06 | bauzas | FWIW, I'm tempted to just rindex() where I can find the DB and just join what's before and after | |
| 21:51:27 | melwitt | bauzas: yeah, that's what I pasted earlier | |
| 21:51:38 | zzzeek | bauzas / melwitt OK so that first URL does go back and forth between URL / string symetrically: http://paste.openstack.org/show/611562/ however, it's not as easy to put inside a file b.c. the character is not ASCII | |
| 21:52:13 | zzzeek | a function that returns an ASCII escaped form of a SQLA URL is defintely a good function to have, in oslo.db to start and SQLA can have it too | |
| 21:53:13 | zzzeek | ah ok %40, let's try that | |
| 21:53:19 | bauzas | zzzeek: right, that's the problem we have | |
| 21:53:39 | bauzas | or we could assume it's a non-problem ? | |
| 21:54:21 | zzzeek | bauzas: well the @ sign has to be %40 because @ is syntactically part of the URL | |
| 21:54:23 | zzzeek | >>> str(u) | |
| 21:54:23 | zzzeek | >>> u = url.make_url('mysql+pymysql://test:abcd0123%40AB@controller/nova') | |
| 21:54:23 | zzzeek | 'mysql+pymysql://test:abcd0123%40AB@controller/nova' | |
| 21:54:43 | zzzeek | if we are talking about @ sign, that has to be %40 in all str representations | |
| 21:54:53 | bauzas | right | |
| 21:54:55 | zzzeek | >>> u.password | |
| 21:54:56 | zzzeek | 'abcd0123@AB' | |
| 21:55:11 | zzzeek | that works symettrically, you can put it in a conf file no problem | |
| 21:56:32 | melwitt | hmm | |
| 21:56:59 | openstackgerrit | Merged openstack/nova master: Remove Babel from requirements.txt https://review.openstack.org/468350 | |
| 21:57:16 | bauzas | that's what I wondered when I stated this a potential non-problem | |
| 21:57:24 | melwitt | yeah, so I guess to the actual database it will work fine but the user would see their password look different in the conf file after we muck with it | |
| 21:57:44 | bauzas | melwitt: we're not updating the file, right? | |
| 21:58:05 | bauzas | melwitt: it's just the connection string that is in the DB that would differ from what the operator provided | |
| 21:58:39 | bauzas | which couldn't be a problem if the service is able to connect thru the given creds even if they are not ASCII-shown | |
| 21:58:44 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Revert "Remove Babel from requirements.txt" https://review.openstack.org/471498 | |
| 21:58:50 | mriedem | sdague: ^ | |
| 21:58:56 | mriedem | babel isn't used in code, it's used in config | |
| 21:59:47 | mriedem | sfinucan: ^ also fyi | |
| 22:04:01 | bauzas | zzzeek: so, just to clarify, the fact that the operator uses special chars like in passwords isn't messed up if we URL-encode those ? | |
| 22:04:41 | zzzeek | bauzas: special chars in the password can all be represented as %XX when they are passed in | |
| 22:14:06 | bauzas | mriedem: still around ? | |
| 22:14:21 | mriedem | depends | |
| 22:14:37 | bauzas | saw the above? | |
| 22:14:43 | mriedem | i didn't follow it no | |
| 22:15:27 | bauzas | the fact that stringifying the URL object makes it RFC1738 compatible doesn't necessarly mean it messes up the connection string | |
| 22:25:44 | melwitt | it doesn't mess it up as far as, it should still work for connecting to the database, but it could store a url different than the user has in their conf file for the nova DB. that is, the password will be percent-encoded for cell0, and they could see the difference when listing cells, if listing cells is possible | |
| 22:26:46 | mriedem | listing cells is possible | |
| 22:26:52 | mriedem | nova-manage cell_v2 list_cells --verbose | |
| 22:27:00 | mriedem | dumps the cells and --verbose dumps the db connection and transport url | |
| 22:28:24 | bauzas | okay, it's becoming late to me | |
| 22:29:24 | bauzas | if we really want to have the string as close as possible with the original opt value, then I only see something like rindex or rsplit helping us | |
| 22:31:12 | bauzas | or we could construct from the URL object by getting the original username and password | |
| 22:31:19 | bauzas | melwitt: mriedem: ^ | |
| 22:31:50 | melwitt | yeah, that's what we were saying earlier. either the rreplace() equivalent or a frankenurl | |
| 22:32:32 | mriedem | ahem, that'll be $.05 please | |
| 22:32:46 | bauzas | frankenurl ? :) | |
| 22:33:21 | melwitt | the frankenurl seems more correct, if there's not danger of leaving something out while we're constructing it | |
| 22:33:53 | melwitt | collecting royalties in perpetuity | |
| 22:36:17 | mriedem | i'd think we could plug the bits into some urlparse method to generate a url and then stringify it | |
| 22:36:27 | mriedem | but i haven't looked of course | |
| 22:37:45 | mriedem | eff we have some functional test race issue now | |
| 22:37:46 | mriedem | gdi | |
| 22:37:46 | mriedem | http://logs.openstack.org/98/471498/1/check/gate-nova-tox-functional-ubuntu-xenial/c84dfef/console.html#_2017-06-06_22_23_07_594859 | |
| 22:37:56 | mriedem | cdent: ^ while you're still burning the oil :) | |
| 22:38:57 | mriedem | https://bugs.launchpad.net/nova/+bug/1696267 | |
| 22:38:57 | openstack | Launchpad bug 1696267 in OpenStack Compute (nova) "Functional test test_sync_standard_traits intermittently fails" [Undecided,New] | |
| 22:38:59 | cdent | mriedem: joy | |
| 22:39:55 | cdent | I'll have a gander, but may not last. If you catch sight of jaypipes (who is either in or going to cali) he might have some ideas, it's basically based off his code. | |
| 22:41:24 | mriedem | my guess is another test has set _TRAITS_SYNCED to True | |
| 22:41:26 | mriedem | and didn't cleanup | |
| 22:41:28 | mriedem | or something | |
| 22:43:04 | cdent | that's a good guess | |
| 22:43:35 | cdent | yeah that's almost ceratinly it. we need a setup | |
| 22:45:45 | mriedem | you pushing or me? | |
| 22:46:30 | cdent | mriedem: i've got it | |
| 22:46:32 | cdent | nearly done | |
| 22:47:21 | cdent | mriedem: i'm doing it as both a setup and teardown | |
| 22:47:33 | cdent | so safety™ | |
| 22:47:40 | mriedem | you can do that with addCleanup in the setUp :) | |
| 22:47:42 | mriedem | if you want to be fancy | |
| 22:47:49 | mriedem | tearDown is so 2003 | |
| 22:48:11 | mriedem | well maybe you can't if it's not a function, idk | |
| 22:48:12 | cdent | oh I supose that's the cool way, sure | |
| 22:48:25 | cdent | it can be a function | |
| 22:48:31 | mriedem | lambda?! | |
| 22:48:36 | mriedem | let's make it was weird as possible | |
| 22:48:44 | mriedem | put an eval in there | |
| 22:52:37 | cdent | i'll create a container to run the function in | |
| 22:55:22 | openstackgerrit | Chris Dent proposed openstack/nova master: Reset the _TRAITS_SYNCED global in Traits tests https://review.openstack.org/471508 | |
| 22:55:35 | cdent | mriedem: ^ there go, feel free to change it if I've left in one of my inevitable typos | |
| 22:57:14 | mriedem | f yes containers ftw | |
| 23:02:38 | openstackgerrit | Chris Dent proposed openstack/nova master: Reset the _TRAITS_SYNCED global in Traits tests https://review.openstack.org/471508 | |
| 23:03:34 | cdent | so many blank lines because I haz a tired. it is tomorrow now, so I'll go. It's all yours now mriedem | |
| 23:03:36 | cdent | goodnight all | |
| 23:08:28 | openstackgerrit | Merged openstack/nova master: Catch neutronclient.NotFound on floating deletion https://review.openstack.org/410815 | |
| 23:16:44 | openstackgerrit | melanie witt proposed openstack/nova master: Add FixedIPList.get_count_by_project() https://review.openstack.org/446246 | |
| 23:16:45 | openstackgerrit | melanie witt proposed openstack/nova master: Add FloatingIPList.get_count_by_project() https://review.openstack.org/446247 | |
| 23:16:45 | openstackgerrit | melanie witt proposed openstack/nova master: Add get_count_by_vm_state() to InstanceList object https://review.openstack.org/446244 | |
| 23:16:46 | openstackgerrit | melanie witt proposed openstack/nova master: Add SecurityGroupList.get_counts() https://review.openstack.org/446245 | |
| 23:16:46 | openstackgerrit | melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242 | |
| 23:16:47 | openstackgerrit | melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243 | |
| 23:16:47 | openstackgerrit | melanie witt proposed openstack/nova master: Count server groups to check quota https://review.openstack.org/446240 | |
| 23:16:48 | openstackgerrit | melanie witt proposed openstack/nova master: Count networks to check quota https://review.openstack.org/446241 | |
| 23:16:48 | openstackgerrit | melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521 | |