| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-06-06 | |||
| 13:40:18 | openstackgerrit | Felipe Monteiro proposed openstack/nova-specs master: Patrole (RBAC) Keystone Gating https://review.openstack.org/471145 | |
| 13:40:50 | mriedem | ok i'll work on cleaning up lee's patch | |
| 13:45:32 | sdague | mriedem: I pushed up a release request for python-novaclient - https://review.openstack.org/#/c/471323/ | |
| 13:45:46 | sdague | please review when you get a chance | |
| 13:46:00 | mriedem | hmm, that might be a 9.0 | |
| 13:46:38 | sdague | mriedem: because of the 1.1 removes? | |
| 13:46:42 | sdague | I was wondering that | |
| 13:46:55 | sdague | but that code has been effectively dead for so long | |
| 13:47:13 | mriedem | was thinking more the deprecated option removals https://docs.openstack.org/releasenotes/python-novaclient/unreleased.html#upgrade-notes | |
| 13:48:03 | sdague | ok, I can go either way. You want me to make it 9.0? | |
| 13:48:03 | mriedem | weird, the 2.32 reno is showing up in 8.0.0-33 as a new feature | |
| 13:48:46 | mriedem | i'm more worried about the misleading renos than the version number | |
| 13:48:50 | sdague | ok | |
| 13:53:40 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Catch neutronclient.NotFound on floating deletion https://review.openstack.org/410815 | |
| 13:53:40 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Improve coverage of floating IP delete https://review.openstack.org/471360 | |
| 13:54:07 | sfinucan | sdague: ^ if you don't feel the latter is actually useful, I'm happy to drop it | |
| 13:55:07 | sdague | sfinucan: works for me | |
| 13:56:55 | mriedem | sdague: sfinucan: no tests needed for https://review.openstack.org/#/c/410815/ ? | |
| 13:57:08 | sfinucan | mriedem: See above | |
| 13:57:26 | mriedem | sfinucan: that doesn't test the neutronv2.api change | |
| 13:57:29 | sfinucan | I broke them out into a separate change because none of those conditions had coverage | |
| 13:57:50 | openstackgerrit | Sean Dague proposed openstack/nova master: Fix deprecation warning around get_transport() usage https://review.openstack.org/471362 | |
| 13:57:54 | sfinucan | mriedem: https://review.openstack.org/#/c/471360/1/nova/tests/unit/api/openstack/compute/test_floating_ips.py doesn't? | |
| 13:58:08 | mriedem | sdague: i've already got a patch for that | |
| 13:58:14 | sdague | mriedem: ok, where? | |
| 13:58:35 | mriedem | https://review.openstack.org/#/c/469659/ | |
| 13:58:47 | sfinucan | mriedem: I can squash the two before it merges if you'd prefer? | |
| 13:59:09 | mriedem | sfinucan: it doesn't because it's mocking out the call to the network_api | |
| 13:59:16 | sfinucan | oh, wait - I getcha you now | |
| 13:59:22 | mriedem | i don't really need the big ddt rewrite in the bug fix, | |
| 13:59:28 | mriedem | because if we backport the fix, ddt isn't used in earlier branches | |
| 13:59:39 | sdague | mriedem: good point | |
| 13:59:39 | mriedem | but that's exactly why we should have tests for a bug fix | |
| 13:59:44 | mriedem | and refactor/cleanup later | |
| 14:00:25 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Catch neutronclient.NotFound on floating deletion https://review.openstack.org/410815 | |
| 14:00:30 | mriedem | ^ just pulled it out of the queue | |
| 14:01:21 | sfinucan | that's fair. I'll fix that up now | |
| 14:01:26 | mriedem | thanks | |
| 14:05:48 | mriedem | sdague: on the novaclient reno thing, i've been bugging doug with reno stuff multiple times in the last week or so, so i'm hesitant to bug him about another one here | |
| 14:06:00 | mriedem | but someone else might have some karma with doug to ask about it... :) | |
| 14:06:21 | mriedem | that reno was added https://github.com/openstack/python-novaclient/commit/7fb0bd4f357a7f9e24c864584b398a25171580cf and tagged in 5.0.0 | |
| 14:06:26 | mriedem | so it shouldn't be showing up again | |
| 14:06:39 | openstackgerrit | Felipe Monteiro proposed openstack/nova-specs master: Patrole (RBAC) Keystone Gating https://review.openstack.org/471145 | |
| 14:06:49 | mriedem | actually nvm | |
| 14:06:52 | mriedem | i know exactly what it is | |
| 14:06:53 | mriedem | https://github.com/openstack/python-novaclient/commit/aa7f35d76b5768ec3fe4d45ad010d53adff7cccd | |
| 14:06:55 | mriedem | someone updated the reno | |
| 14:07:04 | mriedem | i'm going to revert that | |
| 14:08:18 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Revert "Fix a typo" https://review.openstack.org/471365 | |
| 14:08:24 | mriedem | sdague: ^ | |
| 14:08:43 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Revert "Fix a typo" https://review.openstack.org/471365 | |
| 14:09:16 | sdague | mriedem: +A | |
| 14:09:34 | sdague | yeh, when the reno magic breaks, it's kind of sad | |
| 14:12:03 | mriedem | i've got something you might like, | |
| 14:12:14 | sfinucan | mriedem: So you can't update a reno once it's in a major release? | |
| 14:12:36 | mriedem | while working on removing some deprecated nova-network things from devstack https://review.openstack.org/#/c/471004/ - i found that tempest is using nova's floating IP proxy API for all things floating IP for ssh validation https://review.openstack.org/#/c/471116/ | |
| 14:13:17 | mriedem | sfinucan: i guess not. honestly the rules around reno seem to change for me per case | |
| 14:13:34 | mriedem | because i know we've amended release notes that are tagged for milestones in nova, | |
| 14:13:44 | mriedem | but server side it's less of an issue probably, or noticeable | |
| 14:13:53 | mriedem | on the client it's much more obvious and weird | |
| 14:14:39 | sfinucan | Hmm, that sounds like a reno bug 🤔 | |
| 14:14:50 | sfinucan | or at least something that should be documented better | |
| 14:15:37 | bauzas | sfinucan: mriedem: you *can* fix notes after a major release | |
| 14:16:05 | mriedem | can and should are different things | |
| 14:16:06 | bauzas | sfinucan: mriedem: but the only problem is that you need to backport it to the stable branch then | |
| 14:16:19 | mriedem | maybe that was the issue, | |
| 14:16:24 | sfinucan | oh, that would make sense | |
| 14:16:25 | mriedem | they should have fixed the typo in stable/newton instead of master | |
| 14:16:57 | bauzas | the problem is not really with branching | |
| 14:17:03 | bauzas | it's rather with tagging | |
| 14:17:27 | bauzas | since we tag a release by a git commit, it's not possible to update relnotes for a specific release | |
| 14:18:00 | mriedem | hmm, still there http://docs-draft.openstack.org/65/471365/2/check/gate-python-novaclient-releasenotes/7a8a8ff//releasenotes/build/html/unreleased.html | |
| 14:18:02 | bauzas | it will be seen in the branch for sure, but not for the tag | |
| 14:18:23 | bauzas | mriedem: what is the exact problem ? | |
| 14:18:30 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Convert additional floating IP tests to ddt https://review.openstack.org/471360 | |
| 14:18:30 | bauzas | I was just joining the discussion | |
| 14:18:31 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Catch neutronclient.NotFound on floating deletion https://review.openstack.org/410815 | |
| 14:18:39 | sfinucan | ^ mriedem, sdague | |
| 14:19:04 | sfinucan | ddt is pretty nifty. No wonder mdbooth likes it so much | |
| 14:19:13 | sdague | sfinucan: I thought the ddt stuff was not going to be put in there | |
| 14:19:18 | sdague | because that prevents backport | |
| 14:19:24 | sfinucan | Oh | |
| 14:19:39 | sfinucan | I thought he meant the conversion to ddt, which I kept separate | |
| 14:19:42 | sfinucan | ddt in general? | |
| 14:19:53 | mriedem | we don't use ddt in newton | |
| 14:19:56 | mriedem | if this is going to go back that far | |
| 14:20:02 | sfinucan | gotcha. round 3 | |
| 14:21:03 | mriedem | so reno still includes this note on master unreleased because the revert doesn't delete the file, so it still looks changed | |
| 14:22:29 | mdbooth | sfinucan: It is pleasantly succinct and very readable though, isn't it? | |
| 14:23:14 | bauzas | mriedem: if so, you just need to revert the file in the master tree | |
| 14:23:23 | bauzas | and do a stable-only note | |
| 14:23:35 | mriedem | bauzas: revert the file as in delete the file? | |
| 14:23:37 | bauzas | FWIW, I'm just discovering new options with reno | |
| 14:23:40 | bauzas | yup | |
| 14:23:50 | mriedem | bauzas: yes deleting is an option | |
| 14:24:03 | bauzas | in theory, notes are attached to a commit | |
| 14:24:12 | bauzas | so, when a commit is changing a thing, you have the note | |
| 14:24:18 | bauzas | the beauty of that is with backports | |
| 14:24:27 | bauzas | because the note will follow the code | |
| 14:24:50 | bauzas | but sometimes, you're doing cleanups in notes, and you're discovering you forgot something specific on a branch | |