Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-02
19:03:02 mriedem i don't know if there is a patch for it yet
19:03:21 cfriesen_ I can bump directly to 2.47 if there's nothing needed for 2.46
19:03:40 mriedem just do a patch for 2.46 and then do 2.47 on top of it
19:03:50 cfriesen_ kay
19:09:27 cfriesen_ mriedem: is a release note needed?
19:09:48 cfriesen_ or just skip it like was done for 2.42
19:10:32 mriedem we do'nt need a release note in novaclient for 2.46
19:10:44 melwitt gdi I'm getting that my compute node has 0GB disk available in my functional test so it fails to build a server with NoValidHost
19:11:16 melwitt I don't recall ever seeing that before
19:11:19 clarkb melwitt: in the gate?
19:11:24 melwitt no, locally
19:12:25 mriedem melwitt: should be using the fake virt driver already
19:12:30 mriedem via the conf fixture
19:13:33 melwitt thanks, I'm copying a test that did everything manually and didn't realize I needed the set_nodes() etc stuff. my bad
19:16:27 openstackgerrit Dirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility) https://review.openstack.org/470252
19:17:09 cfriesen_ mriedem: do we need cleanup in the novaclient functional tests? (I'm looking at jichenjc's comment in https://review.openstack.org/#/c/435141/7/novaclient/tests/functional/v2/test_servers.py)
19:17:37 cfriesen_ I'm happy to delete the server if desired.
19:17:53 openstackgerrit Dirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility) https://review.openstack.org/470252
19:18:06 mriedem cfriesen_: as in self.addCleanup(server.delete)?
19:18:12 mriedem yes we need that in novaclient functional tests,
19:18:17 mriedem they are backed by a single node dsvm env
19:18:27 cfriesen_ mriedem: was looking at _cleanup_server() actually
19:18:30 mriedem so if you don't cleanup, we can eventually hit resource / quota issues
19:18:49 mriedem we should always cleanup resources in integration tests
19:19:05 mriedem leaking leads to weird test failures later
19:19:05 cfriesen_ addCleanup is probably better?
19:19:30 mriedem i don't know what _cleanup_server() is
19:19:34 mriedem i don't care where we clean up
19:19:39 mriedem we just need to cleanup on teardown of each test
19:19:41 mriedem if we created something
19:19:45 cfriesen_ kay
19:20:14 mriedem just like the gd markers and coloring books all over my living room floor
19:20:17 mriedem i don't care how they got there,
19:20:20 mriedem i just want them cleaned up
19:20:38 melwitt hah
19:22:29 cfriesen_ looks like it's already done for me actually...the helper function I used to create the server adds the cleanup
19:22:47 openstackgerrit Merged openstack/nova master: add new test fixture flavor with extra_specs https://review.openstack.org/470076
19:24:55 melwitt hm, I think maybe this never works to use the DiskFilter in func tests. all the tests that derive from the integrated_helpers base use the chance scheduler and ones I see using filter scheduler aren't using the DiskFilter
19:25:32 melwitt I dumbly tried to just let it use default filters even though I don't care about the filters. changing to the chance scheduler
19:25:48 mriedem there are only like 2 filters you can use if you're doing filter scheduler,
19:25:53 mriedem allhostsfilter and retryfilter i think
19:25:56 mriedem maybe computefilter
19:25:58 mriedem something like that
19:26:07 melwitt yeah. guh, my fault for not knowing how this works until now I guess
19:26:22 mriedem the integrated_helpers stuff hides a lot of this
19:26:27 melwitt I always had just inherited from the integrated_helpers base test case and didn't think about it
19:26:28 melwitt yeah
19:26:40 mriedem once you start not relying on that,
19:26:47 mriedem you find out we use a buttload of fixtures :)
19:27:05 melwitt yeah, for reals
19:28:21 openstackgerrit Chris Friesen proposed openstack/python-novaclient master: 2.47: Show flavor info in server details https://review.openstack.org/435141
19:28:21 openstackgerrit Chris Friesen proposed openstack/python-novaclient master: 2.46: match nova API version https://review.openstack.org/470413
19:28:51 mriedem cfriesen_: you're going to need a unit test change on that bottom one, sec
19:29:14 cfriesen_ oh yeah,
19:29:16 cfriesen_ will update
19:29:23 mriedem cfriesen_:
19:29:24 mriedem https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/unit/v2/test_shell.py#L2907
19:33:28 openstackgerrit Chris Friesen proposed openstack/python-novaclient master: 2.47: Show flavor info in server details https://review.openstack.org/435141
19:33:28 openstackgerrit Chris Friesen proposed openstack/python-novaclient master: 2.46: match nova API version https://review.openstack.org/470413
19:34:57 openstackgerrit OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/469581
19:34:58 cfriesen_ now I need to go make "online_data_migrations" work with our customizations to Newton
19:37:00 cfriesen_ and I resolve to stay away from api_sample_tests as much as possible
19:41:18 mriedem huh i thought we were going to start running nova-api under uwsgi in the gate
19:41:36 mriedem aha https://review.openstack.org/#/c/457715/
19:48:28 openstackgerrit Kaitlin Farr proposed openstack/nova master: Remove deprecated keymgr code https://review.openstack.org/439855
19:54:14 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: Document Pike release review priorities https://review.openstack.org/470420
19:54:19 mriedem dansmith: leakypipes: ^
19:54:29 mriedem long time coming but finally got the review priorities for pike documented
20:04:57 leakypipes mriedem: reviewed.
20:07:19 mriedem oh right
20:09:38 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: Document Pike release review priorities https://review.openstack.org/470420
20:28:30 openstackgerrit Merged openstack/nova master: show flavor info in server details https://review.openstack.org/434514
20:29:19 openstackgerrit Merged openstack/nova master: Add database migration and model for consumers https://review.openstack.org/469633
20:39:08 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: Cap sphinx<1.6.1 https://review.openstack.org/470434
21:18:42 cfriesen_ can someone suggest why gate-python-novaclient-releasenotes is failing for https://review.openstack.org/#/c/435141 ?
21:20:16 openstackgerrit Kaitlin Farr proposed openstack/nova master: Remove deprecated keymgr code https://review.openstack.org/439855
21:22:13 openstackgerrit Merged openstack/nova-specs master: Cap sphinx<1.6.1 https://review.openstack.org/470434
21:24:48 openstackgerrit Chris Friesen proposed openstack/python-novaclient master: 2.47: Show flavor info in server details https://review.openstack.org/435141
21:26:08 clarkb cfriesen_: https://review.openstack.org/#/c/469881/ something like that needed in novaclient?
21:27:25 cfriesen_ clarkb: already had that formatting style
21:28:13 clarkb cfriesen_: in your chnge yes, but I think new relaese of releasenotes is more strict so old things elsewhere may be unhappy
21:28:14 cfriesen_ I'm wondering if maybe it was related to the sphinx change above
21:28:29 clarkb notes/remove-deprecated-option-in-3.3.0-82a413157838570d.yaml is the file it is mad about
21:28:34 clarkb which doesn't use > or |
21:29:20 cfriesen_ ah, right
21:30:44 clarkb I think the problem is that that file is treated as entirely yaml rather than being yaml with rst strings in it and reno is emitting a warning which is treated as an error
21:31:57 clarkb also update doesn't appear to be a valid directive which may be the underlying issue
21:32:02 clarkb https://docs.openstack.org/developer/reno/usage.html
21:32:38 cfriesen_ yeah, was just looking at that
21:32:48 cfriesen_ maybe it was supposed to be upgrade?
21:33:32 clarkb that would be my guess
21:33:43 clarkb beacuse in upgrade you can list things
21:33:54 cfriesen_ I can try fixing it up
21:45:27 openstackgerrit Chris Friesen proposed openstack/python-novaclient master: Fix up release note https://review.openstack.org/470446
22:02:04 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/470474
22:04:49 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/467173
22:06:04 clarkb cfriesen_: that got the error to change :) I think you need to do something like upgrade:\n - |\n notes there
22:07:15 openstackgerrit OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/469581
22:12:45 cfriesen_ clarkb: respinning
22:13:38 openstackgerrit Chris Friesen proposed openstack/python-novaclient master: Fix up release note https://review.openstack.org/470446

Earlier   Later