| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-05-31 | |||
| 13:46:11 | jaypipes | cdent: it was a convenient place to put the sync routine and it matches the resource class cache. | |
| 13:46:43 | cdent | sure, but the resource class cache is needed because we have some stuff in db, and some stuff not in db | |
| 13:46:46 | cdent | not true with traits | |
| 13:46:56 | jaypipes | yes, I'm aware of that | |
| 13:47:07 | cdent | so...? | |
| 13:47:09 | jaypipes | cdent: it was a convenient place to put the sync routine and it matches the resource class cache. | |
| 13:47:15 | jaypipes | cdent: it was a convenient place to put the sync routine and it matches the resource class cache. | |
| 13:47:16 | jaypipes | cdent: it was a convenient place to put the sync routine and it matches the resource class cache. | |
| 13:47:28 | cdent | yeah, that's completely meaningless :) | |
| 13:47:32 | jaypipes | lol, sorry :) | |
| 13:47:35 | cdent | you can say it ten more times | |
| 13:47:41 | jaypipes | didn't mean to repeat that. | |
| 13:47:59 | cdent | :) | |
| 13:48:03 | jaypipes | serves me right for trying to do two things at once :) | |
| 13:48:16 | cdent | only two? that's pretty good discipline | |
| 13:49:01 | jaypipes | cdent: anyway, did you see the original patch from one of alex_xu's colleagues that added a new placement-manage CLI tool to do trait syncs? | |
| 13:49:11 | cdent | yes | |
| 13:49:23 | cdent | we don't want that | |
| 13:49:24 | jaypipes | cdent: so you're aware of the impetus for me doing this, then. | |
| 13:49:42 | jaypipes | cdent: how do you propose to do the syncing? | |
| 13:49:57 | cdent | I'm aware of why you want to have a sync happen in an automatic fashion, but it ought to be possible to do it without the cache | |
| 13:50:03 | cdent | one sec | |
| 13:50:26 | mriedem | sfinucan: i added cfriesen to your series here https://review.openstack.org/#/q/topic:bp/reserve-numa-with-pci - i'd like his review on that before i do | |
| 13:50:41 | mriedem | moshe would probably also be good | |
| 13:50:58 | jaypipes | cdent: oh, it's totally possible to do it without the cache. I just figured the trait cache would be useful in the same way the rc cache is | |
| 13:51:11 | cdent | jaypipes: that's my question: what's the point of the cache? | |
| 13:51:37 | cdent | " I don't understand why need a cache at all?" | |
| 13:51:38 | jaypipes | cdent: just consistency with the resource classes and a convenient place to put the sync thing, like I said. | |
| 13:51:47 | jaypipes | cdent: consistency with rcs | |
| 13:52:04 | jaypipes | cdent: where would you put the auto-sync thing? | |
| 13:52:30 | jaypipes | cdent: feel free to push a patch that doesn't use a cache. I'm happy to review it. | |
| 13:52:52 | cdent | instead of _ensure_trait_cache have _ensure_trait_sync which checks a global boolean to know if sync happend, get rid of all the code in the trait cache file except for the sync method | |
| 13:54:13 | cdent | jaypipes: I'll be happy to push something, but just as a point of order, I don't think it should be incumbent on me to prove why you shoudn't add a piece of code that doesn't appear necessary. It should be on you to prove that it is (beyond consistency). | |
| 13:55:15 | jaypipes | cdent: fair enough | |
| 13:55:50 | cdent | jaypipes: usually you have very good reasons so I was prepared to take this on trust, but I've stumbled to find the reason, thus the questions | |
| 13:56:36 | jaypipes | cdent: I liked the symmetry of it, nothing more. | |
| 13:57:06 | cdent | okay, thanks, given that I'll push an alternate | |
| 13:58:16 | jaypipes | cool beans. | |
| 13:58:21 | jaypipes | cdent: thanks! | |
| 13:58:42 | cdent | so many layers of hell | |
| 13:59:25 | xyang1 | mriedem: hi, question regarding the merge deadline. I only see a Nova spec deadline published here: https://releases.openstack.org/pike/schedule.html Does that mean all code patches have the same merge deadline, Pike-3, regardless of its priority? | |
| 14:06:33 | mriedem | xyang1: yes | |
| 14:06:59 | mriedem | xyang1: https://wiki.openstack.org/wiki/Nova/Pike_Release_Schedule | |
| 14:07:21 | xyang1 | mriedem: thanks. That means we have more time to fix the ScaleIO CI issues | |
| 14:07:25 | mriedem | yup | |
| 14:11:57 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.live_migration_rollback notification https://review.openstack.org/402124 | |
| 14:34:39 | openstackgerrit | Gábor Antal proposed openstack/nova master: Add json style checking for sample notifications https://review.openstack.org/443677 | |
| 14:40:30 | openstackgerrit | Gábor Antal proposed openstack/nova master: Add json style checking for sample notifications https://review.openstack.org/443677 | |
| 14:45:54 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322 | |
| 14:46:49 | mriedem | mgagne: ^ rebased for you, put some todos in there too | |
| 14:49:58 | mgagne | working on it | |
| 14:50:59 | gabor_antal | Hey there, can I get a little help with this ? https://review.openstack.org/#/c/469038/ Currently, on functional-py35 fails due to the inspect library cannot find any frame, however with python 2.7 everything works fine. does someone have any idea? thanks in advance | |
| 14:51:45 | openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova master: Ensure that periodic reclaim cleans DB deleted instances https://review.openstack.org/323250 | |
| 14:56:21 | openstackgerrit | Mathieu Gagné proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322 | |
| 14:58:30 | openstackgerrit | Merged openstack/nova master: Avoid lazy-load error when getting instance AZ https://review.openstack.org/468147 | |
| 15:08:50 | openstackgerrit | Merged openstack/nova master: Add configuration options for certificate validation https://review.openstack.org/457678 | |
| 15:21:07 | ftersin | mdbooth: hi. are you around? | |
| 15:22:10 | clarkb | gabor_antal: it looks like inspect.trace() returns empty list if there is no exception currently being raised. SO possibly that is related to the problem? | |
| 15:24:28 | gabor_antal | clarkb: yeah, it looks like. But there is an exception being raised as running functional tests returns ok so it is raised and catched and notification is being sent | |
| 15:30:51 | openstackgerrit | Merged openstack/nova master: Use plain routes list for limits endpoint instead of stevedore https://review.openstack.org/458805 | |
| 15:45:06 | openstackgerrit | Merged openstack/nova master: Ensure the value of filter parameter is unicode https://review.openstack.org/468614 | |
| 15:45:07 | sfinucan | mriedem: Yup, that makes sense. Thanks | |
| 16:08:01 | sfinucan | ftersin: mdbooth is away all this week. He'll be back Monday though | |
| 16:08:39 | ftersin | thanks | |
| 16:33:18 | sfinucan | alex_xu, gmann: We're seeing a load of merge conflicts with https://review.openstack.org/#/q/topic:bp/api-no-more-extensions-pike+status:open | |
| 16:33:52 | sfinucan | Is there anything we could do to minimize these? Perhaps putting in all the routes in nova/api/openstack/compute/routes.py but commented out? | |
| 16:34:01 | sfinucan | I'll do it if you're OK with me doing so | |
| 16:34:28 | openstackgerrit | Merged openstack/nova master: Add policy description for os-networks https://review.openstack.org/465452 | |
| 16:40:22 | sfinucan | It's low priority but there are a lot of mox-mock conversion patches waiting for an additional +2 https://review.openstack.org/#/q/topic:bp/remove-mox-pike | |
| 16:40:55 | sfinucan | If any core has bandwidth, getting some of those in would be sweet. They're easy wins for Python3 compatibility | |
| 16:41:11 | mriedem | https://review.openstack.org/#/c/342043/ failed jenkins | |
| 16:41:48 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/469577 | |
| 16:41:57 | openstackgerrit | Chris Dent proposed openstack/nova master: Sync os-traits to Traits database https://review.openstack.org/469578 | |
| 16:42:12 | cdent | jaypipes, edleafe: there ^ is alternate for traits sync | |
| 16:42:29 | sfinucan | So it did. I can take a look at it | |
| 16:42:51 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Use microversions for new style volume attachments https://review.openstack.org/469579 | |
| 16:42:52 | mriedem | jgriffith: stvnoyes: ildikov: ^ here is the start of microversion handling with cinderclient, needs tests yet | |
| 16:45:30 | openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/469581 | |
| 16:49:20 | sfinucan | mriedem: That whole test file is a bit of a mess. Given that it's for cells v1, is it worth doing surgery on it or are we better to just keep mox until the whole feature is removed? | |
| 16:49:48 | mriedem | it's definitely low priority | |
| 16:50:32 | sfinucan | meh, I'll leave it so | |
| 16:58:45 | cdent | avolkov: are you and jichenjc colliding on some of the api-ref stuff? looks like there may be some duplicatio of effort on resource class related docs: https://review.openstack.org/#/q/status:open+topic:placement-api-ref-add-resource-classes-put | |
| 17:18:34 | cdent | jaypipes, edleafe, bauzas: quick microversions in placement hygiene thing from alex needs some review: https://review.openstack.org/#/c/458049/ | |
| 17:18:51 | avolkov | cdent: oh, missed those patches | |
| 17:19:05 | edleafe | cdent: reviewed the traits sync patch. Looks much clearer | |
| 17:19:13 | cdent | avolkov: yeah, I think the change in topic made them harder to find | |
| 17:20:25 | openstackgerrit | Ed Leafe proposed openstack/nova master: Have scheduler claim resources https://review.openstack.org/463993 | |
| 17:20:25 | openstackgerrit | Ed Leafe proposed openstack/nova master: Pass the number of hosts to return explicitly https://review.openstack.org/465767 | |
| 17:20:26 | openstackgerrit | Ed Leafe proposed openstack/nova master: Pass a list of instance UUIDs to scheduler https://review.openstack.org/465171 | |
| 17:20:26 | openstackgerrit | Ed Leafe proposed openstack/nova master: Return multiple hosts from select_destinations https://review.openstack.org/465768 | |
| 17:27:00 | openstackgerrit | Chris Dent proposed openstack/nova master: Sync os-traits to Traits database https://review.openstack.org/469578 | |
| 17:28:57 | cdent | edleafe: did you see my comments on ps 11 of https://review.openstack.org/#/c/463993/ ? don't want them lost now that you've rebased | |
| 17:50:29 | edleafe | cdent: yes, I just wanted to clean things up first before making changes | |
| 17:51:03 | cdent | roger | |
| 17:52:25 | edleafe | cdent: I removed the patch that got rid of host_subset_size, so there was that | |
| 18:13:25 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use microversions for new style volume attachments https://review.openstack.org/469579 | |
| 18:13:26 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use 3.27 microversion when creating new style volume attachments https://review.openstack.org/469609 | |
| 18:13:51 | mriedem | ildikov: jgriffith: stvnoyes: ^ ok should be ready for review with tests | |
| 18:14:23 | mriedem | i'm going to push a DNM change on top of that to request something like 3.99 for attachment_create and see it raise the expected error so we can fallback to the old style attach | |
| 18:19:17 | cfriesen | where's the nova api code for boot-from-volume? | |