| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-05-30 | |||
| 19:07:43 | sean-k-mooney | mriedem: its form this import https://github.com/openstack/os-traits/blob/b169eb4a8e13c74673b54512d0577088aa3cc81d/os_traits/__init__.py#L16 | |
| 19:08:12 | mriedem | for loader, name, is_pkg in pkgutil.walk_packages(package.__path__): | |
| 19:08:30 | sean-k-mooney | mriedem: yes on line 52 https://github.com/openstack/os-traits/blob/b169eb4a8e13c74673b54512d0577088aa3cc81d/os_traits/__init__.py#L52 | |
| 19:09:43 | mriedem | sure, i don't know what python black magic it's doing, but it looks like it's walking some packages it shouldn't be | |
| 19:09:53 | mriedem | and it's failing on these changes in nova, logstash confirms that | |
| 19:10:16 | mriedem | https://review.openstack.org/#/c/462770/ i mean | |
| 19:10:44 | sean-k-mooney | mriedem: its trying to import all submodules of os-traits when you import a parent module | |
| 19:11:14 | edleafe | mriedem: yeah, adding them to the proper namespace | |
| 19:12:47 | edleafe | no idea how the django_util tests got into the os-traits module | |
| 19:13:28 | openstackgerrit | Merged openstack/nova master: Add check_deltas() and limit_check_project_and_user() to Quotas https://review.openstack.org/446239 | |
| 19:15:22 | jaypipes | edleafe: would you mind giving that a whirl at fixing? | |
| 19:16:50 | edleafe | jaypipes: sure, but running out in about 15 minutes for a little while | |
| 19:21:14 | jaypipes | edleafe: k, thanks! | |
| 19:30:30 | edleafe | jaypipes: running out now. Haven't found anything yet | |
| 20:00:20 | melwitt | jaypipes: do you know what's the deal with this patch's blueprint? I see that people have reviewed it including you, but the blueprint isn't in Approved state | |
| 20:00:23 | melwitt | https://review.openstack.org/#/c/441183/ | |
| 20:01:49 | jaypipes | melwitt: I'm not sure, no.. | |
| 20:02:19 | melwitt | k | |
| 20:04:45 | openstackgerrit | Merged openstack/nova master: Fix MarkerNotFound when paging and marker was found in cell0 https://review.openstack.org/468559 | |
| 20:06:41 | melwitt | neat, we get merge messages now | |
| 20:08:44 | melwitt | mriedem: have you heard of this blueprint before? https://blueprints.launchpad.net/nova/+spec/opencontrail-dpdk-support there are some reviews on the patch but the bp not approved yet | |
| 20:11:46 | mriedem | melwitt: nope | |
| 20:11:58 | mriedem | i see one patch | |
| 20:12:59 | melwitt | yeah, someone asked about it internally and I see a lot of reviews on the patch, so was surprised to find the bp not approved | |
| 20:14:00 | melwitt | but if no one's heard of it before, it seems like some steps were missed there | |
| 20:15:33 | melwitt | mriedem: just to be complete, is that a thing that needs a bp? adding a new VIF plugin? I assumed so | |
| 20:21:09 | mriedem | melwitt: i think it's a specless blueprint for sure | |
| 20:21:16 | mriedem | it's feature support for a new networking backend | |
| 20:22:01 | mriedem | this is probably chalked up to the contributor not knowing the process | |
| 20:22:15 | mriedem | i.e. bring up the specless blueprint in the weekly meeting to get yay or nay o nit | |
| 20:22:59 | melwitt | yeah, that is my guess as well | |
| 20:32:49 | efried | mriedem If we merge https://review.openstack.org/#/c/443189/ before Thursday, we can add powervm-nova-compute-driver to the Done list for pike ;-) | |
| 20:32:54 | mriedem | melwitt: so on this marker not found bug, i'm working on backporting to newton, but i might not have to - cell0 existed but it doesn't look like we actually populated it in newton | |
| 20:33:35 | mriedem | efried: p-2 is 6/8 | |
| 20:33:39 | mriedem | not this thursday | |
| 20:33:42 | mriedem | and FF is in july sometime | |
| 20:33:51 | efried | mriedem Sure, but numbers. | |
| 20:33:55 | mriedem | so your suggestion is not tempting me atm | |
| 20:34:17 | efried | Sigh. Okay. I'll have to find something more tempting to tempt you with. Beer? | |
| 20:34:34 | melwitt | mriedem: hm, interesting. I can't recall what we were doing before. I guess just legacy behavior, putting the instance in a cell straight away and leaving it there if it failed the schedule, single cell only | |
| 20:36:54 | mriedem | melwitt: yeah i think this is when it started to move things to cell0 https://github.com/openstack/nova/commit/bcbfee183e74f696085fcd5c18aff333fc5f1403 | |
| 20:37:20 | mriedem | which would explain why my functional test is blowing up on newton | |
| 20:39:35 | mriedem | kind of sucks we actually ever look in cell0 when listing instances since we know it's never populating | |
| 20:39:37 | mriedem | *populated | |
| 20:39:54 | melwitt | ah, yeah | |
| 21:04:09 | mriedem | melwitt: why do we still need separate methods for this? https://review.openstack.org/#/c/457857/12/nova/objects/instance_group.py | |
| 21:04:19 | mriedem | was that the staticmethod thing with mock? i thought that was fixed | |
| 21:06:30 | melwitt | mriedem: I can't remember what that was about, but I got errors when I tried to combine the db reader decorator with the remotable one | |
| 21:06:50 | mriedem | ok | |
| 21:06:58 | mriedem | question in there too | |
| 21:07:03 | melwitt | k | |
| 21:09:05 | melwitt | mriedem: okay, so the thing that got fixed was the ability to combine the staticmethod and db.* decorators on a class method https://github.com/openstack/nova/blob/master/nova/objects/flavor.py#L54 | |
| 21:09:24 | mriedem | ah ok | |
| 21:09:50 | melwitt | but I don't think you can ever combine the db.* decorators with the remotable decorators. at least I don't see any example. I tried to do it and got an error but I don't think I tried swapping the order and trying again | |
| 21:10:25 | mriedem | ok, left another comment and -1, looks like we're missing a test where user_id isn't passed in | |
| 21:12:20 | melwitt | yep, thanks | |
| 21:28:08 | mriedem | is it just me or is the xenserver ci failing at a pretty high rate lately? | |
| 21:28:46 | melwitt | I've noticed it too | |
| 21:31:45 | edmondsw | mriedem there are 6 +1s on https://review.openstack.org/#/c/422696/ if you get a chance to look | |
| 21:31:51 | edmondsw | you had opened a bug that got duped to this one | |
| 21:37:41 | mriedem | edmondsw: ok probably not going to get to that today, but it's starred | |
| 21:37:50 | mriedem | auto-disable compute in action http://207.189.188.190/logs/47/468147/1/check-vote/ext-nova-zuul/cbab6d1/n-cpu.log.gz?level=TRACE#_2017-05-26_22_56_46_579 | |
| 23:33:15 | openstackgerrit | Claudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages https://review.openstack.org/447505 | |
| #openstack-nova - 2017-05-31 | |||
| 00:52:15 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Specify keymap on server boot (1/2) https://review.openstack.org/458752 | |
| 00:54:12 | gmann | sfinucan: its ready now - https://review.openstack.org/#/c/445504/ | |
| 00:55:03 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Specify keymap on server boot (2/2) https://review.openstack.org/460987 | |
| 01:57:36 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593 | |
| 02:35:30 | openstackgerrit | Jeremy Liu proposed openstack/python-novaclient master: Fix reservation_id not supported by Nova API https://review.openstack.org/468444 | |
| 03:13:47 | openstackgerrit | Jeremy Liu proposed openstack/python-novaclient master: Fix reservation_id not supported by Nova API https://review.openstack.org/468444 | |
| 03:35:53 | Kevin_Zheng | looks like docs CI is broken? | |
| 04:00:03 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Send out notifications when instance tags changed https://review.openstack.org/459923 | |
| 04:24:53 | openstackgerrit | Rikimaru Honjo proposed openstack/nova master: Calculate stopped instance's disk sizes for disk_available_least https://review.openstack.org/468269 | |
| 04:58:40 | openstackgerrit | Huan Xie proposed openstack/nova master: XenAPIi: use os-xenapi 0.2.0 in nova https://review.openstack.org/453493 | |
| 05:16:57 | openstackgerrit | Jeremy Liu proposed openstack/python-novaclient master: Fix reservation_id not supported by Nova API https://review.openstack.org/468444 | |
| 05:42:45 | openstackgerrit | Béla Vancsics proposed openstack/nova master: Transform keypair.import notification https://review.openstack.org/467514 | |
| 05:42:46 | openstackgerrit | Béla Vancsics proposed openstack/nova master: Transform keypair.create notification https://review.openstack.org/408689 | |
| 06:08:01 | openstackgerrit | Rikimaru Honjo proposed openstack/nova master: Calculate stopped instance's disk sizes for disk_available_least https://review.openstack.org/468269 | |
| 06:21:15 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Added PCI NUMA policies https://review.openstack.org/390520 | |
| 06:54:16 | openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova master: Remove oslo.config deprecated parameter enforce_type https://review.openstack.org/462364 | |
| 07:03:21 | openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova master: live-migration test hook for serial console https://review.openstack.org/347471 | |
| 07:20:31 | gmann | Kevin_Zheng: is it, looks like running fine. - https://review.openstack.org/#/c/445504/ | |
| 07:21:09 | gmann | Kevin_Zheng: ah, got it | |
| 07:21:25 | Kevin_Zheng | yeah | |
| 07:21:38 | Kevin_Zheng | I uploaded a fix | |
| 07:21:45 | Kevin_Zheng | very simple ：） | |
| 07:23:50 | gmann | Kevin_Zheng: oh, thanks, link | |
| 07:24:38 | Kevin_Zheng | gmann: still uploading ... very bad internet connection | |
| 07:26:54 | gmann | Kevin_Zheng: [3]_ right | |
| 07:27:00 | Kevin_Zheng | yeah... | |
| 07:27:09 | gmann | nice | |
| 07:33:00 | openstackgerrit | Alvaro Lopez Garcia proposed openstack/nova master: Ensure that periodic reclaim cleans DB deleted instances https://review.openstack.org/323250 | |
| 07:45:47 | gmann | Kevin_Zheng: if you have internet issue, should i push ? | |
| 07:46:59 | Kevin_Zheng | 10 | |
| 07:47:04 | Kevin_Zheng | 10 mins | |
| 07:47:48 | Kevin_Zheng | gmann: give me one more chance :P | |
| 07:51:33 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Fix docs CI https://review.openstack.org/469365 | |
| 07:53:03 | Kevin_Zheng | ha finally | |
| 07:53:20 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Fix doc job with correct ref link https://review.openstack.org/469365 | |
| 07:53:39 | gmann | Kevin_Zheng: thanks, just updated commit msg. | |
| 07:55:40 | gmann | alex_xu: sfinucan johnthetubaguy melwitt oomichi easy fix to unblock the doc job- whoever gets first - https://review.openstack.org/469365 | |