| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-05-30 | |||
| 14:24:54 | bauzas | jaypipes: now it becomes ask_me_for_(this_request, those UUIDs) | |
| 14:25:09 | bauzas | but anyway, I don't want to open wounds | |
| 14:25:25 | mriedem | since we're not pulling nova-scheduler out, at this point i don't really care | |
| 14:25:32 | mriedem | nova-scheduler is internal to nova | |
| 14:25:48 | bauzas | mriedem: which is what wasn't said in PS7's commit msg... | |
| 14:26:24 | bauzas | if we're saying we don't care of the beauty of the scheduler API, I'm totally fine | |
| 14:26:42 | bauzas | then, we shouldn't be afraid of having alternatives returned by the scheduler... | |
| 14:27:07 | cdent | bauzas: we decided that we have to return alternatives. the only open question is on the data structure | |
| 14:27:46 | mriedem | btw sheeple, the bottom big ass counting quotas change has a +2 on it https://review.openstack.org/#/c/446239/ | |
| 14:27:50 | bauzas | cdent: the reason why I asked edleafe to abandon https://review.openstack.org/#/c/465767/5 in favor of https://review.openstack.org/#/c/465175/7 | |
| 14:28:22 | jaypipes | mriedem: I have the quotas one up in gertty. | |
| 14:28:32 | jaypipes | mriedem: since I previously reviewed it, I'll take that on. | |
| 14:44:09 | EmilienM | mriedem: hey, do you know how nova-coresec launchpad works? I created one for tripleo and don't know the next step | |
| 14:44:19 | EmilienM | should I add the group to another group? | |
| 14:44:53 | mriedem | EmilienM: i never set that up, but https://security.openstack.org/vmt-process.html might have details | |
| 14:44:58 | mriedem | otherwise i'd ask fungi | |
| 14:45:05 | EmilienM | ok, thx | |
| 14:45:11 | EmilienM | you have a checkbox "This bug is a security vulnerability" | |
| 14:45:12 | openstackgerrit | Chris Friesen proposed openstack/nova master: show flavor info in server details https://review.openstack.org/434514 | |
| 14:45:43 | cfriesen | api-ref tweaks ^ | |
| 14:45:46 | openstackgerrit | Jay Pipes proposed openstack/nova master: pci: add uuid field to PciDevice object https://review.openstack.org/469147 | |
| 14:57:47 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Have scheduler claim resources https://review.openstack.org/463993 | |
| 14:57:47 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Scheduler returning alternatives per destination https://review.openstack.org/465175 | |
| 14:57:48 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Pass a list of instance UUIDs to scheduler https://review.openstack.org/465171 | |
| 15:01:03 | bauzas | jaypipes: mriedem: edleafe: there it is, restored the original direction for https://review.openstack.org/465171 with a bit of fixes from me | |
| 15:01:15 | openstackgerrit | Merged openstack/nova master: cinder: add attachment_create method https://review.openstack.org/459111 | |
| 15:03:36 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Completely remove mox from unit/network/test_linux_net.py https://review.openstack.org/445504 | |
| 15:04:33 | openstackgerrit | Merged openstack/nova master: cinder: add attachment_update method https://review.openstack.org/459113 | |
| 15:10:14 | sfinucan | jaypipes, mriedem: Could I ask you folks to take a look at https://review.openstack.org/#/q/status:open+project:openstack/nova+topic:bp/reserve-numa-with-pci today? | |
| 15:11:06 | jaypipes | sfinucan: sure thing. wrapping up a review on melwitt's quotas patch then will do. | |
| 15:11:21 | sfinucan | jaypipes: Sweet. Thank you :) | |
| 15:11:36 | jaypipes | sfinucan: in the meantime, I offer you https://review.openstack.org/469147\ | |
| 15:12:09 | sfinucan | didn't I review that already 🤔 | |
| 15:13:01 | sfinucan | jaypipes: Ah, I did - https://review.openstack.org/#/c/414768/. Yup, I'll take a look now | |
| 15:14:52 | jaypipes | sfinucan: ya, I broke that patch out of the n-r-p series because it's self-contained. | |
| 15:15:49 | bauzas | mriedem: I do wonder about a specific case for https://bugs.launchpad.net/nova/+bug/1689692 | |
| 15:15:49 | openstack | Launchpad bug 1689692 in OpenStack Compute (nova) "MarkerNotFound when limit>num(instances) and marker starts in cell0" [High,In progress] - Assigned to Matt Riedemann (mriedem) | |
| 15:16:10 | bauzas | mriedem: given 3 instances with #1 ACTIVE, #2 ERROR and #3 ACTIVE | |
| 15:16:43 | bauzas | mriedem: if we set the marker to #1, we're still able to get #2 and #3 AFAICU | |
| 15:16:45 | bauzas | mriedem: correct? | |
| 15:17:03 | bauzas | because #2 will verify cell0 with marker #1 and we'll pass on it | |
| 15:17:41 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622 | |
| 15:17:43 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387 | |
| 15:17:49 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082 | |
| 15:17:55 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged volume attachment https://review.openstack.org/391941 | |
| 15:17:56 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021 | |
| 15:19:35 | bauzas | mriedem: nevermind, I'm sure it works | |
| 15:19:46 | bauzas | because we decrease the limit | |
| 15:20:44 | mriedem | bauzas: we wouldn't get #2 if the marker is #1 and it's ACTIVE | |
| 15:20:54 | mriedem | because we process the cells with the ACTIVE instances after cell0 with the ERROR instance | |
| 15:21:14 | bauzas | mriedem: so we would return #1 and #3 ? | |
| 15:21:18 | bauzas | only | |
| 15:21:19 | mriedem | yes | |
| 15:21:19 | bauzas | ? | |
| 15:21:27 | bauzas | mmm, that's another bug, right? | |
| 15:21:28 | mriedem | which is probably also a regression | |
| 15:21:46 | bauzas | lemme double-think on it | |
| 15:21:54 | mriedem | it's not going to get fixed here | |
| 15:21:58 | bauzas | sure | |
| 15:22:02 | mriedem | we search in build requests first, then cell0, then the cells | |
| 15:22:04 | ericyoung | mriedem: regarding https://review.openstack.org/#/c/407440/ (ScaleIO ephemeral) we have a couple of changes to our CI environment and then it should pass | |
| 15:22:12 | mriedem | paging gets wonky | |
| 15:22:13 | ericyoung | hopefully in the nxt day or two | |
| 15:22:15 | mriedem | and is why we said searchlight | |
| 15:22:23 | mriedem | ericyoung: ok | |
| 15:23:07 | bauzas | mriedem: well, so we should only set the marker to the last instance UUID we have, which can be either in cell0 or even a BuildRequesrt | |
| 15:23:32 | bauzas | something like, try to get all you can do with the same marker, and then only set the marker to the last ID you got | |
| 15:24:05 | bauzas | mriedem: in that case, I'd recommend to modify https://review.openstack.org/#/c/468559/ to tackle all those issues | |
| 15:24:38 | mriedem | bauzas: if your marker is on #1 then #2 wouldn't be in the page anyway | |
| 15:24:57 | mriedem | because #1 is ACTIVE | |
| 15:24:59 | mriedem | which means it's in a cell | |
| 15:25:25 | mriedem | our pages right now are basically scheduling (build requests), error (cell0) and then everything else | |
| 15:25:35 | bauzas | that I know | |
| 15:25:45 | mriedem | we said that was what we'd do at the newton midcycle at intel | |
| 15:26:10 | mriedem | and long-term a global search backend like searchlight is what you'd use for accurate searches | |
| 15:26:14 | bauzas | sure, simple pagination | |
| 15:26:41 | bauzas | but here, I'm considering a simple pagination with multiple backends (ie. not sorting) | |
| 15:27:00 | bauzas | for that, we're not needing searchlight, right? | |
| 15:27:19 | mriedem | what does multiple backends mean? | |
| 15:37:17 | mordred | efried: I started on the keystoneauth patches to implement all the things we've been poking at over the weekend | |
| 15:37:39 | efried | mordred Cool man. Please add me to the review(s). | |
| 15:38:14 | efried | mordred I still need to get caught up on the... "literature" backlog ;-) | |
| 15:38:19 | mordred | efried: https://review.openstack.org/#/q/status:open+project:openstack/keystoneauth+branch:master+topic:version-discovery | |
| 15:38:55 | efried | mordred Dig. | |
| 15:39:34 | mordred | efried: I still don't have list-of-interface done, nor the service-types aliases - but those should be easy enough to do as a follow on | |
| 15:40:43 | efried | mordred Okay. If you get a chance to comment in https://review.openstack.org/458257 as to how that guy should change as a result, please do. | |
| 15:45:10 | openstackgerrit | John Griffith proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285 | |
| 15:47:04 | sfinucan | jaypipes: Are these scripts auto-generated by sqlmigrate? https://review.openstack.org/#/c/469147/1/nova/db/sqlalchemy/migrate_repo/versions/362_add_pci_devices_uuid.py | |
| 15:47:22 | jaypipes | sfinucan: no. hand written. why? | |
| 15:47:26 | sfinucan | sqlalchemy-migrate | |
| 15:47:33 | mordred | efried: done | |
| 15:47:38 | sfinucan | Just checking - reading up on the syntax now | |
| 15:47:39 | efried | mordred Thanks | |
| 15:47:58 | mordred | efried: it's possible we might be able to clean up more things once we start poking | |
| 15:48:35 | efried | mordred It would be neat if we could do away with the nova.utils bit entirely. | |
| 15:48:52 | efried | mordred But I wouldn't want the consumers to have to do more than a couple of lines. | |
| 15:49:09 | efried | mordred E.g. they shouldn't have to do the looping logic. | |
| 15:49:25 | mordred | yah- well, the looping logic will definitely go away | |
| 15:50:00 | mordred | but even if we can just get it down to 3 lines of load_from_conf_options calls, it's probably somewhat worthwhile to have as a function perhaps | |
| 15:58:59 | jaypipes | melwitt, mriedem: k, quotas base patch reviewed. | |