| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-05-26 | |||
| 20:09:12 | sdague | I thought there was host based authentication in there | |
| 20:09:26 | sdague | like it actually cares about request ip address | |
| 20:09:36 | sdague | but, that code is so old and wonky, idk | |
| 20:12:42 | mriedem | i might be thinking of it coming up during the summit | |
| 20:12:45 | mriedem | someone saying you can't use https | |
| 20:14:06 | harlowja | leakypipes so u going to finally make https://github.com/jaypipes/enamel a thing -P | |
| 20:14:45 | sdague | https://github.com/openstack/nova/blob/315ae692256939e6925db56c6ac833a237d46571/nova/api/metadata/handler.py#L130 | |
| 20:15:09 | sdague | mriedem: we definitely validate against remote addr, or a proxy header equiv if you tell us to trust a proxy | |
| 20:15:37 | sdague | if you tell us to trust the proxy then you better not let your instances go straight to the server as well, all requests should only come from the proxy | |
| 20:15:49 | sdague | https://github.com/openstack/nova/blob/315ae692256939e6925db56c6ac833a237d46571/nova/api/metadata/handler.py#L131-L132 | |
| 20:16:10 | mriedem | anyway ca'nt find that now | |
| 20:16:18 | sdague | mriedem: it's not over https | |
| 20:16:29 | sdague | but that's all limitations of the amazon implementation I thought | |
| 20:16:37 | sdague | also no ipv6 for same reason | |
| 20:18:02 | sdague | mriedem: I'll respond to the bug | |
| 20:28:50 | sdague | ok, headed out. I'm mostly out next week. Including some camping | |
| 20:28:52 | sdague | enjoy all | |
| 20:35:31 | openstackgerrit | Matt Wisch proposed openstack/nova master: Corrected compute_monitors setting help https://review.openstack.org/468538 | |
| 20:45:18 | mriedem | has it always been the case that if you specify a limit>what's left to page on after the marker we 404? https://bugs.launchpad.net/nova/+bug/1689692 | |
| 20:45:18 | openstack | Launchpad bug 1689692 in OpenStack Compute (nova) "marker not found" [Undecided,New] | |
| 20:45:24 | mriedem | that seems wrong | |
| 20:46:55 | superdan | limit or marker? | |
| 20:46:58 | superdan | marker makes sense to 404 | |
| 20:51:37 | mriedem | the marker in this case exists | |
| 20:51:46 | mriedem | looks like all instances are ERROR state which means they should be in cell0 | |
| 20:52:09 | mriedem | they are sending a limit which is 1 more than how many they have left in the page | |
| 20:55:10 | mriedem | superdan: i think i know | |
| 20:55:29 | mriedem | yup | |
| 20:55:58 | mriedem | so they are all in cell0 | |
| 20:56:04 | mriedem | we get the instances from cell0 here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2554 | |
| 20:56:14 | mriedem | with limit=3, we got 2 back b/c that was the end of the page | |
| 20:56:18 | mriedem | so we are left with limit 1 | |
| 20:56:31 | mriedem | so we continue to page into the cells https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2569 | |
| 20:57:03 | mriedem | and we're going to fail here https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2676 | |
| 20:57:08 | mriedem | because the marker was in cell0 | |
| 20:57:20 | mriedem | so the marker is never found in the other cells, but the limit said to keep checking | |
| 20:57:40 | superdan | we don't clear the marker once we find it? | |
| 20:57:46 | superdan | or maybe we do but not if we start on cell0? | |
| 20:58:15 | mriedem | i don't think we do if we start on cell0 yeah | |
| 20:58:30 | superdan | gotcha | |
| 21:02:39 | mriedem | writing a recreate functional test, should be simple | |
| 21:15:20 | openstackgerrit | Sean Dague proposed openstack/nova master: Migrate to oslo request_id middleware - mv 2.46 https://review.openstack.org/467998 | |
| 21:18:54 | sdague | grrr, requirements conflict | |
| 21:19:00 | sdague | rebased and reapproved | |
| 21:21:07 | mriedem | damn this goes back to newton | |
| 21:21:19 | mriedem | functional regression test has got it recreated though | |
| 21:24:02 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add recreate functional test for regression bug 1689692 https://review.openstack.org/468549 | |
| 21:24:02 | openstack | bug 1689692 in OpenStack Compute (nova) "MarkerNotFound when limit>num(instances) and marker starts in cell0" [High,Triaged] https://launchpad.net/bugs/1689692 - Assigned to Matt Riedemann (mriedem) | |
| 21:24:02 | mriedem | superdan: thar she blar ^ before you leave for 4 days | |
| 21:27:33 | superdan | mriedem: you're going to work on a fix too presumably? | |
| 21:27:40 | superdan | glad that was easy to repro, | |
| 21:27:43 | mriedem | sgordon: heh look familiar? https://bugs.launchpad.net/openstack-manuals/+bug/1693633 | |
| 21:27:43 | openstack | Launchpad bug 1693633 in openstack-manuals "Compute schedulers in Configuration Reference - AggregateImagePropertiesIsolation filter example" [Undecided,Incomplete] | |
| 21:27:45 | superdan | but kinda uncool at the same ime | |
| 21:27:48 | mriedem | superdan: yeah | |
| 21:27:53 | mriedem | should be trivial | |
| 21:27:55 | mriedem | marker = None | |
| 21:28:11 | superdan | aye | |
| 21:40:18 | mriedem | superdan: those hypervisor stats backports are up btw | |
| 21:40:38 | superdan | okay but as soon as the ups man shows up with my weekend toys, I'm outta here | |
| 21:41:00 | mriedem | his truck broke down i heard | |
| 21:41:17 | mriedem | i have to leave soon too | |
| 21:44:13 | mriedem | crap of course there are failing compute api unit tests | |
| 21:48:29 | openstackgerrit | Ed Leafe proposed openstack/nova master: Have scheduler claim resources https://review.openstack.org/463993 | |
| 21:48:30 | openstackgerrit | Ed Leafe proposed openstack/nova master: Pass the number of hosts to return explicitly https://review.openstack.org/465767 | |
| 21:48:30 | openstackgerrit | Ed Leafe proposed openstack/nova master: Remove selecting host based on host_subset_size https://review.openstack.org/465174 | |
| 21:48:31 | openstackgerrit | Ed Leafe proposed openstack/nova master: Pass a list of instance UUIDs to scheduler https://review.openstack.org/465171 | |
| 21:48:31 | openstackgerrit | Ed Leafe proposed openstack/nova master: Return multiple hosts from select_destinations https://review.openstack.org/465768 | |
| 21:49:03 | cburgess | superdan Toys? | |
| 21:49:21 | mriedem | superdan: here it comes | |
| 21:49:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix MarkerNotFound when paging and marker was found in cell0 https://review.openstack.org/468559 | |
| 21:50:02 | figleaf | ...and with that, I'm off. Happy weekend, all! | |
| 21:50:41 | openstackgerrit | Eric Fried proposed openstack/nova master: [WIP] PowerVM: get_inventory() https://review.openstack.org/468560 | |
| 21:51:17 | efried | leakypipes ^^ Hopefully I'm on the right track here. | |
| 22:05:52 | clarkb | as a heads up the nova cells job seems to be failing a lot today | |
| 22:19:08 | sgordon | mriedem_afk, yupppp | |
| #openstack-nova - 2017-05-27 | |||
| 00:07:00 | mriedem | clarkb: looks like a new floating ip test http://logs.openstack.org/11/315311/5/gate/gate-tempest-dsvm-cells-ubuntu-xenial/0ba62de/console.html#_2017-05-26_23_27_35_880306 | |
| 00:07:07 | mriedem | cells v1 doesn't do floating ips | |
| 00:07:51 | melwitt | mriedem: I think this caused it https://review.openstack.org/#/c/458678/ | |
| 00:08:04 | melwitt | bc connect_method defaults to floating_ip | |
| 00:08:12 | melwitt | for [validation] | |
| 00:08:21 | mriedem | hmm | |
| 00:08:26 | mriedem | gggggreat | |
| 00:08:28 | melwitt | tempest.conf from a failed run http://logs.openstack.org/01/468401/4/gate/gate-tempest-dsvm-cells-ubuntu-xenial/1e79120/logs/tempest_conf.txt.gz | |
| 00:09:00 | melwitt | I think we might be able to either disable ssh validation for cells v1 or specify a different connect_method for cells v1 | |
| 00:09:41 | mriedem | i think for now we have to disable validation for cells v1 | |
| 00:09:44 | mriedem | will work up a change | |
| 00:09:55 | mriedem | or someone should | |
| 00:10:04 | melwitt | k. do you think we can put it in our devstack.rc or have to do a devstack change? | |
| 00:11:38 | mriedem | depends on if we can pass TEMPEST_RUN_VALIDATION through d-g | |
| 00:11:44 | mriedem | https://bugs.launchpad.net/devstack/+bug/1693949 | |
| 00:11:44 | openstack | Launchpad bug 1693949 in devstack "cells v1 job failing after ssh validation was enabled by default" [Undecided,New] | |
| 00:12:54 | melwitt | this is the commit, if devstack will pick up what we say in the r. it seems like it would https://github.com/openstack-dev/devstack/commit/ef1e88ec09bda30cad19589629744b59e12b4093 | |
| 00:13:10 | melwitt | *rc | |
| 00:13:25 | mriedem | there isn't a straight pass through for TEMPEST_RUN_VALIDATION | |
| 00:13:29 | mriedem | but i think i know a trick | |
| 00:15:00 | openstackgerrit | Sean Dague proposed openstack/nova master: Be more tolerant of keystone catalog configuration https://review.openstack.org/438049 | |
| 00:19:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Don't run ssh validation in cells v1 job https://review.openstack.org/468585 | |
| 00:19:53 | mriedem | melwitt: ^ let's see if this works | |
| 00:20:26 | melwitt | cool | |