Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-05-25
16:19:33 edleafe I've done it both ways, so I don't care either :)
16:19:33 cdent "that" == add a param
16:19:34 dansmith jaypipes: you know you're just generally silly anyway :)
16:19:38 jaypipes indeed.
16:19:54 jaypipes ok, follow on question...
16:20:37 jaypipes let's say we pass an instance_uuids param to the scheduler. cool, fine by me. But what about the whole "alternate destinations" thing that is designed to solve the no-cell-upcall issue?
16:20:46 jaypipes are we still going for that?
16:21:10 dansmith ...
16:21:22 dansmith have there been other suggestions on how to resolve that other than doing the alternates thing?
16:22:06 edleafe jaypipes: have you seen https://review.openstack.org/#/c/465767/ ?
16:22:21 cdent I gotta run, if there's a summary of this, can someone let me know somehow later this evening?
16:22:31 edleafe cdent: will do
16:22:36 cdent thanks
16:23:02 jaypipes dansmith: not that I'm aware of. was just trying to catch up my thoughts on this series.
16:23:08 dansmith okay
16:23:23 edleafe Adding alternates changes the result of select_destinations() from a list of hosts to a list of a list of hosts
16:24:12 jaypipes edleafe: and you/we are OK with that, yes?>
16:24:39 edleafe It wasn't my preference, no
16:24:52 edleafe But it was a big request from operators, so...
16:25:11 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/468089
16:25:20 mriedem alex_xu: oomichi: we're kind of at an impass with some of the new cinder attachment reviews - john and i are the only reviewers on these but i'm also working on the patches too, so we need a 3rd core to help move some stuff along, can you help review the 3 bottom changes in this series which already have a +2 from john? https://review.openstack.org/#/c/456896/
16:25:32 mriedem *impasse
16:29:35 jaypipes edleafe: is there a reason you undid Sylvain's changes from patch 10 on https://review.openstack.org/#/c/460177/10..11/nova/compute/resource_tracker.py?
16:29:57 jaypipes edleafe: I'd asked him to change the dict comprehension into a simple tracked_keys = set(self.tracked_instances.keys())
16:30:03 jaypipes edleafe: and you undid that.
16:30:26 jaypipes edleafe: and changed instance_uuid -> allocation_uuid.
16:30:31 edleafe jaypipes: probably a rebase screw-up
16:30:34 jaypipes edleafe: just a case of rebase screw up?
16:30:40 jaypipes edleafe: jinx :)
16:30:46 edleafe I rebased my series on master, and his is in the series
16:30:53 jaypipes edleafe: could you please push quick update on that?
16:30:57 jaypipes edleafe: and I will quick approve.
16:30:57 edleafe I'll fix that in a bit
16:31:05 jaypipes since dansmith is already +2 on that
16:31:11 edleafe gimme a few
16:33:45 dansmith mriedem: what ovo impact do you think that context change has?
16:34:14 mriedem dansmith: don't know, but i've thought in the past when we talk about changes to context it can have implications for rpc
16:34:19 mriedem so i was waiting for you
16:34:24 dansmith mriedem: you might also want to get a read from tonyb or jamie on it.. there was some upgrade issue when we bumped oslo.context the last time
16:34:38 dansmith mriedem: yeah, rpc, but not ovo specifically that I know of
16:34:39 mriedem waiting for tony isn't going to be an option
16:34:50 dansmith tonyb was the one handling the upgrade issue last time
16:35:22 openstackgerrit Sean Dague proposed openstack/nova-specs master: oslo.middleware request_id spec https://review.openstack.org/468066
16:36:33 openstackgerrit Sean Dague proposed openstack/nova master: Migrate to oslo request_id middleware - mv 2.46 https://review.openstack.org/467998
16:36:46 sdague mriedem ok all the cross links and blueprint bits filed
16:37:30 sdague dansmith: how do you imagine it would have an impact?
16:38:33 openstackgerrit Ed Leafe proposed openstack/nova master: Have scheduler claim resources https://review.openstack.org/463993
16:38:34 openstackgerrit Ed Leafe proposed openstack/nova master: Pass the number of hosts to return explicitly https://review.openstack.org/465767
16:38:34 openstackgerrit Ed Leafe proposed openstack/nova master: Remove selecting host based on host_subset_size https://review.openstack.org/465174
16:38:35 openstackgerrit Ed Leafe proposed openstack/nova master: Make the method to put allocations public https://review.openstack.org/464086
16:38:36 openstackgerrit Ed Leafe proposed openstack/nova master: Pass a list of instance UUIDs to scheduler https://review.openstack.org/465171
16:38:36 openstackgerrit Ed Leafe proposed openstack/nova master: Return multiple hosts from select_destinations https://review.openstack.org/465768
16:38:38 dansmith sdague: i don't recall the details, which is why I said, but I think that during one of the bumps, we could end up with say a new compute sending a context to an old compute that it couldn't parse or something.. like maybe it wasn't defensive enough in the original version maybe?
16:38:39 edleafe jaypipes: ^^ should be fixed
16:39:02 sdague dansmith: maybe, the from_dict is pretty defensive
16:39:09 dansmith sdague: if the super'd method is defensive with gets like ours is there, then I guess we're okay for this change, I just don't know
16:39:10 sdague it's all .get() calls
16:39:25 mriedem hmm,
16:39:31 dansmith sdague: yeah, either it wasn't before or there was some really subtle detail
16:39:31 mriedem we do have tests for this
16:39:33 sdague https://github.com/openstack/oslo.context/blob/cce83ad5e12baf2edc0e12c2944c587224e71148/oslo_context/context.py#L358-L382
16:39:39 mriedem in the grenade live migration job we have the back and forth live migration thing
16:39:50 sdague mriedem: right
16:39:50 mriedem let me see if that's happening
16:39:58 mriedem it was dependent on a devstack backport to ocata
16:40:01 sdague dansmith: it may not have been a long time ago
16:40:18 sdague jamielennox definitely did a bunch of work on this
16:40:38 dansmith sdague: yeah, that came out of tonyb highlighting the issue I think
16:40:39 dansmith I recall,
16:40:40 jaypipes edleafe: you didn't push the right patch.
16:40:44 dansmith I just don't know the deets
16:40:45 mriedem it was blown up the last midcycle at intel
16:40:48 mriedem which was newton
16:40:48 dansmith right
16:40:50 jaypipes edleafe: https://review.openstack.org/#/c/460177/ was the patch in question.
16:40:51 sdague the worst thing I think that could happen is if we API (new) create context -> cpu (old)
16:40:57 jaypipes edleafe: you pushed all the ones above that.
16:40:59 sdague then pass it back to something new
16:41:04 dansmith yeah
16:41:12 sdague which means some bits would be lost and fall back to defaults
16:41:20 sdague like global_request_id will end up zeroed out
16:41:29 mriedem sdague: ah you merged it https://review.openstack.org/#/c/466033/
16:41:32 mriedem so yeah it should be running
16:41:33 dansmith anyway, if we can't want, then I guess we just do it assuming the tests pass, I'm just saying.. there were dragons here last time and I don't know what they all were
16:41:40 dansmith *wait
16:41:41 edleafe Hmmm... I thought when I changed it back it would push that
16:43:03 openstackgerrit Ed Leafe proposed openstack/nova master: Have scheduler claim resources https://review.openstack.org/463993
16:43:03 openstackgerrit Ed Leafe proposed openstack/nova master: Pass the number of hosts to return explicitly https://review.openstack.org/465767
16:43:04 openstackgerrit Ed Leafe proposed openstack/nova master: Remove selecting host based on host_subset_size https://review.openstack.org/465174
16:43:05 openstackgerrit Ed Leafe proposed openstack/nova master: Make the method to put allocations public https://review.openstack.org/464086
16:43:06 openstackgerrit Ed Leafe proposed openstack/nova master: Don't delete allocation if instance being scheduled https://review.openstack.org/460177
16:43:07 openstackgerrit Ed Leafe proposed openstack/nova master: Pass a list of instance UUIDs to scheduler https://review.openstack.org/465171
16:43:08 openstackgerrit Ed Leafe proposed openstack/nova master: Return multiple hosts from select_destinations https://review.openstack.org/465768
16:43:15 sdague mriedem: yeh, that passed, was there something you were looking for specifically?
16:43:20 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189
16:43:29 edleafe jaypipes: ^^ ok, I made a small whitespace change to make sure it got pushed
16:44:49 sdague mriedem / dansmith if there is an old bug here I could figure out if that could happen again
16:45:25 mriedem looking
16:46:09 jaypipes edleafe: approved.
16:46:17 jaypipes dansmith: https://review.openstack.org/#/c/464086 is ready for your blessing.

Earlier   Later