| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-05-25 | |||
| 14:22:00 | jaypipes | efried: https://review.openstack.org/#/q/topic:cd/placement-api-ref+status:open | |
| 14:22:20 | mriedem | dansmith: the rebase is gone | |
| 14:22:22 | mriedem | *wrong | |
| 14:22:40 | jaypipes | efried: you'll notice we use a similar strategy for most resource creation in the placement client: https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L784-L789 | |
| 14:22:43 | mriedem | but thanks for the stat padding | |
| 14:22:58 | mriedem | oh wait | |
| 14:23:04 | mriedem | yeah, | |
| 14:23:05 | mriedem | wrong again | |
| 14:23:44 | efried | avolkov jaypipes Thanks y'all. | |
| 14:24:06 | dansmith | mriedem: okay, I'm doing like six things at once, so I'll look again in a sec | |
| 14:25:30 | danpawlik | mriedem: http://imgur.com/g5Mo9KT | |
| 14:26:49 | jaypipes | dansmith: only six? | |
| 14:27:26 | dansmith | jaypipes: I can only count that high | |
| 14:28:03 | danpawlik | mriedem: I don't have ant problems to install new nvidia drivers if vendor is not set | |
| 14:28:24 | danpawlik | mriedem: I try to install the newest drivers | |
| 14:29:25 | dansmith | mriedem: oh, I don't get why git keeps dropping that removal | |
| 14:29:27 | mriedem | danpawlik: ok | |
| 14:29:46 | mriedem | dansmith: you can blame it on the rain, but you can't blame it on git | |
| 14:29:56 | mriedem | sdague: question/comment in https://review.openstack.org/#/c/467995/ | |
| 14:30:04 | openstackgerrit | Sean Dague proposed openstack/nova master: Migrate to oslo request_id middleware https://review.openstack.org/467998 | |
| 14:30:11 | sdague | mriedem: looking | |
| 14:32:03 | dansmith | mriedem: well, it just drops that hunk without calling it a conflict, so I'll blame it anyway | |
| 14:32:28 | openstackgerrit | Dan Smith proposed openstack/nova master: re-Allow adding computes with no ComputeNodes to aggregates https://review.openstack.org/460616 | |
| 14:32:37 | dansmith | maybe we could merge this and avoid me chasing rebases | |
| 14:32:49 | sdague | mriedem: answered | |
| 14:33:20 | sdague | the constructor for oslo.context in the from_ methods use the original class | |
| 14:33:24 | mriedem | https://s-media-cache-ak0.pinimg.com/236x/75/c1/dc/75c1dcb4c3ab545deeb1f192eef3c0af.jpg?noindex=1 | |
| 14:33:28 | mriedem | just a bunch of hunks | |
| 14:33:39 | sdague | so that's how we still end up with nova context | |
| 14:33:44 | sdague | after the super call | |
| 14:33:50 | sdague | links in review | |
| 14:34:43 | mriedem | # TODO(sdague): also context has show_deleted, we should | |
| 14:34:46 | mriedem | also or oslo? | |
| 14:35:19 | mriedem | dansmith: i've been your huckleberry for weeks on this one | |
| 14:36:18 | sdague | mriedem: heh, yeh | |
| 14:36:22 | sdague | I can fix the typo | |
| 14:37:36 | openstackgerrit | Sean Dague proposed openstack/nova master: Have nova.context use super from_context https://review.openstack.org/467995 | |
| 14:37:40 | mriedem | alex_xu: jaypipes: re-confirming, but when deleting a service we don't actually delete the compute_nodes record, | |
| 14:37:45 | mriedem | nothing actually deletes the compute_nodes record | |
| 14:37:48 | mriedem | https://review.openstack.org/#/c/467220/4//COMMIT_MSG | |
| 14:40:04 | openstackgerrit | Matt Rabe proposed openstack/nova master: Query deleted instance records during _destroy_evacuated_instances https://review.openstack.org/467774 | |
| 14:41:11 | danpawlik | mriedem: new drivers install correctly. I will add mention about windows and vendor_id | |
| 14:41:23 | danpawlik | in release notes soon | |
| 14:43:25 | edleafe | jaypipes: got a minute (or 10) to talk about https://review.openstack.org/#/c/465171/ ? | |
| 14:43:51 | jaypipes | edleafe: on call for 15, then free. | |
| 14:44:15 | edleafe | jaypipes: okee dokee | |
| 14:46:24 | cdent | edleafe: ping me when you start, I'd like to ride along please | |
| 14:46:41 | edleafe | cdent: roger that | |
| 14:47:32 | sdague | mriedem: the context bits look good to you now? | |
| 14:47:59 | sdague | given that we're blocking a constraint update on that | |
| 14:48:10 | mriedem | sdague: +1 until dansmith can take a look | |
| 14:48:19 | sdague | ok, cool | |
| 14:48:38 | dansmith | mriedem: sdague: I got a call starting in a few and then I'll look | |
| 14:48:45 | sdague | dansmith: sounds good | |
| 14:48:48 | sdague | thank you | |
| 14:49:02 | sdague | mriedem: I have an orthoginal (but related question) | |
| 14:49:27 | sdague | for nova to be a good player in global request id, and accept them, we need https://review.openstack.org/#/c/467998/ | |
| 14:49:33 | alex_xu | mriedem: yea, i think so. and interesting bug, add it into review list | |
| 14:49:39 | sdague | which is going to cause an extra http header to emit | |
| 14:49:50 | sdague | microversion? | |
| 14:49:57 | mriedem | alex_xu: i'm fixing the test in that one | |
| 14:50:10 | sdague | alex_xu might also want to weigh in there | |
| 14:50:46 | mriedem | sdague: i tend to say yes, otherwise how do you know if the cloud has the header or not? | |
| 14:50:48 | mriedem | however, | |
| 14:51:03 | mriedem | do we hook in something that removes the header for requests < new microversion? | |
| 14:51:10 | sdague | nope | |
| 14:51:22 | mriedem | otherwise the new microversion is only signaling | |
| 14:51:27 | sdague | correct | |
| 14:51:42 | sdague | also, it depends on code version on the server and if they follow our upper constraints | |
| 14:52:04 | sdague | it's definitely a little messy, and mostly annoying we didn't do this a long time ago | |
| 14:52:16 | mriedem | sdague: we can't require a new minimum version of oslo.middleware? | |
| 14:52:39 | sdague | maybe, I can look at the force on the requirements side | |
| 14:52:48 | sdague | we could land it with the requirements force | |
| 14:55:16 | mriedem | you want oslo.middleware>=3.27.0 it looks like | |
| 14:55:20 | mriedem | for https://github.com/openstack/oslo.middleware/commit/0e3dbba0d9d373fbfa9e28897cd33377e2491d32 | |
| 14:56:32 | sdague | yep | |
| 14:56:40 | alex_xu | emm...any special reason for not having a microversion? | |
| 14:56:51 | sdague | https://review.openstack.org/#/c/468057/ | |
| 14:57:46 | sdague | mriedem: ok, I'll build on top of that in my spider of crazy depends on | |
| 15:01:28 | edleafe | jaypipes: free? | |
| 15:01:37 | jaypipes | edleafe: sorry, still on call. | |
| 15:01:46 | jaypipes | edleafe: will ping you asap. | |
| 15:02:30 | edleafe | jaypipes: kewl | |
| 15:05:21 | openstackgerrit | Sean Dague proposed openstack/nova master: Migrate to oslo request_id middleware - mv 2.46 https://review.openstack.org/467998 | |
| 15:06:44 | mriedem | sdague: you'll throw a shoe, but we should have a bp and spec for that microversion | |
| 15:06:55 | mriedem | i imagine it will be small | |
| 15:07:36 | sdague | mriedem: specless blueprint? | |
| 15:07:39 | cdent | I should warn you, I do no the other one, so if you like that one, you're gonna hobble for a long time | |
| 15:07:49 | mriedem | sdague: all api changes need a spec | |
| 15:07:53 | mriedem | thems the rules | |
| 15:09:17 | mriedem | smcginnis: so what kind of fun dual maintenance path is it going to be for os-brick in both python and go? | |
| 15:09:31 | sdague | mriedem: ok, let me throw together something quick | |
| 15:10:51 | mriedem | jaypipes: isn't this vestigial now? https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L800 | |
| 15:11:49 | mriedem | added in https://github.com/openstack/nova/commit/8941b45bc58a833261bb09fc7eb8fb5c765e154a | |
| 15:12:18 | mriedem | wondering b/c of https://github.com/openstack/nova/commit/ea4754ba21ea08eb367d62bc46b5eba3777c119c | |
| 15:12:23 | jaypipes | mriedem: yeah. the comment can be removed. | |
| 15:20:49 | smcginnis | mriedem: Eh, it's inevitable. | |
| 15:24:28 | mriedem | hmm, i've got questions about compute nodes and services records | |
| 15:24:34 | mriedem | b/c something isn't adding up | |
| 15:25:44 | mriedem | deleting a nova-compute service record doesn't delete the compute_nodes record, | |