| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-05-18 | |||
| 13:00:16 | mlakat | I also added some more info to today's meeting: https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 13:00:30 | kashyap | And, thanks for the link to that eventlet bug, useful to learn about it | |
| 13:05:03 | openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954 | |
| 13:19:37 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove DeviceIsBusy exception https://review.openstack.org/465723 | |
| 13:35:40 | openstackgerrit | Naichuan Sun proposed openstack/nova master: xenapi: cached images should be cleaned up by time https://review.openstack.org/465954 | |
| 13:35:40 | artom | mriedem, heya, thanks for +W'ing the bottom 2 tagged attach patches :) Question for you in https://review.openstack.org/#/c/376021/49 - I'm not sure what you mean by moving error handling lower down, as I don't see a way to do it consistently without handling at least 1 new exception in the API layer | |
| 13:36:13 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Remove various deprecated options https://review.openstack.org/465502 | |
| 13:38:30 | mriedem | artom: for example https://review.openstack.org/#/c/391941/42/nova/compute/api.py@3786 | |
| 13:38:45 | mriedem | you're now raising VolumeTaggedAttachToShelvedNotSupported from nova.compute.api.API.attach_volume | |
| 13:39:19 | mriedem | but not handling that exception in the REST API controller code https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/volumes.py#L337 | |
| 13:39:25 | mriedem | not in that patch anyway | |
| 13:39:49 | mriedem | and not handling it in the rest api controller code means it would result in a 500 | |
| 13:39:55 | openstackgerrit | Edu Alcaniz proposed openstack/nova master: follow up https://review.openstack.org/465975 | |
| 13:40:04 | mriedem | i realize you can't get that exception until the microversion because the tag isn't in the schema yet, | |
| 13:40:12 | artom | mriedem, oh, you mean move the error handling to the same *patch* | |
| 13:40:16 | artom | Not the same layer | |
| 13:40:17 | mriedem | but i'd prefer to see the error handling for the rest api done in the same methods that introduce those exceptions | |
| 13:40:20 | mriedem | yes | |
| 13:40:23 | mriedem | same patch | |
| 13:40:35 | artom | OK, sorry | |
| 13:40:36 | mriedem | lower layer in the series of changes is what i meant | |
| 13:41:05 | artom | OK, makes sense, will do that :) | |
| 13:43:58 | mriedem | melwitt: replied on https://review.openstack.org/#/c/465042/ - i think we can just backport, resolve the conflict and note it in the commit message | |
| 13:44:04 | mriedem | i don't think we need 2 patches on master for that | |
| 13:44:38 | cdent | mriedem: I think edleafe is at pycon, jaypipes in china, and i have to go outside to wait for someone to come rescue my car, so I think bauzas (if he's around) will be your go to guy for today's meeting's scheduler update | |
| 13:45:21 | mriedem | cdent: i can run it actually, kid is home sick so i'll be here to do it | |
| 13:45:57 | bauzas | yup I'm there | |
| 13:46:12 | cdent | i assumed you were running it, mriedem, just the scheduler part, which looks like bauzas has under control | |
| 13:46:24 | mriedem | oh i see | |
| 13:46:25 | mriedem | ok | |
| 13:47:00 | bauzas | fine by me | |
| 13:57:07 | mriedem | grenade live migration job is basically 100% fail http://logs.openstack.org/42/465042/5/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/6aae0c3/console.html#_2017-05-18_00_39_25_007223 | |
| 13:57:13 | mriedem | Failed to restart devstack@g-api.service: Unit devstack@g-api.service not found. | |
| 13:57:50 | mriedem | i assume because on master that code is expecting systemd, but started on ocata with screen | |
| 14:00:49 | sdague | yeh, though that should have been pinned | |
| 14:01:26 | sdague | mriedem: oh, the live migration scripts are all super custom | |
| 14:01:33 | sdague | they are going to need adjustments | |
| 14:02:27 | sdague | mriedem: grenade completed fine | |
| 14:02:46 | sdague | the scripts after that are making assumptions | |
| 14:03:34 | mriedem | sdague: will dig after the nova meeting | |
| 14:15:29 | mriedem | https://bugs.launchpad.net/nova/+bug/1691769 | |
| 14:15:29 | openstack | Launchpad bug 1691769 in OpenStack Compute (nova) "gate-grenade-dsvm-neutron-multinode-live-migration-nv fails in pike: "Failed to restart <email address hidden>: Unit <email address hidden> not found."" [Medium,Triaged] | |
| 14:40:30 | takashin | dansmith: Would you review https://review.openstack.org/#/c/408955/ again? | |
| 14:44:41 | mriedem | takashin: i'm confused, | |
| 14:44:51 | mriedem | https://review.openstack.org/#/c/408964/49/nova/api/openstack/api_version_request.py and https://review.openstack.org/#/c/459483/3/nova/api/openstack/api_version_request.py are competing for the same microversion, | |
| 14:45:05 | mriedem | but i thought the abort cold migration blueprint dependent on being able to list cold migrations? | |
| 14:45:26 | mriedem | oh nvm | |
| 14:45:30 | mriedem | i'm thinking of a different blueprint | |
| 14:45:37 | mriedem | this is cold migration with a target host | |
| 14:51:25 | takashin | mriedem: As you said, there is no dependency between "cold migration with target host" and "List/show all migration types" blueprint. | |
| 14:55:35 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix uuid replacement in aggregate notification test https://review.openstack.org/465896 | |
| 14:55:42 | mriedem | sdague: i'm confused that USE_SCREEN=False on the old side of this live migration grenade job http://logs.openstack.org/42/465042/5/check/gate-grenade-dsvm-neutron-multinode-live-migration-nv/6aae0c3/logs/old/local_conf.txt.gz | |
| 14:55:43 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix uuid replacement in aggregate notification test https://review.openstack.org/465896 | |
| 14:55:48 | mriedem | i thought screen was still the default in devstack in ocata? | |
| 14:56:43 | mriedem | i guess it is https://github.com/openstack-dev/devstack/blob/stable/ocata/stackrc#L88 | |
| 14:58:24 | sdague | mriedem: the confusion is there are 3 operating modes right now | |
| 14:59:10 | sdague | USE_SCREEN=False before a month ago, means direct exec everything in bash and hope you captured the pid correctly to kill it later | |
| 14:59:32 | sdague | we've used that in the gate for the last 3 years because screen races | |
| 14:59:54 | sdague | and in the non repeat state, it's fine. | |
| 15:00:21 | sdague | it is a different home grown init system with different bad trade offs than screen | |
| 15:01:58 | dpawlik | Hi.If you have some time pls review my PS https://review.openstack.org/#/c/459753/ | |
| 15:02:00 | dpawlik | thanks a lot | |
| 15:02:19 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform aggregate.add_host notification https://review.openstack.org/396210 | |
| 15:04:04 | ftersin | mriedem: hi. who could review https://review.openstack.org/#/c/407440/ ? | |
| 15:04:35 | ftersin | mriedem: who of you guys is more familiar with that area? | |
| 15:04:44 | mriedem | ftersin: mdbooth | |
| 15:05:11 | ftersin | mriedem: thx | |
| 15:07:02 | ftersin | mdbooth: hi. are you around? | |
| 15:07:12 | mdbooth | ftersin: Yep | |
| 15:07:57 | ftersin | mdbooth: could you look at https://review.openstack.org/#/c/407440/ again? | |
| 15:08:05 | mdbooth | Yeah, sure. | |
| 15:08:32 | mdbooth | So, my issue with that patch has always been the number of changes required in driver.py | |
| 15:08:57 | mdbooth | Which is obvious an artifact of the imagebackend interface being completely borked | |
| 15:08:59 | ftersin | mdbooth: i addressed some your comments there. so, it'd be good to get new ones :) | |
| 15:09:06 | mdbooth | Somebody should clean that up... ;) | |
| 15:09:28 | mdbooth | Anyway, we also agreed at some point to move on with it anyway, so I'll try to look again in that light | |
| 15:09:47 | mriedem | sdague: ok, so maybe i didn't ask the right question, | |
| 15:10:01 | mriedem | i'm basically wondering what i can key off of to fix this grenade live migration issue | |
| 15:10:07 | sdague | mriedem: no | |
| 15:10:18 | sdague | you are going to need more complex logic | |
| 15:10:25 | openstackgerrit | Chris Friesen proposed openstack/nova master: correctly log port id in neutron api https://review.openstack.org/466003 | |
| 15:10:36 | cfriesen | ^ trivial fix to logging | |
| 15:11:08 | sdague | mriedem: https://github.com/openstack-dev/devstack/blob/6a62619cbc28625755a76eae08b529438eb4f281/stackrc#L166-L173 | |
| 15:11:17 | sdague | that's the gate level work around, and why grenade works | |
| 15:11:18 | cfriesen | crap, let me respin that...an extra file snuck in | |
| 15:12:47 | sdague | mriedem: USE_SCREEN=False is always the case for the gate | |
| 15:13:02 | sdague | it's just that we decided to make the transition simpler by making that mean something else | |
| 15:13:13 | sdague | so 95% of things just worked | |
| 15:13:14 | dpawlik | mriedem: thanks for review. DocImpact-Group: openstack/glance is because someone on this channel told me that docs are related to Openstack Glance. I will create a new PS soon. Thanks! | |
| 15:13:19 | mriedem | sdague: ok i see that in devstack-gate localrc_set "$localrc_file" "USE_SCREEN" "False" | |
| 15:13:24 | sdague | the grenade cases needed this one extra hit | |
| 15:13:35 | sdague | hint | |
| 15:13:48 | ftersin | mdbooth: this patch does not bring a lot of changes for driver.py. Moreover, some changed might be separated out of this patch. E.g. see a series started with https://review.openstack.org/#/c/411942 | |
| 15:13:55 | sdague | then you are dealing with things that wrote their own service management logic outside of devstack | |
| 15:14:06 | sdague | which reacted poorly | |
| 15:14:36 | sdague | because their start/stop/restart calls aren't going through devstack code with vars that would have done the right things | |
| 15:14:40 | openstackgerrit | Chris Friesen proposed openstack/nova master: correctly log port id in neutron api https://review.openstack.org/466003 | |
| 15:14:54 | sdague | so options are: 1) replicate special logic | |
| 15:15:01 | sdague | 2) redo them to use devstack functions | |
| 15:15:17 | sdague | 3) not care about this one job that's in a tarpit | |