Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-05-01
17:23:49 openstackgerrit Dan Smith proposed openstack/nova master: Make discover_hosts only query for unmapped ComputeNode records https://review.openstack.org/427903
17:24:19 dansmith mriedem: I was thinking, we could make the scheduler call the host discovery on SIGHUP, which may be more straightforward (i.e. you have to SIGHUP the scheduler to notice new hosts
17:24:25 edleafe jaypipes: I sure hope so :)
17:24:35 jaypipes edleafe: thanks for the encouragement.
17:24:42 cdent jaypipes: could be, but it is also very useful for the rest of us who are not in your brain to actually talk about it and figure out the larger context of what's going on. For example my latest comment is basically about what "typical" is.
17:24:57 cdent think of this as an educational opportunity™
17:25:08 cdent a union of souls over one page
17:25:55 jaypipes cdent, edleafe: are you essentially asking me to add a "agg_ids" argument to _get_providers_sharing_capacity() that would winnow the resulting provider ID list to only the aggregates that have been previously selected in ResourceProviderList.get_all_by_filters()?
17:25:59 openstackgerrit Chris Friesen proposed openstack/nova master: Tweak the cpu_realtime_mask handling slightly https://review.openstack.org/461456
17:26:11 cfriesen_ jaypipes: what would you say to something like this?
17:26:59 edleafe jaypipes: no, not if you are then going to use that in a future join expression.
17:27:20 edleafe jaypipes: there wasn't any indication in the code that this would be happening
17:27:24 jaypipes edleafe: precisely my plan, yes.
17:28:05 jaypipes edleafe: what do you mean there wasn't any indication in the code? you mean the code comments didn't say how I'd be using the result of _get_providers_sharing_capacity()?
17:28:07 cdent jaypipes: I'm not asking for a specific action, I'm simply trying to understand the intent and more importantly the context within which the stuff is going to operate. without that I can't review very effectively
17:28:25 edleafe jaypipes: your since-corrected comments also made it sound like it was going to be "in the same aggregate"
17:28:27 jaypipes cdent: k, then lemme push more patches that show that.
17:28:41 jaypipes edleafe: k, lemme push some patches.
17:29:44 cdent my new strategy for everything is to be 5yo and ask "why". Soon everyone will hate me.
17:30:02 edleafe cdent: "soon"??
17:30:13 cfriesen_ cdent: your punishment is to watch all episodes of "Paw Patrol"
17:30:14 cdent edleafe: just because you already hate me
17:30:39 cdent cfriesen_: my mom doesn't let me watch older kids tv
17:33:25 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-agents endpoint instead of stevedore https://review.openstack.org/461459
17:39:16 openstackgerrit Jay Pipes proposed openstack/nova master: placement: get providers sharing capacity https://review.openstack.org/460798
17:40:04 jaypipes cdent: ^^ removed the aggregate stuff from the test case..
17:40:15 jaypipes working on follow up patches now. gimme about half hour.
17:41:17 cdent thanks jaypipes, it wasn't a huge sin that stuff being in there, it was just that it was misleading with regard to the thing being tested (without more insight into what's going on). It really did make me think that I was missing something in your code.
17:41:25 cdent will watch out for the new stuff
17:42:57 dansmith mriedem: what do you want me to put as the message for the NovaException in that coding error case? I don't want to reveal too much to the user
17:43:12 dansmith just "Internal Error" ?
17:43:32 mriedem umm
17:43:52 mriedem default is msg_fmt = _("An unknown exception occurred.")
17:43:59 mriedem maybe that's good enough
17:44:04 dansmith ack
17:45:28 jaypipes cdent: yep, agree with ya.
17:46:30 openstackgerrit Dan Smith proposed openstack/nova master: re-Allow adding computes with no ComputeNodes to aggregates https://review.openstack.org/460616
17:47:35 openstackgerrit Chris Dent proposed openstack/nova master: devref and reno for nova-{api,metadata}-wsgi scripts https://review.openstack.org/461289
17:47:35 openstackgerrit Chris Dent proposed openstack/nova master: Add pbr-installed wsgi application for metadata api https://review.openstack.org/459413
17:47:40 cdent I think I got those nits mriedem ^
17:47:49 cdent but could very well have add more
17:48:53 openstackgerrit Kaitlin Farr proposed openstack/nova master: Remove deprecated keymgr code https://review.openstack.org/439855
18:05:00 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-assisted-volume-snapshots endpoint https://review.openstack.org/461470
18:05:34 mriedem cdent: yup, one tiny issue
18:05:43 cdent yay!
18:06:12 cdent nice catch
18:08:56 openstackgerrit Chris Dent proposed openstack/nova master: devref and reno for nova-{api,metadata}-wsgi scripts https://review.openstack.org/461289
18:16:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Add uuid to service.update notification payload https://review.openstack.org/461473
18:24:17 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-availability-zone endpoint instead of stevedore https://review.openstack.org/461475
18:29:05 openstackgerrit Dan Smith proposed openstack/nova master: WIP: De-complicate some of the instance delete path https://review.openstack.org/458636
18:29:06 openstackgerrit Dan Smith proposed openstack/nova master: Move to proper target_cell calling convention https://review.openstack.org/458634
18:29:06 openstackgerrit Dan Smith proposed openstack/nova master: Make target_cell() yield a new context https://review.openstack.org/458635
18:29:07 openstackgerrit Dan Smith proposed openstack/nova master: DNM: Canary test against multi-cell devstack https://review.openstack.org/458537
18:29:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Add uuid to service.update notification payload https://review.openstack.org/461473
18:36:44 openstackgerrit Mathieu Gagné proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322
18:38:46 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-fixed-ips endpoint instead of stevedore https://review.openstack.org/461479
18:53:21 jaypipes I think dansmith is going to add some vomit to his snot when he sees the SQL in my next patch.
18:56:33 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-baremetal-nodes endpoint instead of stevedore https://review.openstack.org/461480
18:59:37 cdent vomitty snot! \o/
19:01:37 edleafe that reminds me... lunchtime!
19:04:54 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-availability-zone endpoint instead of stevedore https://review.openstack.org/461475
19:05:14 openstackgerrit Eric Fried proposed openstack/nova-specs master: Updates for [glance]api_servers and ksa https://review.openstack.org/461481
19:05:18 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-fixed-ips endpoint instead of stevedore https://review.openstack.org/461479
19:05:26 efried mriedem mordred jaypipes ^^
19:05:39 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-baremetal-nodes endpoint instead of stevedore https://review.openstack.org/461480
19:19:19 dtroyer I've got a question on the interaction between aggregates and cells… I have a Mitaka DevStack configuration that has n-cell enabled; the hosts from "nova host-list" look like cell!region@vxd-mitaka, which aggregate-add-host does not like. Is this not a valid thing? Or am I missing something here?
19:19:43 jaypipes efried: gonna be while...
19:20:03 mriedem dtroyer: cells v1 doesn't support aggregates
19:20:05 efried jaypipes Don't think there's a hurry. mriedem asked me to update based on [glance]api_servers decision.
19:20:25 dtroyer mriedem: cool, that's what I needed to know. is there a way from the API to know if I have cells v1 or v2?
19:21:09 mriedem dtroyer: well, one thing i guess is GET /os-cells would return something for cells v1 if enabled https://developer.openstack.org/api-ref/compute/#cells-os-cells-capacities
19:21:17 mriedem that's admin-only by default
19:21:19 mriedem the api i mean
19:21:36 mriedem but cells v1 runs the separate n-cell service, that's how devstack checks it
19:21:46 mriedem dtroyer: cells v2 is baked in, not a separate service or API
19:21:55 dtroyer mriedem: thanks. I'm trying to do graceful failures in OSC in the aggregate commands so admin-only is OK
19:21:58 mriedem dtroyer: so starting in ocata, you're running cells v2 by design
19:22:00 dtroyer ah, gotcha
19:22:10 mriedem even if you're running cells v1, you have cells v2 :)
19:22:14 mriedem consider your mind blown
19:22:45 mriedem dtroyer: the other thing would probably be the /os-services API
19:23:08 mriedem https://github.com/openstack/nova/blob/master/nova/cmd/cells.py#L41
19:23:08 dtroyer mriedem: one more question… I have a note that nova-net required cells v1, that doesn't seem right to me…
19:23:23 mriedem if you're running cells, there should be a nova-cells service binary in the GET /os-services response
19:23:35 mriedem i think anyway
19:23:43 mriedem dtroyer: other way around
19:23:47 mriedem well,
19:24:01 mriedem cells v1 support in-tree requires nova-net,
19:24:17 dtroyer ok, that explains a couple of things. thanks
19:24:29 mriedem dtroyer: in ocata we made nova-network only start under a cells v1 config
19:24:32 mriedem that's probably the confusion
19:24:48 dtroyer I bet so
19:25:07 mriedem we basically just continued to disable nova-net in ocata,
19:25:15 mriedem and switched all jobs to use neutron except for the cells v1 job
19:31:13 dansmith jaypipes: I don't hate your sql, I admire it.
19:31:18 dansmith jaypipes: I just note that I shan't be debugging it if something goes wrong
19:31:34 cdent tshirt
19:39:21 openstackgerrit Eric Fried proposed openstack/nova-specs master: Updates for [glance]api_servers and ksa https://review.openstack.org/461481
19:53:09 openstackgerrit Ed Leafe proposed openstack/nova master: Remove the can_host column https://review.openstack.org/461494
19:56:21 melwitt jaypipes: fyi I pushed an update to the quotas series attempting to address your comments https://review.openstack.org/#/c/446239

Earlier   Later