| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-27 | |||
| 20:13:54 | cdent | mriedem: have you stopped shaving yet? | |
| 20:13:54 | edleafe | mriedem showers every month whether he needs it or not | |
| 20:13:55 | macsz | edleafe: i was just getting there, which would then require getting there a little further and further :D | |
| 20:14:01 | mriedem | cdent: i actually shave more surprisingly | |
| 20:14:06 | mriedem | b/c i have more time in the morning | |
| 20:14:57 | cdent | ah the halcyon days of early work-at-home: "time in the morning" | |
| 20:15:04 | melwitt | abhi89: in the test if you provide an example message when constructing the OverLimit exception, to simulate the cinder client raising that, then you can assert it in our response text | |
| 20:19:23 | abhi89 | melwitt: when constructing the OverQuota exception(copying OverLimit exception's message to OverQuota exception), i should do what! I didnot understand | |
| 20:19:45 | cdent | 'night all | |
| 20:21:55 | melwitt | abhi89: in the test "test_over_limit_volumes" in nova/tests/functional/regressions/test_bug_1554631.py you could provide an example exception message when constructing the cinder_exceptions.OverLimit() object. and then you assert part of the message in the response text. that would verify that we're passing through the error message from cinder. does that make sense? | |
| 20:27:06 | bauzas | mriedem: dansmith: others, have you seen https://review.openstack.org/#/c/460455/1 ? | |
| 20:27:53 | dansmith | bauzas: hadn't yet but cool | |
| 20:28:04 | efried | mordred Thanks for looking. Will proceed with UT. | |
| 20:28:22 | efried | mordred Having pored over os-client-config code a bit, I think I may be ready to start asking leading questions, whenever you have a mo. | |
| 20:28:26 | bauzas | dansmith: mriedem: the main problem with the scheduler is that we don't have the instance UUIDs there | |
| 20:29:04 | mordred | efried: awesome - I'm on (very fun) phone call at the moment- hopefully off soon | |
| 20:29:15 | abhi89 | melwitt: so the example exception message when constructing cinder_exceptions.OverLimit() should have common text from all 3 types of exception messages, so that we can check with assertIn whether this example message is part of all 3 exception messages.. this is what you meant? | |
| 20:29:36 | erhudy | hdecejhbhdednddujvregvebfhcjhjngbrjhrekfikgf | |
| 20:29:39 | erhudy | oops! | |
| 20:29:54 | erhudy | treacherously betrayed by a hairtrigger yubikey | |
| 20:31:17 | mriedem | bauzas: we don't? i thought the host manager pulled the instance uuids per host on startup? | |
| 20:31:18 | melwitt | abhi89: no, I was suggesting we can just pick one specific one and use it as the example in the test. because what we really want to know is if we are preserving the message from cinder and propagating that to the end user | |
| 20:31:22 | mriedem | via update_instance_info? | |
| 20:31:26 | mriedem | which is configurable though | |
| 20:32:00 | bauzas | mriedem: because we only provide the first instance into the RequestSpec object to the scheduler | |
| 20:32:56 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/460515 | |
| 20:34:29 | abhi89 | melwitt: but how can we pick one specific message & test it against the 3 exception messages.. the UT will fail in the other 2 cases.. i agree with you that we need to know whether we are preservinfg the message from cinder or not.. | |
| 20:36:01 | melwitt | abhi89: we pick one specific message and test against the one specific message. I think that would be good enough. earlier I mentioned all scenarios but since we've been talking about it, the main idea is verifying we preserve the message from cinder, and we can use just one specific example to do that | |
| 20:37:07 | mriedem | dansmith: comments in https://review.openstack.org/#/c/460616/ | |
| 20:42:29 | openstackgerrit | Chris Friesen proposed openstack/nova master: show flavor info in server details https://review.openstack.org/434514 | |
| 20:42:40 | cfriesen | ^ hopefully this passes all the tests now | |
| 20:46:41 | mriedem | sdague: if you can get https://review.openstack.org/#/c/457008/ at some point we can close out the 2.45 blueprint | |
| 20:46:52 | sdague | mriedem: looking | |
| 20:47:20 | sdague | mriedem: bam! | |
| 20:48:06 | mriedem | thanks | |
| 20:48:31 | mriedem | did you see the easter egg i put in there for you? | |
| 20:55:05 | mriedem | nova meeting in #openstack-meeting in 5 minutes | |
| 20:56:54 | dansmith | mriedem: I'm going to skip the nova meeting today.. feeling crappy and doing a few other things | |
| 20:57:05 | dansmith | mriedem: I think you can fill everyone in on the extensive discussions at the cells meeting, right? | |
| 20:57:12 | mriedem | god i hope so | |
| 20:58:14 | abhi89 | melwitt: I will trying doing what you have told. Thanks for your input.. | |
| 21:00:35 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/460515 | |
| 21:03:57 | openstackgerrit | Steve Noyes proposed openstack/nova master: Add Cinder v3 detach to shutdown_instance https://review.openstack.org/456877 | |
| 21:56:34 | mriedem | hferenc: gibi: blasted the ML :) | |
| 22:43:40 | mriedem | mtreinish: some easy stuff to fix up in https://review.openstack.org/#/c/459460 | |
| 23:15:32 | Kevin_Zheng | mriedem: hi, for https://review.openstack.org/#/c/459569 , the assertion fails now, I think it is not what we expected? | |
| 23:16:48 | mtreinish | mriedem: so on the pokicy bits, I tried to delete them before but a bunch of testing started complaining there was no policy for the endpoint | |
| 23:17:07 | mtreinish | s/pokicy/policy/ | |
| 23:23:06 | openstackgerrit | Matthew Treinish proposed openstack/nova master: Remove nova-cert https://review.openstack.org/459460 | |
| 23:23:46 | mtreinish | mriedem: ^^^ | |
| 23:31:55 | mriedem | mtreinish: probably some policy test to see that all apis have policy registered, | |
| 23:32:09 | mriedem | but i'd think we could remove that for os-certificates as we don't actually use the policy | |
| 23:33:34 | mriedem | Kevin_Zheng: you mean this right? http://logs.openstack.org/69/459569/6/check/gate-nova-python27-ubuntu-xenial/3f13311/console.html#_2017-04-27_07_11_57_717635 | |
| 23:35:19 | mriedem | Kevin_Zheng: maybe rather than assert equality, which might not be implemented for ObjectListBase.__eq__, assert the length is the same, is 1, and the single tag between both is the same | |
| 23:35:22 | Kevin_Zheng | yeah | |
| 23:35:23 | mtreinish | mriedem: ok, I'll look at that tomorrow, or later tonight | |
| 23:35:50 | Kevin_Zheng | mriedem: ok, got it | |
| 23:36:15 | mriedem | Kevin_Zheng: yeah it doesn't implement __eq__ https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L778 | |
| 23:36:34 | mriedem | mtreinish: you must be getting soft in your old age | |
| 23:38:39 | mtreinish | mriedem: heh, that must be it | |
| 23:43:24 | openstackgerrit | Chris Friesen proposed openstack/python-novaclient master: 2.46: Show flavor info in server details https://review.openstack.org/435141 | |
| 23:43:59 | cfriesen | mriedem: what's the story on needing functional tests for this ^ ? I noticed that the last couple of changes you made in novaclient had no function tests. | |
| 23:45:31 | mriedem | cfriesen: do as i say, not as i do | |
| 23:46:00 | mriedem | cfriesen: we'll likely want functional tests for those since it's a new microversion that changes the output | |
| 23:46:19 | mriedem | cfriesen: 2.43 and 2.44 were just deprecations, so i think unit tests were sufficient | |
| 23:46:34 | mriedem | and 2.45 wasn't changing output really, it was handling the response differently | |
| 23:47:24 | mriedem | when you have to mess with the fixture stuff too much it gets weird https://review.openstack.org/#/c/435141/5/novaclient/tests/unit/fixture_data/servers.py | |
| 23:49:16 | mriedem | cfriesen: but it looks like you did a lot of work with the fixture stuff already, and i'm probably not going to dig through all of that code tonight | |
| 23:49:33 | mriedem | i've got a mother in law en route | |
| 23:54:22 | cfriesen | mriedem: kay, I'll give it a shot | |
| 23:56:50 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Make discover_hosts only query for unmapped ComputeNode records https://review.openstack.org/427903 | |
| 23:56:50 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add ability to query for ComputeNodes by their mapped value https://review.openstack.org/427902 | |
| 23:56:51 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add ComputeNode.mapped field https://review.openstack.org/427901 | |
| #openstack-nova - 2017-04-28 | |||
| 00:25:51 | openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.46 - Enable cold migration with target host https://review.openstack.org/406707 | |
| 00:25:59 | openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.46 - List/Show all server migration types https://review.openstack.org/430839 | |
| 01:22:20 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: get providers sharing capacity https://review.openstack.org/460798 | |
| 01:22:28 | jaypipes | alex_xu, mriedem, dansmith, edleafe, bauzas: ^^ | |
| 01:22:46 | jaypipes | more of dansmith's favourite SQL-fu. | |
| 01:25:27 | openstackgerrit | Matthew Treinish proposed openstack/nova master: Remove nova-cert https://review.openstack.org/459460 | |
| 01:46:37 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Avoid forcing translation on logging calls https://review.openstack.org/413876 | |
| 01:46:46 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix examples for add/removeFixedIp action https://review.openstack.org/456053 | |
| 01:46:57 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Refactor a test method including 7 test cases https://review.openstack.org/395436 | |
| 02:04:10 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(2/4) https://review.openstack.org/459569 | |
| 02:06:49 | openstackgerrit | Dao Cong Tien proposed openstack/nova master: Stop using mox int unit/virt/xenapi/image/test_utils.py https://review.openstack.org/342626 | |
| 02:10:11 | openstackgerrit | Kiseok Kim proposed openstack/nova master: Fixed a broken link in API Plugins document https://review.openstack.org/460398 | |
| 02:28:10 | openstackgerrit | Matthew Treinish proposed openstack/nova master: Remove nova-cert https://review.openstack.org/459460 | |
| 03:25:52 | mriedem | jaypipes: ok hon | |
| 03:25:58 | mriedem | jaypipes: it's gonna have to be tomorrow at this point | |
| 03:26:06 | mriedem | but i did get your libvirt get_inventory patch reviewed today | |
| 03:26:08 | mriedem | with gusto! | |
| 03:27:37 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for limits endpoint instead of stevedore https://review.openstack.org/460813 | |
| 04:03:31 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for os-services endpoint instead of stevedore https://review.openstack.org/460818 | |
| 04:06:33 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for limits endpoint instead of stevedore https://review.openstack.org/460813 | |
| 04:16:00 | openstackgerrit | jichenjc proposed openstack/nova master: e plain routes list for os-simple-tenant-usage https://review.openstack.org/460821 | |
| 04:23:50 | openstackgerrit | jichenjc proposed openstack/nova master: use plain routes list for os-simple-tenant-usage https://review.openstack.org/460821 | |
| 04:26:28 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for os-certificates endpoint instead of stevedore https://review.openstack.org/460813 | |
| 05:15:37 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for os-services endpoint instead of stevedore https://review.openstack.org/460818 | |
| 06:04:01 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for os-certificates endpoint instead of stevedore https://review.openstack.org/460813 | |
| 06:08:20 | openstackgerrit | jichenjc proposed openstack/nova master: Use plain routes list for os-certificates endpoint instead of stevedore https://review.openstack.org/460813 | |
| 06:11:42 | openstackgerrit | jichenjc proposed openstack/nova master: use plain routes list for os-simple-tenant-usage https://review.openstack.org/460821 | |