| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-27 | |||
| 10:43:47 | johnthetubaguy | sfinucan: I think I added comments on most of that patches now, most of they don't look like they need splitting, the problem is the rules they remove with no deprecation cycle or warning | |
| 10:45:02 | johnthetubaguy | sfinucan: I basically asked them to talk to the nova-api subteam somehow, to describe what their intent is, I suspect I just don't understand it as its not described in their bug | |
| 10:45:26 | sfinucan | Yeah, I was more focussed on the latter. So basically we need to follow the same migration policy as config opts, right? | |
| 10:45:34 | sfinucan | i.e. deprecate one cycle, remove the next | |
| 10:45:58 | johnthetubaguy | sfinucan: Ideally, its just a config file, so the same rules apply, but the bad bit is we have non of the infrastructure, well almost non | |
| 10:46:14 | johnthetubaguy | s/non/none/ | |
| 10:46:33 | sfinucan | Looks like oslo.policy rules need 'deprecated_X' options so | |
| 10:47:30 | johnthetubaguy | sfinucan: yeah, something like that, its just not been done yet, its a bit tricky | |
| 10:48:10 | johnthetubaguy | you can use rule alias and a manual log message though, to get 90% there | |
| 10:49:03 | johnthetubaguy | but a whole load of the slits were not protecting APIs, there were only protecting API extensions, so its a bit odd | |
| 10:58:39 | mdbooth | sfinucan: Keen eyes :) Thanks for restoring that +2 | |
| 10:59:43 | sfinucan | *re-reviewed, even | |
| 11:21:46 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Attach and detach encryptors during swap_volume https://review.openstack.org/460244 | |
| 11:24:21 | alex_xu | cdent: already added that to my review list | |
| 11:24:36 | cdent | alex_xu: thanks! | |
| 11:25:02 | alex_xu | np! | |
| 11:28:05 | openstackgerrit | John Garbutt proposed openstack/nova master: Update description to policies in remaining flavor APIs https://review.openstack.org/460509 | |
| 11:31:18 | openstackgerrit | John Garbutt proposed openstack/nova master: Update description to policies in remaining flavor APIs https://review.openstack.org/460509 | |
| 11:40:30 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Replace diagnostics objects with Nova diagnostics objects https://review.openstack.org/394480 | |
| 11:40:31 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Added nova objects for intance diagnostics https://review.openstack.org/434745 | |
| 11:40:33 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | |
| 11:40:36 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613 | |
| 11:44:06 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/460515 | |
| 12:15:10 | openstackgerrit | Gábor Antal proposed openstack/nova master: [WIP] Transform instance.live_migration_rollback notification https://review.openstack.org/402124 | |
| 12:29:18 | openstackgerrit | Shunli Zhou proposed openstack/nova master: Periodically load nova.conf https://review.openstack.org/460437 | |
| 12:37:50 | mdbooth | jaypipes: Could I convince you to turn a -1 into a +2? https://review.openstack.org/#/c/334956/ | |
| 12:39:27 | jaypipes | mdbooth: looking now. | |
| 12:47:32 | edleafe | /win 13 | |
| 12:47:36 | edleafe | doh! | |
| 12:50:42 | jaypipes | mdbooth: if you're so confident about all of the always-True or always-False conditionals, why not just remove all the code that can never be reached, and flatten down all the conditionals? | |
| 12:50:55 | mdbooth | jaypipes: That's the next patch | |
| 12:51:00 | jaypipes | oh, duh :) | |
| 12:51:09 | mdbooth | I could squash them, but it seemed a bit hard to follow | |
| 12:52:19 | mdbooth | jaypipes: https://review.openstack.org/#/c/334957/ | |
| 12:52:32 | jaypipes | mdbooth: already on it. :) | |
| 12:52:36 | mdbooth | Thanks | |
| 12:58:22 | jaypipes | mdbooth: whole series +Wallaby'd. | |
| 13:02:57 | mdbooth | jaypipes: Sweet, thanks | |
| 13:03:07 | jaypipes | mdbooth: for you? any time :) | |
| 13:06:31 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Add Neutron port capabilities to devspec in request https://review.openstack.org/451777 | |
| 13:07:00 | mriedem | o/ | |
| 13:07:04 | jaypipes | mriedem: holy red slide, Batman. | |
| 13:07:21 | mriedem | jaypipes: i don't control the red scare template | |
| 13:07:25 | jaypipes | my eyes... they burn! | |
| 13:08:13 | jaypipes | mriedem: so how many wisecrack jokes am I allowed to put into these slides? ;P | |
| 13:08:57 | mriedem | like how many k8s things can you slip in for the R release focus? | |
| 13:09:08 | mriedem | i.e. nova as a proxy to k8s or something | |
| 13:09:29 | mriedem | or, nova-compute in a cable box | |
| 13:09:39 | jaypipes | ya. or something to do with NFV.. :) | |
| 13:09:43 | jaypipes | jinx | |
| 13:10:41 | mriedem | there could be a slide of all the things jay wants to do but i won't let happen because i'm a bad guy, however, | |
| 13:10:50 | mriedem | something like that is bound to be taken seroiusly and blow up in our faces | |
| 13:10:55 | mriedem | *seriously | |
| 13:11:09 | mriedem | or offend someone that actually wants said things | |
| 13:11:18 | mdbooth | dansmith: You up and about, yet? I'm currently working on https://bugs.launchpad.net/nova/+bug/1686703 and I keep bouncing off dead ends like a Roomba. | |
| 13:11:18 | openstack | Launchpad bug 1686703 in OpenStack Compute (nova) "Error in finish_migration results in image deletion on source with no copy" [Undecided,New] | |
| 13:11:18 | jaypipes | RiteshPaiboina: hi! | |
| 13:11:32 | jaypipes | RiteshPaiboina: I'm actually in EDT timezone, not PDT :) | |
| 13:11:42 | mdbooth | dansmith: Looking for any relevant insight into migration records you may have. | |
| 13:15:53 | jaypipes | RiteshPaiboina: basically, you will want to add a unit test to here: https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/libvirt/test_imagebackend.py#L1257 that ensures that on calling the RbD imagebackend's clone() method, that the code ends up calling the Rbd image driver's flatten() method. | |
| 13:31:58 | dansmith | mdbooth: yeah, I dunno if it's reliable enough to block cache manager expiration, but I don't know what else to do | |
| 13:33:00 | mdbooth | dansmith: At least I feel better knowing it's not just me :) | |
| 13:34:01 | zioproto | I have a user that has a instance booting from volume. And there are two cinder volumes attached. He opened a ticket that he cannot start this vm anymore. I confirm he cant.. this is my nova-compute log file. WTF ! http://paste.openstack.org/show/608202/ | |
| 13:34:12 | zioproto | What is this Duplicate ID 'drive-ide0-0-0' for drive ?? | |
| 13:38:22 | mriedem | zioproto: might be helpful to get the block_device_mappings table rows for that instance | |
| 13:41:07 | mriedem | zioproto: does the domain xml get logged during _create_domain? | |
| 13:42:50 | mriedem | _get_guest_xml should log it actually | |
| 13:44:12 | mriedem | so i'd check the dumped guest xml against the bdms in the db, specifically the connection_info values in the bdms entries | |
| 13:44:18 | mriedem | see if there is some duplicate id in there | |
| 13:48:37 | edleafe | Any cores want to take a look at https://review.openstack.org/#/c/453862/ and push it through? Already has a +2 from jaypipes | |
| 13:51:18 | dansmith | mriedem: so some ironic people just brought up an issue with me around host mappings and aggregates | |
| 13:51:55 | dansmith | mriedem: if you recall, as of like newton I think, the ironic driver uses this hash ring to choose which ironic nodes get owned by each compute service | |
| 13:52:35 | dansmith | mriedem: if you have more compute services than nodes in ironic (like during setup), then you have some compute services that don't have any ComputeNode records | |
| 13:52:37 | mriedem | i recall that but never was involved in it | |
| 13:53:19 | dansmith | so the problem is, if you're bootstrapping an environment, you can't add those nova-compute services to an aggregate because they don't have ComputeNode records and thus don't have HostMappings | |
| 13:53:32 | dansmith | you can't add the ones that don't "own" any ironic nodes yet I mean | |
| 13:54:09 | dansmith | since you could before we cell-ified the aggregate api, they see it as a regression, which I kindof understand, | |
| 13:54:13 | mriedem | i guess i don't know about the ironic setup issue where we have more compute services than nodes, unless i'm missing something obvious | |
| 13:54:46 | mriedem | or is this, | |
| 13:54:49 | dansmith | mriedem: during bootstrapping.. like you're setting up nova with ironic, but you haven't enrolled any nodes | |
| 13:54:50 | mriedem | you start nova-compute, | |
| 13:55:06 | mriedem | that asks ironic for available resources (nodes) which don't exist yet in ironic, | |
| 13:55:12 | mriedem | so that compute service record is mapped to 0 nodes? | |
| 13:55:17 | mriedem | ok | |
| 13:55:26 | mriedem | unlike libvirt where we have 1x1 | |
| 13:55:26 | dansmith | yep | |
| 13:55:28 | dansmith | right | |
| 13:56:05 | dansmith | so before we cellified that api, we just looked up the service in the one database, and if it was there, then we add it to the aggregate and move on | |
| 13:56:18 | dansmith | now, we also verify that there is a hostmapping, | |
| 13:56:33 | mriedem | i'll have to look up the aggregates api code | |
| 13:56:34 | dansmith | but we use that hostmapping to know which cell db to look for the service | |
| 13:56:47 | dansmith | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L4734-L4760 | |
| 13:56:57 | dansmith | damn, well, a few lines off | |
| 13:57:10 | dansmith | add_host_to_aggregate() is what you want in there | |
| 13:57:29 | dansmith | anyway, there are a couple of things we can do: | |
| 13:57:43 | dansmith | 1. Just say you can't do this, mock ironic for being weird, and move on | |
| 13:57:52 | mriedem | so this is https://developer.openstack.org/api-ref/compute/#add-host | |
| 13:58:12 | dansmith | 2. If we don't find a hostmapping, we scan each cell for a matching service as a fallback, and if we find it, proceed | |
| 13:58:33 | dansmith | it would be a single get-by-hostname per cell, so not *too* bad | |
| 13:58:35 | dansmith | yeah that | |